aliens

Author Topic: menu ui on korean language is broke  (Read 780 times)

greenscarf_005

  • Guest
menu ui on korean language is broke
« on: February 26, 2021, 04:55:24 pm »
using latest oxce version (6.9.1, v2021-01-09).
descriptions work fine but menu ui gets broke when it is on korean language.
also words goes strange (it is originally %uACBD%uACE0 but it's broke into %uACB9%uACEA; tons of things like these)
wonder why it happens? looks like bad unicode to me tho...

Offline Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 6921
  • OXCE developer
    • View Profile
    • My Wiki
Re: menu ui on korean language is broke
« Reply #1 on: February 26, 2021, 05:41:14 pm »
using latest oxce version (6.9.1, v2021-01-09).
descriptions work fine but menu ui gets broke when it is on korean language.

Same issue in OpenXcom.

I guess OpenXcom is missing the Korean characters in the Geoscape fonts.

Code: [Select]
FontBig.png
FontBig_jp.png
FontBig_ko.png
FontGeoBig.png
FontGeoBig_jp.png
FontGeoSmall.png
FontGeoSmall_jp.png
FontSmall.png
FontSmall_jp.png
FontSmall_ko.png

These files are available, but  FontGeoBig_ko.png and FontGeoSmall_ko.png don't exist.

also words goes strange (it is originally %uACBD%uACE0 but it's broke into %uACB9%uACEA; tons of things like these)
wonder why it happens? looks like bad unicode to me tho...

I'm sorry, this is beyond my expertise, can you check please if the same happens also in OpenXcom?

greenscarf_005

  • Guest
Re: menu ui on korean language is broke
« Reply #2 on: February 27, 2021, 11:40:30 am »
I fixed it;
Looks like font files were incomplete and lines loading it lacked from fonts.dat file.
used some of the older korean patch file around 2017.
https://m.blog.naver.com/phoebe_w/220939416620
Surprisingly tho, that nobody found this since like, 5+ years.

To fix it, you need to unzip Language.zip into common/Language. overwrite any conflicts, that should do.
could you integrate it into the next openxcom patch please? (I'm sure this would fix both openxcom and oxce, too)
thank you for your time.

Changes:
Code: [Select]
Font.dat
FontGeoBig_ko
FontGeoSmall_ko
FontBig_ko
FontSmall_ko
« Last Edit: February 27, 2021, 12:00:27 pm by greenscarf_005 »

Offline Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 6921
  • OXCE developer
    • View Profile
    • My Wiki
Re: menu ui on korean language is broke
« Reply #3 on: February 27, 2021, 12:11:27 pm »
Thanks.

Does it fix also the second issue? (also words goes strange (it is originally %uACBD%uACE0 but it's broke into %uACB9%uACEA; tons of things like these))
Or is that still happening?

greenscarf_005

  • Guest
Re: menu ui on korean language is broke
« Reply #4 on: February 27, 2021, 12:28:06 pm »
yes; it also fixes the second issue. as you can see,
the first image on the attatchment(this thread's first topic) is broke;
the second image is how the fixed one looks like.
replacing fontbig_ko to a bigger one containing all possible korean letter combinations fixed this issue.
« Last Edit: February 27, 2021, 12:32:20 pm by greenscarf_005 »

greenscarf_005

  • Guest
Re: menu ui on korean language is broke
« Reply #5 on: February 27, 2021, 05:04:30 pm »
https://github.com/OpenXcom/OpenXcom/pull/1310
also I've done PR on OXC; I would be greatfully thankful if you could implement the same patch on OXCE. I'm planning to write korean workthrough and oxce with korean language implemented would be really helpful to korean players.

Offline Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 6921
  • OXCE developer
    • View Profile
    • My Wiki
Re: menu ui on korean language is broke
« Reply #6 on: February 27, 2021, 06:46:24 pm »
https://github.com/OpenXcom/OpenXcom/pull/1310
also I've done PR on OXC; I would be greatfully thankful if you could implement the same patch on OXCE. I'm planning to write korean workthrough and oxce with korean language implemented would be really helpful to korean players.

Thank you.

Yes, I will merge it into OXCE v7.0 (coming out in 2-3 weeks)