Author Topic: [FIXED] Crash When Generating New Soldiers  (Read 215 times)

Offline OmniscientQ

  • Sergeant
  • **
  • Posts: 15
    • View Profile
[FIXED] Crash When Generating New Soldiers
« on: February 04, 2025, 08:25:39 pm »
Running X-Piratez N10.2, using self-compiled OXCE with the latest 8.0.7 source. Save file and log attached.

I keep encountering a crash when generating new units. I first encountered it while trying to recruit a couple of Castaway Gals. I could create the manufacturing job just fine, but then when I advanced time and the job was carried out, the game would crash. It was repeatable. I managed to get my gals, but I had to manufacture them one at a time then wait for each to arrive before queuing up the next. I shrugged and moved on, but now I'm encountering it again when trying to purchase some Peasants. I can hire peasants one at a time... until I get three of them. Trying to hire a fourth peasant at the new Antarctica base crashes the game.

Offline Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 9351
    • View Profile
Re: Crash When Generating New Soldiers
« Reply #1 on: February 04, 2025, 11:40:35 pm »
It seems like a mod issue.
Basically "names by region" feature activated `hireByRegionOdds: 50`, but not having name pools for all regions for all or some soldier types.

I'll probably just add some fallback to use the first name pool, in case no name pool is found (for a given region).

Offline Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 9351
    • View Profile
Re: [FIXED] Crash When Generating New Soldiers
« Reply #2 on: February 07, 2025, 09:08:18 pm »
Was a mod issue.

I have changed the code to ignore hiring by region when no region name pools are available.

https://github.com/MeridianOXC/OpenXcom/commit/9fcb27113544c7d02d09aca6054222914c12e086