[FIXED][Bug] Player's soldiers' time units are not replenished on a turn start

[DSeyka]

I can literally do nothing past turn 1, and it seems my APs are way lower than supposed to be on turn 1 as well.
Checked on 7.13.8 and 7.13.9 (which still reports itself as 7.13.8 in the main menu for some reason). 7.13.7 seems to be working fine.

[Yankes]

any errors in logs? I change some logic in that regions but most cases it should not affect  behavior in any way.
I will check again if I did not break something there.

[DSeyka]

Yes, this pretty much repeats for almost every armor type (I'm playing XCom Files mod):

Code: [Select]

[24-08-2024_18-13-28] [ERROR] Conflicting overloads for operator 'BattleUnit.manaNormalizedBonusStats' for:
[24-08-2024_18-13-28] [ERROR]   [ptr BattleUnit] [var int] [int] [int] [int] [int]
[24-08-2024_18-13-28] [ERROR] Expected:
[24-08-2024_18-13-28] [ERROR]   [ptr BattleUnit] [var int] [int] [int] [int] [int]
[24-08-2024_18-13-28] [ERROR]   [ptr BattleUnit] [var int] [int] [int] [int] [int]
[24-08-2024_18-13-28] [ERROR] Error in parsing script 'timeRecoveryBonusStats' for 'STR_SHEEP_ARMOR': invalid operation in line: 'unit.manaNormalizedBonusStats bonus 125000000 0 0 0;' (at 3)
[24-08-2024_18-13-28] [ERROR]     for code in C:/Users/rovla/Documents/OpenXcom/mods/XComFiles-master.zip/XComFiles-master/Ruleset/armors_XCOMFILES.rul
[24-08-2024_18-13-28] [ERROR]
[24-08-2024_18-13-28] [ERROR] Conflicting overloads for operator 'BattleUnit.manaNormalizedBonusStats' for:
[24-08-2024_18-13-28] [ERROR]   [ptr BattleUnit] [var int] [int] [int] [int] [int]
[24-08-2024_18-13-28] [ERROR] Expected:
[24-08-2024_18-13-28] [ERROR]   [ptr BattleUnit] [var int] [int] [int] [int] [int]
[24-08-2024_18-13-28] [ERROR]   [ptr BattleUnit] [var int] [int] [int] [int] [int]
[24-08-2024_18-13-28] [ERROR] Error in parsing script 'energyRecoveryBonusStats' for 'STR_SHEEP_ARMOR': invalid operation in line: 'unit.manaNormalizedBonusStats bonus 60000000 0 0 0;' (at 2)
[24-08-2024_18-13-28] [ERROR]     for code in C:/Users/rovla/Documents/OpenXcom/mods/XComFiles-master.zip/XComFiles-master/Ruleset/armors_XCOMFILES.rul
[24-08-2024_18-13-28] [ERROR]
[24-08-2024_18-13-28] [ERROR] Conflicting overloads for operator 'BattleUnit.manaNormalizedBonusStats' for:
[24-08-2024_18-13-28] [ERROR]   [ptr BattleUnit] [var int] [int] [int] [int] [int]
[24-08-2024_18-13-28] [ERROR] Expected:
[24-08-2024_18-13-28] [ERROR]   [ptr BattleUnit] [var int] [int] [int] [int] [int]
[24-08-2024_18-13-28] [ERROR]   [ptr BattleUnit] [var int] [int] [int] [int] [int]
[24-08-2024_18-13-28] [ERROR] Error in parsing script 'moraleRecoveryBonusStats' for 'STR_SHEEP_ARMOR': invalid operation in line: 'unit.manaNormalizedBonusStats bonus 14000000 0 0 0;' (at 3)
[24-08-2024_18-13-28] [ERROR]     for code in C:/Users/rovla/Documents/OpenXcom/mods/XComFiles-master.zip/XComFiles-master/Ruleset/armors_XCOMFILES.rul

[Yankes]

Ok, thanks, I see I messup new stats bonus names to clash with old ones, I will rename them to fix this bug

[DSeyka]

Nice, thank you very much!

[Meridian]

Introduced in OXCE 7.13.8
Fixed in OXCE 7.13.10

https://github.com/MeridianOXC/OpenXcom/commit/c44b378ade01b60d167528b5d7d5e78f10215ed3