[TFTD] Reasearching Live Deep One Terrorist Crashes Game With "No Psionics" Mod

[Bonesnap]

Note: I am aware TFTD has some tech tree issues which is why I didn't file a bug in the tracker; I'm unsure if this is related to that or not.

Background
I was wondering why I wasn't getting Ion Armour in my research topics so I went online and found a tech tree (GameFAQs) that stated I needed a Live Deep One Terrorist. Cool, very next mission was a terror attack so I figured I'd get one. I did. I brought it back and threw all my scientists at it. Did a small mission after shooting down an Aquatoid sub and shortly after the game froze. I always save after completing a mission so I reloaded, waited a bit, and the game froze again. Below is my gamelog.

Gamelog

[22-01-2017_11-30-28]   [INFO]   Data folder is: /usr/share/games/openxcomhttps://
[22-01-2017_11-30-28]   [INFO]   Data search is:
[22-01-2017_11-30-28]   [INFO]   - /home/media/.local/share/openxcom/
[22-01-2017_11-30-28]   [INFO]   - /usr/share/xfce/openxcom/
[22-01-2017_11-30-28]   [INFO]   - /usr/share/xfce4/openxcom/
[22-01-2017_11-30-28]   [INFO]   - /usr/local/sharehttps://openxcom/
[22-01-2017_11-30-28]   [INFO]   - /usr/sharehttps://openxcom/
[22-01-2017_11-30-28]   [INFO]   - /usr/share/mdmhttps://openxcom/
[22-01-2017_11-30-28]   [INFO]   - /usr/share/openxcom/
[22-01-2017_11-30-28]   [INFO]   - /usr/local/share/openxcom/
[22-01-2017_11-30-28]   [INFO]   - /usr/share/openxcom/
[22-01-2017_11-30-28]   [INFO]   - /usr/share/games/openxcomhttps://
[22-01-2017_11-30-28]   [INFO]   - ./
[22-01-2017_11-30-28]   [INFO]   User folder is: /home/media/.local/share/openxcom/
[22-01-2017_11-30-28]   [INFO]   Config folder is: /home/media/.config/openxcom/
[22-01-2017_11-30-28]   [INFO]   Options loaded successfully.
[22-01-2017_11-30-28]   [INFO]   SDL initialized successfully.
[22-01-2017_11-30-28]   [INFO]   SDL_mixer initialized successfully.
[22-01-2017_11-30-28]   [INFO]   requested file not found: openxcom.png
[22-01-2017_11-30-28]   [INFO]   Attempting to set display to 1280x720x8...
[22-01-2017_11-30-28]   [INFO]   Display set to 1280x720x8.
[22-01-2017_11-30-28]   [INFO]   Loading data...
[22-01-2017_11-30-28]   [INFO]   Scanning standard mods in '/usr/share/games/openxcomhttps://standard'...
[22-01-2017_11-30-28]   [INFO]   Scanning user mods in '/home/media/.local/share/openxcom/mods'...
[22-01-2017_11-30-28]   [INFO]   Mapping resource files...
[22-01-2017_11-30-28]   [INFO]   Resources files mapped successfully.
[22-01-2017_11-30-29]   [INFO]   Loading fonts... Font.dat
[22-01-2017_11-30-29]   [INFO]   Loading extra resources from ruleset...
[22-01-2017_11-30-29]   [INFO]   Data loaded successfully.
[22-01-2017_11-30-29]   [INFO]   Loading language...
[22-01-2017_11-30-29]   [INFO]   Language loaded successfully.
[22-01-2017_11-30-29]   [INFO]   OpenXcom started successfully!
[22-01-2017_11-30-29]   [INFO]   Using software scaling routine. For best results, try an OpenGL filter.
[22-01-2017_11-30-40]   [FATAL]   A fatal error has occurred: Research STR_MC_LAB not found
[22-01-2017_11-30-40]   [FATAL]   openxcom(_ZN8OpenXcom13CrossPlatform10stackTraceEPv+0x2a) [0x5f70ca]
[22-01-2017_11-30-40]   [FATAL]   openxcom(_ZN8OpenXcom13CrossPlatform9crashDumpEPvRKSs+0x427) [0x5f78e7]
[22-01-2017_11-30-40]   [FATAL]   openxcom(_Z15exceptionLoggerv+0x5e) [0x4bc37e]
[22-01-2017_11-30-40]   [FATAL]   /usr/lib/x86_64-linux-gnu/libstdc++.so.6(+0x5e6d6) [0x7f9dd79686d6]
[22-01-2017_11-30-40]   [FATAL]   /usr/lib/x86_64-linux-gnu/libstdc++.so.6(+0x5e703) [0x7f9dd7968703]
[22-01-2017_11-30-40]   [FATAL]   /usr/lib/x86_64-linux-gnu/libstdc++.so.6(+0x5e922) [0x7f9dd7968922]
[22-01-2017_11-30-40]   [FATAL]   openxcom(_ZNK8OpenXcom3Mod7getRuleINS_12RuleResearchEEEPT_RKSsS6_RKSt3mapISsS4_St4lessISsESaISt4pairIS5_S4_EEEb+0x18f) [0x7e879f]
[22-01-2017_11-30-40]   [FATAL]   openxcom(_ZNK8OpenXcom3Mod11getResearchERKSsb+0x40) [0x7c0eb0]
[22-01-2017_11-30-40]   [FATAL]   openxcom(_ZNK8OpenXcom9SavedGame28getAvailableResearchProjectsERSt6vectorIPNS_12RuleResearchESaIS3_EEPKNS_3ModEPNS_4BaseE+0xca) [0x90faba]
[22-01-2017_11-30-40]   [FATAL]   openxcom(_ZNK8OpenXcom9SavedGame26getDependableResearchBasicERSt6vectorIPNS_12RuleResearchESaIS3_EEPKS2_PKNS_3ModEPNS_4BaseE+0x4e) [0x91011e]
[22-01-2017_11-30-40]   [FATAL]   openxcom(_ZN8OpenXcom9SavedGame19addFinishedResearchEPKNS_12RuleResearchEPKNS_3ModEb+0x98) [0x910538]
[22-01-2017_11-30-40]   [FATAL]   openxcom(_ZN8OpenXcom13GeoscapeState8time1DayEv+0x5bb) [0x6e0ddb]
[22-01-2017_11-30-40]   [FATAL]   openxcom(_ZN8OpenXcom13GeoscapeState11timeAdvanceEv+0xe0) [0x6ed890]
[22-01-2017_11-30-40]   [FATAL]   openxcom(_ZN8OpenXcom5Timer5thinkEPNS_5StateEPNS_7SurfaceE+0x87) [0x6bbf07]
[22-01-2017_11-30-40]   [FATAL]   openxcom(_ZN8OpenXcom4Game3runEv+0x3d6) [0x611e76]
[22-01-2017_11-30-40]   [FATAL]   openxcom(main+0x12c) [0x4a44bc]
[22-01-2017_11-30-47]   [FATAL]   OpenXcom has crashed: Research STR_MC_LAB not found
Extra information has been saved to openxcom.log.
If this error was unexpected, please report it to the developers.

I have also attached my .sav file.

Steps to reproduce

• Enable the No Psionics mod
• Load game and click the "30 Mins" speed
• Wait a few seconds - crashes at about 23:41 on June 28, 2040

To avoid the crash, load the game but immediately go to the North Atlantic base and cancel the research project. The game proceeds normally.

You can also disable the mod, load the game (click yes to the warning), and click the 30 Mins speed. The research completes as expected and you get Ion Armour and MC Lab for next research topics; however, if you save, exit, reenable the mod, when you try to go back into the game and select a new research topic the game crashes with the same message (STR_MC_LAB not found).

I am on the latest nightly according to the Linux Mint Software Manager. Was prompted to update yesterday: 1.0+20170114.19d7054-1-trusty1 ==> 1.0+20170121.6317d00-1-trusty1.

If you need any other information please don't hesitate to ask! Thanks!

[R1dO]

Looking at the rulesets it is most likely a ruleset bug.

The deep one unlocks the STR_MC_LAB research. However the "No Psionics" mod deleted all references to that.

-- edit --
Quick workaround for this specific error:

You have to adapt the "No Psionics" ruleset file for this. It can be found in your installation folder under:

Code: [Select]

bin/standard/XcomUtil_No_Psionics_TFTD/XcomUtil_No_Psionics.rul

Look for the following snippet:

Code: [Select]

research:
  - delete: STR_MC_DISRUPTOR
  - delete: STR_MC_GENERATOR
  - delete: STR_MC_LAB
manufacture:
and replace it with:

Code: [Select]

research:
  - delete: STR_MC_DISRUPTOR
  - delete: STR_MC_GENERATOR
  - delete: STR_MC_LAB
  - name: STR_BIODRONE_TERRORIST
    unlocks:
      - STR_ALIEN_ORIGINS
  - name: STR_CALCINITE_TERRORIST
    unlocks:
      - STR_ALIEN_ORIGINS
  - name: STR_DEEP_ONE_TERRORIST
    unlocks:
      - STR_ALIEN_ORIGINS
  - name: STR_HALLUCINOID_TERRORIST
    unlocks:
      - STR_ALIEN_ORIGINS
  - name: STR_TENTACULAT_TERRORIST
    unlocks:
      - STR_ALIEN_ORIGINS
  - name: STR_TRISCENE_TERRORIST
    unlocks:
      - STR_ALIEN_ORIGINS
  - name: STR_XARQUID_TERRORIST
    unlocks:
      - STR_ALIEN_ORIGINS
manufacture:

Please note that adaptations to game resource files are generally not advised, you run the risk of loosing your adaptations upon game updates or you could end up mangling your game-files up to the point that a re-installation is required.

P.S. The same error is most likely also present in UFO

[Bonesnap]

Thanks for the reply and analysis!

I haven't tried editing the file but I agree that it's probably best to avoid it. I think for now I'll keep that game on the back burner and start another one with the mod disabled, but turn on the line of sight mod for psionics. My biggest problem with the psionics is I find it way overpowered for the aliens.

Anyway, sounds like a legit bug so I'll make my way over to the bug tracker and file it.

Just out of curiosity... is it possible to include some kind of conditional statement in the .rul file?

[SupSuper]

Should be fixed in latest nightly.
And no, .rul doesn't have conditionals.

[Bonesnap]

That's awesome! Thanks for the fix! I'll be watching the Update Manager for the update.