aliens

Author Topic: healing and melee don't like stairs  (Read 3856 times)

Offline yrizoud

  • Commander
  • *****
  • Posts: 1014
    • View Profile
healing and melee don't like stairs
« on: December 17, 2013, 01:46:05 am »

Soldiers A and B can't heal each other using medi-kit, they get the message "There's nobody here".
Function ActionMenuState::btnActionMenuItemClick() checks that units are on the same "map level", it ignores the units heights and whether they stand on a "stair" block. This is probably going to be annoying on long slopes like mountains (TFTD had quite a few)
 
More strangely, A can't strike B with a stun rod with the same message, and if B tries to strike A he loses TUs but nothing happens.
In this case the first check is TileEngine::validMeleeRange(), and the actual hit, I don't know where it is.

Offline Solarius Scorch

  • Global Moderator
  • Commander
  • *****
  • Posts: 11728
  • WE MUST DISSENT
    • View Profile
    • Nocturmal Productions modding studio website
Re: healing and melee don't like stairs
« Reply #1 on: February 03, 2014, 10:26:21 am »
+1

Isn't much of a problem with healing, but melee suffers.

Offline yrizoud

  • Commander
  • *****
  • Posts: 1014
    • View Profile
Re: healing and melee don't like stairs
« Reply #2 on: February 03, 2014, 10:49:57 am »
I think it got fixed, or at least made consistent between melee and healing (so if a problem is still present, it affects both melee and healing)
https://github.com/SupSuper/OpenXcom/commit/4c7c0d87abf0b43be1f9c296e9ddeb685e544af3

Offline Warboy1982

  • Administrator
  • Commander
  • *****
  • Posts: 2333
  • Developer
    • View Profile
Re: healing and melee don't like stairs
« Reply #3 on: February 03, 2014, 12:43:54 pm »
BUT I FIXED THIS!