[DONE][Suggestion] spawnItemChance split between ranged and melee

[Darox]

I wanted to create a combat knife that a soldier could use to melee or throw at enemies, with the ability to recover it from enemies after throwing. Giving it 1 ammo and using spawnItem to create a copy of the item on impact worked exactly as I wanted, right up until I tested the melee attack and realized that every melee hit also spawned a new knife. This behavior would also stop someone from adding any kind of 'gun bash' melee attack to a flare launcher or similar.

My suggestion is a meleeSpawnItemChance which defaults to -1 aka "use spawnItemChance value" but if set to 0-100 overwrites spawnItemChance when using melee attacks.

Code: [Select]

  - type: STR_COMBAT_KNIFE
[...]
    spawnItem: STR_COMBAT_KNIFE
    spawnItemChance: 100
    meleeSpawnItemChance: 0
[...]

[Yankes]

Doable

[Yankes]

Done in OXCE 8.1.4
https://github.com/MeridianOXC/OpenXcom/commit/449c0a89f2429539edd4876a302a8a5579eb8a1e

Code: [Select]

items:
  - type: STR_PISTOL
    confAimed:
      ammoSpawnItemChanceOverride: 0
    confSnap:
      ammoSpawnItemChanceOverride: 100
  - update: STR_PISTOL_CLIP
    spawnItem: STR_ELECTRO_FLARE
Each action type have its own override (melee too), it work with spawn units, items and zombifcation.

[Meridian]

All 3 attribute names:

Code: [Select]

items:
  - type: STR_PISTOL
    confAimed:
      ammoZombieUnitChanceOverride: 10
      ammoSpawnUnitChanceOverride: 20
      ammoSpawnItemChanceOverride: 30


[Darox]

Excellent, thanks a lot.