Crashes after importing old save

[YaniDubin]

Hi there, just discovered OpenXCOM, and rather excited to get into it.

I saw there was an option to import old saves, so I gave this a go (just out of interest - I want to start over anyway).

It seemed to import just fine, however crashes (segmentation fault) once going to a base and selecting one of the menus (like base information). With a new game, these work just fine (so my source patching to get past bleeding edge gcc fussiness wasn't the culprit).

I figured it is likely not a bug but an incompatibility.

Is this a known issue if doing something as silly as importing a save generated with one of the utils/extenders or other (I forget which), as I certainly did?

On the other hand, if this should work, and you'd like me to investigate further and see if there is a bug in there, I can pursue it (I'm a coder, and I built it from source, so I can gather further info).

[winterheart]

Hello.

Can you provide actual save? Which version of original XCOM (DOS 1.0, 1.4, Gold, Steam) do you have?

[YaniDubin]

Sure thing.

I have the Steam version. Also, when I stopped to think about it, I got the save out of an archive I made prior to applying extender (since I wanted untampered resources). So please ignore everything I said about the extender.

I have attached a zip with the original saves.
Also attached is the save produced after loading / saving with my openxcom (I removed options.cfg - so this is vanilla configuration which is crashing), in case you can't reproduce it from the save.

I built from #db28572, with just a few one-liner fixes for invalid signed/unsigned type comparisons (presumably just recently increased gcc strictness which were warnings - I use ArchLinux which is a bleeding edge distro). As I said, because new games work, I don't believe I broke anything.

[winterheart]

Your savegame got unusual specimen - Reaper Commander (as OpenXcom thinks, by the way how you managed capture this one?)!

Since this STR_REAPER_COMMANDER does not exist in ruleset (imported game has STR_REAPER_TERRORIST), game cannot calculate weight of nothing and crashes.

[winterheart]

... and here fix: https://github.com/SupSuper/OpenXcom/pull/1030

[YaniDubin]

Hey, thanks for the great and rapid response - this is always great to see!

Your savegame got unusual specimen - Reaper Commander (as OpenXcom thinks, by the way how you managed capture this one?)!

Sorry, has been nearly 2 years since I played that game, so recollection is poor.

I can't recall what a Reaper Commander is. I remember reapers (first(?) terror units), and I made a concerted effort to capture all the live aliens I could (for science!). But I have no memory of a commander (I think there might have been floater commanders - certainly soldier/navigator). Should it not be possible to capture, or is there actually not even such a unit? I would have gone to any length to capture at least one of everything.

[ivandogovich]

Hey, thanks for the great and rapid response - this is always great to see!

Sorry, has been nearly 2 years since I played that game, so recollection is poor.

I can't recall what a Reaper Commander is. I remember reapers (first(?) terror units), and I made a concerted effort to capture all the live aliens I could (for science!). But I have no memory of a commander (I think there might have been floater commanders - certainly soldier/navigator). Should it not be possible to capture, or is there actually not even such a unit? I would have gone to any length to capture at least one of everything.

Yeah, the reaper commander doesn't exist, its just reaper terrorist because they are terror units.  You actually uncovered a bug, where the terror unit captives were being converted incorrectly in the save conversion.  The developers have fixed that in a recent release.  Thanks for helping find the bug.