Author Topic: use of uninitialized var fixes  (Read 4073 times)

Offline myk002

  • Colonel
  • ****
  • Posts: 227
    • View Profile
use of uninitialized var fixes
« on: July 03, 2013, 07:08:36 pm »
I tried building with -Wall -Wextra and gcc found a few issues, like variables being used without initialization in some code paths.  These code paths probably aren't being hit too often -- otherwise we would have heard about crashes, I'm sure, but it's probably a good idea to fix them up.  I created a pull request that fixes the issues, but it could certainly use a review to make sure I fixed them correctly : )  Maybe we could add -Wall -Wextra to the flags in the standard build?  It does catch some important issues before they become a problem.

Offline SupSuper

  • Lazy Developer
  • Administrator
  • Commander
  • *****
  • Posts: 2162
    • View Profile
Re: use of uninitialized var fixes
« Reply #1 on: July 08, 2013, 10:53:17 pm »
I think the Makefiles already have -Wall, it's just we don't actively develop on Linux so we don't get to see those messages anyways.