[DONE] Common/standard folder version check

[NebbieZebbie]

This is with both the AppImage and Ubuntu executable, on OpenSUSE Tumbleweed. Happens on any save (one attached has an instant crash because it's pre-battle).
Regular OpenXCom (latest nightly) works.

V7.11 (2024-01-09) Ubuntu executable works. 7.12 and later do not. Log file is from 7.14.4.
...that said, V7.11 has a segfault within the UFOpedia specifically when looking at any UFO component. Testing various old releases shows this happens starting at V7.6.

Latest OXCE appimage works on another PC I have with everything freshly installed, so I'm suspecting this could be an issue with the rather old installation.
The AppImage works on both PCs if the 'common' folder isn't present in the data folders location.

[Meridian]

The AppImage works on both PCs if the 'common' folder isn't present in the data folders location.

I don't know anything about Linux or AppImages, but I know that OXCE requires exactly one 'common' folder with the content that corresponds exactly to that particular version of OXCE.

This should all be completely transparent to the player, even more so with AppImages, so please don't try to make any copies of the 'common' folder or move them from different installations or try to share them across different installations, or anything like that.

The best I can recommend is... delete ABSOLUTELY EVERYTHING and start fresh. Don't experiment.

As for the crashes... the most likely reason is that the content of the 'common' folder corresponds to an older version of OXCE (than the actual executable).
Even more specifically, I think it's because of missing entries in the `interfaces.rul`file, which I update quite often, basically with each release.

[Meridian]

For the next release, I've added some very simple (definitely not perfect) data freshness/consistency checks.

Hopefully that will help identify install/upgrade issues.

[NebbieZebbie]

That should help, yes, and replacing all the folders except for those necessary to keep did work on the 7.14 version.
The problem with deleting every single folder in ~/local/share/openxcom for upgrades is that basically everything lives there; so, the most efficient correct way to do upgrades is to delete everything the archive would replace except the UFO and TFTD folders, then extract everything.