Author Topic: Potentially incorrect award of globeTrotter commendation  (Read 170 times)

Offline mtort

  • Squaddie
  • *
  • Posts: 1
    • View Profile
Potentially incorrect award of globeTrotter commendation
« on: May 28, 2024, 07:33:27 am »
GlobeTrotter is currently awarded if the number of countries visited by a soldier equals the number of countries defined in the rules.

But this is incorrect, since when calculating the number of countries visited by a soldier, places outside the countries (with country="STR_UNKNOWN") are taken into account. That is, a soldier can receive this commendation if he has visited all countries except one, but has also been, for example, in Antarctica.

I propose to exclude from the calculation of countries visited by a soldier places with country = "STR_UNKNOWN". Small patch attached.