Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Delian

Pages: 1 ... 14 15 [16]
OXCE Bugs / Re: [BUG] lowAccuracyHitCounter
« on: September 07, 2020, 01:45:48 pm »
Think about it. If you shoot at someone with 0% accuracy and you somehow hit them, then logically this statistic should increase.

Yes, there's no specification, so... what should the correct behavior be then? I think the idea of accuracy being less than the distance to the target is good, so you can't abuse it at short range. But then, it would still be easy to improve it if, for instance, you shot with 30% accuracy at someone 31 tiles away. So I think that another condition of accuracy being less than ~15% would be good.

Anyway, if you won't fix it, where should this bug be reported then?

OXCE Bugs / Re: [BUG] lowAccuracyHitCounter
« on: September 07, 2020, 01:04:34 pm »
This is standard OXC behavior because the standard beavior doesn't include accuracy reduction with range. If it included it, then the check here would likely also have included the actual reduced accuracy. So as far as I can tell, the behavior, when the realistic accuracy is turned on, is bugged. Even if it was fixed in the OXC, you'd still have to fix it in your fork.

It can't be abused because there's also a check if (victim == targetVictim), so if you aim far behind someone, the bonus won't be applied, because you hit someone that wasn't your target.

OXCE Bugs / [FIXED] lowAccuracyHitCounter [OXC]
« on: September 06, 2020, 10:27:27 pm »
There is a soldier statistic called lowAccuracyHitCounter that is used for commendations. It doesn't seem to work.

I've checked the code in ProjectileFlyBState.cpp, and it looks like this counter was supposed to increase if you hit your target when your accuracy is less than the distance from the target. I've tried debugging the code a little and I've noticed the following:
The BattleUnit::getFiringAccuracy() call returns base accuracy instead of distance-reduced one.

For instance, I'm using a shotgun with a range of 6 and 6 reduction/tile to fire at a target 19 tiles away. At close range, the soldier has 92% accuracy with this shotgun, but due to the distance, the accuracy gets reduced to 14%. I shoot and hit the target, but this statistic doesn't increase. Obviously, since the accuracy value being used in the above check is "92" instead of "14".

I'm using X-PirateZ v.L3 with OpenXcom Extended 6.6 (v2020-08-22).

Pages: 1 ... 14 15 [16]