Topics

1

OXCE Support / [Solved] Number of shots per attack action

« on: December 21, 2017, 05:42:24 pm »

TFTD style UFOpaedia articles (type_id 14) do not correctly report the number of auto shots made. UFO articles (type_id 4) do, so I presume it wasn't updated when this was made configurable.

The offending code is src/Ufopaedia/ArticleStateTFTDItem.cpp line 78, which should be:

Code: [Select]

tr("STR_SHOT_TYPE_AUTO").arg(item->getConfigAuto()->shots).c_str(),

And while we're there, the UFO version changed the code for snap and aimed shots too, so lines 93 and 108 should change similarly:

Code: [Select]

tr("STR_SHOT_TYPE_SNAP").arg(item->getConfigSnap()->shots).c_str(),


Code: [Select]

tr("STR_SHOT_TYPE_AIMED").arg(item->getConfigAimed()->shots).c_str(),

Related to this: the number of snap and aimed shots aren't actually configurable, though they almost are. It looks like it doesn't bother to read aimedshots and snapShots, but it would use them if it could. Can be fixed in src/Mod/RueItem.cpp by adding around the similar code for autoShots on line 588:

Code: [Select]

_confAimed.shots = node["aimedShots"].as<int>(_confAimed.shots);
_confSnap.shots = node["snapShots"].as<int>(_confSnap.shots);

Apologies if this isn't sufficiently clear, I'm not really used to bug reporting.

2

Open Feedback / Infiltration mission looping

« on: July 21, 2016, 08:13:49 pm »

I am struggling to understand why infiltration missions are set to loop. I noticed this playing X-Piratez, but the cause is in the main game code, and is obviously intentded. But as far as I can recall this was not the original behaviour, and it's not mentioned in the Ufopaedia entry.

But in Savegame/AlienMission.cpp it's explicitly special-cased:

Code: [Select]

bool AlienMission::isOver() const
{
if (_rule.getObjective() == OBJECTIVE_INFILTRATION)
{
https://Infiltrations continue for ever.
return false;
}
And later in AlienMission::think

Code: [Select]

https:// Infiltrations loop for ever.
_nextWave = 0;
Why was this introduced? It doesn't seem at all sensible - even if it was in the original I'd have thought it was a bug.