Messages

1

OXCE Builds & Ports / Re: Bugs (?) with my saved games

« on: December 05, 2020, 02:55:48 am »

Yankes, after reading your comments about yaml-cpp being the culprit in most cases and especially your question about what version I used, I decided against to fix the codes per your suggestion in the last post.

What I did instead was to remove the git version of yaml-cpp (0.6.3) and install libyaml-cpp0.6:armhf  (0.6.2-4+rpi1) from the debian system. I also removed the changes in the code for the SavedBattleGame.cpp and Tile.cpp files, simply revert back to the original files. Then recompiled OXCE.

All the saved games worked. I loaded a saved game, saved it, exit, loaded it again - no more black maps and the visibility & smoke effects all are present as they should be. Phew!

The main cause seems to be the git version of yaml-cpp.

Thanks for all the helps in trying to fix the problem.

2

OXCE Builds & Ports / Re: Bugs (?) with my saved games

« on: December 04, 2020, 03:54:36 pm »

See attached SavedBattleGame.cpp & Tile.cpp files.

3

OXCE Builds & Ports / Re: Bugs (?) with my saved games

« on: December 04, 2020, 03:47:38 pm »

No, there is no "black" areas any more. Game correctly loaded tiles, but only forget flags for visibility and smoke.
could you show what changes you finally did to source code?

Yes I meant the visibility  - the black area above & behind the skyranger and smoke.

I simply replaced in SavedBattleGame.cpp,

 
#if 0

with

 
#if 1

and in Tile.cpp,

               throw Exception("Obsolete code");
//             for (int i = O_FLOOR; i <= O_NORTHWALL; i++)
//             {
//                     node["discovered"].push_back(_objectsCache.discovered);
//             }

with

 
               for (int i = O_FLOOR; i <= O_NORTHWALL; i++)
               {
                       node["discovered"].push_back((bool)_objectsCache.discovered);
               }

Then recompiled.

4

OXCE Builds & Ports / Re: Bugs (?) with my saved games

« on: December 04, 2020, 11:29:09 am »

Thanks for refreshing my memory about the code change Yankes. I have recompiled OXCE with the code changes.

So far the game loaded fine and the game played was fine. But the saved game still have some problems -
 a) Loaded the hacked save game.
 b) Deployed smoke grenades.
 c) Saved the hacked save game.
 d) Loaded the saved game.
 e) Map opened to units in the Skyranger and AIs in the terrain, however smoke grenade deployment are missing. Also, there are still black areas of map and the game play is similar to the pre-hacked version of save game with the black map.

I have attached a 2.3 mins recording.

5

OXCE Builds & Ports / Re: Bugs (?) with my saved games

« on: December 03, 2020, 09:45:18 pm »

I'm sure that I have done it a few times but it was a while ago, how do I make change to these two files SavedBattleGame.cpp & Tile.cpp? I 'm aware of the specific parts of the code that needed to be remove & added. I assumed that I'll have to recompile OXCE with these code fixes?

6

OXCE Builds & Ports / Re: Bugs (?) with my saved games

« on: December 03, 2020, 06:36:37 pm »

What version of yaml did you use to compile your binary?

I used the git version 0.6.3.

The one available for my RPi debian system is 0.6.2-4, though it is not installed.

7

OXCE Builds & Ports / Re: Bugs (?) with my saved games

« on: December 03, 2020, 03:27:39 pm »

This mean it loaded correctly? What you did after is irrelevant to this test.

Yes the hacked save game loaded correctly. The game play was fine.

It's only when I saved the (battlescape) game, exited and loaded it, I ended up with the black map.

8

OXCE Builds & Ports / Re: Bugs (?) with my saved games

« on: December 03, 2020, 11:15:00 am »

Could you try load this hacked save game?

I tried the hacked save game, while it worked fine initially the same black map cropped up. It only happened after I have saved it as new saved game & exit from the battlescape. The new saved game opened to the same black map.

Incidentally, I pulled & compiled a fresh git OXC and OXCE overnight, the black map bug still occurred.

Seem to be something up with the save game option for battlescape mission.

Fyi, OXC &compiled in just under an hour (40-50 mins)  while OXCE it was slightly longer probably 1.5 hrs in Raspberry Pi 3 B+ board.

Regards,
Heybeardy.

9

OXCE Builds & Ports / Re: Bugs (?) with my saved games

« on: December 02, 2020, 11:41:12 pm »

Can you enable path preview and when you load save show what it is showing? try imaging that whole map is still there and order unit to move.
Could you show screen shots of this paths that will be show?

I assumed that this is what you mean?



I have attached a minute of recording of this stuff on my desktop - video shows unit moving & AI reaction shooting.

10

OXCE Builds & Ports / Re: Bugs (?) with my saved games

« on: December 02, 2020, 03:39:15 pm »

In game options there is switch that make that only files you need are loaded, its is way to reduce memory overhead in very big mods (that if load all assets could use over 1GiB of memory).

https://openxcom.org/forum/index.php/topic,3287.msg104264.html#msg104264

I figured it as much -I went to look at the config files this morning and have already set 'lazyLoadResources: false'. Didn't help as the black map still remained.

I'm going to take a look at my old AMD64 machine, just to check if it's stable enough to handle a few things before attempting a heavy workout on it. In meantime later tonight I'll probably try a new git pull & compiling of a fresh OXC and also OXCE on my RPi 3 B+ board.

Regards,
Heybeardy.

11

OXCE Builds & Ports / Re: Bugs (?) with my saved games

« on: December 02, 2020, 01:42:13 pm »

One possible fix I would see is to disable lazy loading. Because it look like it do not load all surfaces correctly when load save game, but load them when you start new mission.
What commit you used to compile this version?

Excuse my ignorance, but what's 'lazy loading'?

By commit I assumed you mean the git repo that I used. I pulled from Meridian's --I believe that this is what you're referring to, the commit tag:

d30709a0bf7b4f263e4db28bbce848c8036614cd

$ git show d30709a0bf7b4f263e4db28bbce848c8036614cd
commit d30709a0bf7b4f263e4db28bbce848c8036614cd (HEAD -> oxce-plus, origin/oxce-plus, origin/HEAD)
Date:   Thu Nov 26 17:00:37 2020 +0100

    Derp

diff --git a/src/Battlescape/DebriefingState.cpp b/src/Battlescape/DebriefingState.cpp
index 0a40bf49a..61a0499b5 100644
--- a/src/Battlescape/DebriefingState.cpp
+++ b/src/Battlescape/DebriefingState.cpp
@@ -2554,7 +2554,10 @@ void DebriefingState::recoverAlien(BattleUnit *from, Base *base)
                ss << "; Status = " << from->getStatus();
                ss << "; Faction = " << from->getFaction();
                ss << "; Orig. faction = " << from->getOriginalFaction();
-               ss << "; Spawn unit = [" << from->getSpawnUnit()->getType() << "]";
+               if (from->getSpawnUnit())
+               {
+                       ss << "; Spawn unit = [" << from->getSpawnUnit()->getType() << "]";
+               }
                ss << "; isSurrendering = " << from->isSurrendering();
                throw Exception(ss.str());
        }

Earlier  this morning I copied my OXCE directories to a different micro SD card containing an older raspberry pi OS, tried the saved Battlescape game and the result was the same --black map.

I also tried the game on one of the older board specifically RPi 2+ with the same result.

I have a two PCs, however both have hardware problems. My reliable AMD64 PC while it works fine for general purpose use, is showing its age and breaks down if I attempt to do heavy lifting like compiling etc and a lot of files are corrupted. So I do not have a different machine to test the game on.

12

OXCE Builds & Ports / Re: Bugs (?) with my saved games

« on: December 02, 2020, 01:15:01 am »

First this look like some bad interaction with OS that can't be fix from our end. I would need have exactly same machine recreate this bug to even try fix it.
Second your answer are not precise enough to see what you do, best if you describe what you do in steps what you do to recreate this bug.
E.g.:

Code: [Select]

1) boot machine
2) log in
3) run game
4) load save
5) map work
6) close game
7) log out
8) log in
9) run game
10) load save
11) have black map


Sorry if I wasn't clear. O.k., this is how it goes:

1. Compiled OXCE using the exact commands for Linux installation in Meridian's post. Did it last night on my Raspberry Pi 3 B+ board. Took about 2 (?) hrs to complete without any errors.

2. Played the game this morning --everything seems to worked fine.

3. Later in the morning, I reboot  into my RPi3 B+ board & logged in and attempted to start my saved Battlescape game. It turned out that all saved battlescape games are affected.

4. The sequence went like this:

   a) Boot into RPi3 B+.
   b) Logged in Raspberey Pi Os (based on Debian).
   c) Started OXCE in the terminal.
   d) Clicked on the saved Battlescape game.
   e) Game opened to black map screen with just my units & AI visible --same as the two images
        in my first post above. All saved Battlescape games are affected.
   f) Quit the Battlescape mission.
   g) Clicked on the saved Geoscape game.
   h) Game worked fine. I have one such save game where the skyranger was just about to land
       on a terror mission.
    i) Clicked on the saved Geoscape game with skyranger on way to terror mission.
    j) Game opened to normal map, did the first turn.
    k) Saved the Battlescape game and quit.
    l) Clicked on the save Battlescape game,  game opened to the same black map.

It work fine if I goes through the terror mission from start to finish, return to Geoscape & save it. But I do not have the time to play continuously, hence the need to save the game.

Regards,
Heybeardy.

13

OXCE Builds & Ports / Re: Bugs (?) with my saved games

« on: December 01, 2020, 08:55:50 pm »

I loaded this save and its fine, everything is where it should be. It look like your game get corrupted and stop showing some graphics.
Did you start again whole game after log back or it stay ruining during logoff?

If I stayed in the game it seems to worked fine but  when I tried it by logging out & in then this graphic problem reared its head. This is not the first time it occurred --it happened this morning as well.

So if it worked fine for you, then it must be problem relating to my RPi 3+ platform and/or installation. (?) I haven't the idea of how to fix it as I'm not too familiar with how the graphic in the game works, much less how ARM7v in RPi 3+ works.

Regards,
Heybeardy.

14

OXCE Builds & Ports / Re: Bugs (?) with my saved games

« on: December 01, 2020, 07:16:11 pm »

I went & check my saved games --apparently it's all of the Battlescape. The Geoscape seems to be fine.

I load the Geoscape that I saved before my skyranger landed for the terror mission --the Battlescape seems to be fine and the layout looked similar to the one in my image with black background:



Regards,
Heybeardy.

15

OXCE Builds & Ports / Re: Bugs (?) with my saved games

« on: December 01, 2020, 06:58:36 pm »

Hey, sorry about it - I have attached the wrong save game files I think.

The save files for the images that I posted are from a terror mission --I have attached the right files for these particular images.