OpenXcom Forum

Modding => OpenXcom Extended => OXCE Suggestions DONE => Topic started by: Varana on July 03, 2017, 08:36:22 pm

Title: [DONE] [Suggestion] trainingStatCaps - auto remove from training
Post by: Varana on July 03, 2017, 08:36:22 pm
There should be no need to take the editor and search for the trainingStatCaps of the actual mod. And there should be no need to keep an eye on all the trained stats of all the good soldiers.

Instead, soldiers should be auto removed from the training facility when they can not train the skills of this facility any higher. And they should not be assignable again. Maybe with a 'done' entry at the end of the stats line, or something similar.

Maybe as a selectable option in the options menu, near the place where you can choose to auto remove wounded soldiers.
Title: Re: trainingStatCaps - auto remove from training
Post by: Solarius Scorch on July 03, 2017, 08:46:08 pm
Or just make maxed out stats red in the training menu. I remember proposing it before, but can't remember if there is any inherent problem with it.
Title: Re: trainingStatCaps - auto remove from training
Post by: Meridian on July 03, 2017, 09:50:08 pm
Or just make maxed out stats red in the training menu. I remember proposing it before, but can't remember if there is any inherent problem with it.

Yes, the problem is there is no red color in basescape.
There are literally only 5 colors: white, light blue, yellow, pink and purple.
Title: Re: trainingStatCaps - auto remove from training
Post by: Solarius Scorch on July 03, 2017, 11:52:37 pm
Yes, the problem is there is no red color in basescape.
There are literally only 5 colors: white, light blue, yellow, pink and purple.

I think purple would be okay, maybe... It's dark, so may appear "disabled". Perhaps.
Title: Re: trainingStatCaps - auto remove from training
Post by: Meridian on July 04, 2017, 12:06:35 am
I think purple would be okay, maybe... It's dark, so may appear "disabled". Perhaps.

Purple is already used for soldiers not in training... actually the only color not used on that GUI yet is pink.
Title: Re: trainingStatCaps - auto remove from training
Post by: Solarius Scorch on July 04, 2017, 12:09:57 am
Purple is already used for soldiers not in training... actually the only color not used on that GUI yet is pink.

Ah, this purple... Sorry, colour names are confusing.

I'm not sure pink is appropriate, but I'd have to see it first.
Title: Re: trainingStatCaps - auto remove from training
Post by: Varana on July 08, 2017, 10:33:31 am
Why discussing colors?

My solution was much better than colors. There is no reason to keep someone, who reached all trainingstatcaps, in training. Not training in red, blue, purple or pink. No training.
Title: Re: trainingStatCaps - auto remove from training
Post by: yrizoud on July 08, 2017, 06:12:25 pm
Or a notification screen ? Like when research or production end ?
This may be the most generic answer : if a game/mod is balanced to let training reach the unit caps, it's probably important for the player to swap units, or transfer them away from the training base.

Units have completed training at {BASE}
     [OK]   [View Base]
Title: Re: trainingStatCaps - auto remove from training
Post by: Meridian on August 04, 2017, 12:59:45 pm
Why discussing colors?

My solution was much better than colors. There is no reason to keep someone, who reached all trainingstatcaps, in training. Not training in red, blue, purple or pink. No training.

Or a notification screen ? Like when research or production end ?
This may be the most generic answer : if a game/mod is balanced to let training reach the unit caps, it's probably important for the player to swap units, or transfer them away from the training base.

Units have completed training at {BASE}
     [OK]   [View Base]

- Fully trained soldiers will be removed from training automatically
- You will be informed by a new GUI
- You won't be able to assign a fully trained soldier back into training
- Fully trained soldiers have status "DONE"

Code: [Select]
extraStrings:
  - type: en-US
    strings:
      STR_TRAINING_FINISHED: "Training Finished"
      STR_NO_DONE: "DONE"
Title: Re: trainingStatCaps - auto remove from training
Post by: yrizoud on August 04, 2017, 03:36:23 pm
The status YES / NO / DONE is very elegant.
Title: Re: trainingStatCaps - auto remove from training
Post by: Meridian on August 04, 2017, 05:52:01 pm
For completeness, there's a also a status WOUNDED (=no training in the infirmary).
Title: Re: trainingStatCaps - auto remove from training
Post by: Solarius Scorch on August 04, 2017, 11:11:13 pm
Very nice, I like it too.
Title: Re: trainingStatCaps - auto remove from training
Post by: Biggieboy on March 11, 2018, 03:59:37 pm
- Fully trained soldiers will be removed from training automatically
- You will be informed by a new GUI
- You won't be able to assign a fully trained soldier back into training
- Fully trained soldiers have status "DONE"

Code: [Select]
extraStrings:
  - type: en-US
    strings:
      STR_TRAINING_FINISHED: "Training Finished"
      STR_NO_DONE: "DONE"

Great!

Where can i download it?

Thank you!