OpenXcom Forum

Contributions => Programming => Topic started by: Countdown on June 08, 2016, 10:45:38 pm

Title: [Resolved] UFO/TFTD - Buggy scoring of failed base defense and artifact missions
Post by: Countdown on June 08, 2016, 10:45:38 pm
*UPDATE 2: Was fixed in a later version of the nightlies.

*UPDATE: "objectiveFailed" in the alienDeployments ruleset isn't applied when you lose the mission through a squad wipe, only if you abort mission.

I'd consider this to be wrong, but I'm not an expert on the original game so I'm checking if it is a "bug" or just the way the game is. It's certainly illogical.

Failed base defense missions yield negative points for craft lost if you abort the mission, but not if you lose the mission by everyone dying. I assume you should get the negative craft loss points no matter how you lose.

In TFTD artifact site missions you're supposed to get a score of 750 points if you win and negative 750 points if you fail, negative 2000 if you ignore (source (https://www.ufopaedia.org/index.php/Artefact_Site#Points) ... you can also look this up in the OXC alienDeployments ruleset). However, in losing the mission with a total squad wipe, I found out the negative 750 isn't applied. You only get the negative 750 if you land and then retreat.

See the attached screen shots. First is a total squad wipe; I actually come out with a positive score! Second screen shot is taking off with 3 survivors and recovering some equipment/corpses. I get a negative score. Obviously that just doesn't make much sense. Both should be negative, the total squad wipe being worse.

So is it a mistake that the -750 was left off or just an XCOM loophole that is supposed to exist?
Title: UPDATED: UFO / TFTD - Buggy scoring of failed base defense and artifact missions
Post by: Countdown on June 08, 2016, 10:50:39 pm
PS - On a related note (and this goes for TFTD and UFO), if you lose a mission with unconscious soldiers left in the battle, they are counted as KIA instead of MIA on the post-op screen.

Back in base, the soldier diaries correctly identifies them as MIA, but I don't know why the post op screen adds them to the "XCOM operatives killed total" instead of the MIA total. It doesn't create any major issues since the scoring doesn't change, but it's slightly annoying for those using the commendations mod because it leads to the incorrect medal being awarded.
Title: Re: UPDATED: UFO / TFTD - Buggy scoring of failed base defense and artifact missions
Post by: hellrazor on June 09, 2016, 07:19:20 am
Once you have cleared if this is indeed a bug or not, please be so kind to post it on the openexcom bugtracker.

The bugtracker can be found here (https://openxcom.org/bugs/openxcom)
Username and login are the same as on the forum.
Title: Re: UPDATED: UFO / TFTD - Buggy scoring of failed base defense and artifact missions
Post by: Countdown on June 10, 2016, 07:28:48 am
Yup will do, that was my plan. I've used the bug tracker before (although I created a new account, I didn't realize my same login would have worked), but wanted to double check.

I did confirm what I noted is a bug. I played a quick and dirty campaign in vanilla TFTD in DOSbox (sooo much clicking, sooo tedious :P) and observed a negative 750 point score when having a squad wipe (photo attached).

Plus, for those modding their own custom missions, it seemed most likely that the devs intended "objectiveFailed" to be applied in any instance of a mission failure (squad wipe or abort). Otherwise the language in the wiki probably would have been different if it was just for aborted missions.

EDIT: Bug report here (https://openxcom.org/bugs/openxcom/issues/1237).
Title: Re: UPDATED: UFO / TFTD - Buggy scoring of failed base defense and artifact missions
Post by: Warboy1982 on June 10, 2016, 11:54:36 am
ack! what happened to your screen?
Title: Re: UPDATED: UFO / TFTD - Buggy scoring of failed base defense and artifact missions
Post by: harre on June 10, 2016, 02:15:06 pm
ack! what happened to your screen?

Probably a 100% shot that missed and his whole squad was wiped.  8)
Title: Re: UPDATED: UFO / TFTD - Buggy scoring of failed base defense and artifact missions
Post by: Countdown on June 10, 2016, 06:12:21 pm
Yup, I got so angry after the last squad wipe I just punched my computer in the face. >:(


... The real story is less cool. Computer in back pack on front seat in my car. I stop short. Back pack falls on floor. Screen broken. :'(