OpenXcom Forum

Modding => Work In Progress => Topic started by: Xylon666Darkstar on March 15, 2015, 10:53:32 pm

Title: Question regarding Terror Site mission occurrences
Post by: Xylon666Darkstar on March 15, 2015, 10:53:32 pm
So running the most recent nightly to date (March 13th I believe), and FMP mods for open xcom. All the missions, aliens I've come across run smoothly, but whenever a Terror mission UFO comes out to land on a city, it lands, but turns into a ground assault UFO mission when skyranger lands. Using  these mods/openxcom since last month in total, and I have yet to come across an actual Terror Site mission in the game. Is there an option/mod that I am missing that is preventing these from actually occurring?

Current game am in the month of March, no hyperwave decoder, but I am assaulting terror ships w/sectoids or floaters w/Cyberdiscs or Reapers respectively, but no city/urban maps w/civilians. The first game before that last month, had gone on into a year, and never come across a single terror mission as well.
Title: Re: Question regarding Terror Site mission occurrences
Post by: Hobbes on March 16, 2015, 02:06:27 am
Do you have a Geoscape save after the Terror Site is activated?
Title: Re: Question regarding Terror Site mission occurrences
Post by: Jstank on March 16, 2015, 04:00:24 am
I can confirm this issue, though I have been shooting down a bunch of terror ships so I can't be too sure.
Title: Re: Question regarding Terror Site mission occurrences
Post by: Xylon666Darkstar on March 16, 2015, 04:29:57 am
Roger. Images linked outside, and inside site. Where is the terrorized city!

(https://i.imgur.com/qo5x5QP.jpg)

(https://i.imgur.com/cUHvr5q.jpg)

(https://i.imgur.com/Tf1tWC0.jpg)

Edit: Save attached.
Title: Re: Question regarding Terror Site mission occurrences
Post by: Hobbes on March 16, 2015, 07:51:49 am
Edit: Save attached.

Thanks, although I need one save with the Terror Site mission marker to confirm this is a bug that was reported on the Terrain Pack thread some days ago. This most likely is related to the latest changes to the mission system.
Title: Re: Question regarding Terror Site mission occurrences
Post by: Xylon666Darkstar on March 16, 2015, 08:09:57 am
I have never gotten a Terror Site mission marker(the obvious pink cross with iconic bloody civilian face) since I started playing in the past month. Of note though, I had just now landed on a very large UFO site on a city in Africa (but not Terror Site marked) and it's an MiB terror site w/Civilians.

Edit: nix that. the MiB ufo did NOT land on a city mark.
Title: Re: Question regarding Terror Site mission occurrences
Post by: Solarius Scorch on March 16, 2015, 08:13:34 am
Not every Terror Ship with an Alien Terror mission is meant to actually land in a city. Half of them are basically scouts, looking for the right place to strike.
Title: Re: Question regarding Terror Site mission occurrences
Post by: Xylon666Darkstar on March 16, 2015, 10:16:05 am
I shouldn't be going months to a year w.o terror sites, except random MiB ones that don't even land in cities. I have been completely and thoroughly avoiding shooting down iris and letting them land, small and large, and have never experienced terror sites in openxcom.

See save file/images. It'll land on a city everytime, but never as a Terror.
Title: Re: Question regarding Terror Site mission occurrences
Post by: Warboy1982 on March 16, 2015, 10:20:26 am
try again without mods?
Title: Re: Question regarding Terror Site mission occurrences
Post by: Hobbes on March 16, 2015, 06:02:34 pm
try again without mods?

It can be a mod causing the issue but the first report I had of this on the Terrain Pack thread was simply strange: fo hellrazor everything was OK until the 4th terror site, which took place on an island (i.e. no polygons underneath the mission marker) but when he landed it was a mission on Steppe terrain. Hellrazor provided a Geoscape save and on the MissionSites, the entry was assigned to texture #4 (with Steppe being one possible option for that texture), instead of -2 (for Port Attacks).

I'm still using Nightly 2015_03_04_0147 for mod design (almost two weeks old) and I simply can't reproduce this bug using the same version of the Terrain Pack (just tried it again, Port Attack is generated, with the correct -2 texture). Of course, it could still be some other mod, which is why I haven't reported this until someone has this bug with no mods being used.
Title: Re: Question regarding Terror Site mission occurrences
Post by: SupSuper on March 16, 2015, 06:44:36 pm
So running the most recent nightly to date (March 13th I believe), and FMP mods for open xcom. All the missions, aliens I've come across run smoothly, but whenever a Terror mission UFO comes out to land on a city, it lands, but turns into a ground assault UFO mission when skyranger lands. Using  these mods/openxcom since last month in total, and I have yet to come across an actual Terror Site mission in the game. Is there an option/mod that I am missing that is preventing these from actually occurring?

Current game am in the month of March, no hyperwave decoder, but I am assaulting terror ships w/sectoids or floaters w/Cyberdiscs or Reapers respectively, but no city/urban maps w/civilians. The first game before that last month, had gone on into a year, and never come across a single terror mission as well.
Any mission mods last updated before the 2015-03-03 nightly are likely broken as they will not contain the new mission behavior that actually triggers terror sites.
Title: Re: Question regarding Terror Site mission occurrences
Post by: Xylon666Darkstar on March 17, 2015, 12:39:43 pm
That could be the reason then, yeh? The only mod I am using w/open xcom + updated nightly's is FMP. And presumably, that terrain pack or even FMP itself hasn't been completely updated alongside the nightlys?
Title: Re: Question regarding Terror Site mission occurrences
Post by: Meridian on March 17, 2015, 01:03:21 pm
Yes, that seems to be the reason... I will provide updated FMP 1.0 ruleset today for vanilla missions based on latest changes. For FMP-specific missions however I cannot provide it, because I don't know how they are supposed to work... mod author(s) will have to do it themselves.

Also, I think this is not the only mod-breaking change in the last 2-4 weeks. Would be nice if somebody had the time to inform modders what needs to be updated... if nobody volunteers I will try to post it here (or in some other thread?) over the weekend...
Title: Re: Question regarding Terror Site mission occurrences
Post by: hellrazor on March 17, 2015, 02:28:24 pm
It can be a mod causing the issue but the first report I had of this on the Terrain Pack thread was simply strange: fo hellrazor everything was OK until the 4th terror site, which took place on an island (i.e. no polygons underneath the mission marker) but when he landed it was a mission on Steppe terrain. Hellrazor provided a Geoscape save and on the MissionSites, the entry was assigned to texture #4 (with Steppe being one possible option for that texture), instead of -2 (for Port Attacks).

I'm still using Nightly 2015_03_04_0147 for mod design (almost two weeks old) and I simply can't reproduce this bug using the same version of the Terrain Pack (just tried it again, Port Attack is generated, with the correct -2 texture). Of course, it could still be some other mod, which is why I haven't reported this until someone has this bug with no mods being used.

I so far had not any other Terrormissions in my testplay but everyother textureasignment to UFO Crashsites etc.. was working as expected.
I also took a look into the respective openxcom code for generating the missionmarkers, which is the place where the textures get asigned, but since i am still beginner of c++ i could not really find any error, which could have been causing this (the code looks good in my eyes).

So something else came actually to my mind, which could have caused this was, yaml.
If openxcom creates a missionmarker and asignes textures to it ( or reads them from templates which are filled with yaml data) and this asignment is correct but out of some reason the yaml input was corrupt or inconsistent or the template was read wrong then it could have been leading to this.

As so far the Ruleset get's loaded on the beginning of the game (or on restart/reload when activating a new mod), maybe there was an inconsistancy in the memory (a wrong reference or so) which led to this wrong assignment. But on the other side i find it rather disturbing that the yaml code for savegames is in general in a specific order, but the subsections sometimes a completly out of order, they are still seperated of course and do work but the order / sequence in which the subsection data appears is sometimes not following a specific identifiable rule.

I also had been having a "ghost" soldier, which was appearing in Battlescapemission of another team which was from another base, examining the savegame both soldiers had been assigned the same ID out of some reason, which i could not trace back. So i gave the "ghost" soldier an unused ID and increased the SoldierIDcount by 1 to solve this.

Those maybe related to some degree, but i am just guessing.
Title: Re: Question regarding Terror Site mission occurrences
Post by: hellrazor on March 17, 2015, 02:32:25 pm
That could be the reason then, yeh? The only mod I am using w/open xcom + updated nightly's is FMP. And presumably, that terrain pack or even FMP itself hasn't been completely updated alongside the nightlys?

The Terrainpack is up do date towards the newest mapscript and missionchanges. I am using it on my current testplay on the newest github code avaible.
Title: Re: Question regarding Terror Site mission occurrences
Post by: Solarius Scorch on March 17, 2015, 03:43:04 pm
The Terrainpack is up do date towards the newest mapscript and missionchanges. I am using it on my current testplay on the newest github code avaible.

The FMP is up to date too. Though I cannot guarantee anything if your campaign was played on different nightlies with significant changes.
Title: Re: Question regarding Terror Site mission occurrences
Post by: Hobbes on March 17, 2015, 04:58:30 pm
That could be the reason then, yeh? The only mod I am using w/open xcom + updated nightly's is FMP. And presumably, that terrain pack or even FMP itself hasn't been completely updated alongside the nightlys?

Just a little detail: the images you posted above actually show that you were not using the Terrain Pack during that game, since the Pack's additional cities are not displayed on Geoscape.

Also, I think this is not the only mod-breaking change in the last 2-4 weeks. Would be nice if somebody had the time to inform modders what needs to be updated... if nobody volunteers I will try to post it here (or in some other thread?) over the weekend...

Check this thread (https://openxcom.org/forum/index.php/topic,3287.0.html) for Nightly Changes discussion.
Title: Re: Question regarding Terror Site mission occurrences
Post by: Xylon666Darkstar on March 17, 2015, 06:59:45 pm
Different nightlies, I've restarted my games, hence the two different campaigns I mentioned. Perhaps what was previously stated as something to do with no terror missions? It is true I never once see the pink marker applied/assigned which would enable the terror sites. The lack of being the cause within the ruleset, as to the cause within the coding somewhere?
Title: Re: Question regarding Terror Site mission occurrences
Post by: Xylon666Darkstar on March 17, 2015, 07:01:12 pm
Just a little detail: the images you posted above actually show that you were not using the Terrain Pack during that game, since the Pack's additional cities are not displayed on Geoscape.

Check this thread (https://openxcom.org/forum/index.php/topic,3287.0.html) for Nightly Changes discussion.

Isn't the terrain pack within the FMP mod? Having that enabled, should enable it, yeah? I don't see an additional option for it otherwise in the mod options.
Title: Re: Question regarding Terror Site mission occurrences
Post by: Hobbes on March 17, 2015, 08:47:30 pm
Isn't the terrain pack within the FMP mod? Having that enabled, should enable it, yeah? I don't see an additional option for it otherwise in the mod options.

I haven't checked the latest versions of the FMP, so either Solaris forgot to add the additional cities or they are in a separate ruleset.
Title: Re: Question regarding Terror Site mission occurrences
Post by: Atmus81 on March 17, 2015, 09:09:56 pm
I was/am playing the latestest nightly  build with the terrain packs and a few other mods.

I too was having no terror missions in my play through.  towards the end of the game, i turned off "YetMoreUFOs" mod, and that fixed the problem.  i actually think the mod at this point messes up some other stuff as well but cant confirm (houses and grass were spawning inside some of the UFOs)

I turned on Luke's Extra ufos mod instead of "YetMoreUFOS" and that one seems to have no conflicts with the current nightly build it allowed me to do terror missions)

(The commendation/soldier stat diaries mod does not work at all, but doesnt seem to disrupt the game play in any way)

On a side and off topic note, i cant seem to break through the interior of UFOS with my plasma cannons as easily, sometimes it takes 6 shots, and my blaster launcher doesnt seem to destroy the walls inside the ufo as easily as it did in vanilla,  is this a byproduct of one of the mods or did they make this change on purpose in open xcom?
Title: Re: Question regarding Terror Site mission occurrences
Post by: Meridian on March 17, 2015, 09:35:49 pm
As mentioned above by SupSuper, there were changes in the build "openxcom_git_master_2015_03_03_0153.zip", which break the mission-related mods.

I have fixed the vanilla missions in FMP 1.0 (infiltration, base, retaliation and terror site), so that we can have our terror sites back. Ruleset attached. Enjoy!

PS: I have NOT fixed the new missions added by FMP.
Title: Re: Question regarding Terror Site mission occurrences
Post by: hellrazor on March 17, 2015, 09:38:14 pm
I was/am playing the latestest nightly  build with the terrain packs and a few other mods.

I too was having no terror missions in my play through.  towards the end of the game, i turned off "YetMoreUFOs" mod, and that fixed the problem.  i actually think the mod at this point messes up some other stuff as well but cant confirm (houses and grass were spawning inside some of the UFOs)

I turned on Luke's Extra ufos mod instead of "YetMoreUFOS" and that one seems to have no conflicts with the current nightly build it allowed me to do terror missions)

(The commendation/soldier stat diaries mod does not work at all, but doesnt seem to disrupt the game play in any way)

On a side and off topic note, i cant seem to break through the interior of UFOS with my plasma cannons as easily, sometimes it takes 6 shots, and my blaster launcher doesnt seem to destroy the walls inside the ufo as easily as it did in vanilla,  is this a byproduct of one of the mods or did they make this change on purpose in open xcom?

Interesting to know!
LukeExtraUFO's only adds variant of vanilla UFO's and only contains UFO maps and a ruleset file with only map part.

I guess YetMoreUFO's is missing some of new settings which were introduced in the newest code in aliendeployments or something related to this. Or even worse a redefinition of the alienmissions. Gonna take a look.
Title: Re: Question regarding Terror Site mission occurrences
Post by: animal310 on October 16, 2017, 02:01:02 pm
SOLAR'S NEW UFO'S  is also unfortunately causing this error.

--- posts merged ---

Ok this can be fixed by coping the relevant code from the Alien_Armour_Expanded 1.5b MOD.

17/10/2017

Issue now fixed on SOLAR'S NEW UFO'S download