OpenXcom Forum

Modding => Released Mods => Topic started by: Shoes on November 09, 2013, 02:22:13 am

Title: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on November 09, 2013, 02:22:13 am
11/29/2015 : Stats portion has been merged into the base game. This mod now only provides commendations.

Code: [Select]
08/17/2015 : Merged with the Aug 11th nightly. Untested.

07/22/2015 : There are a few lingering bugs, but stats are being tracked fine. When the bugs are fixed, the commendations can be reset and regiven correctly. Changes are: ufopaedia has a proper commendations entry that has been reordered by Arthanor! Also, the mission details window is enlarged to properly show a mind controlled unit, and psi-related totals are displayed in the kill screen. Psi-related "kills" are still mixed in with regular stats, in order to avoid code duplication.

05/25/2015 : A few commendations are now only awarded for a victory. Thanks to Fudgedragon for bringing this mod up to date with the May 22nd nightly! Hopefully nothing went wrong with uploading the files... it's been a while. A Lost in Service screen has also been added in the mission debriefing.

02/08/2015 : Nightly and Legacy have been updated with new commendations, along with new art. I think there are about 50 unique commendations now? Some of the art is placeholder, however.

01/10/2015 : ivandogovich's ufopaedia mod has been merged into this mod! The French, Italian and Russian translations have been correctly uploaded to the 1.0 version of the mod. Nightly will be a little while longer :)

10/13/2014 : Fixed kills/stuns by melee weapons granting Nike Cross and Order of the Hammer. Improvisation kills/stuns are no longer checked for battle or damage type. Both legacy and nightly have been updated.

10/11/2014 : Added missing lines back to the ruleset.

10/07/2014 : Sync'd with master branch. Added 3 languages! Thanks to SiceX fro Italian, Erased for Russian and werbfred for French!

7/18/2014 : Added missing strings.

7/17/2014 : Added Nike Cross, updated rulesets to reflect the updated code, fixing silly bugs!!

7/08/2014 : Fixed Swiftness medal, added Prowler Cross, fixed modular medals!

6/21/2014 : Base defense locations now save properly. Merged with nightly.

6/20/2014 : Fixed a crash when playing a New Battle. Merged with nightly.

6/15/2014 : Merged with nightly.

5/13/2014 : Memorial works properly. Merged with nightly. Github updated.

5/08/2014 : I play tested and fixed a few things. Also, the person who killed the cyberdisc that killed the whatever now gets credit for that kill!

5/01/2014 : Memorial now works :)

4/30/2014 : More content! I am up to 23 commendations now. Also, lot's of behind the scenes stuff so that save files are less silly. This link has also been merged with the nightly last night.

4/23/2014 : New experimental link. https://dl.dropboxusercontent.com/u/234369005/OXC/04232014%20Commendations%20Mod%20UNTESTED%20MORE%20STUFF.zip

4/21/2014 : Merged with nightly. Also, here are some experimental changes: https://dl.dropboxusercontent.com/u/234369005/OXC/04212014%20Commendations%20Mod%20UNTESTED%20MORE%20STUFF.zip

4/4/2014 : Merged with nightly.

3/30/2014 : Merged with the latest nightly, and added a lot more control over kill related commendations. For example, there is now a commendation for using Incendiary weapons (vanilla only has the Incendiary rocket) and another for killing alien soldiers from each race.

3/24/2014 : Warboy fixed a silly rank oversight in the ruleset, and with his help I was able to rewrite how race and rank are decided for units.

3/23/2014 : Split the ruleset! This mod is now proper in the sense that it does not touch the vanilla rulesets. Replacing the .exe is inevitable, however. Github branch was force updated, so beware of that.

3/18/2014 : Updated the game to match latest changes by devs.

3/7/2014 : Fixed the little mission summary window size problem, and recalculated stat totals instead of updating them (and not saving them which was a bad thing). Only the .exe has been updated

3/6/2014 : Fixed a silly bug that meant you couldn't play past a month using this mod... Oops. Only the .exe has been updated.

2/24/2014 : Sprites scroll!! Also, UFOs now properly display their names in the little mission log window. Links are up to date, however only the .exe and the ruleset has been changed. In the ruleset, I only changed the Merit Star's criteria, so if you did it yourself, then all is well.

2/22/2014 : Fixed HWP bug.

2/21/2014 : Added sprites and commendations to this mod. Commendations do not grant soldiers bonuses. One issue : commendation sprites do not scroll, but nothing crashes. It just doesn't scroll. The github history as been rewritten, so mind that.

1/17/2014 : Finally uploaded my mind control fix. This iteration contains work from my achievement mod, so a ruleset is also needed.

11/18/2013 : Fixed a stun logging bug that crashed the game if the player fell unconscious due to smoke or other environmental effects. Fixed a bug that credited Scout UFOs to terror missions. Here are some more screenshots : https://imgur.com/a/o6OXh. Updated executable and git branch.

11/10/2013 : Kills that are not made by weapons (exploding gas pumps) are credited to the weapon "Improvisation". Wounds are tracked and displayed in mission totals and specific mission information. Git branch updated, dropbox .exe updated.

11/10/2013 : I made some more UI changes. Some basic totals are now displayed in the totals screens, as well as button visibility changes. My git branch's history has been rewritten if anyone is merging it, so beware of that. The dropbox link is also now a public link, so that's good too.

11/9/2013 : _Shadow gave me a lot of feedback on UI stuff, and now things look a ton better. If there are more suggestions, let me hear them. Next thing I want to add are tallies on the kill and mission screens; simple "total missions> #" and the like. Links updated.

This mod tracks more stats for individual soldiers and adds a button to the soldier info screen that allows you to view said stats. It is feature complete, but not everything that is being tracked is shown. I will probably add more information to the career totals screen, but if you have requests, or more importantly suggestions on how I should lay out this information, I am all ears. Also, pallet and background image suggestions are welcome as well.

For those using github : https://github.com/Shoes01/OpenXcom/tree/alpha_release

Link to the .zip containing the ruleset and resources : https://openxcom.org/forum/index.php/topic,1718.msg55250.html#msg55250
Link to a ruleset using the updated syntax: https://openxcom.org/forum/index.php/topic,1718.msg79897.html#msg79897

Link to the .zip containing exe, ruleset, sprites and the README (this is no longer necessary if you use the latest nightly) :
Nightly version : https://dl.dropboxusercontent.com/u/234369005/OXC/2015-08-11%20Nightly.zip
Latest 1.0 version (reported to crash on start) : https://dl.dropboxusercontent.com/u/234369005/OXC/2015-02-08%20Legacy.zip
Old 1.0 version : https://dl.dropboxusercontent.com/u/234369005/OXC/10132014%20Legacy.zip

The following forum post contains various alternate versions of this mod, including OpenXCom Extended : https://openxcom.org/forum/index.php/topic,1718.msg45954.html#msg45954

New button :
(https://i.imgur.com/Rf1dwzy.png)

List of missions :
(https://i.imgur.com/ukXTKKo.png)

Mission specific details :
(https://i.imgur.com/WqFnjKm.png)
(https://i.imgur.com/vVEFLws.png)

Career totals by kills:
(https://i.imgur.com/VHpxTLt.png)

Career totals by mission:
(https://i.imgur.com/gnRFfGQ.png)

Commendations:
(https://i.imgur.com/WzVFos4.png)
(https://i.imgur.com/KhOMgR4.png)
(https://i.imgur.com/ug2kZD4.png)

Commendation award screen:
(https://i.imgur.com/s7Jy7I5.png)
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Sharp on November 09, 2013, 03:03:08 am
So for further suggestions to this awesome piece of work, perhaps a mission diary for past missions, this could essentially just be the standard mission debrief screen but maybe have an additional space or button to view list of soldiers who went on that mission, not a clickable list (as perhaps many of them died), that might be harder to track though.

As for soldier tracking it looks pretty good, only other things I could think of adding are listing wound history (i.e. 5th Jan Medium Scout, wounded 5 days) and/or total time in sick-bay and maybe rank progression date in diary but these are both extremely minor things which don't really add much, just like the only things not in the mod yet, the alien kill tracking is great.

I am wondering how Dominique Garcia killed 4 sectoids, a floater and a reaper on a Medium Scout mission, or is it just that terror mission doesn't show up as UFO type (as it's not a UFO durrr)?

Thanks for this, im going to have so much fun now :D , Just wondering though are you keeping this fairly close to nightly builds or just going to wait until it gets merged (as it so rightfully deserves)
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on November 09, 2013, 04:02:44 am
So for further suggestions to this awesome piece of work, perhaps a mission diary for past missions, this could essentially just be the standard mission debrief screen but maybe have an additional space or button to view list of soldiers who went on that mission, not a clickable list (as perhaps many of them died), that might be harder to track though.

Another thread talked about a "leaderboard" of sorts; it would be like tracking the same stats as soldiers, but instead of you the commander. It would be very similar to what I have accomplished here, but that would have to wait until after I make my medals mod.

Quote
As for soldier tracking it looks pretty good, only other things I could think of adding are listing wound history (i.e. 5th Jan Medium Scout, wounded 5 days) and/or total time in sick-bay and maybe rank progression date in diary but these are both extremely minor things which don't really add much, just like the only things not in the mod yet, the alien kill tracking is great.

Wound history I want to add, because that's a great number to look at. I also thought about having another list but for mind controls, but that might be pushing it. A number might be enough but depending on how the MC code is written, I could probably still track it though, for my medals ;p when I get to work on my medals mod again, keeping track of dates for promotions would be a good idea.

Quote
I am wondering how Dominique Garcia killed 4 sectoids, a floater and a reaper on a Medium Scout mission, or is it just that terror mission doesn't show up as UFO type (as it's not a UFO durrr)?

You're right, terror and base missions don't have a UFO. I will be adding a list of mission types as well.

Quote
Thanks for this, im going to have so much fun now :D , Just wondering though are you keeping this fairly close to nightly builds or just going to wait until it gets merged (as it so rightfully deserves)

This current build includes the nightly. I will probably not bother to update it too often, but it's easy for me to do, so if there is a new feature that you need from the nightly, let me know! Also, if you're going to use this mod, please let me know if you run into formatting issues :) Like certain names getting cut off or something. I tested for functionality, but I haven't really tested for beauty!

edit : Shadow gave me some good feedback on the IRC, I will be posting new screenshots of a much prettier mod tomorrow!

--- posts merge ---

Wounds are tracked, updated screenshots and exes.

--- posts merge ---

Fixed a stun logging bug that crashed the game if the player fell unconscious due to smoke or other environmental effects. Fixed a bug that credited Scout UFOs to terror missions. Here are some more screenshots : https://imgur.com/a/o6OXh. Updated executable and git branch.

Edit : More screenshots : https://imgur.com/a/UGBEE
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: xracer on January 08, 2014, 02:15:43 am
I guess this is what you were talking about Shoes, i guess i was away for so long that i didn't even realized this existed :O, but man this will e fantastic for a service record, basically tracking all the stats for all your soldiers, a lot of work but looks awesome!!!!
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on January 16, 2014, 09:49:48 pm
Yeah, I sort of have "two" mods going on, but really it's one mod with parts A and B.

This was part A :) I forget the .exe has the fix for mind controlled units; it may not.

What's left for part B, award medals, is extracting the numbers from the diary. And probably make things more efficient.

--- posts merge ---

I have decided that I will start a "battle log" as well, so that I can more easily track certain stats for my achievments mod.

At the moment, I will track : when turns change, when units are spotted (by who, how far), when units fire (reaction? did the hit land? what body part did it hit? who/what did it hit? what weapon? how much damage?)

I would like to think that such a log would be helpful to others, but really, this is just so I can give commendations to soldiers who kill x many in one turn, or reaction fire while under 4 hp, or shoot their teammates in the back from less than 2 tiles away, or land head shots from 25 tiles away. You know.

This may evolve into a "commander log", which could be tied into a commander leaderboard, which was discussed when I first brought up my achievements mod.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Sharp on January 17, 2014, 10:45:48 pm
Sounds brilliant, looking forward to it :D
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on January 18, 2014, 01:25:26 am
Added a fresh link to the .exe with a link to the ruleset for commendations.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: SupSuper on February 05, 2014, 05:42:03 pm
We tried to set this up in the last live stream, but I couldn't get it to compile and the exe kept giving DLL errors. :(
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on February 05, 2014, 09:24:51 pm
We tried to set this up in the last live stream, but I couldn't get it to compile and the exe kept giving DLL errors. :(

Thanks for showing interest! I was busy all weekend, which is a shame. I would like to take time and patch things up so that the mod is shareable. March break is coming up...
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: hszp on February 07, 2014, 03:19:32 pm
Awesome!
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: BlackLibrary on February 09, 2014, 01:45:37 am
I've been waiting about 19.5 years for this mod.  Literally.  Must you let your education and future get in the way???  :)   This helps bring out to the RPG flavor to XCOM that was always there right under the surface.

Quick questiono:   If you could also show the date the Soldier joined XCOM?  Or Base transfer dates?  My lord...with all the info there, I could -literally- autoscript the framework of a short story using the material your log/diary could produce alone. 
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on February 09, 2014, 05:06:03 pm
Quick questiono:   If you could also show the date the Soldier joined XCOM?  Or Base transfer dates?  My lord...with all the info there, I could -literally- autoscript the framework of a short story using the material your log/diary could produce alone.

At the moment, I track how many months a soldier as been on the team so that I can award a service medal. Getting a date out of that should be easy.

Tracking transfer dates and stuff I could do too, but I am not sure how important that is ;p Next time I dive into my code, I might look at tracking it; in a related note, I've been meaning to track award dates too, so it's all related I guess.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: ThatDude on February 16, 2014, 06:35:56 am
Is this finished, and/or released to the public yet? (I'm only asking this because I've searched for some time and haven't found a download link)
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Fox105iwsp on February 16, 2014, 08:28:28 am
There are links above the pictures in the first post.

But I'm also curious, do I need github for this to work, I never got this to work >_<
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on February 17, 2014, 12:42:46 am
To be honest, I don't know how to distribute this ;p I've made source code changes, so it is more than just a ruleset mod. As such, you need to download the executable. But maybe you also need to download the new art assets I made? Now that people are showing interest, maybe I should renew my efforts :3
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: SupSuper on February 17, 2014, 02:18:50 am
Yeah to distribute it you'd basically have to bundle your own exe/dlls/ruleset/stuff much like Warboy's old mod.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: BlackLibrary on February 17, 2014, 03:37:58 am
To be honest, I don't know how to distribute this ;p I've made source code changes, so it is more than just a ruleset mod. As such, you need to download the executable. But maybe you also need to download the new art assets I made? Now that people are showing interest, maybe I should renew my efforts :3

Did you make your change based on the most latest source, or is it old source with changes made long ago?  Makes a big difference and might explain why it did not work for the OP.  You've got folks interested.  Spot lights on you, Shoes!
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on February 17, 2014, 01:53:04 pm
Did you make your change based on the most latest source, or is it old source with changes made long ago?  Makes a big difference and might explain why it did not work for the OP.  You've got folks interested.  Spot lights on you, Shoes!

Every time I revist my mod, I pull in the newest changes from SupSuper. I don't think I've worked on this for maybe a month :( starting Thursday though, I will have more free time, so I think I will try and release something playable!
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Mr. Quiet on February 17, 2014, 07:49:37 pm
That's great thanks Shoes. Can't wait for an update!
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: AzureSkye on February 17, 2014, 08:15:41 pm
Maybe make a diff patch file? Or push the source and get it added to the trunk :P
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on February 17, 2014, 10:52:31 pm
I do have a git branch for it, which I think is functional if people want the source. However, I tend to finish a fix, and then leave the project without pushing the fix to gitub...

All this attention is great though :D
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: AzureSkye on February 18, 2014, 01:07:30 am
This is something I really really want to play with! It gives personality to the otherwise faceless drones. Kinda like customization for EU and EW
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Mr. Quiet on February 18, 2014, 03:41:34 pm
Same too, I love the idea of making this extra info accessible to us.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on February 21, 2014, 12:06:43 am
I have one more nut to crack and then I think I will be happy.

https://i.imgur.com/3bCSyvn.png

I've gotta find a way to get the commendation sprites to scroll with the text lists. After that, the only thing that will be missing is more stats to make more medals. Everything else will be feature complete, I think.

I could also clean up the code probably...
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Mr. Quiet on February 21, 2014, 12:51:00 am
Damn how the heck did you get medals into the game?! I've been waiting for this for a long time!! Well since I saw it in the 2012 game.

For naming badges, I'd like to see badge names from Nations in the CFN since X-COM is an international force. Translated names would be nice too. Or have a new set of badge names just for X-COM Operatives. I'm only saying this because you called them all Merit Star. Is this correct or are you going to change the names of them?

Beautiful work to say the least, Shoes.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on February 21, 2014, 01:05:12 am
I was testing scrolling issues and checking decoration and ribbon sprites, so I modded the save game to show more medals. They all have different names, and will be somewhat moddable too! Each stat that I track can be used in a medal commendation, but you wouldn't be able to mod "headshot medals" without writing code to track headshots.

I agree that it would be really cool for countries to give their own medals, but that may be difficult... at the moment, I have "X Campaign Medal" for having Y amount of missions in country X.

However... it could be possible to create unique medals from different countries. It would just require manually adding each and every one, unlike my generic "X Campaign Medal". The more I think about it, the more I like the idea of a "Order of Canada" commendation for having like, 10 missions, 3 terror missions, 50 kills, 5 stuns, 0 civilian kills, 0 friendly fire... you know, something super unique.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Mr. Quiet on February 21, 2014, 01:14:25 am
The more I think about it, the more I like the idea of a "Order of Canada" commendation for having like, 10 missions, 3 terror missions, 50 kills, 5 stuns, 0 civilian kills, 0 friendly fire... you know, something super unique.

Yeah that's something I would really keep track of. The headshot medal maybe not. Immersion breaking, unless the military keeps track of that sort of thing. Maybe now they do for the growing military crowd with COD experience.

Where's Warboy or Sup, we need them to fix your problem and then we can have this mod!
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: alienfood on February 21, 2014, 02:50:52 pm
You could try pushing the mod in pieces. For instance, first push any new data structures, even though they may not get used anywhere. Then push the data collection. Make sure the save file changes do not break anything. Then push the GUI changes along with an INI switch to turn it off.

Probably, the powers-that-be may find this acceptable after 1.0, which can't be long now.  ;D
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on February 21, 2014, 07:18:05 pm
I was looking pushing the mod without the medals, and only having the stat tracking. However, over time, the two became very intermingled: I would track certain statistics for the purpose of a medal, and would work from both ends.

I am down to (what I think is) the final puzzle piece. If I really can't crack the nut, I might just push the mod anyway, and we would have non-scrolling-sprites.

Maybe that's what I will do tonight... try to publish the mod despite this imperfection that only becomes a problem when you have like 10+ medals. The savegames would not be affected by a fix either, so that's good :)
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Mr. Quiet on February 21, 2014, 09:36:52 pm
Yes That's perfectly acceptable to me, go for it, tonight!  8)
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: ThatDude on February 22, 2014, 12:30:44 am
I'm seriously glad I brought this up!  ;)
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on February 22, 2014, 04:14:23 am
I updated the first post with links to download the .exe and other assets, as well as the next github branch. Let me know if you run into trouble running this, because I have no idea how to test things!! :D

edit : I am testing this myself, and I am running into trouble with .dlls.

edit : tried using a different compiler, but wow that's a lot of hoops to jump through. I will instead go to bed and hope that someone more knowledgeable fixes my problem :x
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Fox105iwsp on February 22, 2014, 11:13:28 am
I think it works....crashes when I bring a HWP/Cannon on a mission >_<
also no button markings...
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on February 22, 2014, 01:36:26 pm
I forgot to include the language file! Here is the link, but it in the data/Language file : https://dl.dropboxusercontent.com/u/234369005/OXC/en-US.yml

If you made mods to your English US file, you will have to do them again after you paste my file over it.

I thought I took care of HWPs, but maybe I never actually tested anything... I will look into it! No promise that I will have a fix today since I am going to be a little busy :3 but thanks for testing!

edit : The files have been updated with the fix, thanks!
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Fox105iwsp on February 22, 2014, 03:10:58 pm
Thanks for your mod ^-^ take your time testing it
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on February 22, 2014, 05:58:18 pm
So Fox105iwsp, did you follow my instructions for getting the mod to work? Because I can't get my own mod to work when I try and run it normally; I keep getting DLL problems. Did you put all the DLLs in the same folder as the .exe like I instructed?
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Fox105iwsp on February 22, 2014, 06:01:20 pm
Yup, copied all the .dlls to the main folder with the .exe, it loaded, I can play even with add-on armors and weapons. But when I bring HWPs, it crashes >_<
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on February 22, 2014, 06:07:43 pm
But when I bring HWPs, it crashes >_<

If you redownload the .exe and the language file, it should be fixed. The crash was caused by me trying to access the HWPs rank; it doesn't have one.

It's great that there are no conflicts with other mods; they only issue with how I am sharing this is that you can't update the game yourself. You would need to wait for me to pull the latest changes into my mod, make a new .exe, and then share it.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Fox105iwsp on February 22, 2014, 06:08:58 pm
Okay, I'll give another shot
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Fox105iwsp on February 22, 2014, 06:16:28 pm
Coool! ^-^ I think it works fine for now
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Mr. Quiet on February 22, 2014, 06:31:53 pm
When I get home I'll see if I can get the mod working. Thanks again shoes, for releasing this early!

Fox, can you tell us what mods you are using? What is that blue and black machine next to the tank?
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Ascadix on February 22, 2014, 09:54:10 pm
Maybe a recoulored amphibious tank "Coelacanth" from TFD  ?

I wonder where can i find this re-designed SkyRanger ?
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Fox105iwsp on February 22, 2014, 11:01:06 pm
Nuts >_< I was so happy to get this great mod to work, I let the cat out of the bag >_<

Yes, I've been building my own custom mods:
-Advance Armor Systems
- Hero Armor & Weapons Systems
- Advance HWP Line Up
- New Fighter or two
- 3 New Transports, 5 if you count Alloy Variants
- Expanded Standard Weapon Lineup
- Melee Weapons

A lot of them are only just passed Field testing, I haven't added Research trees or Manufacturing systems yet >_<
Here is my STAR RANGER? (Advance Sky Ranger) preview. Not quite done yet >_< and yes, what you see is an Alloy Version of my Recon Tank/ Minigun Unit. A recolored TFTD Coelacanth with Twin fixed Miniguns, no turret >_<
Also waiting for the Pirates Mod, it can help speed up some of my builds ^_^

Also, a research QUIZ for everyone seeing this, Who can Recognize the first Two Pics right away? Who is The Gold Guy & Who is the Armored Suit? These are some of my family favorites, just seeing who knows them ^-^
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Ascadix on February 23, 2014, 12:21:41 am
Mhhhh ....

Gold Guy -> "Captain Power" from the serie "Captain Power and the Soldiers of the Future"

And the dark One, "Tank" from the same TV series


LOL .. it's a time machine this mod.


I like a lot your "Star Ranger" and the others units .. do you plan to release them one by one or in a pack in near futur ?
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on February 23, 2014, 12:35:28 am
Fox105iwsp, did everyone get a bunch of Merit Stars? I think the ruleset I am sharing is my debug Merit Star... where if you kill 0 aliens, you can get up to the 4th award or something. I updated the ruleset in the zip so that it's not so easy to get.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Fox105iwsp on February 23, 2014, 01:11:36 am
Yeah, I thin I saw that ^-^ People hiding in the back of the skyranger  unarmed, get Medal pins for lots of kills ^_^

I'll try the new one ^_^ (Got error 404 from dropbox >_< )


As for mu mods, I'll release them when they are ready, in separate mods so you all can chose what you want ^_^

Top Marks for Identifying  "Captain Power" ^_^ But the second one is not "Tank" >_<
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on February 23, 2014, 01:25:19 am
Alternatively, you can just modify the ruleset yourself :)
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Mr. Quiet on February 23, 2014, 01:44:37 am
The second one looks like Boba Fett or his dad's armor. Anyways, great description of mods.


I still need to get home soon and check out this mod!! I current have lots of mods, so I should remove them first before installing this? My save will probably break if I play without some of those mods. I'll just start over no biggy.

Thanks everyone
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on February 23, 2014, 07:46:25 am
If you've made changes to any file that I am asking you to replace, you will have to re-mod them.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Fox105iwsp on February 23, 2014, 11:57:36 am
I've tested this with all the mods I have and are currently building, they work! ^-^
Even thee latest Firing Sound Mod works (Where your weapon sounds different according to the magazine loaded )
Minor error involving Blaster Launcher, or is this error always present?

Will proceed with further testing, Medal earning and such while building my mods ^_^

As for the second Armor I showed, I guess its too obscure and old, even if it's one of my favorites  >_<
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on February 25, 2014, 02:09:32 am
Sprites now scroll :) also fixed the UFO names being bonkers -- if you want to fix that, you will need to mod your save file or restart a new game.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: ceilingrat on March 04, 2014, 05:05:58 am
Brand spiffy new here, this mod is rather awesome.
One small problem however. I'm getting the 'invalid sector [T] subscript' error when I complete a UFO Recovery with a Terror Ship. The first UFO Recovery I did on Large scout went fine.

I do have other mods installed, but I haven't had any crashes until I installed Soldier Diaries. Mods installed are Grenade Launcher, Shotguns, Combat Armour, Custom Grenades, Quickdraw and Firestorm Restyle.
I'm using the nightly 2014_03_02_0717.

Am I getting this crash because the nightly is too advanced?

Savefile attached, end turn a few times and voila! Floater exits UFO, my guys shoot, end mission, crashes at turn screen.

Cheers,

Ceilingrat
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on March 04, 2014, 07:33:52 pm
If you replaced the .exe you downloaded from my zip with the .exe downloaded from the nightly, then you will have wiped out my mod. Your save game would still have all the information from commendations and stats and all that, but I don't think that would cause the crash...

For some reason the save file is not working. Can you post a save from before you started the mission? I will also try and check on my side of things what happens when you shoot down a terror ship and then start the recovery mission.

edit: could you try something for me? Could you start a "new battle" against a terror ship and could you beat it? If you enable debug mode in your options.cfg (located with your save files), you can ctrl+D to enable debug and then ctrl+K kill all aliens.

I am able to test against terror ships and "win" using debug, and there are no crashes.

I am also told that if you tried to remove mods from your current game, that would cause issues.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: ceilingrat on March 05, 2014, 04:42:23 am
New battle against a Terror Ship - Won ok using debug.
I do have a save from after I shot down the terror ship in the Geoscape.
I installed the nightly first, backed up all files that would be replaced by your mod, then installed the mod.


I received medals before this mission fine.


Now, I had to futz around with the language file (coz I hate USA spelling). Copied and pasted the relevant bits from en-US to en-GB in the same spots (Notepad++ for the win!). Also changed medal names to reflect a more British outlook.
I did switch the language back to en-US, still had the crash.


Also pointing out an error with the night terror mission medal description, you're missing an 'r' in the word horros.

edit: just tested with debug mode on the Battlescape save and the Geoscape save after mission start. Had same crash.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on March 05, 2014, 05:48:01 pm
I installed the mods and I am still not able to load your game; it keeps crashing on armor related things, despite my having downloaded the armor mods.

Does the game crash at the end of turn screen? Or does the mission end, you see your score, you get your promotions, and then when you're supposed to see your medals, it crashes?
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: ceilingrat on March 06, 2014, 04:35:50 am
It crashes at the end of turn screen after last alien dies. My guys have killed the last Floater with a reaction shot on the alien turn. End of turn screen, boom!crash!.


I'll start another game and see if I get the same problem.


The armour is Combat Armour by Warboy1982. It's the only armour-related mod I'm using.


What does the 'invalid vector subscript' thing mean anyway?

edit: installed openxcom with nightly build from feb 23 into different folder. installed only soldier diaries. will see how this goes.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: ceilingrat on March 06, 2014, 08:28:01 am

Preface, because I forget my manners far too often. Thanks for all the help you've given and in advance. I really do need to start learning this stuff, so I can help more.

Did new testing with clean install. Nightly build openxcom_git_master_2014_02_23_1921. Only installed Soldier Diaries. Backed up files and overwrote DLLs, .exe, .rul, and the language file. Plopped resources into resources folder as instructed.


On second mission overall after the awarding of XCOM Service Medal. First mission in Feb is the monthly terror ship I've managed to shoot down.
Killed the last alien, end turn. 'Invalid sector T subscript' crash.


WTF? Much confusion. I have no idea what is going on.


Anyway, I've attached save from after the last alien is dead but before mission over.


New post 'coz I couldn't attach a file to old post.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on March 06, 2014, 02:10:38 pm
Awesome, thanks for the save. I will look into it shortly. I think the crash has something to do with one of the lists I have; I haven't actually ever tested a crashed terror ship, so it may be a simple oversight on my part. Once this is fixed, you should be able to resume your previous game.

You also mentioned modding the commendations a bit; feel free to feedback on them too :) I am glad you're using and enjoying the mod! Minus the crash.

edit: the bug is me trying to award a medal when there are no more awards to give. Expect a fix later today! :D

edit: in case you're in a hurry for a fix, you can remove the entry of Honor Cross from the ruleset. Or you can add another entry for like 999 or something in the []s.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: ceilingrat on March 06, 2014, 05:04:21 pm
Much appreciated.


I will wait for the fix, however in a (minor) fit of annoyance, I deleted the saves. Then, with much facepalm, I realised I have them uploaded to the forum.


Testing will commence sometime tomorrow.


Also, I have attached the en-GB language file. For those of us who prefer the proper spelling of the English language.


It's possible I missed something.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on March 06, 2014, 06:45:04 pm
I updated the .exe with the fix. I am working on segregating my rulesets like a proper mod should, and then I will update again and include your GB language file :)
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: ceilingrat on March 07, 2014, 02:59:48 am
I've gone and goofed (I think). The language file I uploaded is the standard one.
New one attached.


Also, I've noticed that language stuff can be added at the bottom of your ruleset file under 'extraStrings'.

Tested game, I can now end mission and I now get a lovely debriefing screen.
Just noticed, if a soldier gets more than 3 kills/stuns in one mission, the info box that pops up when you click on the mission (the mission details), doesn't fit. Can scrolling be fitted?


Here's to helping!
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on March 07, 2014, 04:18:48 am
Tested game, I can now end mission and I now get a lovely debriefing screen.
Just noticed, if a soldier gets more than 3 kills/stuns in one mission, the info box that pops up when you click on the mission (the mission details), doesn't fit. Can scrolling be fitted?

If you're saying the little text info box can't fit more than 3 lines and that it is not scrolling, then there is a little bug to investigate. The scrolling should be a non issue; it could be I copy pasted some code incorrectly. Thanks again!
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: ceilingrat on March 07, 2014, 05:19:19 am
Me again.


In the Soldier Record:


It seems the listings for Kills and Missions reset every month. (Click on the kills button to see list of kills by weapon, of alien type, of alien rank. Click on the missions button to see missions by location, type, ufo.)


Only the last mission of the previous month appears to match up with mission details info box. The previous two appear in the mission details info box, but their stats aren't in the other Soldier record screens.


Save attached.


I really like this mod, so you'll most likely be hearing from me lots as I find stuff.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on March 07, 2014, 03:40:06 pm
Is this the issue you were talking about? https://imgur.com/6bBeJCl

I will fix this then look into the "rests every month" thing you mentioned.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: ceilingrat on March 07, 2014, 05:02:00 pm
That's it. Sometimes there is a scroll button for more than 3 lines but often it isn't there. And when you do scroll down, the very bottom line can hardly be seen.


I like looking at nice big lists of my guys being awesome. :D
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on March 07, 2014, 05:31:17 pm
I toyed with the window size so things are more proper: https://imgur.com/tlbkJ6L

I also found the source of the bug you mentioned about stats disappearing: I wasn't saving them! I am gonna find out if its better to save them or to recalculate them. I am inclined to recalculate them, so nothing will be lost if that's the case.

edit: updated the download link with a fresh .exe with those two fixes. Lemme know when you find more!
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: ceilingrat on March 08, 2014, 02:55:52 am

(insert happy dance here)

- Mission details now display correctly.
- Stats in Kills and Missions are now there and very shiny. ;D
- Minor Niggle - Long weapon names get cut off in mission details info box. Screenshot attached. My grenadiers happen to be little trigger-happy.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on March 08, 2014, 06:08:21 am
I will increase the size of the window some more, or I will look to see what text wrap will do. Text wrapping might be a more long term solution.

I also appreciate you helping me out like this! It's fun to know someone is actually playing with the mod :)
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: LouisdeFuines on March 08, 2014, 05:43:45 pm
I would like to use that mod but fear, I produce a crash, when replacing my working ruleset with yours.

How is it possible to play with the latest nightly build AND using your ruleset?
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on March 08, 2014, 06:47:18 pm
How is it possible to play with the latest nightly build AND using your ruleset?

If you didn't mod your ruleset, I am pretty sure you can copy paste. I don't think there have been changes to the ruleset. I am working on moving my rules into its own ruleset.

When is your game crashing? Is it on launch? Is it complaining about DLLs?
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: LouisdeFuines on March 08, 2014, 07:05:42 pm
Excuse me, I should`ve explained.

I was only worrying. When you`ve made your own ruleset, I`ll immediately use your mod.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: kharille on March 08, 2014, 07:21:38 pm
Hm, any room for additional information like age, height, weight, cv and all? 
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on March 08, 2014, 07:34:51 pm
I was only worrying. When you`ve made your own ruleset, I`ll immediately use your mod.

Hopefully before the end of the weekend!

Hm, any room for additional information like age, height, weight, cv and all? 

Most of the work needed to do that would be laying down the foundation, but it could be done the same way that stats are determined, even defined via ruleset or something. Maybe after 1.0 comes out I could look into adding age/height/weight. CV would be tricky because it's more than just a random number, but doable too I suppose.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Solarius Scorch on March 08, 2014, 08:09:35 pm
Hm, any room for additional information like age, height, weight, cv and all?

I loved that one feature in Xenonauts: each soldier also had a nationality (well, they sort of do here, it just isn't displayed) and, lo and behold, their original military unit (for example SAS) and combat experience (for example Afghanistan). I think it really added to the characters and would love to see something similar here.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: kharille on March 08, 2014, 10:26:51 pm
Oh yeah, must've got it from watching Xenonauts or Silent Storm.  I suppose, its just rpg value, like this guy is an urban combat specialist, that guy is a desert fighter, so and so trained in the arctic and all...   
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: LouisdeFuines on March 09, 2014, 01:12:26 am
Please tell us, when your own ruleset has been done! :-)
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Fox105iwsp on March 17, 2014, 06:54:42 pm
I have a request please ^_^ Can this mod be updated to include Custom movesounds for units?
Warboy recently upgraded the nightly build for it, but I can't get it to work >_< Please let me know if it can be done, otherwise, I'll have to program default sound effects for my mods >_<
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on March 17, 2014, 07:36:33 pm
Yup, one down side about this being a source-code mod is that it can become out dated. I will try to remember to update the .exe with the newest nightly!

Also, as for splitting the ruleset: I think that since I am adding a new subset of rules, I might not be able to create my own ruleset for it. I have to look into it more, and it's an unfamiliar part of the source for me.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: LouisdeFuines on March 17, 2014, 10:24:19 pm
This is so sad, wished, you could optimize your mod...
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on March 17, 2014, 10:37:28 pm
This is so sad, wished, you could optimize your mod...

I will look to see if I can modify the source code further, but at the moment you have to replace the stock ruleset. It is not the proper way to do things, but if my mod is the only one doing this, then it's okay! :D
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Fox105iwsp on March 18, 2014, 12:08:55 am
I don't mind the ruleset replacement, just thanks for looking into updating your mod. It will my mod construction ^_^
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on March 18, 2014, 11:59:38 am
Merged latest changes from the devs, updated only the .exe.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Fox105iwsp on March 18, 2014, 12:13:40 pm
Cool, I'll give it a shot ^_^

Thanks, it works great!
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on March 18, 2014, 01:23:22 pm
Glad to hear it!
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: LouisdeFuines on March 18, 2014, 10:20:04 pm
I still wait, till you get an own ruleset.... Sorry.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Fox105iwsp on March 19, 2014, 12:52:57 am
Hee-hee, your lost pal ^_^ you don't know the potential you're missing ^_^
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: ceilingrat on March 20, 2014, 06:20:34 pm

Shoes,

Updated the en-GB language file. Award names sound better.


Also, I caught a bit missing when one deactivates a grenade at the pre-mission inventory screen. 'STR_GRENADE_IS_DEACTIVATED: Grenade is De-activated!' was missing from both the en-GB and en-US files. Should be next line after 'STR_GRENADE_IS_ACTIVATED'. The nightly build 2014_03_20_1130, its language files are correct. I did add this line in the attached files.


Also, ping me when you need the en-GB bits for the mod ruleset. I'll pull it out of the language file for you.


CeilingRat
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on March 20, 2014, 06:30:50 pm
Much appreciated!
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: xracer on March 21, 2014, 05:40:39 pm
Awesome work Shoes, hope to see it completed soon :)
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: ceilingrat on March 22, 2014, 05:13:54 am
Shoes,


Found something else in my travels. There's an error on the kills screen. under KILLS/STUNS by rank, I'm getting STR_HEAVY_WEAPO1. Look like somethings cut off. Now, I'm pretty sure the Cyberdisc, Reaper, Celatid, Silacoid and Sectopod come under Terrorist. And I haven't bought any HWPS at all.


Mod list - Taser Pistol, Grenade Launcher, QuickDrawB, Custom Grenades, Shotgun, Combat Armour, Firestrom Restyle(coz it looks cool).




Plus I use my own little mod ruleset that changes some stuff around, like facility staff numbers, making the laser cannon actually useful, starting time, less time futzing around at start with equipment, etc. Nothing about aliens, HWPs.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on March 22, 2014, 01:31:17 pm
It looks like it's a missing string in the language file for the "rank" of the Tank you killed. Probably a typo either in the source code, or in the language code.

I think I will have time to look at it today :)
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: hszp on March 23, 2014, 12:23:44 pm
Hey Shoes! I've tried to compile the alpha_release branch as that seemed to be the most recent one and I noticed some files missing as well as some calls with wrong arguments. I filled in the gaps from the medals branch (I think) and in the end I was not even sure that alpha_release the most up-to-date branch and I absolutely was not sure that my changes made any sense other than to get the source compiled =)
Can you please look into these source issues? Here is the link to the diffs: https://github.com/szabopeter/OpenXcom/compare/Shoes01:alpha_release...alpha_release
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on March 23, 2014, 01:42:28 pm
I think MedalsInfoState is a left over from when I rewrote the system :x That probably shouldn't be there at all. Same with SoldierDiaryMissionsState.cpp; all its code has been merged into SoldierDiaryKillsState. It also seems like you've added my old code from the medals  (SoldierMedals.cpp/.h), but all that code is inside the SoldierDiary files too.

I didn't actually expect anyone to pay attention to the git branch! I guess I have a bit of cleaning up to do :D

edit: I've removed those files, and merged with upstream master again. I am surprised you were getting compilation errors; let me know if you still get any!
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: hszp on March 23, 2014, 03:29:28 pm
It all compiled flawlessly now, thanks Shoes!
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: ceilingrat on March 23, 2014, 03:53:18 pm
Shoes,


Your erstwhile Australian helper again.


I've noticed that the latest nightly has added options and renamed some options in the advanced options and controls menus.
So I was getting the usual 'STR_(blah)' where stuff didn't match up.
However, I updated the en-US and en-GB language files and attached them to this post.


I have also pulled out the various bits and pieces from the language files for your mod. Popped them into their own file set up for extraStrings at the bottom of the mod ruleset file.


Cheers,


Ceilingrat
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on March 23, 2014, 04:52:55 pm
I've successfully split the ruleset, so everything should be cleaner now. I've also added your changes ceilingrat, and updated my git repo. However, I had to force the update because I rebased my stuff incorrectly :x so beware of that.

edit: also, I took a look a the string error you got in your screenshot, and I am not sure what happened there. The string exists, so it might be something you did while modding the language files? Let me know if it persists. The string name is "STR_HEAVY_WEAPONS_PLATFORM_LC". And now that I've mentioned this, I am not finding it anymore :x but it will be updated shortly.

edit2: updated github. Now I am worried I may have lost other things :x
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: ceilingrat on March 24, 2014, 04:39:38 am
I took a whole bunch of screenshots of where this happens. Zipped up because there was more than 5. The one with the alien base assault, I remember the only time I used a Taser Pistol was to stun the Sectoid commander.


The rest are missions where there aren't any tanks/vehicles/HWP's, etc. So I've got no idea what's going on.


I'll have a look for that string name, but it pops up for different things, so I could be up a creek without a paddle.


Will be downloading the new files and testing.


Ceilingrat
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on March 24, 2014, 11:51:55 am
Do you happen to be mind controlling the enemies before stunning them? The way my code logic works is it checks a bunch of special cases, and if they all fail, then it must be the last case : a HWP. I must have missed a special case. The new language strings won't fix that, it will just replace the STR_ with the actual string.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: ceilingrat on March 24, 2014, 05:49:17 pm
Yes, mind control, wait a turn, stun. Or mind control each turn and move important alien to safe place, and then stun.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on March 24, 2014, 06:17:29 pm
Awesome, then I can fix that. Mind control has been the root of a number of issues I've run into!

Unfortunately, fixing this will not fix your game. To clean up your game, you will have to edit the save game. Either you could remove the entries all together, or modifiy them to reflect the aliens their stunned.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: ceilingrat on March 24, 2014, 07:33:37 pm
That's cool, I'll wear it. Not far off Avenger and Cydonia anyway.
Will start new game when a) finished old game, b)fix is available.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on March 25, 2014, 12:02:21 am
Should be fixed now :)
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: BlackLibrary on March 29, 2014, 06:20:16 am
Doing some testing.  Few things:

1.  Rec'd the Blah blah of restraint after a mission.  However, I don't see the medal on anyone.
2.  On the memorial to the fallen, it would be good if you can click on a soldier and see his diary. 
3.  Would it be good to see rewarded medals in the Ufopedia somewhere?  Not sure...but it seems like an opportunity.

Big kudos on this, btw.  Nicely done!
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on March 29, 2014, 07:38:47 pm
1: You're saying you've landed some stuns, but you're not getting commendations for it? I am revamping the back end, so that will be a moot point soon enough! However, it's odd that it doesn't work.

2: I agree. I think SupSuper had coded the ability to be able to view the Soldier's stat page, which would lead to the commendations. I will check to see if I can reenable that.

3: I like the idea (and I am sure xracer would as well) of creating a Ufopedia page for each medal with the large sprite + medallion for each commendation. I also like the idea of having a list where you can see how many commendations in total you have unlocked. If I get around to doing that (not a big art guy), it will probably one of the last additions to the mod.

Thanks for the feedback! I am glad that you are enjoying it :)
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on March 30, 2014, 10:45:20 pm
Big update! Kill related commendations can now be very finely tuned. A commendation can be awarded for stunning a mind controlled high ranking soldier simply by adding it to the ruleset. I plan on adding a few commendations for stunning alien leaders for example. At the moment, it would still give you the commendation even if the alien woke up after getting stunned, however...

Also it has been merged with the nightly, so you can play with the new UI changes too.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: ceilingrat on March 31, 2014, 06:35:33 am
Shoes! Shoes! Shoes!


Updated! Much happy! Serious Awesome!


I've figured out far more Commonwealth style names for the three new awards.
Medal of Heroism - Gollop Cross. Coz hey without the Gollop, XCOM wouldn't exist.
Hellraiser Medal - Inferno Star. Also, anyone with one would be unofficially nicknamed some form of pyro, firebug or nutcase.
Distinguished Service - Order of the Hammer.


I'm really reluctant to use the names of specific medals, like Medal of Honour, Victoria Cross, Distinguished Service Medal or Cross, etc. It cheapens those who earned the things in my mind.
Also, small things!
In the distinguished service description you have soldirs, needs an 'e'.
EN-GB is missing both strings for the Distinguished service award.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on March 31, 2014, 01:27:07 pm
Oh silly me, I did totally forget to add those strings! I will do that some time today maybe. I like the names you're suggesting, so I will also change those.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: ceilingrat on April 02, 2014, 03:32:12 am
Shoes,


(Preface, I'm kinda hopeless with words, so bear with me.)


I've only just started learning how to code, starting with python. So, although I wish I could help with coding and awesomeness, I can't.


So, is there any chance you can merge your mod again with the latest nightly?


When they changed the options GUI, it introduced one small bug. That being not being able to rename craft. I reported it and it's fixed (thanks SupSuper!), but your mod doesn't have the fix.


If I could merge it myself, I would and not bother you about it.


ceilingrat

Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Fox105iwsp on April 02, 2014, 10:38:38 am
uhh. I'm a little lost here, what happened? >_<
Do I need to download the latest nightly build first or what?
Also, no mods are appearing for free battle except my custom craft.
I think I activated all my mods >_<
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: ceilingrat on April 02, 2014, 10:46:15 am
Download latest nightly, extract and overwrite. Then install the latest version of mod.


What you're seeing is the the old language file from the mod would replace the one in the language folder. Shoes has separated his ruleset out into its own file which incorporates all the language strings in en-US and en-GB.


Any problems, just yell.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Fox105iwsp on April 02, 2014, 10:53:56 am
Okay, I did all that ^_^
Coool...
it went totally insane @_@
now my mods can't be tested in quick battle, the stat & awards no longer work and screenshots are messed up ^_^ EPIC
Good thing I kept a full backup ^_^
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: ceilingrat on April 02, 2014, 11:00:32 am
Huh, weird.


Maybe a full reinstall? Shoes might have a better idea.


I'm out of ideas atm.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Fox105iwsp on April 02, 2014, 11:03:09 am
Right, that's okay, I'll continue my construction on the older version. Can't field test equipment without quick battle, my mods work in campaign mode for some reason though....
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on April 02, 2014, 01:09:38 pm
New update : https://dl.dropboxusercontent.com/u/234369005/OXC/04022014%20Commendations%20Mod.zip

I have a feeling this will fix your problems judging by all the shader files I was seeing that are new. Hope it does at least!
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Fox105iwsp on April 02, 2014, 06:09:18 pm
Cool, it works fine now ^_^ thanks
by the way, if you want Batman, he's up now.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on April 21, 2014, 05:39:15 pm
I updated the .exe with the new nightly. I also have an untested batch of changes : https://dl.dropboxusercontent.com/u/234369005/OXC/04212014%20Commendations%20Mod%20UNTESTED%20MORE%20STUFF.zip

In short, I added a new category of medals (kills per mission, kills per turn), improved the multiple-kills aspect, improved saving, and added 5 or 6 new commendations. New commendations don't have their own sprites yet, and I haven't tested it in the least!! :D

edit: Lot's of little bugs, but seems playable... :3
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Fox105iwsp on April 21, 2014, 11:09:53 pm
Sounds  like fun! ^_^
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on April 30, 2014, 12:58:14 pm
Up to 23 commendations now! Also, Soldiers no longer save each mission they're on (thus saving the same mission like 30 times per mission), and other little things like that. Save files should be smaller in general. Not that it really matters?

I am up for suggestions for commendations too. Most of the big ones have been done I think, or at least have the ability to be quickly done.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: wsmithjr on May 01, 2014, 07:59:20 am
Very interesting in trying out this mod.  I think I have everything installed correctly and the game seems to run.  I can even click on the "Record" button for a soldier and get to the various pages of information.  However, if I click on the "Record" button for a soldier in the Memorial page, the game crashes.  No error messages, just a "circle of death" and then windows says OXC has stopped running.  Anybody else experiencing this or have I done something wrong?

I had another mod installed, but I disabled it and still have the problem.

Thanks for any help.

P.S.  I've got the latest version as of 4-30.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on May 01, 2014, 12:34:12 pm
Oh yeah, memorial page... I am both surprised and not surprised it's crashing, because I coded anything to make sure it worked :D I will look into it this weekend.

edit; now fixed :D
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: FudgeDragon on May 12, 2014, 08:13:21 pm
Hey Shoes,

Built your mod from your GitHub source today but at first it refused to compile. It seems you were calling textList->setScroll(0) (which doesn't exist) once in SoldierDiaryOverviewState and nine times in SoldierDiaryPerformanceState. I think the method you wanted was scrollTo(0). Other than that, love the mod.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on May 12, 2014, 08:27:37 pm
That darned SupSuper and making UI changes. Glad to hear you like it! Always looks for feedback :3
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: FudgeDragon on May 15, 2014, 09:04:18 am
Hi Shoes,

I've been having a crash attempting to look at a particular dead soldiers mission details. The message I get is invalid vector<T> subscript.

I can't post the save as one its ironman and therefore difficult to test, and running a couple of personal ruleset tweaks (although nothing that would affect missions in any way, it adds extra tanks.

However if it helps, I've attatched the relevent sections of my savegame.

The trouble soldier:
Code: [Select]
  - id: 7
    name: Klaus Mueller
    initialStats:
      tu: 54
      stamina: 50
      health: 37
      bravery: 50
      reactions: 54
      firing: 53
      throwing: 68
      strength: 32
      psiStrength: 56
      psiSkill: 0
      melee: 36
    currentStats:
      tu: 64
      stamina: 59
      health: 47
      bravery: 50
      reactions: 56
      firing: 57
      throwing: 70
      strength: 49
      psiStrength: 56
      psiSkill: 0
      melee: 36
    rank: 4
    gender: 0
    look: 1
    missions: 18
    kills: 5
    armor: STR_PERSONAL_ARMOR_UC
    improvement: 0
    death:
      time:
        second: 25
        minute: 15
        hour: 14
        weekday: 5
        day: 6
        month: 5
        year: 1999
    diary:
      commendations:
        - commendationName: STR_MEDAL_MILITARY_CROSS_NAME
          decorationLevel: 3
        - commendationName: STR_MEDAL_ORDER_OF_EARTH_NAME
          decorationLevel: 3
        - commendationName: STR_MEDAL_HONOR_CROSS_NAME
          decorationLevel: 0
        - commendationName: STR_MEDAL_SERVICE_MEDAL_NAME
          decorationLevel: 0
        - commendationName: STR_MEDAL_MERIT_STAR_NAME
          decorationLevel: 0
        - commendationName: STR_MEDAL_CAMPAIGN_RIBBON_NAME
          noun: STR_SIBERIA
          decorationLevel: 0
      killList:
        - rank: STR_LIVE_SOLDIER
          race: STR_SECTOID
          weapon: STR_RIFLE
          weaponAmmo: STR_RIFLE_CLIP
          status: 6
          faction: 1
          mission: 0
          turn: 12
        - rank: STR_LIVE_SOLDIER
          race: STR_FLOATER
          weapon: STR_LASER_PISTOL
          weaponAmmo: STR_LASER_PISTOL
          status: 6
          faction: 1
          mission: 1
          turn: 315
        - rank: STR_LIVE_ENGINEER
          race: STR_SECTOID
          weapon: STR_GRENADE
          weaponAmmo: STR_GRENADE
          status: 6
          faction: 1
          mission: 2
          turn: 621
        - rank: STR_LIVE_ENGINEER
          race: STR_FLOATER
          weapon: STR_HEAVY_LASER
          weaponAmmo: STR_HEAVY_LASER
          status: 6
          faction: 1
          mission: 6
          turn: 1839
        - rank: STR_LIVE_SOLDIER
          race: STR_FLOATER
          weapon: STR_HEAVY_LASER
          weaponAmmo: STR_HEAVY_LASER
          status: 6
          faction: 1
          mission: 10
          turn: 3018
      missionIdList:
        - 0
        - 1
        - 2
        - 3
        - 4
        - 5
        - 6
        - 7
        - 8
        - 9
        - 10
        - 12
        - 13
        - 14
        - 15
        - 16
        - 18
        - 19
      alienRankTotal:
        STR_LIVE_ENGINEER: 2
        STR_LIVE_SOLDIER: 3
      alienRaceTotal:
        STR_FLOATER: 3
        STR_SECTOID: 2
      weaponTotal:
        STR_GRENADE: 1
        STR_HEAVY_LASER: 2
        STR_LASER_PISTOL: 1
        STR_RIFLE: 1
      weaponAmmoTotal:
        STR_GRENADE: 1
        STR_HEAVY_LASER: 2
        STR_LASER_PISTOL: 1
        STR_RIFLE_CLIP: 1
      regionTotal:
        STR_AUSTRALASIA: 1
        STR_CENTRAL_ASIA: 1
        STR_EUROPE: 4
        STR_NORTH_AMERICA: 3
        STR_SIBERIA: 5
        STR_SOUTH_AMERICA: 3
        STR_SOUTH_EAST_ASIA: 1
      countryTotal:
        STR_AUSTRALIA: 1
        STR_BRAZIL: 1
        STR_CANADA: 1
        STR_FRANCE: 1
        STR_RUSSIA: 5
        STR_UK: 1
        STR_UNKNOWN: 6
        STR_USA: 2
      typeTotal:
        STR_ALIEN_BASE_ASSAULT_LC: 2
        STR_TERROR_MISSION_LC: 3
        STR_UFO_CRASH_RECOVERY_LC: 13
      UFOTotal:
        NO_UFO: 5
        STR_LARGE_SCOUT: 6
        STR_MEDIUM_SCOUT: 7
      scoreTotal: 4514
      killTotal: 5
      missionTotal: 18
      winTotal: 17
      totalShotFriendlyCounter: 1
      terrorMissionTotal: 3
      nightMissionTotal: 5
      monthsService: 4
      importantMissionTotal: 17
      longDistanceHitCounterTotal: 1
and the missions:
Code: [Select]
missionStatistics:
  - id: 0
    country: STR_UK
    time:
      weekday: 4
      second: 45
      minute: 35
      hour: 14
      day: 13
      month: 1
      year: 1999
    region: STR_EUROPE
    type: STR_UFO_CRASH_RECOVERY
    ufo: STR_MEDIUM_SCOUT
    success: true
    score: 105
    rating: STR_RATING_OK
    alienRace: STR_SECTOID
    daylight: 0
    injuryList:
      6: 0
      1: 0
      2: 0
      3: 0
      4: 0
      5: 0
      7: 0
      8: 0
  - id: 1
    region: STR_SOUTH_EAST_ASIA
    country: STR_UNKNOWN
    type: STR_TERROR_MISSION
    ufo: NO_UFO
    time:
      minute: 52
      second: 5
      hour: 22
      weekday: 1
      day: 17
      month: 1
      year: 1999
    success: true
    score: 369
    rating: STR_RATING_GOOD
    alienRace: STR_FLOATER
    daylight: 0
    injuryList:
      2: 0
      3: 0
      4: 0
      5: 0
      7: 0
      8: 0
      9: 0
      10: 0
  - id: 2
    region: STR_EUROPE
    country: STR_FRANCE
    type: STR_UFO_CRASH_RECOVERY
    ufo: STR_LARGE_SCOUT
    time:
      minute: 34
      second: 5
      hour: 7
      weekday: 7
      day: 30
      month: 1
      year: 1999
    success: true
    score: 226
    rating: STR_RATING_GOOD
    alienRace: STR_SECTOID
    daylight: 1
    injuryList:
      2: 0
      3: 0
      4: 0
      7: 0
      8: 19
      9: 0
      10: 0
      11: 0
      12: 0
      13: 0
  - id: 3
    region: STR_SOUTH_AMERICA
    country: STR_UNKNOWN
    type: STR_UFO_CRASH_RECOVERY
    ufo: STR_LARGE_SCOUT
    time:
      minute: 43
      second: 15
      hour: 19
      weekday: 1
      day: 7
      month: 2
      year: 1999
    success: true
    score: 196
    rating: STR_RATING_OK
    alienRace: STR_SECTOID
    daylight: 0
    injuryList:
      2: 0
      3: 0
      4: 0
      7: 0
      9: 0
      10: 0
      11: 0
      12: 0
      13: 0
      14: 0
  - id: 4
    region: STR_EUROPE
    country: STR_UNKNOWN
    type: STR_UFO_CRASH_RECOVERY
    ufo: STR_LARGE_SCOUT
    time:
      minute: 47
      second: 25
      hour: 6
      weekday: 7
      day: 13
      month: 2
      year: 1999
    success: true
    score: 160
    rating: STR_RATING_OK
    alienRace: STR_SECTOID
    daylight: 0
    injuryList:
      4: 0
      7: 0
      9: 0
      10: 0
      11: 0
      13: 0
      14: 0
      15: 0
      16: 0
      17: 0
  - ufo: NO_UFO
    time:
      minute: 53
      second: 20
      hour: 14
      weekday: 3
      day: 2
      month: 3
      year: 1999
    injuryList:
      13: 0
      4: 0
      7: 0
      9: 0
      10: 0
      11: 0
      14: 0
      15: 0
      16: 0
      17: 0
    success: true
    score: 265
    rating: STR_RATING_GOOD
    alienRace: STR_SECTOID
    daylight: 0
    id: 5
    region: STR_SOUTH_AMERICA
    country: STR_BRAZIL
    type: STR_TERROR_MISSION
  - country: STR_USA
    type: STR_UFO_CRASH_RECOVERY
    ufo: STR_LARGE_SCOUT
    success: true
    score: 178
    rating: STR_RATING_OK
    alienRace: STR_FLOATER
    daylight: 0
    injuryList:
      2: 40
      3: 0
      4: 0
      7: 0
      8: 0
      9: 0
      11: 18
      12: 0
      15: 0
    region: STR_NORTH_AMERICA
    id: 6
    time:
      minute: 44
      hour: 16
      weekday: 4
      day: 3
      second: 35
      year: 1999
      month: 3
  - id: 7
    region: STR_AUSTRALASIA
    country: STR_AUSTRALIA
    type: STR_TERROR_MISSION
    ufo: NO_UFO
    time:
      second: 40
      minute: 25
      hour: 1
      weekday: 3
      day: 23
      month: 3
      year: 1999
    success: true
    score: 140
    rating: STR_RATING_OK
    alienRace: STR_FLOATER
    daylight: 0
    injuryList:
      3: 20
      4: 0
      7: 0
      8: 0
      11: 0
      12: 0
      15: 0
      18: 0
      19: 0
      20: 0
      21: 0
      22: 0
      23: 0
  - id: 8
    region: STR_SOUTH_AMERICA
    country: STR_UNKNOWN
    type: STR_UFO_CRASH_RECOVERY
    ufo: STR_LARGE_SCOUT
    time:
      second: 5
      minute: 10
      hour: 15
      weekday: 6
      day: 26
      month: 3
      year: 1999
    success: true
    score: 265
    rating: STR_RATING_GOOD
    alienRace: STR_FLOATER
    daylight: 0
    injuryList:
      4: 0
      7: 0
      8: 0
      12: 0
      15: 16
      19: 0
      20: 0
      21: 0
      22: 0
      23: 0
  - id: 9
    region: STR_SIBERIA
    country: STR_RUSSIA
    type: STR_UFO_CRASH_RECOVERY
    ufo: STR_MEDIUM_SCOUT
    time:
      minute: 2
      second: 35
      hour: 13
      weekday: 5
      day: 1
      month: 4
      year: 1999
    success: true
    score: 152
    rating: STR_RATING_OK
    alienRace: STR_SNAKEMAN
    daylight: 14
    injuryList:
      4: 0
      7: 0
      8: 0
      12: 12
      19: 0
      20: 0
      21: 0
      22: 0
      23: 0
  - id: 10
    region: STR_NORTH_AMERICA
    country: STR_CANADA
    type: STR_ALIEN_BASE_ASSAULT
    ufo: NO_UFO
    time:
      minute: 25
      second: 30
      hour: 9
      weekday: 2
      day: 5
      month: 4
      year: 1999
    success: true
    score: 1629
    rating: STR_RATING_EXCELLENT
    alienRace: STR_FLOATER
    daylight: 15
    injuryList:
      4: 0
      7: 0
      8: 0
      19: 0
      21: 0
      22: 0
      23: 0
      24: 0
      25: 0
      26: 0
      27: 0
      28: 0
      29: 0
      30: 0
  - id: 11
    region: STR_SIBERIA
    country: STR_RUSSIA
    type: STR_UFO_CRASH_RECOVERY
    ufo: STR_LARGE_SCOUT
    time:
      minute: 32
      second: 35
      hour: 4
      weekday: 2
      day: 19
      month: 4
      year: 1999
    success: true
    score: 206
    rating: STR_RATING_GOOD
    alienRace: STR_SNAKEMAN
    daylight: 0
    injuryList:
      19: 0
      22: 0
      23: 0
      24: 0
      25: 18
      26: 0
      27: 0
      30: 0
      31: 0
      32: 0
  - id: 12
    region: STR_NORTH_AMERICA
    country: STR_USA
    type: STR_UFO_CRASH_RECOVERY
    ufo: STR_MEDIUM_SCOUT
    time:
      minute: 51
      second: 45
      hour: 17
      weekday: 4
      day: 21
      month: 4
      year: 1999
    success: true
    score: 159
    rating: STR_RATING_OK
    alienRace: STR_FLOATER
    daylight: 0
    injuryList:
      7: 0
      19: 0
      21: 0
      22: 0
      23: 0
      24: 0
      26: 0
      30: 0
      31: 0
      32: 0
  - id: 13
    region: STR_CENTRAL_ASIA
    country: STR_UNKNOWN
    type: STR_UFO_CRASH_RECOVERY
    ufo: STR_MEDIUM_SCOUT
    time:
      minute: 59
      second: 55
      hour: 6
      weekday: 7
      day: 1
      month: 5
      year: 1999
    success: true
    score: 186
    rating: STR_RATING_OK
    alienRace: STR_SNAKEMAN
    daylight: 0
    injuryList:
      7: 0
      19: 0
      21: 0
      22: 0
      23: 0
      24: 0
      26: 0
      30: 0
      31: 1
      32: 0
  - id: 14
    region: STR_SIBERIA
    country: STR_RUSSIA
    type: STR_UFO_CRASH_RECOVERY
    ufo: STR_MEDIUM_SCOUT
    time:
      minute: 14
      second: 50
      hour: 0
      weekday: 1
      day: 2
      month: 5
      year: 1999
    success: true
    score: 157
    rating: STR_RATING_OK
    alienRace: STR_SNAKEMAN
    daylight: 0
    injuryList:
      7: 0
      15: 0
      19: 0
      21: 0
      22: 0
      23: 0
      24: 0
      26: 0
      30: 0
      32: 0
  - id: 15
    country: STR_RUSSIA
    region: STR_SIBERIA
    type: STR_UFO_CRASH_RECOVERY
    ufo: STR_MEDIUM_SCOUT
    time:
      second: 5
      minute: 14
      hour: 10
      weekday: 1
      day: 2
      month: 5
      year: 1999
    success: true
    score: 125
    rating: STR_RATING_OK
    alienRace: STR_SNAKEMAN
    daylight: 0
    injuryList:
      7: 0
      15: 0
      19: 0
      21: 0
      22: 0
      23: 0
      24: 0
      26: 0
      30: 0
      32: 0
  - id: 16
    region: STR_SIBERIA
    country: STR_RUSSIA
    type: STR_UFO_CRASH_RECOVERY
    ufo: STR_LARGE_SCOUT
    time:
      minute: 53
      second: 35
      hour: 22
      weekday: 1
      day: 2
      month: 5
      year: 1999
    success: true
    score: 322
    rating: STR_RATING_GOOD
    alienRace: STR_SNAKEMAN
    daylight: 0
    injuryList:
      7: 0
      15: 0
      19: 0
      21: 0
      23: 0
      24: 0
      26: 0
      30: 0
      32: 0
      33: 36
  - id: 17
    region: STR_NORTH_AMERICA
    country: STR_USA
    type: STR_UFO_CRASH_RECOVERY
    ufo: STR_MEDIUM_SCOUT
    time:
      minute: 47
      second: 40
      hour: 18
      weekday: 4
      day: 5
      month: 5
      year: 1999
    success: true
    score: 127
    rating: STR_RATING_OK
    alienRace: STR_FLOATER
    daylight: 0
    injuryList:
      3: 0
      4: 0
      8: 0
      12: 0
      34: 0
      35: 0
      36: 0
      37: 0
      38: 0
      39: 0
  - id: 18
    region: STR_EUROPE
    country: STR_UNKNOWN
    type: STR_UFO_CRASH_RECOVERY
    ufo: STR_MEDIUM_SCOUT
    time:
      minute: 53
      second: 0
      hour: 4
      weekday: 5
      day: 6
      month: 5
      year: 1999
    success: true
    score: 9
    rating: STR_RATING_OK
    alienRace: STR_SNAKEMAN
    daylight: 2
    injuryList:
      7: 0
      15: 0
      19: 0
      21: 0
      22: 0
      23: 0
      26: 0
      30: 0
      31: 0
      32: 0
  - id: 19
    region: STR_SIBERIA
    country: STR_RUSSIA
    type: STR_ALIEN_BASE_ASSAULT
    ufo: NO_UFO
    time:
      minute: 15
      second: 25
      hour: 14
      weekday: 5
      day: 6
      month: 5
      year: 1999
    success: false
    score: -129
    rating: STR_RATING_POOR
    alienRace: STR_SNAKEMAN
    daylight: 15
    injuryList:
      7: 0
      15: 0
      19: 0
      21: 0
      22: 0
      23: 0
      26: 0
      30: 0
      31: 0
      32: 0
  - id: 20
    region: STR_SIBERIA
    country: STR_RUSSIA
    type: STR_UFO_CRASH_RECOVERY
    ufo: STR_MEDIUM_SCOUT
    time:
      minute: 55
      second: 40
      hour: 5
      weekday: 4
      day: 12
      month: 5
      year: 1999
    success: true
    score: 177
    rating: STR_RATING_OK
    alienRace: STR_SNAKEMAN
    daylight: 0
    injuryList:
      2: 0
      19: 0
      22: 0
      26: 0
      30: 0
      44: 0
      45: 0
      46: 0
      47: 0
      48: 0
  - id: 21
    region: STR_CENTRAL_ASIA
    country: STR_UNKNOWN
    type: STR_UFO_CRASH_RECOVERY
    ufo: STR_LARGE_SCOUT
    time:
      minute: 45
      second: 25
      hour: 12
      weekday: 6
      day: 14
      month: 5
      year: 1999
    success: true
    score: 249
    rating: STR_RATING_GOOD
    alienRace: STR_SNAKEMAN
    daylight: 0
    injuryList:
      2: 0
      19: 0
      22: 0
      26: 0
      30: 0
      44: 0
      45: 0
      46: 0
      47: 0
      48: 0
  - id: 22
    region: STR_EUROPE
    country: STR_UNKNOWN
    type: STR_UFO_CRASH_RECOVERY
    ufo: STR_LARGE_SCOUT
    time:
      minute: 0
      second: 55
      hour: 10
      weekday: 3
      day: 18
      month: 5
      year: 1999
    success: true
    score: 276
    rating: STR_RATING_GOOD
    alienRace: STR_SNAKEMAN
    daylight: 0
    injuryList:
      2: 0
      19: 0
      22: 0
      26: 0
      30: 0
      44: 0
      45: 0
      46: 0
      47: 0
      48: 0
  - alienRace: STR_FLOATER
    daylight: 0
    injuryList:
      3: 0
      4: 0
      8: 0
      12: 0
      35: 0
      36: 0
      37: 0
      38: 0
      39: 0
      34: 0
    id: 23
    region: STR_NORTH_AMERICA
    country: STR_USA
    type: STR_UFO_CRASH_RECOVERY
    ufo: STR_LARGE_SCOUT
    time:
      minute: 23
      second: 10
      hour: 14
      weekday: 3
      day: 18
      month: 5
      year: 1999
    success: true
    score: 306
    rating: STR_RATING_GOOD
  - id: 24
    region: STR_SOUTH_AMERICA
    country: STR_UNKNOWN
    type: STR_UFO_GROUND_ASSAULT
    ufo: STR_SUPPLY_SHIP
    time:
      second: 10
      minute: 17
      hour: 7
      weekday: 5
      day: 20
      month: 5
      year: 1999
    success: true
    score: 658
    rating: STR_RATING_EXCELLENT
    alienRace: STR_FLOATER
    daylight: 15
    injuryList:
      3: 26
      4: 0
      8: 22
      12: 6
      34: 0
      35: 0
      36: 0
      37: 0
      38: 0
      39: 0

If this helps, great. If not I'll try to reproduce it in a more isolated environment (and not ironman).
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on May 15, 2014, 01:06:55 pm
Do other dead soldiers cause a crash? Are you playing the most recent version of my mod (May 13th)? If you did, did you continue your save or start a new game?

With your help, I'll get that memorial sorted!
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: FudgeDragon on May 15, 2014, 03:59:41 pm
I running your most recent code, although I may have started the game on the previous version.

Ok, I think I've worked out what causes it. Klaus was my longest serving soldier (the last of my starting 8 to die.) As a result one of only three soldiers,  dead or alive with a scrollbar on his missions screen. These are the only soldiers that crash, and only when selecting a mission that was below the starting 15. I hadn't noticed with the live ones because, well they seem less interesting. If any of them die I'm sure I'd head straight to the memorial to pay my respects.

Attempting to select one of those three missions throws a invalid vector<T> subscript which is a std::out_of_range

As I am running my own build of your code, I changed by build profile to debug and had a dig for you.
The error is thrown on the execution of this line:
Code: [Select]
SoldierDiaryMissionState.cpp Line 100: int missionId = _soldier->getDiary()->getMissionIdList().at(_rowEntry);
Experementing a little it seems _rowEntry gets more and more inaccurate the further you scroll down.
Looking at
Code: [Select]
SoldierDiaryOverviewState.cpp Line 312: int absoluteRowEntry = _lstDiary->getSelectedRow() + _lstDiary->getScroll();I find that
Code: [Select]
_lstDiary->getSelectedRow() already seems to be respecting scrollbar position. So every time we moved the scrollbar down all our missions would become offset by 1, eventually you moved off the bottom of the array :)

Change that row to
Code: [Select]
int absoluteRowEntry = _lstDiary->getSelectedRow() and everything seems to clear up the problem.

I've included a patch file of the fix in case it makes it easier for you. Scratch the patch file, it wouldn't apply, I was working on a branch with some of my own changes too.

One thing to note, debugging this has drawn attention to the fact that the textList returns to the top after viewing each mission. Any chance of getting it to remember where it was so I don't have to scroll back down to view the next mission?



Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on May 15, 2014, 04:43:59 pm
Awesome work! The help is greatly appreciated.

Quote
One thing to note, debugging this has drawn attention to the fact that the textList returns to the top after viewing each mission. Any chance of getting it to remember where it was so I don't have to scroll back down to view the next mission?

The reason this happens is lines 170, 171 in SoldierDiaryOverviewState::init() : the _lstDiary is cleared and set to 0. I would have to be at my home computer to see how the logic flows, but when you popState in SoldierDiaryMissionState, it might run through the SoldierDiaryOverviewState constructor again. If that's the case, a bit of creative coding would need to be done to fix the scroll/reset thing. If the constructor is not called, then the _lstDiary clearing and setting could be moved to the constructor and copied in the next/prev buttons too. This way it won't get called every time init() is called. I'll give this a try at home; I agree that it is a nuisance.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: FudgeDragon on May 15, 2014, 08:24:34 pm
Got carried away and made the missions page stay put after looking at one too. Was fairly simple after I had a look at SoldiersInfo.cpp as I realised that it sould have the same problem and didn't. Turns out you don't have to reset the scroll position straight away. Instead wait a until the list is repopulated, then check if you need to, i.e. outside new bounds.

I submitted a pull request to github with the code for you.

EDIT:
Apologies for spamming your git with pull requests. When I initially did the fixes I had trouble creating the pull request, I didn't realise I could only do pull requests from remote branches. Thinking I could only do it with branches based on my master (which was up to date with SupSupers) I create a branch off of that and merged everything in. Once I realised what was going on I created another branch off of yours this time. Then I created the new pull request and closed the wrong one!

Oh well, Its there now if you want it.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on May 16, 2014, 12:31:40 am
Awesome, a collaborator :3 my very first! I am new to being on the recieving end of a PR, but I think you will need to do your PR again.

Pull my alpha_branch into a new branch, cherry-pick the 2 commits that you're adding from your old branch, and then PR the resulting new branch. The branch you PR with should be identical to the branch you are PRing into, except for the changes you are making. I know it would be easy for me to take your code and commit it under my name, but then I have no evidence of collaboration :3
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: FudgeDragon on May 16, 2014, 08:04:32 am
Heh, no problem, I'm new to pull requests too. Actually I'm new to git on the whole, its a miracle its working as well as it is.

EDIT: Right, I know that ones good! New PR up on github.

EDIT2: Just got the email notification that you did the merge. We got there in the end! I'll keep playing with the mod and let you know if I run into any further problems.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on May 16, 2014, 02:09:25 pm
Merged! Nice having a playtester who also bug fixes :3

The next thing I am working on is redoing the super ugly post-battle commendations screen.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: ceilingrat on May 16, 2014, 04:46:59 pm
Shoes,


Congrats on your first coder person helping! I helped, but Fudgedragon can do so much more than I can. The whole understanding code thing.


Wish I had time (and patience) to actually playtest things atm.




ceilingrat
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on May 18, 2014, 12:35:47 am
Ya I am pretty happy to have FudgeDragon lend a hand! All playtesters are appreciated too :3

Here is the new post-mission commendations screen!

(https://i.imgur.com/f2FlkPq.png)
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Souljah1214 on June 15, 2014, 01:19:53 pm
Hi! I think this is one of the greatest addition (as for immersion) to OXC! I tried to mod the freshly installed 1.0 with this, but unfortunatly i was unsuccesful... I started the game as i have downloaded (1.0) and in the mainmenu it showed the correct version number... when i added this (installed correctly before on the lates nightly version with no problems) to the 1.0 version it reduced the number back to 0.9... does this mean that this mod is currently incompatible with 1.0 or we are just waiting for an updated version?

I like this mod cause it gives more personality for a soldier... which could be used to write some cool fanfictions...
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on June 15, 2014, 03:05:31 pm
Because this is a source mod, I have to manually update my mod when the game updates. I should probably do that, on the account of 1.0 being released! I will try to get that done before the end of the day.

:D
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: animal310 on June 15, 2014, 03:19:03 pm
That's great news shoes. Thanks for all your work on it, its a great mod.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Solarius Scorch on June 15, 2014, 03:33:51 pm
Integration when? :)
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Shoes on June 15, 2014, 03:39:03 pm
Integration when? :)

I will wait until the dust settles from the 1.0 release, then I will pester the devs to get this merged :3

I am compiling the updated mod now, then I will playtest it a little bit make sure all the features still work.
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: Solarius Scorch on June 15, 2014, 03:41:51 pm
I will wait until the dust settles from the 1.0 release, then I will pester the devs to get this merged :3

Good, you have my vote. :)
Title: Re: [STAT TRACKING] Soldier Diaries
Post by: the_third_curry on June 15, 2014, 04:06:02 pm
I do hope it gets merged. This mod is one of the best looking on the site. It's a real shame that it can get disrupted by updates.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on June 15, 2014, 04:11:21 pm
It's up to date now, and I expect it to still work great with the new updates!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: SupSuper on June 15, 2014, 06:47:22 pm
I will wait until the dust settles from the 1.0 release, then I will pester the devs to get this merged :3

I am compiling the updated mod now, then I will playtest it a little bit make sure all the features still work.
We will be more convinced when it doesn't crash everytime we take it for a test-run. ;)

(but seriously it's a great mod, keep up the good work)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: wsmithjr on June 15, 2014, 08:24:43 pm
It's up to date now, and I expect it to still work great with the new updates!

Don't know if I'm doing something wrong.  I've used this before.  But, I duplicated a working OXC 1.0 install and followed the install instruction for this and it won't even start up.

Get "The application was unable to start correctly (0xc000007b)"

Downloaded from Dropbox link on first post in thread, 06152014CommendationsMod.zip.

What did I mess up?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on June 15, 2014, 08:28:15 pm
Did you have the DLLs in the same folder as the .exe?

edit: I just tried it on windows; you need to replace the DLLs that are already there. I would suggest backing those up too, in case you want to remove this mod.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: wsmithjr on June 15, 2014, 08:36:29 pm
Did you have the DLLs in the same folder as the .exe?

 :o <sigh>  No, I had the DLL's *folder* in the same folder as the EXE.

So, for those of us who are brain dead, would it be worth putting the DLLs into zip along with the exe instead of in a separate folder?  That or change the readme to "extract the contents of the DLLs folder".  To me that's more clear.  That said, I obviously did get this to work before though I suspect I made the same error but figured it out before making a fool of myself, unlike this time.  Must be too tired.

Thanks.  All better now.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on June 15, 2014, 08:43:20 pm
I hope you enjoy it!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: the_third_curry on June 15, 2014, 11:46:17 pm
This may have been brought up before, but to what extent is this mod compatible with other mods?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on June 15, 2014, 11:59:56 pm
I think works with any other mod, except other mods that have their own .exes like mine. Even to the extent where modded guns would have their own proficiency medals :D

If you run into problems though, let me know.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: the_third_curry on June 16, 2014, 04:23:07 am
I think works with any other mod, except other mods that have their own .exes like mine. Even to the extent where modded guns would have their own proficiency medals :D

If you run into problems though, let me know.

Nice.

Any idea what happens if other enemies are modded in, like robin's waspites and men in black?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Peperonis on June 16, 2014, 11:10:03 am
Amazing mod m8, imo the best around. It really gives personallity to your troops! Btw is there any chance u make a stat track mod for tftd?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on June 16, 2014, 01:04:21 pm
Nice.

Any idea what happens if other enemies are modded in, like robin's waspites and men in black?

The Xenocide medals should work against modded aliens too :)

Amazing mod m8, imo the best around. It really gives personallity to your troops! Btw is there any chance u make a stat track mod for tftd?

Thanks! When OXC starts TFTD support, I will make sure my mod still works with it too.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: the_third_curry on June 16, 2014, 08:24:50 pm
The Xenocide medals should work against modded aliens too :)

Thanks! When OXC starts TFTD support, I will make sure my mod still works with it too.

Great. I'm hoping to do a playthrough with this mod, Solarius Scorch's expanded armory, and shoes' new aliens. And perhaps a few others as well; it's really impressive how many interesting mods this game had even before there was 1.0 release.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: wsmithjr on June 17, 2014, 05:07:09 am
Really like the mod.  Thanks for the work on it.  Is there somewhere you can see all the various types of medals you can earn.  I know they don't mean anything, but they're pretty cool.  I'll admit I haven't checked every page of this thread, so I apologize if they're listed within.

That said, I think I'm having a problem with the mod.  I can't replicate the problem with a standing OXC 1.0 install.  Even with all mods disabled, however, I can replicate it with the Commendations exe.

If you start a "New Battle" from the main menu and then get to the battlescape and Abort the Mission, the game crashes.  It's consistent though I haven't checked every single configuration of options in the battle setup screen.  I have a bunch of mods installed, but all of them are disabled so shouldn't be interfering, correct?

Anyway, I know you normally wouldn't just abort a mission.  I found it because I wanted to check what graphics for used for some of the weapons with various mods.  Not a big deal, but if it is related to your mod, thought you'd want to know.

Thanks again for a great mod.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on June 17, 2014, 04:49:32 pm
I will look into that crash, it's probably something silly that I forgot to consider.

If you to see the list of commendations, you can look in the ruleset for all their names, description, the criteria to get them, etc etc. The sprites are in the Resources folder as well.. I don't have any in game screenshots of a soldier with all the commendations, but it's something that can be done by modifying the save file.

Also, if you do go digging into the ruleset and think of good commendations to be added, let me know :3
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: the_third_curry on June 17, 2014, 09:49:34 pm
My game has started to crash from losing or aborting new battles. The problem doesn't clear up when I disable the mod.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on June 17, 2014, 10:20:25 pm
My game has started to crash from losing or aborting new battles. The problem doesn't clear up when I disable the mod.

Since the mod contains an exe, it's not enough to disable it; you would have to return the original executable file and any files you may have overwritten.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: the_third_curry on June 18, 2014, 12:31:36 am
I forgot to mention, it crashes in new battles only. During a campaign, everything still works fine.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on June 18, 2014, 04:24:07 am
I've found the cause of the crash : in a new battle, there is no "race" associated with the mission, so when I try and track what race you are fighting... well, crash.

I have not updated the mod yet as I am a little busy and this is a pretty minor ordeal ;p It is likely tomorrow I will have it updated.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: the_third_curry on June 20, 2014, 07:29:45 am
The problem with New Battle is gone now. I played a brief campaign (about the first two-and-a-half months) and it looks like this mod works perfectly with robin's aliens/MIB and Solarius' weapons. Excellent flexibility.

The only problem I encountered was a minor one when some moders named the UFO something too long to fit in the space allotted (see picture.) However, the stat tracker still lists the number, so it's no big deal. This is definitely one of my favorite mods.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Souljah1214 on June 20, 2014, 11:30:50 am
Hi! Im still waiting this mod to be compatible with the 1.0 eagerly.... and i was thinking... cant we just merge this gem with the future versions of OXC?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on June 20, 2014, 01:38:08 pm
As you can see I am a little slow getting some updates out ;p so I wouldn't want to shift the burden of maintaining the code from me to them by merging it. Once this gets thoroughly played, and once I get the code under the hood up to their standards, they will consider merging it.

I heard there might be an issue with base defense missions; if someone could confirm that or post a saved game, that would be very helpful.

I've updated the download links with a freshly compiled version of the mod too!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Renegado on June 20, 2014, 05:49:03 pm
I've been playing the campaign with this mod and the only issue I could find regarding base defense is that is listed as "Undisclosed Location" in the Mission Stats page.

Anyway I've attached a savegame in my post with a base defense mission with a single alien left just so you can check it out.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on June 20, 2014, 05:52:16 pm
Ha, that's funny. "Undisclosed Locations" are used in the case that something went wrong and there _the UFO_ has no location. In this case however, I probably forgot to fetch the base location. This is an easy fix, however you will have to modify your save file if you don't want to see that location anymore, even after I fix that issue.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: the_third_curry on June 20, 2014, 06:16:13 pm
I've been playing the campaign with this mod and the only issue I could find regarding base defense is that is listed as "Undisclosed Location" in the Mission Stats page.

X-com facilities are so secret that not even X-com knows where they're at.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: niculinux on June 21, 2014, 12:20:58 pm
Sice the mod uses its own .exe files, that  means it won't work under linux, right? :/
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on June 21, 2014, 12:53:51 pm
There's a link to the git branch so you can compile it yourself, but you're right, I have never tested it and do not provide and pre-compiled linux version :(
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Aliums on June 21, 2014, 06:31:52 pm
This mod doesn't seem to work,it crashes everytime i try to enter a battle.I'm also pretty sure i installed it correctly and the game works flawlessly if unmodded.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on June 21, 2014, 10:52:10 pm
This mod doesn't seem to work,it crashes everytime i try to enter a battle.I'm also pretty sure i installed it correctly and the game works flawlessly if unmodded.

I updated the link with a fresh compile, and "play tested" 2 missions and they worked fine. Let me know if that fixes your issues.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Peperonis on June 22, 2014, 12:19:36 am
Crashes when i enter the inventory screen when equiping my ships or when i enter a battle. Must be something with the equipment screen in general  :'( :'( :'( :'( :'(
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: lorrdmatt on June 22, 2014, 01:06:54 am
I'm having the same issue with crashes when I try to enter the Inventory or Battle screen. It might be how I'm installing the mod. Could I please have a really simple guide to properly installing the mod, especially the dll's? I'm new to modding and I just want to make sure I'm getting it right! Thanks!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: lorrdmatt on June 22, 2014, 01:39:31 am
I updated the link with a fresh compile, and "play tested" 2 missions and they worked fine. Let me know if that fixes your issues.

I just installed the newest version on a fresh install and it's still crashing at the inventory and battle screen for me. Running windows 7 64 bit.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on June 22, 2014, 03:45:26 pm
Shoot sorry guys, I didn't look at the inventory screen, only ending a battle. When I get a chance later today I will properly test equipping soldiers
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: FudgeDragon on June 22, 2014, 04:23:26 pm
I assume therefore that it crashes the second you press the new battle button on the main menu?

I'm not seeing an issue, either with my personal git build or with the version in the first post. Lemme have a crack at some sort of installation guide, it might be an installation issue.


If it still doesn't work after that I will be most confused. Either that or I'm worse at instructions that I thought :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: wsmithjr on June 22, 2014, 07:25:06 pm
If it still doesn't work after that I will be most confused. Either that or I'm worse at instructions that I thought :)

It's not you, it's the install.  I had a working install with the 6/15 download, but the 6/21 download breaks it.  Didn't test extensively, but it does crash when you attempt to enter the inventory screen when equipping the Skyranger.  6/15 version worked perfectly and reinstalling that gets everything working again.

[Clarification: when I say "working perfectly" I mean in the regular campaign itself.  The 6/15 version still has the bug where it crashes upon exiting the single battle mode, which is a separate issue from this latest problem.]
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on June 22, 2014, 07:46:22 pm
Are you all playing the nightly, or the milestone build? It might be because I keep updating with the nightly... I will see if I can release a nightly updated mod and a milestone mod.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: wsmithjr on June 22, 2014, 08:06:20 pm
Are you all playing the nightly, or the milestone build? It might be because I keep updating with the nightly... I will see if I can release a nightly updated mod and a milestone mod.

I think that's it.  Went  and installed the nightly and then reinstalled 6/21 and the problem went away.

Individual battle mode problem is solved as well.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on June 22, 2014, 08:22:34 pm
Good to hear!

edit : a Legacy version has been compiled with a link on page one.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Peperonis on June 22, 2014, 08:55:54 pm
Confirming that Legacy update works perfect with 1.0 version (milestone one). Also one quick question. 1.0 version is the 'official' one while nightly versions are something like 'modded' versions? thx a lot again! :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on June 22, 2014, 09:38:58 pm
Confirming that Legacy update works perfect with 1.0 version (milestone one). Also one quick question. 1.0 version is the 'official' one while nightly versions are something like 'modded' versions? thx a lot again! :D

OXC development is ongoing, so the devs keep adding more code to the game; when they do, they release nightlies for us all to experiment with. Normally when I update my mod, I merge the nightlies into it. So if you don't download updates to the game and you only play the 1.0 release, then stick with the legacy mod :) I will update both when I update my mod!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Aldorn on June 22, 2014, 11:14:49 pm
Confirming that Legacy update works perfect with 1.0 version (milestone one). Also one quick question. 1.0 version is the 'official' one while nightly versions are something like 'modded' versions? thx a lot again! :D
No, it would better to say that nightly builds are WIP
Nightly... Nightly... Nightly... (some weeks)... Nightly... Nightly... 1.1
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: lorrdmatt on June 23, 2014, 01:20:56 am
Just an update to let the mod creator know that his legacy mod is working with 1.0 for me as well AND a working nicely alongside some other mods. Excellent work on the mod!

Quick question regarding the commendations; how exactly can I find out the requirements for each commendation or create any of my own?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on June 23, 2014, 01:51:38 am
Just an update to let the mod creator know that his legacy mod is working with 1.0 for me as well AND a working nicely alongside some other mods. Excellent work on the mod!

Quick question regarding the commendations; how exactly can I find out the requirements for each commendation or create any of my own?

Thanks! To create your own commendatinos, find your OpenXcom location (Probably C:\Program Files\OpenXcom), go into the Data folder, into the Ruleset folder. Open Commendations.rul in either Notepad++ or Notepad. If you don't know how to mod rulesets in general : https://www.ufopaedia.org/index.php?title=Rulesets_(OpenXcom)

There are 3 chunks of text in the ruleset: extraSprites, extraStrings and then commendations. There is also a huge comment block before commendations where I try to explain how to create your own commendations.

Take a look at that and the commendations below it; I have no idea how clear it is because I wrote the code and the explanation, so it's obvious to me!

edit: and if you have a great idea but "can't" create it through modding, share it and I will see if I can create it via source code changes.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Souljah1214 on June 23, 2014, 09:45:59 am
i was a bit away, and now i see this mod is 1.0ready.... so hopefully my campaing against the invasion can begin... thanks for your work! and hopefully this mod will be implemented in future releases, since it gives such a new taste to the good old flavour:)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ibanix on July 03, 2014, 04:31:55 pm
Unfortunately this crashes for me immediately on run, using 1.0. Sadface.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 03, 2014, 04:42:33 pm
The game won't launch? Make sure you replaced the DLLs as well. They are found in the folder named "DLLs"; this seems to be the most common problem.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ibanix on July 03, 2014, 05:06:50 pm
Yup, was using the new DLLs.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 03, 2014, 09:31:24 pm
That's odd. If you're using the 1.0 Legacy version of the mod with the 1.0 release (not the nightly) of the game, and you replaced the .exe and the .dlls, then I am not sure what is going wrong here.

Are you able to provide more details?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 03, 2014, 10:42:36 pm
Hello just tried this and it's simply great :)

Thanks for the work :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: wsmithjr on July 04, 2014, 03:04:25 am
Yup, was using the new DLLs.

I don't mean any offense by this, but did you overwrite the DLLs in the main OXC folder with the DLLs from the DLL sub-folder in the mod pack?  If you ask me, the install instructions are a little unclear and I had similar problems to you until I figured out that the DLLs don't go in a DLL subfolder, but need to overwrite the original DLLs in the same folder as the .exe.

FWIW
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ibanix on July 04, 2014, 05:41:59 am
I was able to get this to work on a second try. I had to add the Commendations.rul manually in options.cfg. Without that it would just crash at startup.

Works so far! I'll report back on any other issues.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ibanix on July 04, 2014, 07:31:04 am
I had a soldier win the 'Swiftness Citation' via a kill from a proximity grenade. I'm guessing that's not what was intended.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 04, 2014, 01:14:45 pm
I had a soldier win the 'Swiftness Citation' via a kill from a proximity grenade. I'm guessing that's not what was intended.

Totally correct; all I did was track to see if he killed an enemy during the enemy turn. I will split the commendation into Swiftness, for killing an alien using the weapon in your hand, and perhaps a Trap laying commendation for killing an enemy with an explosive on their turn. Thanks!

Also, if you feel some commendations are "too easy" to get or something let me know too, I haven't play tested this extensively for 'fun', only for functionality.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 04, 2014, 05:26:34 pm
Also, if you feel some commendations are "too easy" to get or something let me know too, I haven't play tested this extensively for 'fun', only for functionality.

I was thinking about this - sometimes it feels that the squad is showered with medals after a mission. For instance, the Service Medal says it is received after serving many months but it seems to be awarded after a single month has passed. Overall you may want to increase the criteria so that most medals are distinctions of exceptional service and not the norm. Otherwise medals become boring after you receive tons of them after a mission.

And another suggestion is to display the full criteria for receiving the medal on the description ('awarded after serving for 3 months', 'given by killing at least 10 Sectoids', etc.) so that it's easier to figure what a soldier still needs to do to receive that medal.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: the_third_curry on July 04, 2014, 05:45:29 pm
I was thinking about this - sometimes it feels that the squad is showered with medals after a mission. For instance, the Service Medal says it is received after serving many months but it seems to be awarded after a single month has passed. Overall you may want to increase the criteria so that most medals are distinctions of exceptional service and not the norm. Otherwise medals become boring after you receive tons of them after a mission.

And another suggestion is to display the full criteria for receiving the medal on the description ('awarded after serving for 3 months', 'given by killing at least 10 Sectoids', etc.) so that it's easier to figure what a soldier still needs to do to receive that medal.

Are you sure about the Service Medal? All of my soldiers get the Military Cross after the first month (as they're supposed to), but I've never seen anyone get the Service Medal after their first month.

Also, I believe one reason that some of the medals are a bit easy is that there are 9 Decoration Levels. I'm in December of my current playthrough and I don't think I've seen any of my soldiers go higher than a Third Bronze Pin. Getting medals isn't too hard, but having people live long enough to see any meaningful decoration level is a bit of rarity for me.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 04, 2014, 06:20:21 pm
Are you sure about the Service Medal? All of my soldiers get the Military Cross after the first month (as they're supposed to), but I've never seen anyone get the Service Medal after their first month.

Also, I believe one reason that some of the medals are a bit easy is that there are 9 Decoration Levels. I'm in December of my current playthrough and I don't think I've seen any of my soldiers go higher than a Third Bronze Pin. Getting medals isn't too hard, but having people live long enough to see any meaningful decoration level is a bit of rarity for me.

I might be confusing the medal, but it is the one that says that a soldier has served many months.

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ibanix on July 04, 2014, 07:18:08 pm
I might be confusing the medal, but it is the one that says that a soldier has served many months.

I got the same thing - it seems to be triggered after 3 missions? 5 missions seems better.

Also, I can't figure out the criteria for the Order of Earth.

Personally I'd also remove the Honor Cross (or whichever) that everyone gets; it feels cheap.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: the_third_curry on July 04, 2014, 07:26:13 pm
I got the same thing - it seems to be triggered after 3 missions?

That must be it then.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 04, 2014, 07:31:48 pm
Awesome feedback :3

And another suggestion is to display the full criteria for receiving the medal on the description ('awarded after serving for 3 months', 'given by killing at least 10 Sectoids', etc.) so that it's easier to figure what a soldier still needs to do to receive that medal.

I thought about this and decided against it. My rationale is that it's less gamey and more realistic (sort of not really ;p) when the commendation sounds like something that could actually be given. On the other hand, the ruleset lays everything bare; if you want to know, you can go look there.

I was thinking about this - sometimes it feels that the squad is showered with medals after a mission.

As the_third_curry said, commendations have 10 levels. What I have coded already but yet to take advantage of, is the ability to "skip" decoration levels, lowering the amount of awards. That is to say, maybe the "kills" commendation will only get 1 bronze star, 2 silver stars and 3 gold stars as it's decorative levels, allowing me to reduce the amount of times it gets reawarded without increasing difficulty. I am considering doing this to all the "odd" commendations, like night terror missions and the like, but keeping the ten levels for all the modular medals, like the gun related or alien related ones.

I got the same thing - it seems to be triggered after 3 missions? 5 missions seems better.

Also, I can't figure out the criteria for the Order of Earth.

Personally I'd also remove the Honor Cross (or whichever) that everyone gets; it feels cheap.

The Military Cross is awarded after 3, 5, 10... missions and the last one is up to 50.

The Order of Earth medal is awarded for completing missions that are considered "important"; mostly non-scout missions and no base defense missions.

The Honor Cross is indeed awarded to everyone, even if they didn't do anything. I could require the soldier to at least be a squaddie to receive it... however a medal that everyone gets isn't special, I agree. I think the rationale behind this one was "not every soldier gets it, only xcom soldiers get it"

The Service Medal is awarded after 3 months, 6, 9, ... up to 30 months of service.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: wsmithjr on July 05, 2014, 12:35:10 am
Personally I'd also remove the Honor Cross (or whichever) that everyone gets; it feels cheap.

Yeah, perhaps.  But, it is a common thing for military personnel as far as I understand it.  For example, the American Campaign Medal recognized American military service members who performed military duty in the American Theater of Operations during World War II.  If you're interested, you can find info at https://en.wikipedia.org/wiki/American_Campaign_Medal.  I'm sure there are hundreds of other medals or campaign ribbons like this throughout military history.

So, I can see on the one hand how it's a little silly because "everybody gets it" but it's cool and it's consistent with military history.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ibanix on July 05, 2014, 12:39:13 am
The Military Cross is awarded after 3, 5, 10... missions and the last one is up to 50.

The Order of Earth medal is awarded for completing missions that are considered "important"; mostly non-scout missions and no base defense missions.

The Honor Cross is indeed awarded to everyone, even if they didn't do anything. I could require the soldier to at least be a squaddie to receive it... however a medal that everyone gets isn't special, I agree. I think the rationale behind this one was "not every soldier gets it, only xcom soldiers get it"

The Service Medal is awarded after 3 months, 6, 9, ... up to 30 months of service.

Thanks for the info. Personally, I'd start the Military Cross at 5 missions instead of 3, and go up from there.

The thing about the Honor Cross is - all of our soldiers ARE xcom soldiers! We never play with any others!

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ibanix on July 05, 2014, 12:40:57 am
Maybe turn the Honor Cross into a six-month medal? For fighting the XCOM Campaign.  ;D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: the_third_curry on July 05, 2014, 04:01:22 am
Maybe turn the Honor Cross into a six-month medal? For fighting the XCOM Campaign.  ;D

That would create a redundancy with the Service Medal.

Also, doesn't the soldier who took a plasma blast to the face stepping off the Skyranger in their first mission deserve something for their contribution?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ibanix on July 05, 2014, 04:08:07 am
Does he deserve the same medal as everyone else? We've got the Purple Heart for wounded soldiers. Can you make a posthumous medal for dying in the service of XCOM?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 05, 2014, 04:29:27 am
Does he deserve the same medal as everyone else? We've got the Purple Heart for wounded soldiers. Can you make a posthumous medal for dying in the service of XCOM?

Why don't you take a look at the medals of your dead soldiers ;)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ibanix on July 05, 2014, 05:13:28 am
Hah, I just noticed that and was going to comment "whoops".

Suggestion: How about a medal for killing an enemy with a proximity grenade?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 05, 2014, 02:29:27 pm
I will add that as a sort of trapper/surprise medal with all thrown explosives detonating on the enemy turn, and fix the Swiftness medal to not count those explosives :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ibanix on July 06, 2014, 03:24:50 am
I stole a look at the ruleset, and there are still a few medals I've yet to get anyone to get, but they have higher requirements.

I wouldn't mind a medal for *causing* friendly fire; a Medal of Shame or the like. For humor purposes more than anything.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 06, 2014, 01:26:03 pm
Yeah, there are some commendations that are very unlikely to get without trying. Especially beating a mission with only one soldier ;p

I had considered 'demotivational' commendations like that, because those events are notable too, but I am not sure how to make it happen properly. Perhaps instead of a medal they get a skull and crossbones? I am not sure.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on July 06, 2014, 02:24:38 pm
Skull and bones is too often used in a positive way, for example for counting kills. I think a printed page with a big red X would be better. ;)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Falko on July 06, 2014, 02:50:46 pm
how anbout a dunce hat or a fools cap
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 06, 2014, 06:48:29 pm
Some of my soldiers aren't getting any Campaign Ribbons (STR_MEDAL_CAMPAIGN_RIBBON_NAME) on regions after reaching the 1st level (5 missions on a region) but other soldiers on the same game are getting them without any problems.

Could this be a bug?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 06, 2014, 07:12:43 pm
I am able to reproduce a silly bug where two soldiers have x amount kills with a rifle, but only one of them is being properly awarded for it. I think they're both related.

The modular medals were a puzzle to put together, so I sort of ... quietly hoped nobody would notice.. :D

It's a thing that needs to be looked into. Once it's fixed, your guys will be awarded their medals properly.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 06, 2014, 07:26:35 pm
I am able to reproduce a silly bug where two soldiers have x amount kills with a rifle, but only one of them is being properly awarded for it. I think they're both related.

The modular medals were a puzzle to put together, so I sort of ... quietly hoped nobody would notice.. :D

It's a thing that needs to be looked into. Once it's fixed, your guys will be awarded their medals properly.

Well, this is happening a lot on my current game since I'm trying to get as many commendations as possible for my Commander and I've noticed it happening so far with awards related with regions, weapons and alien races.

And I have two or more soldiers having anyone of the previous awards but a third soldier won't receive it.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ibanix on July 07, 2014, 01:05:26 am
Some of my soldiers aren't getting any Campaign Ribbons (STR_MEDAL_CAMPAIGN_RIBBON_NAME) on regions after reaching the 1st level (5 missions on a region) but other soldiers on the same game are getting them without any problems.

Could this be a bug?

I have something similar, where my guys will ONLY get North American Campaign ribbons. They never seem to get them for anywhere else.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 07, 2014, 02:38:54 am
I have something similar, where my guys will ONLY get North American Campaign ribbons. They never seem to get them for anywhere else.

I have plenty of Southeast Asia ribbons to trade... ;)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ibanix on July 07, 2014, 02:44:17 am
I just took out an alien base and was surprised not to get medals for it. That's a pretty huge accomplishment, I think a medal is in order.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 07, 2014, 03:40:41 am
I just took out an alien base and was surprised not to get medals for it. That's a pretty huge accomplishment, I think a medal is in order.

Huh, you're right there isn't one. I will rectify this shortly :3

In your experiences, would you guys say that modular commendations (the ones that are specific to weapons, aliens, regions, etc) are being awarded correctly _once_, but it is not being awarded correctly for a second level same soldier or for a first level second soldier? Any data on how this fails to be awarded would help me focus my search through the logic!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ibanix on July 07, 2014, 03:52:59 am
Well, for me, the bronze pins are working correctly; but the <area> Campaign medals have only triggered for North America, yet I've done missions just about everywhere.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 07, 2014, 04:56:40 am
Huh, you're right there isn't one. I will rectify this shortly :3

In your experiences, would you guys say that modular commendations (the ones that are specific to weapons, aliens, regions, etc) are being awarded correctly _once_, but it is not being awarded correctly for a second level same soldier or for a first level second soldier? Any data on how this fails to be awarded would help me focus my search through the logic!

This may help... these are the stats of my top soldier.

(https://www.openxcom.com/content/modimages/JBUBEPJV070620140950.png)
(https://www.openxcom.com/content/modimages/KZBAOMQG070620140950.png)

If I'm deducing correctly, he should have 1 award for Chryssalids, Mutons and Sectoids, and 4 awards for Floaters and Snakemen, plus being both proficient with Heavy Plasma and Rocket Launcher. From the second pic he should have campaign ribbons for Australasia, SE Asia and Europe.

These are his actual commendations:
(https://www.openxcom.com/content/modimages/QEOZCNDN070620140950.png)
(https://www.openxcom.com/content/modimages/SLADYQVG070620140950.png)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ibanix on July 07, 2014, 05:10:04 am
'Improvisation' ? How do you get THAT kill type?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 07, 2014, 05:43:36 am
'Improvisation' ? How do you get THAT kill type?

When you improvise ;) It is interpreted by the source as any kill not from a weapon. Cyberdisk deaths, barrels, gas tanks, etc.

Would you be able to post your save somewhere Hobbes? Even a link to pastebin. That way I can tweak the logic, win a quick match and see if you get the mission medals you should have.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 07, 2014, 06:01:29 am
When you improvise ;) It is interpreted by the source as any kill not from a weapon. Cyberdisk deaths, barrels, gas tanks, etc.

Would you be able to post your save somewhere Hobbes? Even a link to pastebin. That way I can tweak the logic, win a quick match and see if you get the mission medals you should have.

Saved Game (https://dl.dropboxusercontent.com/u/18824603/312.zip)

Try the above link.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 07, 2014, 06:42:54 pm
Meanwhile a little more feedback that came to my mind yesterday.

This mod is great for recording a soldier's history and the commendations so far work like collecting cards - I'm trying to get as many as possible for my elite squad.

There seems to be also two types of commendations - the ones you get by doing regular actions (reaching certain numbers for killing aliens, missions on areas, using specific weapons) and the ones you get by doing crazy and/or risky stuff (Man Of Steel, Black Cross, Iron Man, Star of Value, etc.). However all of these medals are given automatically upon certain conditions and none is given directly by the player.

So, what may be interesting to explore would be:
* Separate better the proficiency commendations from the medals for exceptional actions.
* One thing that would help would be if it's possible to give ranks for the commendations list order, so that exceptional medals are always on top. If I have a soldier that has earned Man Of Steel, that award is much more satisfying to look at than nearly all others and I shouldn't need to scroll down the list to see it.
* Another idea would be to have different screens from both proficiency commendations and exceptional medals. You'd use the commendations screen to keep track of a soldier's progress (which this mod is tailor made to do so) and the medals screen to enjoy the crazy/heroic stuff he/she has done. It would be also nice that the medal's info includes details of the mission where it was earned.
* Finally add the possibility of the player awarding specific medals to soldiers. While playing I sometimes wanted to give a soldier an additional medal because he/she did actions that although not recorded made a significant contribution.

Another suggestion, of a graphical nature: it might look better if the commendations have a border (see attached pic) or if more different colors are used because when some ribbons are next to the other and have similar colors it completely makes them lose their individual shape.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 08, 2014, 05:42:51 am
I like those borders, especially with the changing colors! That would actually be pretty painless to try, because I can mod the star pin things to have a border and be done. No need to mod the individual sprites.

Differentiating between commendations is not a bad idea, I will look into being able to list them in some order. One way of sort of differentiating between "good" and "better" commendations would be through name, where "Citations" are so-so, "medals" are good, "stars" are great. I don't see myself adding a new screen for the two categories of awards just because of how little space I have to work with.

Being able to award medals yourself to soldiers would be cool, but would require almost everything to be coded. Hardly anything I've written so far could be reused. Too bad, because I know that there are some things that just can't be commended with the use of computer logic! I am interested in the idea of awarding commendations to "you", the commander, though.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ibanix on July 08, 2014, 06:53:00 am
I second the borders.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 08, 2014, 07:38:59 am
I like those borders, especially with the changing colors! That would actually be pretty painless to try, because I can mod the star pin things to have a border and be done. No need to mod the individual sprites.

I have already edited the .png files to include the borders. I tried first doing it with the stars but I found out that if there's no star (1st award) the border will not be displayed.

I am interested in the idea of awarding commendations to "you", the commander, though.

What kinda of criteria you'll use?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ibanix on July 08, 2014, 08:04:48 am
What kinda of criteria you'll use?

There should be awards for finishing a mission without getting anyone killed or wounded (but requires at least one alien kill). Awards for killing more aliens than soldiers (not HWPs) brought on a mission (you brought 10 guys, 10+ aliens). Award for a successful alien base assault.

Just a few ideas.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 08, 2014, 06:03:50 pm
Other "commander" commendations would be total money, having lots of highly decorated soldiers, keeping civilian casualties low, keeping all countries happy or something. I don't plan on doing any of that stuff soon though; I would rather perfect the current state of the mod and get it merged into the game base :3

So I posted new zip files; these should be more straight forward to install! Modular medals should work now, and I will tweaked a lot of the criteria for medals. I did not get around to adding a "Alien Base Assault" medal.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 08, 2014, 06:39:46 pm
So I posted new zip files; these should be more straight forward to install! Modular medals should work now, and I will tweaked a lot of the criteria for medals. I did not get around to adding a "Alien Base Assault" medal.

Thanks. I've already tried it and after the medals updated after a mission, the modular medals weren't correctly updated. my top soldier got this:

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 08, 2014, 07:06:15 pm
Dang, I will look into why the name of the weapon wasn't saved.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 08, 2014, 08:08:18 pm
I've been looking at the ruleset.

I got no clue of whatever is required to get this medal. I don't know if it was kept vague on propose.
     STR_MEDAL_IRON_MAN_NAME: "Iron Man"
     STR_MEDAL_IRON_MAN_DESCRIPTION: "Given to a soldier who is truly an Iron Man or Iron Woman."

This one I'm imagining that it is related with prox mines:
     STR_MEDAL_TRAP_NAME: "Prowler Cross"
     STR_MEDAL_TRAP_DESCRIPTION: "Given to a soldier for demonstrating keen tactical sense."
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 08, 2014, 09:11:02 pm
Iron Man is given to a soldier who goes on a mission alone and wins. I used to have 1 through 10 awards of it, but settled for a one time triple gold star award ;p

Prowler Cross is for killing an enemy on the enemies turn using grenades or proximity mines. The intent was to reward setting traps, but I wasn't sure how to convey that properly through the description without sounding too weird. I thought that setting traps was a good indicator of someone having a keen tactical sense.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: arrakis69ct on July 08, 2014, 09:26:39 pm
Can update for last nighly???
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 08, 2014, 09:28:28 pm
Iron Man is given to a soldier who goes on a mission alone and wins. I used to have 1 through 10 awards of it, but settled for a one time triple gold star award ;p

That was my suspicion but my top soldier failed to receive it after recovering a Medium Scout on his own, so I reloaded the game, brought him and 2 rookies to the UFO and got him a Star of Valor instead. ;)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on July 08, 2014, 10:06:47 pm
I thought that setting traps was a good indicator of someone having a keen tactical sense.

Sorry, but tactical sense brings many things to my mind before traps get a mention. It is a very broad thing.

How about: "Given to a soldier for demonstrating mastery of the battleground" or "Given to a soldier for demonstrating exceptional use of terrain"? Neither is perfect, but I think both are more related to mines.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 09, 2014, 02:18:11 am
Thanks. I've already tried it and after the medals updated after a mission, the modular medals weren't correctly updated. my top soldier got this:

I tried testing more thoroughly: new game and giving a soldier 20 kills without a commendation, but neither reproduced the error you got. I know the source of it: the commendation did not get a weapon name or anything attached to it. Do you know which weapon it was supposed to be for? Does it happen to more than one soldier? Does the award continue to get awarded each mission?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 09, 2014, 03:05:48 am
I tried testing more thoroughly: new game and giving a soldier 20 kills without a commendation, but neither reproduced the error you got. I know the source of it: the commendation did not get a weapon name or anything attached to it. Do you know which weapon it was supposed to be for? Does it happen to more than one soldier? Does the award continue to get awarded each mission?

I've posted pics on a previous post and the commendations that he is missing (Plasma Pistol, Plasma Rifle and Heavy Plasma).

That guy is currently wounded for 17 days but I'll play a bit more to see what happens and get back to you later.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ibanix on July 09, 2014, 03:10:43 am
I just upgraded. At the end of my mission (10 guys, 1 HWP vs 3 Ethereals, Large Scout), ALL of my soldiers got the following medals:

* Black Cross
* Bolt's Cross
* {0} Campaign Ribbon
* Performance Citation
* Defender Medal
* Order of the Hammer
* Greanadier's Medal
* Inferno Star
* Longest Night
* Man of Steel
* Medal of Heroism
* Merit Star
* Military Cross
* Order of Earth
* Order of Glory
* Order of Restraint

and so on - I think every medal possible.

My save file is attached.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 09, 2014, 03:42:45 am
I just completed a mission. All of my soldiers got a ton of decorations, including these ones:
* {0} Campaign Ribbon (this is exactly what appeared, no weapon attributed)
* {0} Xenocide Medal (same as above)
* {0} Proficiency Medal (same as above)

In some cases the soldier wasn't even supposed to get a medal, i.e. 1 soldier has the Heavy Plasma Proficiency and now received a {0} Proficiency Medal but he made nearly all kills with the Heavy Plasma.

EDIT: I started a new game and after the first mission I got a ton of achievements for all my soldiers that they were not supposed to get, including the {0} ones.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 09, 2014, 03:24:34 pm
I am at a loss, I just started a new game, turned on some other mods, and I am not getting flooded with medals. The {0} ones worry the me the most, but I am not seeing them.

ibanix, I made a lot of the commendations easier to get, so a first time burst of medals isn't necessarily a bug... but the {0} ones definitely are. But I can't figure out how they keep hapenning.

You guys are playing with a lot of mods (shouldn't be the culprit), but could you make a copy of your save, open it up, and then turn off all the mods except commendations? I am not able to test your saves with all the mods on them.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 09, 2014, 03:44:04 pm
I am at a loss, I just started a new game, turned on some other mods, and I am not getting flooded with medals. The {0} ones worry the me the most, but I am not seeing them.

ibanix, I made a lot of the commendations easier to get, so a first time burst of medals isn't necessarily a bug... but the {0} ones definitely are. But I can't figure out how they keep hapenning.

You guys are playing with a lot of mods (shouldn't be the culprit), but could you make a copy of your save, open it up, and then turn off all the mods except commendations? I am not able to test your saves with all the mods on them.

On the new game I got the Black Cross (surviving friendly fire) for all of my soldiers even though I can't recall any occasions of friendly fire.

I'm going to disable all mods except yours and start a new game to see what happens. I will try also disabling the other mods from my previous game as you requested before saving, although I'm not sure how the game will act without the other mods.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: arrakis69ct on July 09, 2014, 04:10:23 pm
I see this morning a update, this afternoong no is present. Why??
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 09, 2014, 05:04:32 pm
I see this morning a update, this afternoong no is present. Why??

Some forum members are running into problems with it, so I took it down. It's still on the main page of this one, though it says it's broken. Try at your own risk! :D

I'm going to disable all mods except yours and start a new game to see what happens. I will try also disabling the other mods from my previous game as you requested before saving, although I'm not sure how the game will act without the other mods.

I thought about it, and I don't think you can disable mods before loading, so my request may be impossible to fulfill. However, I have a hypothesis! I think the faulty modular medals are to blame for the current ones not working. I am going to add a debug option to clear a soldier's commendations, and then the next mission/end of month he will get them all back. If he still gets {0}s, then we know something is up. Otherwise, we can assume that my hypothesis was correct!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: arrakis69ct on July 09, 2014, 05:05:51 pm
Ok. Thx and i wait to stable version. Thx a lot
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 09, 2014, 05:26:12 pm
I thought about it, and I don't think you can disable mods before loading, so my request may be impossible to fulfill. However, I have a hypothesis! I think the faulty modular medals are to blame for the current ones not working. I am going to add a debug option to clear a soldier's commendations, and then the next mission/end of month he will get them all back. If he still gets {0}s, then we know something is up. Otherwise, we can assume that my hypothesis was correct!

OK, meanwhile I started a game only using your mod and I had a ton of decorations (Black Cross for everybody again) plus the {0} ones. Do you still need the save file? And do you want the pre-mission save or the after mission?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 09, 2014, 06:02:47 pm
OK, meanwhile I started a game only using your mod and I had a ton of decorations (Black Cross for everybody again) plus the {0} ones. Do you still need the save file? And do you want the pre-mission save or the after mission?

Give me both why not. Are you using the Legacy version? I am compiling a version with a debug option that removes commendations to have them re-awarded. After this mess is sorted out, you will be able to re-award your commendations to your soldiers, taking out all the bugged ones ;p

Here is a debug legacy version : https://dl.dropboxusercontent.com/u/234369005/OXC/Legacy%20Debug.zip

Press Ctrl+D in the geoscape, and then Ctrl+C to delete all commendations. Let me know if the bad ones keep coming back.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 09, 2014, 06:13:48 pm
Give me both why not. Are you using the Legacy version? I am compiling a version with a debug option that removes commendations to have them re-awarded. After this mess is sorted out, you will be able to re-award your commendations to your soldiers, taking out all the bugged ones ;p

Here is a debug legacy version : https://dl.dropboxusercontent.com/u/234369005/OXC/Legacy%20Debug.zip

Press Ctrl+D in the geoscape, and then Ctrl+C to delete all commendations. Let me know if the bad ones keep coming back.

The saves are attached and they're both for legacy. I'll try the debug version.

EDIT: Just tried the debug version you posted, did Ctrl+D and Ctrl+C to delete the commendations. They were deleted but I took the squad for a couple missions and I still get the {0}s, plus everyone got Man of Steel, which only 1 of them had, plus the same for other decorations. 
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 09, 2014, 07:25:16 pm
The saves are attached and they're both for legacy. I'll try the debug version.

EDIT: Just tried the debug version you posted, did Ctrl+D and Ctrl+C to delete the commendations. They were deleted but I took the squad for a couple missions and I still get the {0}s, plus everyone got Man of Steel, which only 1 of them had, plus the same for other decorations.

Good news! I can reproduce your "soldiers are so awesome, give them all the awards!" bug, so now I can start figuring out what the heck is going on :)

edit: I think I found the problem. Only like half of my new code got moved over to the Legacy version of the mod, so there are 16 commendations whose criteria are being looked at incorrectly. Those are probably the ones getting handed out.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 09, 2014, 08:59:51 pm
Good news! I can reproduce "your soldiers are so awesome, give them all the awards!" bug

That isn't a bug - of course my soldiers are awesome ;)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 10, 2014, 04:58:58 am
That isn't a bug - of course my soldiers are awesome ;)

I think this fixes the issues: https://dl.dropboxusercontent.com/u/234369005/OXC/Legacy%20Debug.zip

Give it a try, clear your commendations with the debug and see what happens! I also added two new commendations while I was at it (one for alien base assault missions) ;p and updated the Prowler Cross description.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ibanix on July 10, 2014, 09:23:51 am
I tried the most recent upload and it hasn't fixed my problem; everyone still gets every medal. I cleared the medals via the debug option first.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 10, 2014, 03:07:59 pm
I tried the most recent upload and it hasn't fixed my problem; everyone still gets every medal. I cleared the medals via the debug option first.

Did you try the one I linked in my above post? That ones difference from the one on the front page. Or at least it should be :x

If not, try this : https://dl.dropboxusercontent.com/u/234369005/OXC/071022014%20Legacy%20Debug.zip

That one has the new sprites for the new commendations; I forgot to add them last time :x
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ibanix on July 10, 2014, 05:04:33 pm
I was using this one:

https://dl.dropboxusercontent.com/u/234369005/OXC/Legacy%20Debug.zip

I'll try the other one shortly.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 10, 2014, 05:15:39 pm
Did you try the one I linked in my above post? That ones difference from the one on the front page. Or at least it should be :x

If not, try this : https://dl.dropboxusercontent.com/u/234369005/OXC/071022014%20Legacy%20Debug.zip

That one has the new sprites for the new commendations; I forgot to add them last time :x

Just tried this version and the bugs are still there (the {0} and getting a ton of decorations). I activated the debug mode, did Ctrl D and Ctrl C, went to a terror site and lift off at the 1st round.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: BlackLibrary on July 14, 2014, 06:24:30 pm
If this could get stabilized, its worth putting in the build so you don't have to keep updating after various nightlies.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: the_third_curry on July 14, 2014, 10:36:23 pm
If this could get stabilized, its worth putting in the build so you don't have to keep updating after various nightlies.

I agree. Having to continuously update for nightlies that don't even affect the functions of the mod has to get old after a while. Unfortunately, merging it with the build might would take some of the creative freedom of the mod out of Shoes' hands.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ibanix on July 14, 2014, 11:54:30 pm
It shouldn't be that difficult, but code has to be well tested before being committed.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: SupSuper on July 15, 2014, 07:34:05 am
I agree. Having to continuously update for nightlies that don't even affect the functions of the mod has to get old after a while. Unfortunately, merging it with the build might would take some of the creative freedom of the mod out of Shoes' hands.
Shoes can still do whatever maintenance he wants before and after the mod's integrated, it's open-source. If it makes it simpler, he can always just keep his Commendation Medals as a separate mod, while the stats part is integrated into the main game, so it just becomes a regular ruleset mod like all the others.
The main delays in integrating are:
1. From this thread's recent posts, there are still issues to work out.
2. His changes involve over 5000 changed lines of code (much bigger than your typical PR) that have to be carefully reviewed to make sure they don't cause any problems to existing players.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: BlackLibrary on July 15, 2014, 11:55:25 am
5000 lines of code?  Shoes...you are one dedicated mofo.  Thank you!  Do what you do.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: arrakis69ct on July 15, 2014, 08:39:44 pm
5000 oh my god. More than the game original XD
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Aldorn on July 15, 2014, 11:15:42 pm
5000 lines of code?  Shoes...you are one dedicated mofo.  Thank you!  Do what you do.
Beware, I suspect Sup to be the Cydonian Brain, whose we try to beat an illusion in the final mission  8)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: BlackLibrary on July 16, 2014, 12:45:50 am
Beware, I suspect Sup to be the Cydonian Brain, whose we try to beat an illusion in the final mission  8)

You know...that would explain quite a few things I've noticed.  Quite a few things...
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ibanix on July 17, 2014, 02:37:37 am
The last actual working version seems to be the 06/22 build.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 17, 2014, 05:24:00 pm
I've been lazy as of late :3

I am pretty certain I have fixed the legacy bug of commendations being given too often, so I am going to publish what I have now for legacy and nightly and see what happens. I am less hesitant to do this now that I've added a debug command to clear a soldier of his commendations.

edit: I think I just figured out the part-two of the "everyone gets commendations" bug... I haven't been bundling my updated ruleset in the zip... >.>
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: PegasusOrgans on July 18, 2014, 01:19:26 am
Is there are a chance this can be added to Final Mod? I can't imagine playing it without these amazing features!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on July 18, 2014, 01:33:59 am
Is there are a chance this can be added to Final Mod? I can't imagine playing it without these amazing features!

Hopefully it will be added to the main game, so there will be no need for this.

As for the Final Mod Pack, perhaps; but not at this moment, since I don't want to get into modifying the exe, especially since the Commendations mod is unfinished. Nevertheless, there's no problem with running the FMP and the Commendations mod at the same time; they shouldn't conflict with each other.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: wsmithjr on July 18, 2014, 04:09:54 am
Nevertheless, there's no problem with running the FMP and the Commendations mod at the same time; they shouldn't conflict with each other.

I run them both without any problems.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 18, 2014, 04:40:21 am
I run them both without any problems.

Yup, just tried the Legacy Debug and the promotions seem to be working again :)

However, the text for the strings STR_MISSIONS_UC and several others are missing.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 18, 2014, 04:56:41 am
Yup, just tried the Legacy Debug and the promotions seem to be working again :)

Yes!

Quote
However, the text for the strings STR_MISSIONS_UC and several others are missing.

Crap! Maybe I should test my stuff better :x Oh! I bet I know what happened! I am working towards getting this merged into the game, so I moved "stats" strings to the main game, and "commendations" strings are still in the ruleset. You (everyone, both versions) are missing the "stats" strings. Oops :3

edit: it's up; I am sure that was the problem, but let me know if it wasn't!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 18, 2014, 09:41:18 pm
edit: it's up; I am sure that was the problem, but let me know if it wasn't!

Everything looks OK now, thanks for the work :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 19, 2014, 05:05:48 pm
Awesome. Now you mentioned at one point that the "winning a mission with one soldier" commendation wasn't working; I haven't looked into it, but it very well could be. Do you know of any other commendations that are wonky?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 19, 2014, 05:36:22 pm
Awesome. Now you mentioned at one point that the "winning a mission with one soldier" commendation wasn't working; I haven't looked into it, but it very well could be. Do you know of any other commendations that are wonky?

I'll test if the last version still has that bug about the "winning a mission with one soldier". I'm currently playing a new game and I'm keeping an eye to see if everything is working and I'll let you know if I find anymore bugs :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 21, 2014, 12:22:59 am
Just noticed something peculiar. After a Terror Site that took place at dawn (right after sun came up) two my of my veteran soldiers got the Longest Night Ribbon, third award, but the rookies didn't receive it as first award.

edit: now I've gotten the Longest Night Ribbon, 3rd award, notice twice appearing for the soldiers at the end of the month. Something's definitely bugged here.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Mr. Quiet on July 21, 2014, 01:23:51 am
Suggestion. After completing the mission, after the debriefing screen. You should add some immersion text saying, "commendation ceremony at 0200 hours, wear grey formal uniforms" yadda yadda. Also for dead companions ;_; should make a screen of the ones that didn't make it back. similar text, wear blue uniforms and I don't know, click ok, and back to the geoscape. After that nothing else happens.

I got the idea after playing the new Wing Commander Saga standalone, some guy died during the second mission, and I love the profession script they have in these old space sims, very realistic and immersing.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 21, 2014, 03:46:13 pm
I will look into the award level thing. I hacked something together to allow skipped decoration levels,  maybe I overlooked something.

I will also think of a way to add some flavor text if I can. Would be nice :3
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 21, 2014, 09:14:45 pm
Meanwhile I just completed a mission using only a single soldier (no HWPs also) and he didn't receive the Iron Man award (but he did receive the Nike Cross).
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: essohbe on July 23, 2014, 04:41:05 am
So does this mod work yet? It just crashes my game every time I tried to install it. How are you guys using it? AFAIK it won't work with 1.0
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: the_third_curry on July 23, 2014, 06:40:35 am
So does this mod work yet? It just crashes my game every time I tried to install it. How are you guys using it? AFAIK it won't work with 1.0

It works with 1.0 for me. Are you using a nightly?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Elyseon on July 23, 2014, 09:50:26 pm
As of late, the mod seems to be causing a crash at the end of a mission. Switching between the nightly build and the Legacy Debug version produces the same result. Also, the download link from the mod page itself seems to be broken.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 23, 2014, 10:02:06 pm
Meanwhile I just completed a mission using only a single soldier (no HWPs also) and he didn't receive the Iron Man award (but he did receive the Nike Cross).

I think I found the error in the logic; I will be updating the .exe soon enough! You will have to retry a mission to get the award though; the stat itself failed to be recorded.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Elyseon on July 23, 2014, 10:25:54 pm
While you're at it, you may want to consider renaming that particular award to Rambo Medal (or Chuck Norris?)  :P A mission done with just one soldier? That's 80s movie hardcore.

EDIT: Upon finding a build of the mod that wouldn't crash the game at the end of the mission, the game promptly went crazy and gave my troops ALL OF THE MEDALS!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 24, 2014, 01:16:08 am
EDIT: Upon finding a build of the mod that wouldn't crash the game at the end of the mission, the game promptly went crazy and gave my troops ALL OF THE MEDALS!

Be sure to use the build appropriate for the version of the game you play. If you're playing 1.0, use the Legacy version. If you want to reset the commendations, enable debug mode in geoscape (ctrl+d) and then clear commendations (ctrl+c). An old version of my mod had that issue, but it should be fixed now ...

As for the rambo medal, maybe I could add a medal that gets awarded if you're alone, you kill all the aliens, using only rifles and grenades, in the jungle tileset. At night? I only ever watched the first 15 minutes of the first movie ;p
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 24, 2014, 01:21:22 am
I think I found the error in the logic; I will be updating the .exe soon enough! You will have to retry a mission to get the award though; the stat itself failed to be recorded.

Nice. :) Did you manage to find the error on the Longest Night as well?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Elyseon on July 24, 2014, 03:26:17 am
Be sure to use the build appropriate for the version of the game you play. If you're playing 1.0, use the Legacy version. If you want to reset the commendations, enable debug mode in geoscape (ctrl+d) and then clear commendations (ctrl+c). An old version of my mod had that issue, but it should be fixed now ...

As for the rambo medal, maybe I could add a medal that gets awarded if you're alone, you kill all the aliens, using only rifles and grenades, in the jungle tileset. At night? I only ever watched the first 15 minutes of the first movie ;p

Still testing and trying to see if I can get one of the Legacy builds to work properly again. The weird thing is, I'm pretty sure it was doing just fine last time I played. Anyway, here's the error I keep getting when trying to download from the mod page itself.

Quote
THERE WAS AN ERROR
The page you requested was not found. Please try again.

DISABLED: TEMPORARY PAGE

I'm going to see if I can get the debug mode to clear things up, and I'll chime in with the results.

EDIT: OK, I'm using version 1.0, and managed to do a little testing using a zip with the Legacy build of the mod. Unless I'm doing something wrong, I can't seem to get debug mode to activate. Also, the only legacy version the site is letting me download right now is the 0.92 one. All the others give me that error message above and the nightly gives me that mission crash.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 24, 2014, 04:02:21 pm
Here is a direct link to my dropbox : https://dl.dropboxusercontent.com/u/234369005/OXC/07182014%20Legacy%20Debug.zip

You may need to enable debug mode in your config file before being able to use it in the game... I think
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 24, 2014, 04:34:01 pm
Shoes, I'm starting to suspect that there is something wrong in the mod which is causing the game to crash to desktop. Last night I was playing a mission on Farm terrain and when I killed the last alien and finished tactical the game crashed without a reason.

This hasn't been the first unexplained crash I had lately but while before it was possible that it had to do with my terrain pack, last night I had confirmation that it most likely isn't related with the terrain pack and the most probable suspect now is the Commendations mod.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Elyseon on July 24, 2014, 05:09:50 pm
Using that particular Legacy build seems to cause a crash at the end of the mission. The same seems to happen both when finishing the current mission file and when reverting to an earlier Geoscape save file. After doing several reinstalls of the original game files and disabling other mods I'd installed after getting this one, I'm pretty sure it's something in this one that's causing the crashes. Further experimentation has shown that using the modified dlls and exe, but with the commendations mod disabled in the options allows the mission to finish as normal.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 24, 2014, 05:49:44 pm
I'll have to sit down and have a proper run through at some point to see if I can reproduce any of these happenings. :(
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Elyseon on July 24, 2014, 06:00:32 pm
I can try to set up a dropbox and put up a zip with the game files I'm currently using, if you think it'll help.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 24, 2014, 06:39:30 pm
Someone else has also reported issues with the Commendations mod (https://openxcom.org/forum/index.php?topic=2670.0).

I'll have to sit down and have a proper run through at some point to see if I can reproduce any of these happenings. :(

No hurries :)

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Elyseon on July 24, 2014, 07:18:03 pm
Someone else has also reported issues with the Commendations mod (https://openxcom.org/forum/index.php?topic=2670.0).

No hurries :)

In regard to that thread, I can attest that so far, purging the config file doesn't seem to have had any effect.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on July 25, 2014, 05:57:18 pm
Just wanted to chime in here.  I tried out the Legacy build last night and had a great time.  Looks like medals are being correctly assigned, though I'm running through Carbon-Based Life-Forms at a terrible rate. :) (SuperHuman/Pistols&Grenades Only).

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Elyseon on July 25, 2014, 08:49:34 pm
Just to be clear here, which build of the Legacy version did you use?
EDIT: Acting upon this latest update, I decided to try a different approach and start a new game. Things seem to be working fine now, so I'm guessing there was some leftover data in the previous saves that didn't take well to the updates? Also, did you remove that medal rookies get upon being recruited? That threw me for a loop until the first actual mission, since I wasn't 100% sure the mod was working, but everything seems to be fine now.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on July 25, 2014, 10:20:15 pm
I'm running the base 1.0 OpenXcom and I grabbed the Legacy Build called out as the 1.0 version in the opening post.

Of my two surviving soldiers on my first mission, only one received a commendation, so I think that  isn't a problem in the Legacy build.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 25, 2014, 10:52:55 pm
I'm using the Legacy debug version that Shoes recently posted and I keep getting these occasional crashes, the last two on terror sites, that it can't attribute to any other mod than this one.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Elyseon on July 25, 2014, 10:58:34 pm
I'm using the Legacy Debug build Shoes posted here earlier. Things seem to be working fine since starting a new game. I guess the reason why the X-COM Service Medal wasn't already there is because it's supposed to kick in at the end of the month? At least that's what happened to me.
Kind of wondering how many Black Crosses these guys will end up with on the long run now. Heh, damn rookies.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 26, 2014, 06:43:49 pm
Yeah, the service medal is based on months, not missions; end of month, everyone gets one! Yaaay! All your soldiers can feel special.

I still haven't found time to play, so all I can do is sit here and wonder why Hobbes gets crashes, ivandogovich is running smooth, and Elyseon gets uncalled for commendations. :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on July 26, 2014, 10:12:15 pm
Yeah, the service medal is based on months, not missions; end of month, everyone gets one! Yaaay! All your soldiers can feel special.

I still haven't found time to play, so all I can do is sit here and wonder why Hobbes gets crashes, ivandogovich is running smooth, and Elyseon gets uncalled for commendations. :D

I removed your mod for my current game so that I can check if the crashes are being caused by something else.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Elyseon on July 27, 2014, 05:25:22 am
Yeah, the service medal is based on months, not missions; end of month, everyone gets one! Yaaay! All your soldiers can feel special.

I still haven't found time to play, so all I can do is sit here and wonder why Hobbes gets crashes, ivandogovich is running smooth, and Elyseon gets uncalled for commendations. :D

I was a bit confused because the Service Medal's description states that it's awarded when they first join. Anyway, I'll keep poking around that new save file and will let you know if it acts up again.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on July 27, 2014, 06:05:01 am
The only funny thing that I have noticed is that some of my soldiers have been credited with kills for enemy types they have not encountered or killed.

I.e.  I have only seen sectoids, but one soldier was reported to have a kill on a "floater."
On another mission, one of the soldiers was credited with killing a "rookie/human" but there were no friendly fire incidents to the best of my knowledge.

Cheers, Ivan :D
(Legacy build, with OXC 1.0)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: MrTwentyThree on August 14, 2014, 06:47:45 pm
This doesn't work for me. All the buttons have things like "STR_DIARY," "STR_MISSIONS," "STR_AWARDS," and stuff written on them.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on August 15, 2014, 05:24:01 pm
Did you extract everything properly? The missing strings means the ruleset hasn't been installed; make sure the Commendations.rul is in the same folder as xcom1.rul.

(for those wondering about lack of updates, I have yet to find time to play test! :3)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: MrTwentyThree on August 16, 2014, 09:40:47 am
I'm an idiot. I had no idea I had to enable the mod in the mods menu in the game's options. Totally new to OpenXcom (but not to o.g. x-com). Thanks!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on August 17, 2014, 04:26:19 am
 :-[

I just had a crash at the end of my first mission. 5 soldiers evaccing from a Terror mission.  When I disabled the commendations mod, it doesn't crash.

Save file attached.

Legacy 1.0 debug version

Other mods:
UpClose Modpack.  ( the only thing in action here is combat knives, and scout drones)
Lukes extra Ufos
statstring
psi-line of sight
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Hobbes on August 17, 2014, 04:31:51 am
(for those wondering about lack of updates, I have yet to find time to play test! :3)

I hope you find time... this is one of my favorite mods but I currently have it disabled because of the bugs :'(
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on August 17, 2014, 05:20:34 am
After the mission, I referenced before in my save, I re-enabled the commendations, and just completed my second mission successfully.

I was concerned that destroyed scouts may have been causing the crash, so I replayed the last turns, and destroyed one of my drones.  Still no crash.

I don't know what the cause of the first crash was...  There were two cyberdisks killed and about 6 sectoids.  There were some fratricides as well. 
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on August 18, 2014, 12:34:53 am
More Playtesting feedback.

Situation:  Touch and go, night terror mission.

A rookie (named "Novice") in the door with a primed HE Pack, tossed it out and killed a floater.  Then we pull the scout back in, and abort. (9 civ KbA, 1 AKbX).

The award screen showed an appropriate number of Longest Nights, Military Crosses and Honor Crosses. ( I don't have a screen shot, sorry ).

When I check "Novice's" award, he has the Longest Night and the Nike Cross!!

(https://i.imgur.com/cWz7o6l.png)

links to kill record and mission record too:

https://i.imgur.com/8QXQuHX.png
https://i.imgur.com/lv2JvCw.png

So somehow, he erroneously got the Nike Cross, instead of an Honor Cross.

Edit:  at the end of the Month, "Novice" got a second award of the Nike Cross.  I'll try to look into the ruleset and see if I can find the error..  I think this should be an Honor Cross but shouldn't have gotten a second award.

https://i.imgur.com/tSWmzOv.png


Edit: As I have played forward, "Novice" has gotten extra awards for the Nike Cross at just about ever opportunity (end of missions, end of month).  He now has two gold stars.
Title: New Crash
Post by: ivandogovich on August 20, 2014, 06:31:49 am
I haven't been able to work this one out. 

I had a soldier shot who fell unconscious... his live proximity grenade went of shortly there after and destroyed him and a stunned sectoid.

FF about 15 turns, while the rest of the squad wipes out the crew of the abductor, and when the last alien goes down, the End Turn screen pops.  When I click to continue and bring up the end of mission report, the game freezes, and crashes. 

I have tried disabling various mods that I'm running to no effect  (including disabling "Commendations" in the modlist  (which also cleared up the previous crash that I had with 5 survivors trying to abort)).

Edit: I think I may be closer on this now.  It looks like the save, does not record a soldier death on the fallen soldier.

The structure of the save files makes it a little hard to parse, as entries are not uniform.  i.e. its hard to tell when one soldier's entry starts and where it ends.

I see this the save file.  The soldier's name is "Shortimer"
Code: [Select]
    - id: 5
      faction: 0
      soldierId: 5
      genUnitType: SOLDIER
      genUnitArmor: STR_POWER_SUIT_UC
      name: Shortimer
      status: 6
      position:
        - 29
        - 28
        - 0
      direction: 3
      directionTurret: 0
      tu: 58
      health: 0
      stunlevel: 33
      energy: 53
      morale: 100
      kneeled: false
      floating: false
      armor:
        - 100
        - 80
        - 80
        - 70
        - 60
      fatalWounds:
        - 0
        - 0
        - 0
        - 0
        - 0
        - 0
      fire: 0
      expBravery: 0
      expReactions: 0
      expFiring: 1
      expThrowing: 0
      expPsiSkill: 0
      expMelee: 0
      turretType: -1
      visible: true
      turnsSinceSpotted: 255
      rankInt: 1
      moraleRestored: 0
      killedBy: 0
      specab: 0
      motionPoints: 0
      tempUnitStatistics:
        wasUnconcious: true
        shotAtCounter: 0
        kills:
          - status: 7
            faction: 0
            mission: 18
            turn: 4
            rank: STR_SQUADDIE
            race: STR_HUMAN
            weapon: STR_WEAPON_UNKNOWN
            weaponAmmo: STR_WEAPON_UNKNOWN
          - rank: STR_LIVE_SOLDIER
            race: STR_SECTOID
            weapon: STR_FLASHBANG_GRENADE
            weaponAmmo: STR_FLASHBANG_GRENADE
            status: 7
            faction: 1
            mission: 18
            turn: 4
        hitCounter: 0
        shotByFriendlyCounter: 0
        shotFriendlyCounter: 0
        loneSurvivor: false
        ironMan: false
        longDistanceHitCounter: 0
        lowAccuracyHitCounter: 0
        shotsFiredCounter: 0
        shotsLandedCounter: 0

and it looks like where he died.  is STR_WEAPON_UNKNOWN a problem? or "      killedBy: 0" ??

He has no entry however in the Memorial Section earlier in the .sav file.

I'll attach the save for parsing. 

In order to test this, the two critical mods that I'm running apart from Commendations are 
 - Lukes' UFOs, and
 - Up Close Mod Pack.

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on August 21, 2014, 04:37:30 am
More bug reports. :(

I kept the game going, by avoiding the previous mission.  The same scenario played out with abductors running missions in Europe.  I down two and tackled the third on the ground without a problem.  However, I went back to tackle a crash site, and completed the mission without taking losses, but the game crashes on end of mission. :(

I disabled the "Commendations" Ruleset and it still crashes.  I'll attach this save file too, for analysis.  Still running the same mods.

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on August 22, 2014, 07:06:53 pm
I may have hit upon what is happening!!  ;D

I all of the crash cases above, I had a unit "goomba stomped."   This occurs when and alien walks off a roof and lands on your soldier below.  When the alien lands, your soldier goes unconscious.    I have also had this happen to small (1 tile) scout drones.   Almost all of the units recovered conciousness.

In each situation, when the battle ended, the game crashed. 

Is Soldier Diaries having a hard time categorizing this damage/weapon/etc?

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: wsmithjr on August 23, 2014, 05:47:01 am
Has the mod been temporarily removed from the mod site?  Tried to download the latest version and nothing happens.  I've downloaded other mods, so I'm thinking it's not the mod site itself.

Thanks.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Day on August 23, 2014, 05:45:12 pm
A fun idea could be that soldiers originally from countries which do not support xcom anymore would receive traitor qualifications, "wanted: shoot on sight" info news :-)

First, it would improve the story (I always felt that the fact that countries stop to support xcom should be used more; for example, it should be linked with the places where the alien bases are; and when  you destroy a base, yay the country thanks you and comes back to supporting xcom!).

Second, it could make the soldiers doubt, affecting their psi strength :p
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on August 23, 2014, 11:42:26 pm
A fun idea could be that soldiers originally from countries which do not support xcom anymore would receive traitor qualifications, "wanted: shoot on sight" info news :-)

First, it would improve the story (I always felt that the fact that countries stop to support xcom should be used more; for example, it should be linked with the places where the alien bases are; and when  you destroy a base, yay the country thanks you and comes back to supporting xcom!).

Second, it could make the soldiers doubt, affecting their psi strength :p

I think this idea would go nicely with the "flash news" idea that was expressed elsewhere. :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on August 24, 2014, 04:02:30 pm
Has the mod been temporarily removed from the mod site?  Tried to download the latest version and nothing happens.  I've downloaded other mods, so I'm thinking it's not the mod site itself.

Thanks.

The direct links are still up on the first post of this thread

A fun idea could be that soldiers originally from countries which do not support xcom anymore would receive traitor qualifications, "wanted: shoot on sight" info news :-)

First, it would improve the story (I always felt that the fact that countries stop to support xcom should be used more; for example, it should be linked with the places where the alien bases are; and when  you destroy a base, yay the country thanks you and comes back to supporting xcom!).

Second, it could make the soldiers doubt, affecting their psi strength :p

At the moment I am staying away from 'bad' commendations ;p things like "you killed your friends" and "you're the reason everyone is homeless in this town" things would be funny, but would look weird next to hard earned commendations.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: wsmithjr on August 24, 2014, 05:09:26 pm
The direct links are still up on the first post of this thread

Ah.  Thanks.  Checked a few pages back but forgot about the first post.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on August 27, 2014, 09:07:40 pm
I just re-read through the entire thread.  :o

This is still an amazing mod, I am showing it off to the world in my Up Close and Personal Series that started this week.  :) 

Looking back at some of the unexplained crashes, I'd check for the "goomba stomping thing."  It may be applying in most cases...

Anyway, the first tactical mission (3 floaters in crashed ufo) completed successfully, with no awards made, but stats being tracked. :)
I'll probably change some of the commendation names around in my ruleset, to reflect what I feel might be better for things like service awards, etc.

If I can ever figure out how to actually create a working UFOPedia Graphic, I would be happy to help with Commendation Entries. :)

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: XB-7 on August 29, 2014, 12:00:14 am
WOW.  This mod is a nice touch!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on August 29, 2014, 02:04:54 pm
Well I am happy you're still able to use the mod for your thing! Most of my free coding time is being spent on a different project I started at the moment :x After you're done making changes to the ruleset name wise, you should post it on the forums. A lot of the names came from xracer, but I am open to suggestions!

WOW.  This mod is a nice touch!

Thanks! :3
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on August 29, 2014, 04:38:13 pm
....Most of my free coding time is being spent on a different project I started at the moment :x

 :-\  ouch, ok.  Well, I guess we'll just have to go with crashes if they happen.  Thanks for the update.  I was trying to stall my series start, to wait for Goomba crashes to be fixed... but I had to go ahead with it anyway.

....After you're done making changes to the ruleset name wise, you should post it on the forums.

Will do. (attached) ;)
(# Modified Honor Cross to "XCOM Service Medal",  Service Medal to "Longevity Medal")
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: TigerLord on September 05, 2014, 05:22:13 am
Hello, really good mod.

However when i use it it over writes the UI for auto equiping soldiers. Am using Fmp. Any way i can keep both?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on September 07, 2014, 03:27:24 pm
I've got another erroneous award.

In episode 5 of my Up Close LP, I run through the memorial screen.  Capt Green has posthumously received the Bolt's Cross.  The criteria is a leader or commander stun, but all this soldier has on record is 2 kills of Floater Soldiers.  The missions he has been on have only been small ufos, so no leaders or commanders were present.

The only unusual thing is a kill with a combat knife.

I guess Order of the Hammer is erroneous too.  "killed enemies of all kinds..."  (STR_MEDAL_DISTINGUISHED_SERVICE_NAME)

(https://i.imgur.com/W27haDp.png)

(https://i.imgur.com/1KRyarm.png)

Soldier's Save snippet:
Code: [Select]
  - death:
      time:
        month: 1
        day: 20
        year: 1999
        hour: 0
        minute: 44
        weekday: 4
        second: 50
    initialStats:
      reactions: 53
      throwing: 57
      tu: 60
      stamina: 58
      health: 37
      bravery: 10
      strength: 33
      psiStrength: 79
      psiSkill: 0
      melee: 31
      firing: 45
    currentStats:
      reactions: 53
      health: 41
      bravery: 10
      tu: 61
      stamina: 63
      throwing: 58
      firing: 45
      strength: 34
      psiStrength: 79
      psiSkill: 0
      melee: 31
    rank: 1
    diary:
      commendations:
        - decorationLevel: 0
          commendationName: STR_MEDAL_BOLTS_CROSS_NAME
        - commendationName: STR_MEDAL_DISTINGUISHED_SERVICE_NAME
          decorationLevel: 0
        - decorationLevel: 0
          commendationName: STR_MEDAL_FALLEN_NAME
      missionIdList:
        - 0
        - 1
      countryTotal:
        STR_USA: 2
      regionTotal:
        STR_NORTH_AMERICA: 2
      typeTotal:
        STR_UFO_CRASH_RECOVERY_LC: 1
        STR_UFO_GROUND_ASSAULT_LC: 1
      killList:
        - weaponAmmo: STR_GRENADE
          status: 6
          rank: STR_LIVE_SOLDIER
          mission: 0
          race: STR_FLOATER
          weapon: STR_GRENADE
          faction: 1
          turn: 12
        - race: STR_FLOATER
          weaponAmmo: STR_COMBAT_KNIFE
          weapon: STR_COMBAT_KNIFE
          rank: STR_LIVE_SOLDIER
          status: 6
          faction: 1
          turn: 336
          mission: 1
      killTotal: 2
      shotAtCounterTotal: 3
      hitCounterTotal: 2
      importantMissionTotal: 2
      longDistanceHitCounterTotal: 1
      lowAccuracyHitCounterTotal: 1
      UFOTotal:
        STR_MEDIUM_SCOUT: 1
        STR_LARGE_SCOUT: 1
      scoreTotal: 355
      winTotal: 2
      nightMissionTotal: 1
    armor: STR_NONE_UC
    improvement: 0
    kills: 2
    missions: 2
    gender: 0
    look: 2
    id: 3
    name: CaptainGreen


Cheers, Ivan
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: SiceX on September 09, 2014, 04:04:45 am
Hi! I worked on translate your mod, and here is the ruleset:
Code: [Select]
  - type: it
    strings:
      STR_ALIEN_BASE_ASSAULT_LC: Assalto ad una Base Aliena
      STR_AWARDS_UC: Riconoscimenti
      STR_AWARD_0: Primo Riconoscimento
      STR_AWARD_1: Secondo Riconoscimento
      STR_AWARD_2: Terzo Riconoscimento
      STR_AWARD_3: Quarto Riconoscimento
      STR_AWARD_4: Quinto Riconoscimento
      STR_AWARD_5: Sesto Riconoscimento
      STR_AWARD_6: Settimo Riconoscimento
      STR_AWARD_7: Ottavo Riconoscimento
      STR_AWARD_8: Nono Riconoscimento
      STR_AWARD_9: Decimo Riconoscimento
      STR_AWARD_DECOR_0: Nessuno
      STR_AWARD_DECOR_1: Prima Stella di Bronzo
      STR_AWARD_DECOR_2: Seconda Stella di Bronzo
      STR_AWARD_DECOR_3: Terza Stella di Bronzo
      STR_AWARD_DECOR_4: "Prima Stella d'Argento"
      STR_AWARD_DECOR_5: "Seconda Stella d'Argento"
      STR_AWARD_DECOR_6: "Terza Stella d'Argento"
      STR_AWARD_DECOR_7: "Prima Stella d'Oro"
      STR_AWARD_DECOR_8: "Seconda Stella d'Oro"
      STR_AWARD_DECOR_9: "Terza Stella d'Oro"
      STR_BASE_DEFENSE_LC: Difesa di una Base
      STR_COMMENDATIONS: Encomi
      STR_COMMENDATIONS_UC: Encomi
      STR_DAY: Giorno
      STR_DAYLIGHT_TYPE: "Tempo> {ALT}{0}"
      STR_DAYS_WOUNDED: "Giorni da Ferito> {ALT}{0}"
      STR_DETAILS_UC: Dettagli
      STR_DIARY: Record
      STR_HEAVY_WEAPONS_PLATFORM_LC: Piattaforme per Plasma Pesante
      STR_HUMAN: Umano
      STR_KILLED: Uccisi
      STR_KILLS_BY_RACE: Uccisi/Storditi per Razza
      STR_KILLS_BY_RANK: Uccisi/Storditi per Rango
      STR_KILLS_BY_WEAPON: Uccisi/Storditi per Arma
      STR_KILLS_UC: Uccisioni
      STR_LOCATION: Località
      STR_MEDALS: Medaglie
      STR_MEDAL_ALIEN_BASE_ASSAULT_DESCRIPTION: Data ad un soldato che ha fatto parte di un incursione ad una base aliena che ha avuto successo.
      STR_MEDAL_ALIEN_BASE_ASSAULT_NAME: Croce Terrestre
      STR_MEDAL_AWARD_LEVEL: Livello di Riconoscimento
      STR_MEDAL_BLACK_CROSS_DESCRIPTION: Data ad un soldato sopravvissuto a del fuoco amico.
      STR_MEDAL_BLACK_CROSS_NAME: Croce Nera
      STR_MEDAL_BOLTS_CROSS_DESCRIPTION: Data ad un soldato che usato una forza non letale per abbattere un obiettivo importante.
      STR_MEDAL_BOLTS_CROSS_NAME: Croce del Fulmine
      STR_MEDAL_CAMPAIGN_MEDAL_DESCRIPTION: Data ad un soldato che ha difeso con successo varie regioni.
      STR_MEDAL_CAMPAIGN_MEDAL_NAME: Medaglia della Campagna
      STR_MEDAL_CAMPAIGN_RIBBON_DESCRIPTION: "Data ad un soldato che è stato importante nella protezione di {0}"
      STR_MEDAL_CAMPAIGN_RIBBON_NAME: "Nastro della Campagna in {0}"
      STR_MEDAL_CRIMSON_HEART_DESCRIPTION: Data ad un soldato che è rimasto ferito per un lungo periodo di tempo.
      STR_MEDAL_CRIMSON_HEART_NAME: Cuore Cremisi
      STR_MEDAL_DBLKILL_TMPDESCRIPTION: "Data ad un soldato che ha agito mirabilmente sul campo di battaglia, uccidendo più di una minaccia ostile in breve successione."
      STR_MEDAL_DBLKILL_TMPNAME: Citazione per le Prestazioni
      STR_MEDAL_DECOR_LEVEL: Livello di Decorazione
      STR_MEDAL_DEFENDER_MEDAL_DESCRIPTION: Data ad un soldato che ha fatto parte di una missione di difesa di una base che ha avuto successo.
      STR_MEDAL_DEFENDER_MEDAL_NAME: Medaglia alla Difesa
      STR_MEDAL_DESCRIPTION: Descrizione
      STR_MEDAL_DISTINGUISHED_SERVICE_DESCRIPTION: Data ad un soldato che ha ucciso soldati alieni di tutti i tipi.
      STR_MEDAL_DISTINGUISHED_SERVICE_NAME: Ordine del Martello
      STR_MEDAL_FALLEN_DESCRIPTION: Data ad un soldato per onorare la sua morte ed il suo impegno nella difesa della Terra.
      STR_MEDAL_FALLEN_NAME: "L'Ordine dei Caduti."
      STR_MEDAL_GRENADIERS_MEDAL_DESCRIPTION: Data ad un soldato che ha lanciato un esplosivo uccidendo 3 alieni in una volta.
      STR_MEDAL_GRENADIERS_MEDAL_NAME: Medaglia dei Granatieri.
      STR_MEDAL_HELLRAISER_MEDAL_DESCRIPTION: Data ad un soldato che ha usato armi incendiarie per uccidere degli alieni.
      STR_MEDAL_HELLRAISER_MEDAL_NAME: "Stella dell'Inferno."
      STR_MEDAL_HONOR_CROSS_DESCRIPTION: "Data a tutti i soldati di ritorno come riconoscimento per aver combattuto la minaccia Aliena, e per esser stati parte della forza per salvare l'umanità. Questa Medaglia non ha decorazioni aggiuntive."
      STR_MEDAL_HONOR_CROSS_NAME: "Croce dell'Onore"
      STR_MEDAL_IRON_MAN_DESCRIPTION: "Data ad un soldato che è veramente un Uomo d'Acciaio, o una Donna d'Acciaio."
      STR_MEDAL_IRON_MAN_NAME: Iron Man
      STR_MEDAL_LONGEST_NIGHT_DESCRIPTION: Data ad un soldato che ha assistito agli orrori delle missioni di terrore aliene di notte.
      STR_MEDAL_LONGEST_NIGHT_NAME: Nastro della Notte più Lunga
      STR_MEDAL_LUCKYSHOT_TMPDESCRIPTION: "Data ad un soldato che ha vinto le probabilità, mandando a segno un imprevedibile colpo ad un altro bersaglio."
      STR_MEDAL_LUCKYSHOT_TMPNAME: Citazione per la Buona Fortuna
      STR_MEDAL_MAN_OF_STEEL_DESCRIPTION: Data ad un soldato che è stato colpito varie volte durante una sola missione.
      STR_MEDAL_MAN_OF_STEEL_NAME: "Uomo d'Acciaio."
      STR_MEDAL_MEDAL_OF_HEROISM_DESCRIPTION: "Data ad un soldato che ha combattuto fino all'ultimo respiro."
      STR_MEDAL_MEDAL_OF_HEROISM_NAME: "Medaglia all'Eroismo"
      STR_MEDAL_MERIT_STAR_DESCRIPTION: Data ad un soldato che ha ucciso molti alieni.
      STR_MEDAL_MERIT_STAR_NAME: Stella al Merito.
      STR_MEDAL_MILITARY_CROSS_DESCRIPTION: Data ad un soldato che ha partecipato a molte missioni.
      STR_MEDAL_MILITARY_CROSS_NAME: Croce Militare
      STR_MEDAL_NAME: Nome della Medaglia
      STR_MEDAL_NIKE_CROSS_DESCRIPTION: Data ad un soldato che ha ucciso da solo tutti gli alieni durante una missione.
      STR_MEDAL_NIKE_CROSS_NAME: Croce di Nike
      STR_MEDAL_ORDER_OF_EARTH_DESCRIPTION: Data ad un soldato che è stato importante nella difesa della Terra
      STR_MEDAL_ORDER_OF_EARTH_NAME: "L'Ordine della Terra"
      STR_MEDAL_ORDER_OF_GLORY_DESCRIPTION: Data ad un soldato che è stato importante nella riuscita di una missione.
      STR_MEDAL_ORDER_OF_GLORY_NAME: "L'Ordine della Gloria"
      STR_MEDAL_ORDER_OF_RESTRAINT_DESCRIPTION: Data ad un soldato che ha usato una forza non letale per abbattere vari nemici.
      STR_MEDAL_ORDER_OF_RESTRAINT_NAME: "L'Ordine del Contenimento"
      STR_MEDAL_PURPLE_HEART_DESCRIPTION: Data ad un soldato che è stato ferito sul campo di battaglia.
      STR_MEDAL_PURPLE_HEART_NAME: Cuore Viola
      STR_MEDAL_REACTIONFIRE_TMPDESCRIPTION: "Data ad un soldato che ha dimostrato riflessi pronti, uccidendo degli alieni prima che potessero rivalersi."
      STR_MEDAL_REACTIONFIRE_TMPNAME: Citazione alla Rapidità
      STR_MEDAL_SERVICE_MEDAL_DESCRIPTION: Data ad un soldato che ha prestato servizio per vari mesi.
      STR_MEDAL_SERVICE_MEDAL_NAME: Medaglia al Servizio
      STR_MEDAL_SNIPER_TMPDESCRIPTION: Data ad un soldato che ha mandato a segno un colpo a grande distanza sul bersaglio designato.
      STR_MEDAL_SNIPER_TMPNAME: Citazione per il Tiratore Scelto
      STR_MEDAL_SPECIALISTS_MEDAL_DESCRIPTION: Data ad un soldato che ha usato forze non letali per controllare vari alieni con successo.
      STR_MEDAL_SPECIALISTS_MEDAL_NAME: Medaglia dello Specialista
      STR_MEDAL_STAR_OF_ASCLEPIUS_DESCRIPTION: Data ad un soldato che è stato sottoposto al fuoco nemico dalla minaccia aliena.
      STR_MEDAL_STAR_OF_ASCLEPIUS_NAME: Stella di Asclepio
      STR_MEDAL_STAR_OF_VALOR_DESCRIPTION: "Data ad un soldato che è stato l'ultimo sopravvissuto di una missione."
      STR_MEDAL_STAR_OF_VALOR_NAME: Stella al Valore
      STR_MEDAL_TRAP_DESCRIPTION: Data ad un soldato per aver usato le tattiche di guerriglia.
      STR_MEDAL_TRAP_NAME: Croce del Predatore
      STR_MEDAL_VALIANT_CRUX_DESCRIPTION: Data ad un soldato che ha protetto tutti i civili durante una missione del terrore.
      STR_MEDAL_VALIANT_CRUX_NAME: Il Punto Cruciale
      STR_MEDAL_WEAPON_PROFICIENCY_DESCRIPTION: "Data ad un soldato che ha dimostrato una differenza usando un {0}"
      STR_MEDAL_WEAPON_PROFICIENCY_NAME: ""
      STR_MEDAL_XENOCIDE_MEDAL_DESCRIPTION: "Data ad un soldato che ha combattuto con successo la minaccia dei {0}"
      STR_MEDAL_XENOCIDE_MEDAL_NAME: "Medaglia allo Xenocidio dei {0}"
      STR_MISSIONS_BY_LOCATION: Missioni per Località
      STR_MISSIONS_BY_TYPE: Missioni per Tipo
      STR_MISSIONS_BY_UFO: Missioni per UFO
      STR_MISSIONS_TYPE: Missioni
      STR_MISSIONS_UC: Missioni
      STR_MISSION_DETAILS: "Dettagli Missione per {NEWLINE}{0}"
      STR_MISSION_LOSS: Sconfitte
      STR_MISSION_TYPE: "Missione> {ALT}{0}"
      STR_MISSION_WIN: Vittorie
      STR_NIGHT: Di Notte
      STR_NO_KILLS: Nessun uccisione
      STR_RACE_TYPE: "Razza> {ALT}{0}"
      STR_REGION_UNKNOWN: Località Riservate
      STR_SCORE_VALUE: "Punteggio> {ALT}{0}"
      STR_STUNNED: Storditi
      STR_STUNS: "Stordimenti> {ALT}{0}"
      STR_TANK: Tank
      STR_TERROR_MISSION_LC: Missione del Terrore
      STR_UFO_CRASH_RECOVERY_LC: Recupero di un UFO Schiantato
      STR_UFO_GROUND_ASSAULT_LC: Attacco di un UFO Atterrato
      STR_UFO_TYPE: "UFO> {ALT}{0}"
      STR_VEHICLE: Veicolo
      STR_WEAPON_UNKNOWN: Improvvisazione
      STR_WINS: "Vittorie> {ALT}{0}"
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Vulgar Monkey on September 11, 2014, 08:22:10 pm

At the moment I am staying away from 'bad' commendations ;p things like "you killed your friends" and "you're the reason everyone is homeless in this town" things would be funny, but would look weird next to hard earned commendations.

If you ever decide to implement this I suppose it'd make sense to get around the tonal dissonance by creating a separate page (assuming you can find space in the UI). Perhaps 'commendations / citations'?

I expect the psi-weenies would have a good collection of demerits for poor discipline in battle / desertion / friendly fire / negligent discharge / conduct unbecoming, etc etc. Not to mention unwarranted destruction of property / loss of civilian life etc etc.

You get enough crap off the council, it'd only be fair to pass that down the chain as in real life. If only we could have them spend the week peeling potatoes or on latrine duty. :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on September 11, 2014, 10:18:33 pm
You get enough crap off the council, it'd only be fair to pass that down the chain as in real life. If only we could have them spend the week peeling potatoes or on latrine duty. :D

That makes so much sense :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on September 11, 2014, 11:57:23 pm
Hello, really good mod.

However when i use it it over writes the UI for auto equiping soldiers. Am using Fmp. Any way i can keep both?


If the auto equip is from another mod, it would be difficult for me to predict overlaps like that. However, if it's a merged mod I will just have to take a look myself and fix it! I am in the middle of a different project, so it'll be a little whiles away.

SiceX: Thanks for the translation! Including the Russian one that was PM'd to me, that makes 3 total languages :D

ivandogovich: Thanks again for the bug reports. So it seems like there is the goomba stomping, and a few erroneous commendation awards. If you keep tracking them (the soldier save is a big help), I will likely be able to fix them. Hopefully it's a simple logic error and not like ... save file corruption.

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on September 12, 2014, 12:04:35 am
ivandogovich: Thanks again for the bug reports. So it seems like there is the goomba stomping, and a few erroneous commendation awards. If you keep tracking them (the soldier save is a big help), I will likely be able to fix them. Hopefully it's a simple logic error and not like ... save file corruption.

No problem, I'll keep reporting stuff as I find it.  And keep passing saves, or snippets as needed. 

I did test editing the save file directly to remove erroneous commedations, and that seemed to work just fine.  They did not reappear.

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on September 12, 2014, 11:12:21 pm
No problem, I'll keep reporting stuff as I find it.  And keep passing saves, or snippets as needed. 

I did test editing the save file directly to remove erroneous commedations, and that seemed to work just fine.  They did not reappear.

Cheers, Ivan :D

That's very very interesting. There is some information that is not saved, but it could also be corruption/bad code that awarded the commendation.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: TigerLord on September 13, 2014, 01:09:25 pm
Hey Shoes, i think the auto equip is now just the standard UI option in Openxcom and that the exe of your mod is overwriting that part.

 No worries anyone dude, thanks for your reply and thank you for your hard work and awesome mod:)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on September 21, 2014, 04:04:57 pm
A bit more feedback.  This is a save from my current Lets Play.  I've been getting some more erroneous awards.  Multiple Bolt's crosses some Orders of the Hammer, and now a Nike Cross for a soldier who has only stunned a Navigator.

Cheers, Ivan
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on September 25, 2014, 02:49:00 pm
Thanks again, this will be a great help when I finish my other project and start polishing this one for merge!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on September 27, 2014, 06:26:18 pm
Erroneous Award Reporting. 
I just finished recording ep 018.  (this will air on Wed Oct 1st).   I have two rookies that killed sectoids with a combat knife.   Both of them Received Order of the Hammer (for killing many kinds of aliens) and Bolt's Cross (for stunning high ranking aliens (which should be for Leaders and Commanders Only).

I am attaching the save for evaluation, whenever your time frees up, Shoes. ;)

Soldier ids are:
56
54

I have also removed earlier erroneous awards before this save (Nike Crosses, Bolts Cross, Order of the Hammer).

Cheers, Ivan

Title: Re: [STAT TRACKING] Soldier Diaries 1.0 - Ufopedia
Post by: ivandogovich on September 30, 2014, 07:40:38 am
I've been brainstorming a bit, on the UFOpedia entries and started fiddling until I got some working images.

I've done up the Merit Star and Military Cross, and set up a Photoshop template to work on these.  The medal pendant is just a simple placeholder to test the over all effect.

I'm using the Type 7 Entry (Alien Lifeforms, and UFO Components) as it allows a tall image on the right, and text in the left.   There is not really a good section of the ufopedia to put these it, so I've shoved them into UFO Components.   When an opportunity is presented to do some more coding, I wonder if it is possible to add a "Commendations" section to the Ufopedia.

Here are the screen Caps of the first two that I have worked up.

(https://i.imgur.com/wZdWhlC.png) (https://i.imgur.com/bFHGmME.png)

It feels like the short descriptions which work well on the soldier awards screen, are too short here.  Maybe a more indepth description might be worthwhile.

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on September 30, 2014, 10:32:12 am
Ooh! That looks nice! I've been watching the commendations in your LP and I find it very interesting. For someone as attached to their soldier as I am, it's a nice reward. I am still unsure about leaving my "safe" 1.0 zone, to go into nightlies and/or different executables..

For the text, longer descriptions which cover the requirements for the awards would probably work. Once you get wordy and start using paragraphs, it is easy to fill the space in the UFOPaedia.

As for categories... Maybe "Weapons and Equipments"? That's where more stuff related to XCom operatives ends up and with a good listOrder, you could stack all the awards at the end, in order of..? how easy they are to get?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 01, 2014, 06:34:51 am
OK. Run Number Two.   Worked with Shoes, Xracer, RandomCommander and Arthanor, and wrote up some longer descriptions.

Shoes suggested going with a color coded background.

Black = Somber
(https://i.imgur.com/bYrklgX.png)

Purple = Wounds
(https://i.imgur.com/ZDm50js.png)

Blue = Normal
(https://i.imgur.com/EkJYfD3.png)

Green = Support
(https://i.imgur.com/hKIiqEN.png)

Red = Awesome
(https://i.imgur.com/HEGSKJQ.png)


After reviewing these, its obvious that the descriptions can be even longer.  I'm not completely happy with the way the gradients work in the UFOPEDIA pallet.  There is a lot of Purple in the Blue one.  But over all, I think they work pretty well.

Thoughts, comments, complaints...  etc?

I have the medals and their descriptions on a google docs spreadsheet, if someone would like to help word smith the long descriptions. :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0 - Bug report
Post by: ivandogovich on October 01, 2014, 09:09:02 pm
Just some on camera examples of Erroneous Bolt's cross and Order of the Hammer being issued for Combat knife kills.

https://www.youtube.com/watch?v=6i__OhKhzt8  esp 26:50.

Cheers, Ivan

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on October 01, 2014, 09:34:39 pm
Looking good!

One thing on the background, have you tried making them yourself using the colors in the palette? The colors within a line naturally "fade to black", so it could work and be smoother than trying to convert an image? Or it could look like a bunch of blocky lines since there aren't enough choices.. :/
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Vulgar Monkey on October 01, 2014, 10:36:36 pm
If you want a little more control over pallette conversion you might try HD Indexing: https://danfessler.com/blog/hd-index-painting-in-photoshop
It's not as complex as it sounds.

Personally though I think your options might be a bit limited due to the nature of the pallette on offer. At a push, though, you might be able to use the above method to force a particular type of dithering pattern. Certain ones might look a bit nicer, if only for the introduction of a pattern over random noise.


Great job on the mod so far though, I love the ribbons in particular. Also, I like the subtlety of the Fallen medal being upside down.....reminds me of the tradition of upside-down flags or missing-man formations.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 01, 2014, 11:33:22 pm
Looking good!

One thing on the background, have you tried making them yourself using the colors in the palette? The colors within a line naturally "fade to black", so it could work and be smoother than trying to convert an image? Or it could look like a bunch of blocky lines since there aren't enough choices.. :/

Yeah, when I limit it strictly to the colors of the pallette it just becomes bands of colors, so dithering seem like the way to go.

If you want a little more control over pallette conversion you might try HD Indexing: https://danfessler.com/blog/hd-index-painting-in-photoshop
It's not as complex as it sounds.

Personally though I think your options might be a bit limited due to the nature of the pallette on offer. At a push, though, you might be able to use the above method to force a particular type of dithering pattern. Certain ones might look a bit nicer, if only for the introduction of a pattern over random noise.


Great job on the mod so far though, I love the ribbons in particular. Also, I like the subtlety of the Fallen medal being upside down.....reminds me of the tradition of upside-down flags or missing-man formations.

Thanks a bunch for the feedback. :) 

Yeah, the pallette is definitely limited.  I tried using "diffusion, noise, and pattern" for the renders of the gradients.  It definitely looks better in photo shop than when rendered against this pallette. XD

The majority, I used diffusion, for, with the exception being Purple as patterned.

And thanks for the feedback on the Fallen Medal. That was the effect I was going for. :D

I am working on more medalions.  I have the spreadsheet I'm working on here.

https://docs.google.com/spreadsheets/d/1ibFwqFzgI0JNJz0eIBYP_uW5grm7fW4yE_j38skyadg/edit?usp=sharing

If anyone would like to contribute, let me know. :)

Cheers, Ivan :D

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on October 01, 2014, 11:54:41 pm
I hadn't noticed, but that's a nice little feature on the Fallen medal indeed! I'd love to help, but I am already spending most of my time trying to bring the XCom Armoury Expanded to 1.0 (finally got graphics! And making good progress but still..) and now it looks like I might be working on Cybersnakes and Cyberlids, for an improved late game show (along with other alien late game tweaks I am thinking of).

Too much to do! But that's what you get with such an awesome platform as OpenXCom :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: the_third_curry on October 02, 2014, 01:04:33 am

I am working on more medalions.  I have the spreadsheet I'm working on here.

https://docs.google.com/spreadsheets/d/1ibFwqFzgI0JNJz0eIBYP_uW5grm7fW4yE_j38skyad
Cheers, Ivan :D

The spreadsheet doesn't display for me.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 02, 2014, 01:16:50 am
https://docs.google.com/spreadsheets/d/1ibFwqFzgI0JNJz0eIBYP_uW5grm7fW4yE_j38skyadg/edit?usp=sharing 

here is another try at the spreadsheet
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Vulgar Monkey on October 02, 2014, 02:36:08 am
The quotes are really welcome. Adds an air of authority and realism to the game.
And lets face it, when the graphics are basic and the mechanics abstract, a tangible atmosphere counts double.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on October 02, 2014, 02:44:46 am
Yes, the quotes are a really nice addition. Atmosphere and random bits of culture are great.

When reading some description, I found the Star of Valor, which says:
Quote
I will never quit. My nation expects me to be physically harder and
mentally stronger than my enemies. If knocked down i will get back up,
every time. I will draw on every remaining ounce of strength to protect
my enemies and to accomplish our mission. I am never out of the fight.”
―  (Marcus Luttrell)'  When the squad wipe is in progress, this soldier
kept their head and managed to salvage the dropship.
The lone survivor of any mission is awarded this medal only once."

After double checking, the original quote indeed talks about protecting his teammates, not his enemies ;)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 02, 2014, 03:25:46 am
Heheh!  Nice catch!  Thanks for the extra set of eyeballs!   8)
Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on October 02, 2014, 03:38:20 am
No worries :D

I'll try to read through them all over the next few days, when I take a few minutes away from thinking at work.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 02, 2014, 06:12:41 am
Some more ufopedia entries with the longer quotes. :

(https://i.imgur.com/Z6gqcfg.png) (https://imgur.com/Z6gqcfg)(https://i.imgur.com/3Scwc0L.png) (https://imgur.com/3Scwc0L)(https://i.imgur.com/MeLYbXN.png) (https://imgur.com/MeLYbXN)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 02, 2014, 05:16:33 pm
These are really good! Are you doing the big sprites by hand? I can't get over how more "real" the mod feels with these ufopedia pages.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Random Commander on October 02, 2014, 05:30:38 pm
You know what? I would've chosen that same quote for that Longest Night entry just to make it longer. :P

And yes, this mod really is getting more and more realistic. Just need to fix those erroneous awards! ;)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 02, 2014, 05:36:12 pm
These are really good! Are you doing the big sprites by hand? I can't get over how more "real" the mod feels with these ufopedia pages.

Sort of by hand. ;)
 Borrowing alot from other medals, and then photoshop /pixlr alterations, recoloring, etc.  (For the medallions).

The ribbons are a matter of enlarging and replicating the existing commendation ribbons, and then trimming them to the "pendant" shape.  Some are definitely more challenging (i.e. Longest Night) where diagonals are involved.  It involved a lot of chopping them up into pieces and mixing and match them.  Once all that is done, I'm applying a slight canvas texturizing filter to the ribbons.  I'm not sure its really noticeable, but it makes me feel like they have more of an "fabric" feel.

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 02, 2014, 05:39:10 pm
You know what? I would've chosen that same quote for that Longest Night entry just to make it longer. :P

And yes, this mod really is getting more and more realistic. Just need to fix those erroneous awards! ;)

I haven't been able to figure out how to add a "hard return" to the extraStrings for the UFOpedia Texts. :|   I think that would help break up the Text Block if I could figure that out.

And some of these quotes are awesome. :)
Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: XOps on October 02, 2014, 06:47:15 pm
I haven't been able to figure out how to add a "hard return" to the extraStrings for the UFOpedia Texts. :|   I think that would help break up the Text Block if I could figure that out.

Try {NEWLINE}
For an example of this load up one of the language files in notepad and look for the Medikit entry. It has several examples of a new line.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 02, 2014, 06:57:57 pm
Try {NEWLINE}
For an example of this load up one of the language files in notepad and look for the Medikit entry. It has several examples of a new line.

Awesome !  I will!  I thought that there was some entry that had line breaks but I couldn't remember what it was!  I'll test it tonight!

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on October 02, 2014, 07:37:24 pm
Indeed, {NEWLINE} will do the trick (don't do like me, writing in lowercase and spending half an hour wondering why it just displays {Newline} instead of working!). Use a pair to change paragraph.

And the fabric texture is totally worth it on the ribbons. You're doing neat work, and a great showcase, for this mod. I'm looking forward to the update.

@Shoes: Since you're already modding the executable, do you think you could add a medal category in the ufopaedia? That would be better than trying to fit these in a random category.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 02, 2014, 07:43:03 pm
Thanks for the Tips, Arthanor! Awesome! :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on October 02, 2014, 08:34:55 pm
I like it!!! very nice work

The only thing i would say, do not say how many times you can or the explicit circumstances, try to keep it vague :)
So the user will be like "WOW so this is what they meant" :)

instead of says "the horror of terror missions at night", just say "the horrors of the night"
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 02, 2014, 08:45:48 pm
@Shoes: Since you're already modding the executable, do you think you could add a medal category in the ufopaedia? That would be better than trying to fit these in a random category.

Yup, I will definitely do that when I get back to this project!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 03, 2014, 06:46:08 am
OK, some great progress with the descriptions! The double NEWLINE is awesome.  I'm showing one that we featured already and three new ones. :)
I'll also be featuring these in my LP.

(https://i.imgur.com/u1dgLIb.png) (https://imgur.com/u1dgLIb)(https://i.imgur.com/BkfXauw.png) (https://imgur.com/BkfXauw)
(https://i.imgur.com/eJrz7cN.png) (https://imgur.com/eJrz7cN)(https://i.imgur.com/YcQ25FT.png) (https://imgur.com/YcQ25FT)

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on October 03, 2014, 06:57:23 am
Neat! Very nice :) Keep up the good work!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: cjones on October 04, 2014, 12:16:55 am
Has anyone tried this with any other mods?  I believe this creates a custom .exe, so prob not compatible?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 04, 2014, 12:48:00 am
It works with many other mods... just not those that require a custom executable.
I am using my UpClose Modpack with Soldier Diaries, and it works well.  There are some quirks like combat kills with a knife, and some erroneous awards, but its well worth it.

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 04, 2014, 02:09:29 pm
ivandogovich, have you noticed if it's the _same_ awards that keep getting awarded erroneously? For some reason I have in my mind it's "random" awards that get awarded incorrectly.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: new_civilian on October 04, 2014, 02:24:05 pm
Nice mod and it really adds to the game! AND unlike other exe-mods this one has no performance problems. Excellent work!  :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 04, 2014, 03:15:46 pm
Nice mod and it really adds to the game! AND unlike other exe-mods this one has no performance problems. Excellent work!  :)

Thanks! Soon I'll have to share credit between even more people!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 04, 2014, 06:17:02 pm
ivandogovich, have you noticed if it's the _same_ awards that keep getting awarded erroneously? For some reason I have in my mind it's "random" awards that get awarded incorrectly.

So far, I have found this to be true.  The most common erroneous awards, are :
Bolts Cross
Order of the Hammer
Nike Cross
(I'm not sure if there are any others)

Bolt's Cross and Order of the Hammer seem to be awarded for Knife Kills.  I don't think your code takes melee kills into account very well, and these are triggering some code value.
Then Nike Cross... yeah, that I don't understand.  I don't know your code well enough to figure it out.  From looking at the .ccp and .h files on git, I couldn't find anything glaring to my non-programmer eye.   Are there other things in the modified .dll files that would have an impact on how the reward criteria work as well?  I haven't looked in those.

The only other issue with the mod, as I have mentioned before, is that of Goomba stomping.  I haven't encountered that in my current playthrough, but I haven't been in condusive situations.  I am now playing with "Sneaky AI" too, so that may make E.T. more reluctant to "run to the guns" thereby jump off the buildings onto my unsuspecting troops.

Working on the UfoPedia has been a ton of fun!  I've been working on more medals, and will probably have some more mockups ready this weekend. :)
Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 04, 2014, 10:58:52 pm
Order of Restraint opinions needed:

This award is for soldiers who have captured may aliens alive.  I have two medallion concepts.  Which is better?

Thanks! :)

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on October 04, 2014, 11:18:36 pm
Personally and like the first better
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on October 05, 2014, 12:53:09 am
I like the second one better! :P But I also thing that you should shrink the stun rod so it fits on the medallion and apply the same colours to it so it looks engraved. Make it kind of a "Oh, that's a stun rod? Clever!" instead of super obvious.

Barring that, I like the 1st one better ;)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: moriarty on October 05, 2014, 01:02:05 am
Why not shrink the stun rod and change the shape of the medallion itself to match the hit animation sprite?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 05, 2014, 04:21:18 am
Why not shrink the stun rod and change the shape of the medallion itself to match the hit animation sprite?

I like that idea ;p I feel like it's just the right amount of cliché
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 05, 2014, 05:23:37 am
Best of both worlds?

"the shape of the hit animation sprite" ... I completely missed that the first time around.  XD

I actually tried that, but had problems with the absolute chunkiness of the sprite.  It really looked pretty bad. :(
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 05, 2014, 05:54:20 am
Okay, cliches delivered.   8)

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on October 05, 2014, 06:37:53 am
Pretty nice! Now for some reason the first thing I thought was: "Wouldn't it look better with a diagonal stun rod?" From top right to bottom left? But if you think you've worked enough on that one, feel free to ignore me ;)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Random Commander on October 05, 2014, 06:51:42 am
Hey, if for some reason the hit animation shaped medal seems to be too hard to work with, I have a good idea for the Hexagon-shaped one:

Engrave the hit animation like you did with the first sketch, and then put a stun rod (Diagonal or across, whatever) in front of that hit animation. That should work almost perfectly.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: moriarty on October 05, 2014, 07:12:59 am
While the hit-animation-shaped medal looks good, it also looks very pointy (as well as a bit flimsy... those points might break off)... maybe just engrave it full-size on a pentagonal or circular medal? And move the stun rod down a bit so it doesn't obscure the points?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0 - Erroneous Award feedback
Post by: ivandogovich on October 05, 2014, 03:42:03 pm
@Shoes..  a bit more analysis here....

I was checking out the awards abit more.   I found one more problem  https://youtu.be/-lY3C6G8nFY?t=28m44s

I had a soldier get the Man of Steel (Rosie) for being shot sixtimes in quick succession.  The criteria is five so all is good here.  What is the problem is that after the next mission, in which they didn't get hit at all, they received "first award" at end of mission screen, and then a bronze pin on their record.

It looks like the code isn't cleaning up the hit5times flag. (or maybe some other function) ;)

Code: [Select]
        diary:
          missionIdList:
            - 10
            - 11
          commendations:
            - decorationLevel: 1
              commendationName: STR_MEDAL_MAN_OF_STEEL_NAME
          regionTotal:
            STR_NORTH_AMERICA: 2
          killList:
            - rank: STR_LIVE_ENGINEER
              race: STR_SECTOID
              weapon: STR_FLASHBANG_GRENADE
              weaponAmmo: STR_FLASHBANG_GRENADE
              faction: 1
              mission: 11
              turn: 3321
              status: 7
          countryTotal:
            STR_USA: 2
          typeTotal:
            STR_UFO_CRASH_RECOVERY_LC: 2
          UFOTotal:
            STR_LARGE_SCOUT: 1
            STR_MEDIUM_SCOUT: 1
          scoreTotal: 453
          winTotal: 2
          stunTotal: 1
          hitCounterTotal: 6
          importantMissionTotal: 2
          hitCounter5in1Mission: 1
          shotAtCounterTotal: 7

Cheers, Ivan
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 06, 2014, 06:55:36 am
Final Order of Restraint.  I'm pretty happy with it.  hit shape just didn't really look good in the background no matter how I parsed it.

(https://i.imgur.com/cvaxYX5.png) (https://imgur.com/cvaxYX5)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 06, 2014, 07:54:14 am
New Honor Cross: Aka "X-Com Service Medal"   
(Edit: And... I just realized I'm using the wrong ribbon. :(  I should be using the green and white one)
(https://i.imgur.com/LNyjiay.png)

And the Performance Citation:

(https://i.imgur.com/7LGVm0s.png)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: new_civilian on October 06, 2014, 12:02:37 pm
So, where's the download for the new version?  ;D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 06, 2014, 01:29:00 pm
So, where's the download for the new version?  ;D

I am in the polishing stage of a different project, so the new version is still the old version, on the first page of the forum post. When I get back to this, I will add a commendations section in the ufopedia and import all of ivandogovich's pages! And maybe fix the bugs :x
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on October 06, 2014, 06:55:47 pm
- "So what's in the new version, does it work better?"
- "Nah, but it's prettier!"
- "But... Shouldn't it work?"
- "It should be pretty!"

Jokes aside, your mod looks really interesting. I wish I knew c++ to be able to help. But then, between that and modding, I'd never get anything done..! What's your other project?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 06, 2014, 07:28:06 pm
I started my modding ventures with Cataclysm: Dark Days Ahead. I've modeled body temperature, and now I've returned to it to model windchill. I am quite pleased with it, as it really makes the world feel alive.

As for your jokes!! The only bugs left are immersion breaking more than anything. Stats are tracked correctly, but (some rarer) commendations aren't given out correctly.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on October 06, 2014, 08:02:54 pm
I didn't know of that game. It looks interesting.. But I already have no time just playing OpenXCom ;)

I did not mean to offend with the comment above, it's just what went through my head when you said you'd work on the UFOPaedia and maybe fixes. Is your code on github? Maybe if I focus on one small issue, I could make sense of it, instead of trying to read the actual OpenXCom (which proved to be too much to handle). Would be an interesting way for me to get on github too.. hum..!

Let me know if you think I could help.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 06, 2014, 10:30:24 pm
No offense taken! My code is on github, but the remaining bugs by me too obscure for someone to drop in and fix them easily (as pretentious as that sounds). The first post of the thread has a link to my github; feel free to take a look and contribute in any way you want, even by adding more commendations!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 07, 2014, 12:05:25 am
Hey Shoes, i think the auto equip is now just the standard UI option in Openxcom and that the exe of your mod is overwriting that part.

 No worries anyone dude, thanks for your reply and thank you for your hard work and awesome mod:)

My mod is now up to date with the latest code base, but I couldn't find any conflicting windows or buttons. If you could provide a screenshot, I would be better able to address the issue!

Also, my mod is now up to date. No actual changes though. First page has been updated to reflect this.

edit: Actually, I've bundled the 3 translations people have sent me over the last few months. I should have gotten those in sooner, but I never forgot :3
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: davidjruss on October 07, 2014, 02:21:17 pm
Shoes ,

A couple of quick questions :-

I use the nightly builds before commencing a new game. These include a new exe file , as does your mod.

A) If I use your mod over the current nightly gitmaster exe , does it revert OpenXcom to a base 1.0 version or are the changes from the nightly version still available?

B) Can you confirm that if I use your mod and I then subsequently overwrite your exe with a new nightly build exe , that I then lose the use of your mod.

Many thanks

DavidR
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 07, 2014, 07:47:58 pm
A) I have two releases of my mod, one for nightly and one for 1.0. I updated this morning the nightly branch, so it is quite fresh. If you update your game and use my outdated .exe, your game will be outdated.

B) If you replace my .exe with a new one, it will be as if you're not playing with my mod anymore (the save files however will not delete any information, so you can come back to it later, or even wait for an update). You can also turn my mod off as any other mod but keep my .exe, and the stat tracking code will continue to work and be displayed; you simply wouldn't get any commendations for them.

Hope you like it!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on October 07, 2014, 08:00:02 pm
Kind of a weird question, but how does it play with different OS? I'm using Linux and have been playing 1.0 (there's no nightly released for Linux as far as I know). I have started looking into compiling my own version using the nightly though, since there are a lot of updates to take advantage of.

But, if it were as simple as getting the exe, that would mean it's OS independent, which it doesn't seem to be. Or is the compilation process making other files than the exe that are the OS dependent ones while the .exe isn't? As you can surely tell, I'm confused :P
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 07, 2014, 11:39:24 pm
Hm, you could try and compile the source from my github: https://github.com/Shoes01/OpenXcom/tree/alpha_release

Other than that, I can't really help you :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 08, 2014, 03:21:46 pm
Latest Medals

(https://i.imgur.com/LCEKnCc.png)(https://i.imgur.com/fcFQ7u2.png)(https://i.imgur.com/PnCcqHz.png)

Did I actually, just quote Monty Python? ;)

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on October 08, 2014, 07:32:15 pm
It's a very cool project, hopefully we'll see it implemented soon.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Aldorn on October 08, 2014, 11:55:24 pm
Nice improvement Ivan  :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: arrakis69ct on October 09, 2014, 10:48:09 am
A idea a scree wit the real soldier. Clothes of gale and the real medals put in the clothes

Enviado desde mi LG-D802 mediante Tapatalk

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: CryptoCactus on October 09, 2014, 08:44:21 pm
Did you realize a significant number of string definitions are missing from your nightly build for en-US and en-GB?

Easily solved by just copying over the missing ones from the legacy/1.0 build, but still.

Also, this is an effing great mod. :p
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 09, 2014, 11:29:03 pm
Did you realize a significant number of string definitions are missing from your nightly build for en-US and en-GB?

Easily solved by just copying over the missing ones from the legacy/1.0 build, but still.

Also, this is an effing great mod. :p

It's been a while since I dug deep, but I think it's because I ported some of the strings to the xcom ruleset, in anticipation of getting my work merged.

Thanks for the heads up :3
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 11, 2014, 06:49:49 am
The latest:
Base Defense Medal and Prowler Cross (Trap Kill Medal)

(https://i.imgur.com/rL3dSx7.png) (https://i.imgur.com/nhiWLFA.png)


I've also started three new medals:

Sapper Medal: for blowing up CyberDiscs and Sectopods with Grenades/HE Packs
Cold Steel Metal:  for Melee Kills
Metal Menace Citation: For each Sectopod Kill

(I'm working up the ruleset and graphics to add these in, but initially, it will be a small standalone add-on mod).

Cheers, Ivan :)
P.S.  - I'll be on school break for a week and won't be around as much. :/
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: new_civilian on October 11, 2014, 11:33:05 am
Did you realize a significant number of string definitions are missing from your nightly build for en-US and en-GB?

Easily solved by just copying over the missing ones from the legacy/1.0 build, but still.

Also, this is an effing great mod. :p

Ok someone beat me at posting this  :D

And yes: Great mod!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 11, 2014, 01:44:51 pm
Oh right, if I updated the xcom1 ruleset I would kind of have to add that to the mod too... instead I just added the lines back to the commendations ruleset.

https://dl.dropboxusercontent.com/u/234369005/OXC/10112014Nightly.zip
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Dioxine on October 11, 2014, 01:48:55 pm
Awesome designs Ivan! I love your idea, and these medals are really well-though of and gloriously looking. The more I am sad that your Photoshop conversion skills do not give full credit to these designs. I believe I could do a better conversion to UFO format if you provided the original files?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: XOps on October 11, 2014, 05:03:30 pm
Awesome designs Ivan! I love your idea, and these medals are really well-though of and gloriously looking. The more I am sad that your Photoshop conversion skills do not give full credit to these designs.

I was thinking the same thing. It would be a tricky thing though. You would want to keep the dithering on the background and parts of the cloth texture while keeping the metal free of dithering to give it that shiny look.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Dioxine on October 11, 2014, 06:37:22 pm
Yeah, definitely the dithered background looks nice. For the cloth, I have mixed feelings - some of it looks good, some doesn't; certainly the green dots don't. Metal parts definitely need clean conversion though :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: new_civilian on October 12, 2014, 05:05:14 pm
Btw, did you add the STR_HEAVY_WEAPONS_UC string for the tanks and other units? (dogs, tanks etc) In my edit I translated it into "Support-Unit" so dog and tank both were ok  ;D

I really like this mod, started a new campaign now and it really is a great tool. I didn't expect that I browsed so often and long through my soldier's dossiers when I installed it, but now after very mission, the ifrst thing I do after replenishing my ammo is to read the dossiers! Rerally nice addition to the game.  :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 12, 2014, 05:29:22 pm
I added "STR_HEAVY_WEAPONS_UC" so that I could use HWP's full name. If you create an entirely new unit like a dog, and it's not considered a HWP by the source code, I am not sure where it will fall in the commendations logic... if it is considered a HWP, then your dog will be called a HWP... unless you rename the string to "support unit" like you say, or "non-payroll combatant" ;p

ivandogovich, I've fixed the Nike Cross medal being given when you kill an alien an then abort -- it is now only given if you win a mission. That should fix that. I've also fixed commendations that "skip" levels but were not skipping properly. I tried installing the combat knife mod but I was getting errors with the .wav file. Do you have a link to a working one?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: new_civilian on October 12, 2014, 05:31:35 pm
The attack dog mod uses no name and it seems to default to that string. Support-Unit works fine!  :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 12, 2014, 05:43:42 pm
Come to think of it, it's going to be a little more complicated than that... I am going to look into making it more moddable by making the source code check to see if there is a rank/race, and if not then go with the generic strings.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 12, 2014, 05:55:11 pm
ivandogovich, I've fixed the Nike Cross medal being given when you kill an alien an then abort -- it is now only given if you win a mission. That should fix that. I've also fixed commendations that "skip" levels but were not skipping properly. I tried installing the combat knife mod but I was getting errors with the .wav file. Do you have a link to a working one?

Thanks for that fix, Shoes!
I'm still getting other erroneous Nikes. :( sometimes multiple soldier get them during a mission. ( of course this is not with your updated code. )  I have been looking at your code (and the ruleset ) and could never find where it was defined.  That and valiant cross, and ironman... Can you point me to where they are in the code? i.e. file and line number?

https://www.openxcom.com/mod/upclose-modpack/download/ed08efa5

^^ here is a link to the updated combat knife ... if the sound doesn't work, here. I'll try to re-package it. :)

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 12, 2014, 06:26:30 pm
Line 199 of DebriefingState.cpp for Valiant Crux.

Line 278 of DebriefingState.cpp for Nike Cross.

Line 661 of DebriefingState.cpp for Iron Man.

As for the combat knife, I get the following error : ".../KnifeSlice.wav:Mix_LoadWAV_RW with NULL src". Any idea what that means? Despite my modding openxcom, I've never actually installed any mods :x
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 13, 2014, 09:26:17 am
Line 199 of DebriefingState.cpp for Valiant Crux.

Line 278 of DebriefingState.cpp for Nike Cross.

Line 661 of DebriefingState.cpp for Iron Man.

As for the combat knife, I get the following error : ".../KnifeSlice.wav:Mix_LoadWAV_RW with NULL src". Any idea what that means? Despite my modding openxcom, I've never actually installed any mods :x

Heheh!!  Why did  I never check Debriefing State???  LOL!   I was looking in SaveGame, Battlescape, etc...

I think I might see the problem with the knife slice..

Code: [Select]
extraSounds:
  - type: BATTLE.CAT
    files:
      #67: Resources/CombatKnife/Sounds/knifeHit.wav
      67: Resources/UpClose/CombatKnife/Sounds/KnifeSlice.wav

Should read:
Code: [Select]
extraSounds:
  - type: BATTLE.CAT
    files:
      #67: Resources/CombatKnife/Sounds/knifeHit.wav
      67: Resources/CombatKnife/Sounds/KnifeSlice.wav



I left the "upclose" path in it. XD, I'll work on fixing it and reuploading it.

(EDIT:  Reuploaded it with correct path in the fileset. https://www.openxcom.com/mod/upclose-modpack/download/d36b394a )


Thanks, Shoes!
Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 13, 2014, 01:50:07 pm
Awesome designs Ivan! I love your idea, and these medals are really well-though of and gloriously looking. The more I am sad that your Photoshop conversion skills do not give full credit to these designs. I believe I could do a better conversion to UFO format if you provided the original files?

@Dioxine. :)  I'd love any pointers.  I'll PM you my .psd.    I have been disappointed with the finished product too, but figured it was just the limitations of the indexed pallettes.

Cheers, Ivan :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 13, 2014, 03:19:53 pm
ivandogovich, I found another problem with your package ;p your "Sounds" folder was not inside the CombatKnife folder, so the game couldn't find the wav. Oops ;D Now on to bug testing..

edit: able to reproduce it. It looks like killing with a knife awards every type of kill, thus triggering commendations of the "if you get EVEN ONE...". Other than this and the goomba stomp, was that all of them?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 13, 2014, 03:58:56 pm

edit: able to reproduce it. It looks like killing with a knife awards every type of kill, thus triggering commendations of the "if you get EVEN ONE...". Other than this and the goomba stomp, was that all of them?

I think I'm having a similar problem with my Flashbang grenades, then.   It applies stun damage, but I'm getting a lot of Order of the Hammer and Bolt's Cross.  I have also gotten these for kills that were neither, knife, nor flashbangs.

These posts have saves, but I didn't check them to see if they are knife related.
https://openxcom.org/forum/index.php?topic=1718.msg32758#msg32758
https://openxcom.org/forum/index.php?topic=1718.msg33107#msg33107

https://openxcom.org/forum/index.php?topic=1718.msg33661#msg33661  << hit more than 5 times award... getting issued more than once.

I think we are getting really close!  I'm excited!

Cheers, Ivan :D

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 13, 2014, 06:14:00 pm
Fixed erroneous Bolt's Cross and Order of the Hammer. Turns out, arrays can't be used like vectors. When I was checking the size of the array, it was giving me it's literal length of characters, 7, which is the melee battle type. So every kill was considered to have been done as a melee. This should also fix the flashbang!

I think all the bugs in your list have been fixed, so all that's left is goomba stomping!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 13, 2014, 06:15:13 pm

I think all the bugs in your list have been fixed, so all that's left is goomba stomping!

Woot Woot Woot!  :D

I'm less available this week, but I'll continue working on the graphics and my "Commendations_Ufopedia" mod.  I'm making pretty good progress and have over half of the medals done already.

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 13, 2014, 06:20:30 pm
Medallion ideas for the Reaction Fire award:

I'm looking to emphasize swiftness.  Two motiff ideas for feedback:

Thoughts or ideas, anyone?
Cheers, Ivan :D

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 13, 2014, 07:26:11 pm
Goomba stomping fixed :3
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 13, 2014, 07:31:42 pm
Goomba stomping fixed :3

Woot, Woot, Woot!  8)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 13, 2014, 08:06:26 pm
So links have been updated for both nightly and legacy. In the nightly, I also add the language file because of work I did in anticipation of getting my stat tracking code merged.

My next project will be to add a commendations page to the ufopedia ;p but that will not be for today.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 13, 2014, 09:55:42 pm
Working Draft of Reaction Kill Medallion and ribbon.  :D

(https://i.imgur.com/9HWfHYM.png) (https://i.imgur.com/TfuVsmY.jpg)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on October 14, 2014, 03:40:49 am
Of the two choices, I like the snake more than the smoking gun (unless you can show it shot it's own shadow, Lucky Luke style). Looking at the picture, I just had an idea you might (not) like though: What about a mongoose? Those things are fast! And in the typical mongoose-snake fight, I always picture the snake as the attacker, the mongoose as the one reacting.

Plus, it's nice to picture the aliens as the snake and cute mammal for humans ;) We're the nice ones, right?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on October 14, 2014, 11:31:00 am
How about

(https://featheredphotography.com/blog/wp-content/uploads/2011/03/long-tailed-weasel-0319.jpg)

?

:D

Seriously, everything is better with weasels... :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 14, 2014, 03:29:18 pm
Latest 4 UFOPedia Entries

Valiant Crux, Bolt's Cross, Swiftness (Maybe better named as "Quick Strike Citation"?,
and The Sapper Medal ( a new award that I have developed)

(https://i.imgur.com/gAWl31b.png)(https://i.imgur.com/FnRkhuD.png)
(https://i.imgur.com/8sVVJ0u.png)(https://i.imgur.com/BdsDp9M.png)

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: new_civilian on October 14, 2014, 04:12:06 pm
Had some problems with one soldier ALWAYS receiving the "Lucky something" award each mission even when doing absolutely nothing. The soldier had a 10-autoshot mini-gun maybe that's causing the problems?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on October 14, 2014, 05:26:25 pm
That Valiant Crux looks incredible
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 14, 2014, 06:34:07 pm
ivangodovich, your sapper medal is actually implementable with me adding any more code :3 you should just specify that a HE charge needs to be used on a cyberdisk, sectopod, etc. There is no "race" of robots, so you would either need to list each individually (and add more if you have mods), or use the race STR_LIVE_TERRORIST and include the weird two legged dog creature thing.

Had some problems with one soldier ALWAYS receiving the "Lucky something" award each mission even when doing absolutely nothing. The soldier had a 10-autoshot mini-gun maybe that's causing the problems?

This is with the latest nightly? There is an award given for a lucky shot, which means that you hit your target when it was improbably to do so. It makes sense with the 10-autoshot mini-gun, but if he wasn't firing it... :x

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 14, 2014, 06:49:39 pm
ivangodovich, your sapper medal is actually implementable with me adding any more code :3 you should just specify that a HE charge needs to be used on a cyberdisk, sectopod, etc. There is no "race" of robots, so you would either need to list each individually (and add more if you have mods), or use the race STR_LIVE_TERRORIST and include the weird two legged dog creature thing.



 And already done. ;)  But I would like to verify that this will work as an "or" condition (i.e. a Cyberdisk or a Sectopod).   I went with "BT_GRENADE" because I haven't seen any examples of specifying a weapon.  I've also got the rule for the other two citations, I'm adding as well.

Code: [Select]
commendations:
  - type: STR_MEDAL_SAPPER_NAME
    description: STR_MEDAL_SAPPER_DESCRIPTION
    sprite: 33
    criteria:
      killsWithCriteriaCareer: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
    killCriteria:
      -
        1: ["STR_SECTOPOD_TERRORIST", "STR_LIVE_TERRORIST", "STATUS_DEAD", "BT_GRENADE,"]
      -
        1: ["STR_CYBERDISC_TERRORIST", "STR_LIVE_TERRORIST", "STATUS_DEAD", "BT_GRENADE,"]

  - type: STR_MELEE_KILL_MEDAL_NAME
    description: STR_MELEE_KILL_MEDAL_DESCRIPTION
    sprite: 34
    criteria:
      killsWithCriteriaCareer: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
    killCriteria:
      -
        1: ["DT_MELEE", "FACTION_HOSTILE", "STATUS_DEAD"]
  - type: STR_SECTOPOD_KILL_MEDAL_NAME
    description: STR_SECTOPOD_KILL_MEDAL_DESCRIPTION
    sprite: 35
    criteria:
      killsWithCriteriaCareer: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
    killCriteria:
      -
        1: ["STR_SECTOPOD", "FACTION_HOSTILE", "STATUS_DEAD"]
extraStrings:
  - type: en-US
    strings:
     STR_MEDAL_SAPPER_NAME: "Sapper Medal"
     STR_MEDAL_SAPPER_DESCRIPTION: "Given to a soldier who kills a metal foe with a high explosive pack"
     STR_MELEE_KILL_MEDAL_NAME: "Cold Steel Metal"
     STR_MELEE_KILL_MEDAL_DESCRIPTION: "Given to soldiers for melee kills."
     STR_SECTOPOD_KILL_MEDAL_NAME: "Metal Menace Citation"
     STR_SECTOPOD_KILL_MEDAL_DESCRIPTION: "Given to a soldier that kills the most fearsome enemy construct: The Sectopod!"
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 14, 2014, 07:17:10 pm
The syntax looks good in all of them. It's a little redundant to use both the rank and race of a sectopod, as there is only one of each. I also notice you used STR_SECTOPOD and STR_SECTOPOD_TERRORIST. I don't know if one is wrong.

They may not be example of commendations with weapon names, but it can be done! Or even with a specific ammunition type if you so desire ;p Throw "STR_HIGH_EXPLOSIVE" in there and you are done!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 14, 2014, 07:22:50 pm
Cool. :)  "STR_SECTOPOD_TERRORIST" was what was in the XCOMruleset, so thats what I went with. :)  (Edit: I see what you mean! Thanks!)

And, yeah, I thought about using Damage Type HE, but wanted to exclude Rockets, and Tanks, etc for the Sapper.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 15, 2014, 12:15:44 am
ivandogovich, is your ufopedia code hosted anywhere or are these all mockups? I've begun poking around the ufopedia source code to add these pages to my mod. If you could link me your material, I could start working on it this week :3
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 15, 2014, 12:59:46 am
I've been building the ruleset and resources on my Home PC>  let me see what I can do to get you a copy. :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 15, 2014, 01:49:49 am
You don't have to upload every distinct art asset, just as long as I have one in the format you are using and what not.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 15, 2014, 02:06:11 am
Just pm'ed you the link. 

I tried fiddling with the item order value to try to order them in the Ufopedia, but I'm not sure it ever worked.   I don't know if my item number range in the 3000s is out of scale or not.

Also, while we are thinking about it... I don't know how hard it would be to code, but it would be cool if we could set it up to show only those awards that have been issued. 

On the otherhand, by having all of them listed, a player could more easilly see what the requirements are, and what they need to do to get them.

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on October 15, 2014, 02:46:17 am
I'm all for hiding the not-yet-acquired medals; the complete list can be found online for the overly curious. :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Dioxine on October 15, 2014, 10:47:33 am
I've done the first conversion, I believe it looks better (and the quality will differ more radically in most other medals). It took me an hour of work, 95% of which was trying to decipher Ivan's .psd files :) I'll do the others once I receive medal models in a comprehensible form (every PS user works differently, it's only natural), else it'd take me days :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Meridian on October 15, 2014, 11:54:42 am
...and The Sapper Medal ( a new award that I have developed)

Well, Cyberdiscs usually succumb to 1 or 2 HE packs... but Sectopods will survive a lot more (I'd say you'll need about 10 HE packs to kill a Sectopod, although I never tried it)... they are resistant to explosives, have better armour (especially under armour) and tons of HP.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 15, 2014, 02:57:31 pm
I've done the first conversion, I believe it looks better (and the quality will differ more radically in most other medals). It took me an hour of work, 95% of which was trying to decipher Ivan's .psd files :) I'll do the others once I receive medal models in a comprehensible form (every PS user works differently, it's only natural), else it'd take me days :)

I don't know what voodoo magic you have used but that looks awesome!  If you can show me how you did it, it would take me minutes. :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Dioxine on October 15, 2014, 03:39:12 pm
Unfortunately I can't since there's no magic trick, it just takes skill in fine-tuning hue/saturation prior to conversion and NOT PASTING OVER :P I assure you, your method of work is black magic to me as well :) So you can either train to acquire that skill or leave it in my hands.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 15, 2014, 03:52:02 pm
Yeah, I would love to train to acquire that skill.   I'm not sure where hue and saturation are impacting the indexing conversion.  That conversion is always so destructive for me, that I can't seem to figure out how to make it look any better.  If i desaturate, I can get a beautiful, completely white indexed image, but that doesn't seem to be a useful skill. XD
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: XOps on October 15, 2014, 04:43:41 pm
Yeah, I would love to train to acquire that skill.   I'm not sure where hue and saturation are impacting the indexing conversion.  That conversion is always so destructive for me, that I can't seem to figure out how to make it look any better.  If i desaturate, I can get a beautiful, completely white indexed image, but that doesn't seem to be a useful skill. XD

I really need to make a tutorial on working with colors one day in photoshop. Uncontrolled dithering is one of the most common mistakes I see with a lot of mod artwork. If you are switching to index color mode within the image itself, it shouldn't be dithering at all. At least it doesn't on mine. Now if you copy and pasted over to an indexed color image, then the conversion is very destructive. Using File-> Save for Web & Devices lets you control the colors and level of dithering. Still even if you get a good clean conversion, you will almost always need to touch up.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Dioxine on October 15, 2014, 04:45:24 pm
I've PM'ed you with the solution (TURN THE DITHERING OFF :) ), I am simply lucky to have an old Photoshop it seems :) By fine-tuning I mean getting colors closer to what the palette can support, so the result will attain more smooth look (that's how I've managed to get the Cross without any wild green pixels - you have to work with very limited yellows, so I've reddened the whole medal a bit, so it errs in the orange side, has plenty of shades to choose among, instead on going into very dangerous vivid green territory where it has only a couple of shades to work with).

Oh yeah and (dithered) backgrounds that IMO look a little better than yours (I'd advise pasting non-dithered medals over them):

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 16, 2014, 04:58:04 pm
Just got the new .exe installed.  8)

I ran an IronMan test. :) One soldier, medium scout.  Liberal application of HE Packs and Grenades.

Result, one Ironman and one Nike Cross! :)  except that the soldiers's award screen shows Three gold stars on the Iron Man and on Bronze Star on the Nike Cross.

Is that the intended effect of:

Code: [Select]
  - type: STR_MEDAL_NIKE_CROSS_NAME
    description: STR_MEDAL_NIKE_CROSS_DESCRIPTION
    sprite: 32
    criteria:
      totalAllAliensKilled: [1, 1, 2, 2, 2, 2, 3, 3, 3, 3]

  - type: STR_MEDAL_IRON_MAN_NAME
    description: STR_MEDAL_IRON_MAN_DESCRIPTION
    sprite: 19
    criteria:
      totalIronMan: [1, 1, 1, 1, 1, 1, 1, 1, 1, 1]
??

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 16, 2014, 05:24:37 pm
Also, due to Dioxine's awesome coaching, I have figured out how to dither my backgrounds and not my medals, and combine the two to make a much nicer image. :)

(https://i.imgur.com/gAWl31b.png)(https://i.imgur.com/pVAYU74.png)

Image on the left is with dithering everything at the "Save for Web and Devices" step, and the image on the right is with a pre-dithered background image and the medallion and Ribbon saved without dither.

The key to this is to convert (As Dioxine said) to index prior to "save for web and devices."  This will flatten everything, so you need to carry out, just your ribbon and medallion and no background, or maybe a transparent color like pink? 

Once indexed, to bring the back ground back in, the image(s) need(s) to be reconverted to RGB. Select pixels, copy medal, paste into background,  and voila!

Cheers! and thanks for helping me figure this stuff out!

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 16, 2014, 06:41:47 pm
Just got the new .exe installed.  8)

I ran an IronMan test. :) One soldier, medium scout.  Liberal application of HE Packs and Grenades.

Result, one Ironman and one Nike Cross! :)  except that the soldiers's award screen shows Three gold stars on the Iron Man and on Bronze Star on the Nike Cross.

Is that the intended effect of:

Cheers, Ivan :D

Yes it is! That was to avoid commendation spam. If I had 10 commendations of every kind, I would need to give one out on every "first" a soldier does. Also, the tougher commendations have fewer levels to make reaching the last one possible. That's why Iron Man has only one level: 3 gold stars. Also notice how it still said "first award"? Everything is working :D:D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: cjones on October 16, 2014, 07:52:37 pm
Hello,

Got this mod installed with another and noticed that I cannot see the full medal info screens?  the blown up ones with a quote and further info about the medal as well as a full view of the medal?  I am getting medals and can see them in my soldier data screens, but how do I get the full medal description?  are they pedia entries?

Attached is my save and config if that helps,

thanks!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 16, 2014, 08:34:49 pm
They're not in the mod yet :(
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: cjones on October 16, 2014, 09:31:41 pm
Ah OK. Thanks!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 17, 2014, 12:43:47 am
@cjones  -- sorry about that. :) 

I have been working on them, but I don't have all the graphics done and need to redo alot of them, now that Dioxine taught me how to make them look better.

 I'm about 75-ish percent done with the medals, and  I have it as an additional mod ruleset that I am building that makes the ufopedia entry.   

When I get all of these complete, I'll at least post them here so that others can use them until Shoes incorporates them fully into the base mod.  He will work on getting a separate Ufopedia section for the awards, I think.

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: cjones on October 17, 2014, 01:41:33 am
Cool.  Another quick question.  I am using latest nightly and I downloaded the mod for latest nightly.  But my open xcom reports as 1.0?  Is this due to the custom exe?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 17, 2014, 01:55:32 am
Cool.  Another quick question.  I am using latest nightly and I downloaded the mod for latest nightly.  But my open xcom reports as 1.0?  Is this due to the custom exe?

I've noticed that too. Does it normally not say 1.0? It's been compiled with pretty recent code, like as recent as last week. Not sure what that's about ;p
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: cjones on October 17, 2014, 03:19:02 am
I think it usually says 1.0 if you are using the milestone build.  I believe it tells u what nightly build otherwise
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on October 17, 2014, 04:02:54 am
Actually, I've had that conversation with Supsuper recently when I was trying to compile the nightly version. The "1.0" is just a string somewhere, so if you compile the nightly yourself, it will say "1.0" (or whatever you replace that string with). The funky version number in the nightly is put there when they compile the code for people to use, so people know what version they have (for bug reports), it is not in the code itself.

Just check if your version contains some of the features that are only available in the nightlies, like.. sorting by category in manufacture, and that will tell you that you have a nightly version (1.0 just lists everything in manufacture). Then you will know.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0 -
Post by: ivandogovich on October 17, 2014, 11:52:54 pm
@Shoes:  Question about Grenadier's Medal.

I have a soldier who killed four sectoids in one batch with an HE Pack.  He didn't receive a Grenadier's medal. 

According to this code: Any thing with Battle Type Grenade, should count, right?
Code: [Select]
  - type: STR_MEDAL_GRENADIERS_MEDAL_NAME
    description: STR_MEDAL_GRENADIERS_MEDAL_DESCRIPTION
    sprite: 14
    criteria:
      killsWithCriteriaTurn: [1, 2, 3, 3, 3, 3, 4, 4, 4, 4]
    killCriteria:
      -
        3: ["FACTION_HOSTILE", "STATUS_DEAD", "BT_GRENADE"]
      -
        3: ["FACTION_HOSTILE", "STATUS_DEAD", "BT_PROXIMITYGRENADE"]


AmmoCan's record from Save file. (four kills on turn 1803)

Code: [Select]
      - diary:
          killList:
            - rank: STR_LIVE_SOLDIER
              race: STR_FLOATER
              weapon: STR_GRENADE
              weaponAmmo: STR_GRENADE
              status: 6
              faction: 1
              mission: 1
              turn: 309
            - rank: STR_LIVE_ENGINEER
              race: STR_FLOATER
              weapon: STR_PISTOL
              weaponAmmo: STR_PISTOL_CLIP
              status: 6
              faction: 1
              mission: 1
              turn: 345
            - rank: STR_LIVE_SOLDIER
              race: STR_FLOATER
              weapon: STR_PISTOL
              weaponAmmo: STR_PISTOL_CLIP
              status: 6
              faction: 1
              mission: 2
              turn: 606
            - rank: STR_LIVE_MEDIC
              race: STR_FLOATER
              weapon: STR_PISTOL
              weaponAmmo: STR_PISTOL_CLIP
              status: 6
              faction: 1
              mission: 2
              turn: 609
            - rank: STR_LIVE_SOLDIER
              race: STR_FLOATER
              weapon: STR_PISTOL
              weaponAmmo: STR_PISTOL_CLIP
              status: 6
              faction: 1
              mission: 2
              turn: 609
            - rank: STR_LIVE_SOLDIER
              race: STR_SECTOID
              weapon: STR_HIGH_EXPLOSIVE
              weaponAmmo: STR_HIGH_EXPLOSIVE
              status: 6
              faction: 1
              mission: 6
              turn: 1803
            - rank: STR_LIVE_SOLDIER
              race: STR_SECTOID
              weapon: STR_HIGH_EXPLOSIVE
              weaponAmmo: STR_HIGH_EXPLOSIVE
              status: 6
              faction: 1
              mission: 6
              turn: 1803
            - rank: STR_LIVE_SOLDIER
              race: STR_SECTOID
              weapon: STR_HIGH_EXPLOSIVE
              weaponAmmo: STR_HIGH_EXPLOSIVE
              status: 6
              faction: 1
              mission: 6
              turn: 1803
            - rank: STR_LIVE_SOLDIER
              race: STR_SECTOID
              weapon: STR_HIGH_EXPLOSIVE
              weaponAmmo: STR_HIGH_EXPLOSIVE
              status: 6
              faction: 1
              mission: 6
              turn: 1803
          missionIdList:
            - 0
            - 1
            - 2
            - 3
            - 4
            - 6
            - 7
            - 13
          regionTotal:
            STR_CENTRAL_ASIA: 1
            STR_EUROPE: 1
            STR_NORTH_AMERICA: 5
            STR_SIBERIA: 1
          countryTotal:
            STR_CANADA: 1
            STR_INDIA: 1
            STR_RUSSIA: 1
            STR_UNKNOWN: 2
            STR_USA: 3
          typeTotal:
            STR_TERROR_MISSION_LC: 3
            STR_UFO_CRASH_RECOVERY_LC: 4
            STR_UFO_GROUND_ASSAULT_LC: 1
          UFOTotal:
            NO_UFO: 3
            STR_LARGE_SCOUT: 2
            STR_MEDIUM_SCOUT: 3
          scoreTotal: 378
          killTotal: 9
          winTotal: 6
          daysWoundedTotal: 9
          terrorMissionTotal: 3
          nightMissionTotal: 3
          nightTerrorMissionTotal: 2
          monthsService: 4
          shotAtCounterTotal: 2
          importantMissionTotal: 6
          timesWoundedTotal: 1
          commendations:
            - commendationName: STR_MEDAL_HONOR_CROSS_NAME
              decorationLevel: 0
            - commendationName: STR_MEDAL_DBLKILL_TMPNAME
              decorationLevel: 0
            - commendationName: STR_MEDAL_LONGEST_NIGHT_NAME
              decorationLevel: 1
            - commendationName: STR_MEDAL_ORDER_OF_EARTH_NAME
              decorationLevel: 1
            - commendationName: STR_MEDAL_MILITARY_CROSS_NAME
              decorationLevel: 1
            - commendationName: STR_MEDAL_PURPLE_HEART_NAME
              decorationLevel: 0
            - decorationLevel: 0
              commendationName: STR_MEDAL_SERVICE_MEDAL_NAME

Also the HE pack code from Xcom1Ruleset

Code: [Select]
  - type: STR_HIGH_EXPLOSIVE
    size: 0.2
    costBuy: 1500
    costSell: 1200
    weight: 6
    bigSprite: 22
    floorSprite: 22
    power: 110
    damageType: 3
    battleType: 4
    invWidth: 2
    invHeight: 1
    blastRadius: 5

Cheers, Ivan :D


EDIT:  One more funny thing:  Suicide Bombers are getting a Double Kill medal for killing themselves and an enemy with HE Packs. XD

Code: [Select]
diary:
      commendations:
        - commendationName: STR_MEDAL_HONOR_CROSS_NAME
          decorationLevel: 0
        - commendationName: STR_MEDAL_DBLKILL_TMPNAME
          decorationLevel: 0
        - commendationName: STR_MEDAL_DEFENDER_MEDAL_NAME
          decorationLevel: 0
        - commendationName: STR_MEDAL_FALLEN_NAME
          decorationLevel: 0
      missionIdList:
        - 15
      killList:
        - rank: STR_ROOKIE
          race: STR_HUMAN
          weapon: STR_HIGH_EXPLOSIVE
          weaponAmmo: STR_HIGH_EXPLOSIVE
          status: 6
          faction: 0
          mission: 15
          turn: 4530
        - rank: STR_LIVE_TERRORIST
          race: STR_CYBERDISC
          weapon: STR_HIGH_EXPLOSIVE
          weaponAmmo: STR_HIGH_EXPLOSIVE
          status: 6
          faction: 1
          mission: 15
          turn: 4530
      regionTotal:
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 18, 2014, 04:26:45 am
I will look at the grenadiers thing. It might have been a decision I made to tell the difference between a "doube kill" and a "triple kill", ie if you get a triple kill you actually got two double kills :x Might be a bug, might be me saying "bah, that'll never happen"

As for the double kill in killing ones self and an enemy: lol! I am almost tempted to leave that in there ;p
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Random Commander on October 20, 2014, 09:06:46 am
As for the double kill in killing ones self and an enemy: lol! I am almost tempted to leave that in there ;p

Actually, you could put it as a standalone medal!


Martyr's Cross

Many a time soldiers will feel that they will not make it through the battle. Sometimes they are right, they are bleeding on the floor and at the mercy of the aliens. There is only one thing left to do: take the aliens with you to hell. We honor these individuals for sacrificing their lives to prevent other soldiers from dying on the field.

This medal is awarded to soldiers who used a grenade or other high-explosive bomb to kill the enemy as well as take their own lives. It is issued only once.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on October 20, 2014, 09:11:42 am
Actually, you could put it as a standalone medal!


Martyr's Cross

Many a time soldiers will feel that they will not make it through the battle. Sometimes they are right, they are bleeding on the floor and at the mercy of the aliens. There is only one thing left to do: take the aliens with you to hell. We honor these individuals for sacrificing their lives to prevent other soldiers from dying on the field.

This medal is awarded to soldiers who used a grenade or other high-explosive bomb to kill the enemy as well as take their own lives. It is issued only once.

Don't encourage Ivan D!!!!! he does it just for shits and giggles :P

And i would imagine the award only being awarded once :O, but the caveat is that only given if you "kill" the enemy unit, because as we can see in Ivan D LP there is a lot of suicide going on everywhere. those soldiers must have been pushed beyond their limits XD  :o
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 20, 2014, 03:42:49 pm
The latest Medal: "Cold Steel Medal"

(https://i.imgur.com/G1WcgBy.png)

To reward those Knife Killers ;)

And I have finished remastering the older images (Thanks Dioxine!), and have about 10 more to do.  All the designs are done, just need to work up the graphics.  I may get them all done this week.

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on October 20, 2014, 05:07:41 pm
A rapier?! As someone who used to fence, I would LOVE to see an XCom trooper lunge on a sectoid with a rapier! But really, that's not much of a weapon to use in real combat. Maybe the more generic "sword" would be better?

Also, the idea of a martyr cross is great. Maybe instead of saying "It is issued only once", you could say "This award is given posthumously."
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 20, 2014, 07:32:30 pm
I like the Cold Steel commendation, even though I don't think it's possible to get in vanilla xcom ;p Don't tell the completionists it's there!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 20, 2014, 07:42:22 pm
Truth.

It definitely requires a mod.  Either Melee damage option turned on from bashing the aliens with rifle butts, or a lovely Combat Knife / Daichi Blade (to name just a couple).

I did enjoy melee as part of the tactical package in Terror from the Deep, so the Combat Knife was a no-brainer for me.  Part of the reason for Up Close and Personal TBH.

And yeah, I'll make it available as a separate (additional) medal pack for the commendations mod. :)

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 21, 2014, 03:38:26 am
@Shoes:  is it possible that "DT_MELEE" isn't defined in the mod?

I'm trying to award my soldiers the melee medal through save file editing and when I try to pull up the soldier's kill screen in their record the game crashes.

This is my criteria.
Code: [Select]
  - type: STR_MELEE_KILL_MEDAL_NAME
    description: STR_MELEE_KILL_MEDAL_DESCRIPTION
    sprite: 34
    criteria:
      killsWithCriteriaCareer: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
    killCriteria:
      -
        1: ["DT_MELEE", "FACTION_HOSTILE", "STATUS_DEAD"]
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 21, 2014, 03:49:21 am
I know the DT_* works because the incendiary commendation is given out without crashing. Are you sure you have a sprite? And that is is called medal_134.png? Without a sprite, the game crashes. I should probably create a fallback generic sprite ;p that seems more reasonable...

Also, if you typo something in the criteria, nothing crashes. If you wrote "DT_MEEE", I think you would get the commendation simply for killing a hostile unit. Or you would never get it. One or the other ;p
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 21, 2014, 06:34:56 am
Ok, thanks Shoes!  I think I may have got it !

I had the strings named differently!


STR_MEDAL_MELEE_KILL_MEDAL_NAME instead of STR_MELEE_KILL_MEDAL_NAME!  ::)

That should fix it!

Thanks for the extra set of eyes and helping me look at it closer!
Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 21, 2014, 04:42:08 pm
@Shoes. :(

Still getting erroneous Nike Crosses with my FlashBang Grenades and the most current .exe (legacy version). 

Popped a terror mission.  Five troops handed out stuns all around with the flashbang grenades.  Five Nike Crosses Awarded. :(
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on October 21, 2014, 05:31:32 pm
Ivan would when are we going to see all your hard work!!!! I can't wait, combined with Shoes mods its is a addition for inmmersion
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 21, 2014, 05:53:02 pm
Ivan would when are we going to see all your hard work!!!! I can't wait, combined with Shoes mods its is a addition for inmmersion

Heheh... you can get a great taste just by watching my LP... I'm featuring a new medal every episode as part of the outro. ;)

(Of course I know you knew that)

But seriously,  I have about 10-12 more medal images to make.  I have the designs finished, I just need to get them made around work, school (started classes again this week), and recording and editing episodes for UpClose and Personal.  I produced Ep 30 last night, and uploaded this morning.  It will air on Wednesday.  I recorded 31 & 32 this morning.  They will air on Friday and Sunday, so I don't have to produce them immediately.  I'd like to get some time to work on the medals tonight, but I'm not sure how far I can get.  It would be great to have them worked up by this weekend, but I can't guarantee anything. ;)

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on October 21, 2014, 06:03:19 pm
Heheh... you can get a great taste just by watching my LP... I'm featuring a new medal every episode as part of the outro. ;)

(Of course I know you knew that)

But seriously,  I have about 10-12 more medal images to make.  I have the designs finished, I just need to get them made around work, school (started classes again this week), and recording and editing episodes for UpClose and Personal.  I produced Ep 30 last night, and uploaded this morning.  It will air on Wednesday.  I recorded 31 & 32 this morning.  They will air on Friday and Sunday, so I don't have to produce them immediately.  I'd like to get some time to work on the medals tonight, but I'm not sure how far I can get.  It would be great to have them worked up by this weekend, but I can't guarantee anything. ;)

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 22, 2014, 06:12:58 am
Latest Medals: :)

The Black Cross, Star of Asceplius, (country/region) Campaign Ribbon, and Grenadier's Medal

(https://i.imgur.com/uXfX7ik.png)(https://i.imgur.com/DjYD4uf.png)
(https://i.imgur.com/61dZY4e.png)(https://i.imgur.com/v5q33C2.png)

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 22, 2014, 12:44:44 pm
Hm, perhaps a general "Campaign Ribbon" string could be made for the ufopedia. When I code it up, I could do that.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 22, 2014, 03:53:39 pm
I have a dilemma:  :o

I made a medallion that I really like, for the Honor Cross, which is the award that everyone gets for joining Xcom.  The medal matches the color in the ribbon, and I really like the effect.
(https://i.imgur.com/ZOyfMV4.png)

However, it turns out I used the WRONG RIBBON.  :-[  I should have used the Green Ribbon.  The purple and blue one is for Weapon Proficiency.  I don't think the Green Ribbon works as well with this medallion.
(https://i.imgur.com/vAejcr9.png)

Here is my Weapon Proficiency medallion with both ribbons.

(https://i.imgur.com/36FqZqk.png) (https://i.imgur.com/53o83cd.png)


I think it works well with the green ribbon.

BUT that requires swapping the ribbons around in the original Commendations mod, and I don't want to haphazardly do that.   I'd only do that if Shoes is in agreement with the switch....

Alternatively, I can scrap the purple/blue Xcom medallion and just work up something new for the Honor Cross.

Thoughts?

Cheers, Ivan

(Edit:  My preferred selection is the set of the first and third images in this post.  Just to clarify.)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on October 22, 2014, 03:57:40 pm
I think green is way better for accuracy than blue. Green makes mew think of the green light as in "high chances to hit". Blue makes me think of, uh... nothing much in the OXC context, it's pretty much generic. So I'll say do the swap. :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 22, 2014, 05:30:39 pm
@Shoes:

More thoughts about the erroneous nikes

Code: [Select]
if ((*j)->getGeoscapeSoldier())
{
int soldierAlienKills = 0;
for (std::vector<BattleUnitKills*>::const_iterator k = (*j)->getStatistics()->kills.begin(); k != (*j)->getStatistics()->kills.end(); ++k)
{
if ((*k)->faction == FACTION_HOSTILE)
{
soldierAlienKills++;
}
}
if (aliensKilled && aliensKilled == soldierAlienKills && _missionStatistics->success == true)
{
(*j)->getStatistics()->nikeCross = true;

In this scenario, 8 sectoids were stunned and one was pistol shot and wounded, then stunned.  The end of mission screen had 1 killed, and 8 stunned. 

I think the aliensKilled value is counting the one that died, but everyone else who stunned at least one alien is getting the soldierAlienKills as one as well.  I think the code is matching those values and awarding the Nikes on that basis.

I'll upload the save here too.

Cheers, Ivan :D

Edit:  Oh wait.  In the Save I see this line:


Code: [Select]
      - diary:
                   allAliensKilledTotal: 1

Could that cause them to get issued the Nike? even if I manually remove it from the commendations section?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 22, 2014, 06:56:50 pm
I think you found the bug! I check to see if ALL kills are given to one soldier. That means that if only one alien was killed, the killer gets the cross. I have to say "if you killed all the dead aliens AND none have been taken alive", which means I can add an even more badass medal, "Mercenary of Mercy", where you captured live all the aliens.

There is one existing "bug" that I am not sure I want to resolve.. if an alien wakes up and is stunned again, your team will have "stunned 2 aliens". Tracking what alien was stunned, and if he wakes up, seems like a lot of work for something that only a power user would do.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 23, 2014, 06:05:00 am
Heres another batch as I get close to wrapping the Ufopedia section up. :)

Distinguished Service: aka Order of the Hammer   and the Weapon Proficiency Medal
(https://i.imgur.com/NHSNQrb.png)(https://i.imgur.com/CramPSd.png)

Iron Man Medal &  the Good Luck Citation
(https://i.imgur.com/X2xxCNA.png)(https://i.imgur.com/2vx8cFw.png)

Hellraiser: aka Inferno Star & The Metal Menace Citation (A new custom metal to honor Sectopod Kills)
(https://i.imgur.com/8JlD7mf.png)(https://i.imgur.com/HEA0n0F.png)

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on October 23, 2014, 08:55:14 pm
They are looking awesome

About the Proficiency medal, wouldn't it better if you create 3 medal instead of 1 we have pistols, rifles and Heavy
so proficency with pistol will give you one, and so on. Because we all know the more medals we have the more "awesomer" our soldier is :D

The same goes for Campaing Ribbon, each continent or area can have their individualized medal, as we know differentiation is key, and this way you can see right away where they have served :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 23, 2014, 08:58:48 pm
The proficiency is tied to the individual weapon.  ie. service pistol, laser pistol, plasma pistol, heavy laser, etc, etc.

The campaign ribbons work the same way.  Also the Xenocide medals. :)

I'm going to create a new string for the Ufopedia name that will just say "Weapon Proficiency Medal" where as the soldier's record will say "Rifle Proficiency Medal" etc.

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 24, 2014, 06:24:57 am
Wooot!  The Final Medals! 

The Military Cross (redesigned from the horrible initial mockup & The Xenocide Medal
(https://i.imgur.com/jme5LNc.png)(https://i.imgur.com/Rk6MVdb.png)

The Marksman Citation (aka Sniper Medal) & The Order of Glory
(https://i.imgur.com/EOh4lyV.png)(https://i.imgur.com/EyelRxg.png)

And the Venerable Nike Cross!
(https://i.imgur.com/DCuUceg.png)

I'll probably get everything tidied up (did alot of that tonight and found medals that I had missed in the ruleset) and then run it through the ModChecker and post it this weekend as "Commendations Ufopedia Mod."

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on October 24, 2014, 05:43:12 pm
Those are gorgeous! Nice work! Now that I just figured out how to compile the nightly, I'll have to figure out how to compile the nightly commendation version.. It never ends! It's always getting better :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 24, 2014, 07:37:13 pm
Those are gorgeous! Nice work! Now that I just figured out how to compile the nightly, I'll have to figure out how to compile the nightly commendation version.. It never ends! It's always getting better :D

I have a link on the first post with a compiled old nightly, but you can have fun merging my mod to the latest nightly yourself to take advantage of all the nightly updates!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 25, 2014, 06:25:15 am
Commendations UFOPedia posted as a standalone mod Here:  https://openxcom.org/forum/index.php?topic=3048.msg34775#msg34775


I have started a new thread and posted this mod there until Shoes can incorporate it into the main mod. 

I have also set up a mini mod with my three custom medals as a separate attachment.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: MrFrustrated on October 26, 2014, 06:36:33 am
Dear Shoes,

I very much like this idea, however other than Open Xcom, your mod is the only mod I have in my game, and since downloading and installing the nightly version, my game crashes everytime I load a save game or try to start a new game.

Since its late,  there are over 30 pages in this thread, and I'm feeling rather ... well frustrated, I figure I would simply ask for some help.

I've already tried switching the option off, but that didn't help. I did flip a few other options on, can't remeber, but they would have all been standard open xcom options.

To Shoes or anyone who can help me, I would deeply appreciate it

Also to Shoes and anyone who makes mods, please when possible have a trouble shooting section in your OP or 1st post after your op.

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on October 26, 2014, 01:49:26 pm
Dear Shoes,

I very much like this idea, however other than Open Xcom, your mod is the only mod I have in my game, and since downloading and installing the nightly version, my game crashes everytime I load a save game or try to start a new game.

Since its late,  there are over 30 pages in this thread, and I'm feeling rather ... well frustrated, I figure I would simply ask for some help.

I've already tried switching the option off, but that didn't help. I did flip a few other options on, can't remeber, but they would have all been standard open xcom options.

To Shoes or anyone who can help me, I would deeply appreciate it

Also to Shoes and anyone who makes mods, please when possible have a trouble shooting section in your OP or 1st post after your op.

Did you do a complete install?  for example did you copy all the .dll files etc, that come with the Mod?

I don't run the nightly version, but the Legacy version is working well for me.  You might try using that version, especially if you aren't using any other mods that rely on capabilities in the nightlies.

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: MrFrustrated on October 26, 2014, 06:32:41 pm
Thanks Ivan, its working.

I would download your add on but I'm not sure if I would bungle it. So I'll wait when everything is working together.

Thanks.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 26, 2014, 09:27:21 pm
Thanks Ivan, its working.

I would download your add on but I'm not sure if I would bungle it. So I'll wait when everything is working together.

Thanks.

Glad to hear it's working! Was it the .dll issue, or did you move to the legacy/1.0 version?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: MrFrustrated on October 27, 2014, 07:05:41 pm
"Glad to hear it's working! Was it the .dll issue, or did you move to the legacy/1.0 version?"

I went to the legacy version.

I am enjoying the flavor it adds very much.

Any chance you could list how long someone served. I would really like to follow the careers of my orginal 8.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0: Feedback on Hellraiser Medal
Post by: ivandogovich on November 02, 2014, 04:43:48 pm
@Shoes:

I just wanted to note that the Hellraiser Medal, as it currently stands, will be extremely difficulty to obtain. 

Code: [Select]
  - type: STR_MEDAL_HELLRAISER_MEDAL_NAME
    description: STR_MEDAL_HELLRAISER_MEDAL_DESCRIPTION
    sprite: 11
    criteria:
      killsWithCriteriaCareer: [5, 10, 15, 15, 15, 15, 20, 20, 20, 20]
    killCriteria:
      -
        1: ["DT_IN", "FACTION_HOSTILE", "STATUS_DEAD"]

As it currently works, this only tracks an instantaneous kill with DT_IN, so any of the enemies that expire on subsequent turns are not tracked.  i.e. the soldier who caught them on fire with the incendiary weapon, doesn't get credit for the kill when the enemy dies later.  I just completed a mission where I killed 4 enemies with fire, and one with a proxie, and only the proxie was credited to anyone.

I don't know if its possible to get it working with code to track that, but I thought I'd pass the feedback along. :)

In other news, I've had some other folks downloading the Commendations UFOPedia mod, and making LPs and livestreams with it, so your mod is getting some great exposure. :)

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on November 03, 2014, 12:28:22 pm
The problem with "death by being on fire" is that I would need to write up some code so the game remembers who set that guy on fire. At the time, I didn't feel like doing that ;p

That's some good news about your mod, cool!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: MrFrustrated on November 05, 2014, 09:19:09 pm
Any chance you can make a medal for using a medikit?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on November 06, 2014, 02:25:18 pm
Any chance you can make a medal for using a medikit?

Good call, that should definitely be in there. Could probably make one medal for each time of the meds that kit has, and award it for how often it was used.

When my IRL work load dies down, I'll definitely take a look!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: MrFrustrated on November 07, 2014, 04:39:59 am
Good call, that should definitely be in there. Could probably make one medal for each time of the meds that kit has, and award it for how often it was used.

When my IRL work load dies down, I'll definitely take a look!

Thanks Shoes.

I'm one of those players who gives everyone a medkit.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on November 07, 2014, 08:02:03 am
Red Cross Medal!!!!!! :)

You saw it here first folks!!!! :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on November 07, 2014, 02:40:35 pm
Red Cross Medal!!!!!! :)

You saw it here first folks!!!! :)

OOo!  Nice. :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: MrFrustrated on November 24, 2014, 01:28:22 am
Red Cross Medal!!!!!! :)

You saw it here first folks!!!! :)

Congrats?

Any chance you can medals for if the medkit is used on a civilian or an alien?



One other thing, I have commendations turned on, but they don't show up anymore. I recently tried installing a nightly to fix no psi strength improvement, I again I had to go back to version 1.0. Shortly after making the change I notice I wasn't getting medal updates.

I briefly tried starting a new game and aborted from my 1st fight, no medals and no luck.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on November 24, 2014, 01:44:07 am

One other thing, I have commendations turned on, but they don't show up anymore. I recently tried installing a nightly to fix no psi strength improvement, I again I had to go back to version 1.0. Shortly after making the change I notice I wasn't getting medal updates.

I briefly tried starting a new game and aborted from my 1st fight, no medals and no luck.

If you are installing nightlies, you are over writing the custom .exe file that the Soldier Diaries / Commendations mod relies, on.  You can have one but not the other.   That said, Shoes usually has a couple versions of the mod available.  One at the legacy 1.0 version (which is what I'm using), and another, more recent based on a somewhat recent nightly.  I think its been a month or more since he updated the recent version.  If that is what you are using, please ignore this explanation as I must have misunderstood your statement.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on November 24, 2014, 09:54:50 pm
Yeah, you can't install over my .exe without losing the commendations code.

A medpack medal should be easy to implement; calculate how many points of X Y or Z was recovered, track and save that. Could be a map element so I could assign a string for the type of unit it was, so you can track civilian heals and alien heals and soldier heals. I might not do that however, because I don't think anyone ever heals non-soldiers for good reason.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on November 24, 2014, 10:09:27 pm
Actually, I've healed both aliens and civilian. To prevent a stunned gazer from dying (that was cruel, he did die at the base... but not after he revealed his secrets!), and a civilian that had been clipped by an explosion (not that they survive often though..)

If it's not much more work, it could be a neat little surprise (and even an occasion for a little humour: Alien Hugger Award?)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: MrFrustrated on November 26, 2014, 10:01:04 am
Only purple and crimson heart being awarded, but none of the other medals. Any advice?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on November 27, 2014, 05:11:15 am
Well that's interesting ;p I would say re-download the ruleset or something. I can't imagine any sort of "new" bug were only part of the medals are commended.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on November 27, 2014, 05:18:04 am
Just for the record, Commendations is still working pretty well for me.   The only unusual occurrence recently was a mission where 5 soldier got the Order of the Hammer, despite never encountering more than two races.

Legacy 1.0 version.

Cheers, Ivan :D

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: MrFrustrated on November 28, 2014, 10:34:44 pm
It seems like I'm not getting merit stars or restraint medals. I've stunned 3 aliens in 2 missions, and killed about 13 aliens.

I've gotten the hammer, military cross.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on November 29, 2014, 03:03:03 am
I'm pretty sure Restraint takes more than three. ;)

(https://i.imgur.com/cvaxYX5.png)

The Merit star should be applicable if its one soldier with 13 kills.

(https://i.imgur.com/fcFQ7u2.png)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: MrFrustrated on November 29, 2014, 06:56:21 am
Was at any piont different standards used?

I could have sworn there was one medal my guys constantly got if they did anything on there first mission.

Thanks Ivan.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on November 29, 2014, 05:18:25 pm
There is the Honor Cross which is the "Hi, welcome to Xcom. Here is your medal for participating."  - it is awarded for a month of service.  So everyone should get one at the end of the month.  In my customized setup I renamed it the XCOM Service Medal.  But otherwise there isn't one of for just taking part in a mission. 
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: BlackLibrary on December 02, 2014, 09:07:11 am
Curious...Can one take a inprogress game using nightlies and merge in the Soldier Diaries mod.  I love the mod, can't wait to play it..but I have an ongoing game I would hate to end.   

Any assistance would be helpful.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on December 02, 2014, 03:28:41 pm
Curious...Can one take a inprogress game using nightlies and merge in the Soldier Diaries mod.  I love the mod, can't wait to play it..but I have an ongoing game I would hate to end.   

Any assistance would be helpful.

Generally, you can take a save game from another build and play it with Soldier Diaries.  Because Soldier Diaries uses another .exe you may lose some features of the Nightlies.  You also will be starting your Awards and Diaries program fresh, so all of your soldiers will get no credit for what has gone before.  They will only start receiving awards for accomplishments going forward.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on December 02, 2014, 09:57:51 pm
So... Main build integration when? :q
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on December 02, 2014, 11:31:15 pm
So... Main build integration when? :q

We pretty much know it isn't happening until after OpenTftd. :|
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on December 03, 2014, 12:51:37 pm
I might be able to convince the devs, but I've been busy with work. Last I spoke with them their stance was "great, let's sit down one day and go through the code together and see if it will work!", but I've yet to approach them ;p
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: MrFrustrated on December 03, 2014, 10:00:03 pm
I think I got the grompa stomp bug in battlescape.

I have Openxcom 1.0 and two mods, the orginal soldier diaries and that mod that compliments it.

My auto save and regular save always ended with a game crash, 'not working' message.

I eventually went to a a geoscape auto save. Game works fine now.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: MrFrustrated on December 04, 2014, 02:03:57 am
Again I'm getting the same problem. Both saves won't work. Both times was sectiod terror ships.

UPDATE. Finally finished a sectiod terrorship without crashing
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: MrFrustrated on December 04, 2014, 07:26:46 am
Unrelated to crashes,

Any chance you could make a medal or medals for

1) damaging an enemy without killing it, call it something like the assist medal

2) hitting the enemy without damaging the enemy, call it something like Futile resistence or plonk medal (plonk is the sound you hear when tanks square off, and one tank isn't penatrating the other tanks armor).

I would argue for these because they shows up in cases with heavy enemies like cyberdisk, mutons, Chryssalids, and sectopods. You  can have a character who kicks butt but doesn't get any kills. The second idea is the medal you don't want to get
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on December 04, 2014, 01:06:29 pm
For the crashes, would it be possible for you to post your save? That way I could try debug it and see what's going on. Also, is it only crashing at the end of the mission?

For the medals, 1) might be tricky to do, because I think the "hit" code and the "kill" code don't really talk to each other. If 1) can be done, so can 2), but 2) sounds a little bit like an anti-commendation: "way to go scrub, you did no damage". Perhaps 3 no-damage shots like that in one mission could get a "persistance" award ;p
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: SaintChozor on December 04, 2014, 01:42:59 pm
I'm having trouble downloading any of the nightly versions from the site, have they been taken down?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on December 04, 2014, 05:15:56 pm
If they have, you can download them from the first post of this thread. Mind you, the nightly will be outdated :x any new features since the date of my nightly will be missing from the official nightly.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: MrFrustrated on December 05, 2014, 02:06:27 am
Shoes, I'm sorry, I deleted those saves for fear that saving onto those spaces might muck up future saves, but if I encounter the bug again, I will keep the save. It always happen on farmland, and it happen when the mission ended successfully (kill or capture didn't matter). I never tried aborting.

As for the medals, it would be cool if you can do them. I like your thoughts for the persistence award.

3 other shooting medals.

1) Hitting/killing an enemy(s) from the front, call it the Frontal Assult or Direct Approach Medal

2) Hitting/killing/stunning an enemy(s) from behind, call it the Sneak Attack or 'They came from behind'

3) The flanking version.

-You possibly limit these medals to certain enemies. For example a frontal assult on a sectopod is risky and worth accomending.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on December 05, 2014, 02:35:39 am
The good news is that you have unlimited saves... well only limited by your hardrive (and yes, the save files are tiny).  All you have to do is save your game with a new name, like "Ithinkthisoneisgoombasstompedshoeshelpme.sav"

Cheers, Ivan
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: MrFrustrated on December 08, 2014, 01:14:44 am
A few ideas for medals

Could we have another pair of Fallen Soldier medals?

1. Best of Class. 1st/Best of a given rank died. The first time in any mission you lose a particular rank, that casualty gets this medal. Aftwards, the medal is only given to a soldier of the same rank who exceeds the first soldier of that rank to recieve it.

So I recently lost Colenel Meghan Rory, who had 26 kills and 3 stuns over 26 missions. She's not the first Colenel I've lost and she's not the last Colenel I've lost.

Lets say the 1st Col who died was Harry Amos, who had 13 kills. He gets the Best of Class, Colenel version.

Col. Rory gets it because her records exceeds Col. Amos's. Afterwards, only Colenels with a better record than Rory gets that medal. So if Commader Flovio dies (18 kills, 1 stun), he gets it because no other Commander has been KIA. It doesn't matter that his record is less than Rory's because they are not the same rank.

2. Fallen Best Soldier Medal. Regardless of rank, your very best soldier whos fallen to date gets this medal. So when Rory got killed, she gets this medal and no one else until another soldier of any rank dies who had more kills/stuns than Rory.


-For the purpose of determining best, you might use a combination of kills and stuns minus any friendlies killed. Then have a formualas that takes into account psi strength and psi training. Clearly a soldier with 100+ psi training was a guy you put considerable time into perfecting. You might consider crimson and purple hearts as well.


Why have these medals? Because you get attached to your high performers. I am getting rid of every rookie who does have a 75 psi strength or better, but I grandfathered in any squadie or higher. It helps that I have psi on line of sight setting. Otherwise, I would have likely tossed Rory who had a 22 Psi str. Had my Commander died, Flovio, I knew Rory would have gotten the promotion. She was by far my best long surviving soldier. The closest to her is the Commander and even he doesn't compare.

As it is now, I look at my memorial section to see the first time I lost someone of a given rank. These medals are an extension of that tendecy.



Another idea for a medal, 1st contact or 1st mission medal. The first time you fight the aliens, every soldier gets this medal regardless of how much they did.

Again why? I follow more closely my orginal troops; first battle was Jan 7th.. I still have one left, he's a captain, been injured at least twice. I lost 5 people on my first mission but it was worth the price since I captured 2 navigators and an engineer. Rory was the 2nd to last one I had left. Flovia's first mission was Jan 25th.


BTW, if I encounter the grompa stomp bug, I will upload the save.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on December 08, 2014, 07:28:35 pm
For those Fallen Soldier medals, I would probably just go with score ;p if their score is better, they get a medal. I think it would be pretty easy to do.

I like the idea of "first contact", and I think I could make it work. Something along the lines of checking to see if the medal had been given already and if not, award it.

Don't get too optimistic about this getting done soon, I still have time commitments elsewhere :(
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: MrFrustrated on December 08, 2014, 10:43:48 pm
Shoes, I appreciate anything that adds more flavor.

I'm glad you like the first contact idea.

Could you put on a non renewable trigger that only triggers for the first mission with a hostile on it?

Or were you planning to do it for all the alien races?

Anyways, a lot of people I know are in the middle of finals. Those who aren't have end of the year projects. Good luck with whatever is on your plate.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on December 08, 2014, 11:37:25 pm
I was thinking a "first to sight alien race X". You're looking for a special distinction for your day 1 soldiers though, right? I'm sure there would be a way to give them a "first come first serve" kind of medal.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: MrFrustrated on December 10, 2014, 12:14:45 am
I would be happy with Mission 1, but I can see the merit in your view. If you can do both, that's awesome, but even 1 is very cool bit of flavor.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Lobster on January 04, 2015, 11:23:57 am
Appears to be an excellent mod, from what I've seen in video and pictures (adds a great RP element),  but I'm having a little trouble getting this mod to work properly for some reason.  I hope someone can point me in the right direction (I'm somewhat new to modding here).

It does somewhat work on my system, meaning the new buttons and screens show up (haven't tested the actual mission tracking).  However, the problem is the button names and all column headings and words have a "str_" in front of the name, which I assume represents the variable name of each object.  So basically, variable names are showing instead of the proper words themselves.

Any ideas?

Thanks.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on January 05, 2015, 07:57:48 pm

It does somewhat work on my system, meaning the new buttons and screens show up (haven't tested the actual mission tracking).  However, the problem is the button names and all column headings and words have a "str_" in front of the name, which I assume represents the variable name of each object.  So basically, variable names are showing instead of the proper words themselves.

Any ideas?

Thanks.

Looks like you are dealing with a language pack issue.  There are a few translations for the commendations mod, and you should be able to use one of those.  If you are trying to use the Ufopedia Commendations addition, sadly, only English: US is guaranteed to work.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on January 06, 2015, 01:26:01 pm
If it is not a language issue, it could be a ruleset issue; did you put it in the right folder? If the buttons are there, the .exe is working. If you're getting commendations, then the mod is working (if not, check that it's turned on in the mod menu in-game).
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Lobster on January 07, 2015, 07:33:23 am
Thanks a bunch for the replies Ivan and Shoes, but I am beyond stupid.  You were correct Shoes, it simply wasn't turned on in the mods section, like the other mods are.  Everything was working, the stats, tracking, etc, it was only the button labels and column headings that weren't displaying properly with the mod turned off.   Thanks again.   Terrific mod.   Makes me "care" even more about the soldiers.

By the way Ivan, been enjoying your Up Close and Personal series on youtube.  Was well into it until you mentioned Marbozir and his Long War series, then I got hooked on that  :)  I'll come back to yours though, was done very well.

Thanks guys.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on January 10, 2015, 09:48:18 pm
Commendations UFOpedia 2.0 now available

This is an update to the UFOpedia mod that is available that adds a "COMMENDATION ENTRIES" Section in the Ufopedia and also adds English-UK support.

(https://i.imgur.com/CbsedUQ.png)
(HWP's have been consolidated with Craft and Armaments)


Download link here:
https://www.openxcom.com/mod/commendations-ufopedia-mod/download/9288e4a7
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on January 10, 2015, 10:40:30 pm
I've added a link to it on the first page of this thread!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on January 26, 2015, 09:11:49 pm
Heya Shoes: An interesting wrinkle on the Nikes: :)

Situation: Downed SnakeMan Medium Scout, crew of 4, two of them killed in the crash.

Of the remaining snakes one is stunned by flashbang and pistol fire and falls unconcious.

The other dies to an alien grenade.

Both soldiers got Nikes.  (Footage in this episode: https://www.youtube.com/watch?v=aNvfVtYNAe4)

Only one enemy was killed.  But both of them dropped an enemy so they were both awarded the medal.

I think the logic might need to be adjusted to take account of "stunned" enemies as well as killed ones.
I can see the logic is coded here:  src/Battlescape/DebriefingState.cpp line 269  but I don't know code well enough to understand it.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on January 26, 2015, 10:51:16 pm
The fact both of them got a Nike cross is definitely not good. The bug is the following: kills and stuns are kept in the same vector, but the Nike check does not count "alien kills", only the size of the vector "kills", so "stuns + kills". So since the vector size for each soldier is 1 (kill) and 1 (stun), they are both equal to 1 (kill) that the Nike Cross looks for. Fun stuff! You can check out how kills are stored in "void BattlescapeGame::checkForCasualties"

So that's an easy fix, but I want to ask you this: is the Nike Cross too easy to get? Should it count if some aliens are taken alive? Should it count if there are as few as two aliens? Should it count if some aliens were killed in the crash landing?

edit: also, while I'm in here, we can add a commendation for a soldier who takes all the units alive. Would that be a good commendation?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on January 26, 2015, 11:30:37 pm
Is the Nike too easy to get??   I don't think so.  If you single handledly take care of an alien crew, I think you deserve it (stunned or killed, it doesn't matter).  Even if its a crew of one for the small scout.   You can get and IronMan and a Nike fairly easily on a small scout.

"Take them all Alive"  -- hmmm... sounds kinda cool. :)  "Tag them and Bag them"   With just a stun rod, certainly a challenge.  With small launcher, definitely easier.  With custom stun tools like my flashbangs, very easy. 

We have the Order of Restraint, that ranks up for accumulated captives, but doesn't account for stunning all enemies in a single mission.  Overall, I'd judge this one to be harder than the Nike Cross.  So yeah, probably worthwhile. ;)

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on January 28, 2015, 07:24:24 pm
I've added a number of new commendations to the mod, without any new art or UFOpaedia entries.

When a soldier kills a unit, I now track the body part hit and what side was hit. I've also adapted my flexible commendation system to make use sides and body parts. So now, you can award a medal for killing a commander by shooting him in the head from behind with a pistol. To make use of this, I've added a headshot medal, a rear shot medal, and a flank shot medal.

I've also added a healer medal. I would like to track revives too, but that's a little tricky. We'll see.

Here is a list of commendations that I think you guys have suggested. If you have more suggestions, I would like to hear them :) https://gist.github.com/Shoes01/3af40f402d287ae9c229
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on January 28, 2015, 07:37:15 pm
I've added a number of new commendations to the mod, without any new art or UFOpaedia entries.
<snip>
To make use of this, I've added a headshot medal, a rear shot medal, and a flank shot medal.

I've also added a healer medal. I would like to track revives too, but that's a little tricky. We'll see.

Here is a list of commendations that I think you guys have suggested. If you have more suggestions, I would like to hear them :) https://gist.github.com/Shoes01/3af40f402d287ae9c229

Ack! Looks like Ivan's gonna be busy for a while.  :o
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on January 28, 2015, 07:48:12 pm
Actually, I have been thinking of some completionist medals....

- Like... participating in a mission with each UFO type.
- Getting Kills/Stuns with each class of weapon : melee, pistol, rifle, heavy, launcher, grenade  (This actually may get cumberson due to having to define each weapon, and mods would not be accounted for) 
(Edit:  The usable battle types are : 1 - Firearm, 2 - Ammo, 3 - Melee, 4 - Grenade, 5 - Proximity Grenade.  Not sure if Rocket Counts as Ammo)
- Getting Kills/Stuns with each class of Damage : AP, HE, Laser, Plasma, Stun, (Optional: Melee, Smoke, Incendiary, Acid)  (Maybe any 5 of the above)


Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on January 29, 2015, 09:21:01 pm
O.K.  Good news.  Shoes has had time to work on this mod more.   New commendations have been developed, which means I'll need to work up more art work for the UFOpedia section.   

At current build, there are 33 commendations.  About 6 more have been coded.
For naming and numbering purposes, I wonder if we should also consider incorporating two of my pre-built additional commendations:

The Sapper Medal ("Given to a soldier who kills a metal foe with a high explosive pack")  https://i.imgur.com/BdsDp9M.png
and
The Metal Menace Medal ("Given to a soldier that kills the most fearsome enemy construct: The Sectopod!")  https://i.imgur.com/HEA0n0F.png

Shoes, what do you think?  Would you like to include these?  If so, they will become #34 & 35, ect with the other new ones sequential after that.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on January 29, 2015, 10:00:51 pm
I actually assumed when you PR'd your ufopaedia mod that your two commendations were already there! I would be happy to add those two commendations.

I'll try and put my ar-legacy branch up to date with my new code so that you can pull it, put your new artwork and #33 and #34, and the PR it.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on January 29, 2015, 10:08:08 pm
I actually assumed when you PR'd your ufopaedia mod that your two commendations were already there! I would be happy to add those two commendations.

I'll try and put my ar-legacy branch up to date with my new code so that you can pull it, put your new artwork and #33 and #34, and the PR it.

<chuckle> when I did the PR, I didn't add any of the new commendations that I made.  Mainly, because the third was non-vanilla (Cold Steel for Melee Kills).  And at the time, I didn't want to add anything that wasn't agreed on.  So, now as we are expanding the mod, I thought, I'd propose them and see.

I'll get a chance to work on these some more tonight after work, so I'll refresh my branch then.  I did so this morning too.

One other thing.... some of the logic in the new awards requires the enemies to be "STATUS_DEAD" .   Would it be possible to include stunned as an either/or proposition?  i.e. for someone to use BT_MELEE, in vanilla they need to use a stun rod... and you see it might be tricky to get a "STATUS_DEAD"  ;)

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on January 30, 2015, 12:27:36 am
You're right, the using melee AND killing units is not quite feasible. I forgot to fix that before pushing to ar-legacy, so you can fix it if you think about it :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on January 31, 2015, 10:17:41 pm
Ok.  I have a PR in for the two awards.  Also cleaned up some of the ruleset for the new awards.  Still have to make ribbons and medals for the new awards.

I'm considering creating a couple graphics called "place holder" to put in until the others are finished.  These could be phased out as I get a chance to complete them.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 01, 2015, 12:55:59 am
I'm considering creating a couple graphics called "place holder" to put in until the others are finished.  These could be phased out as I get a chance to complete them.

I think that's a great idea. Normally I use the very first sprite as a place holder ;p

I appreciate the work you're doing! :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 01, 2015, 03:17:21 am
First glimpse at the newest write up. Place holder image with Mercy Cross writeup.  I'll be getting another pull together will the ruleset and graphics updates.  (Edit... these have accumulated under the previous PR, so they are ready to pull).

(https://i.imgur.com/696bTQe.png)
(Placeholder Image)

Edit:  Mercy Cross Medal completed:
(https://i.imgur.com/NvZoCU9.png) (https://imgur.com/NvZoCU9)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: volutar on February 01, 2015, 06:50:47 am
Sorry ivandogovich I can't look on these backgrounds withoud bloody tears. This error diffusion techique doesn't work well for xcom.

Concerning medals. I think mercy is closer to first image. Second cross looks somehow more brutal.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 01, 2015, 02:40:30 pm
PR merged! I added a comment to it so you can read the minor edit I did.

I agree with what volutar is saying about the medal, but I do like it.. maybe Mercy Cross isn't the correct name for this commendation. Maybe "World Police" or something like that ;p
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 01, 2015, 03:06:33 pm
PR merged! I added a comment to it so you can read the minor edit I did.

I agree with what volutar is saying about the medal, but I do like it.. maybe Mercy Cross isn't the correct name for this commendation. Maybe "World Police" or something like that ;p

The medal in the placeholder image is already the Military cross just shoved in so there would be something. 

Otherwise, the alien behind bars on the Mercy Cross is not appealing?   I can take it back to the drawing board.

@volutar: as far as the background diffusions go,  I worked long and hard with Dioxine to get something that looked decent.  These are the backgrounds that he provided.  His graphics skill is beyond question, so I'm happy with that.  I understand, Volutar, what you are saying, about XCOM gradients being single color and not random diffusion, but those techniques don't work well with the Black blended to Color effect.

Shoes, Here are some backgrounds that volutar is suggesting in the place of the ones that have been used so far: https://openxcom.org/forum/index.php/topic,3048.msg37324.html#msg37324
These are more of a Single color effect.   If you would prefer using something like these for the backgrounds,  I can remaster all of the previous medals.

Cheers, Ivan.

Oh yeah.  Shoes, I also had a question on your commit .  I left a comment on Git.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 01, 2015, 04:28:30 pm
Replied to git.

I like the alien behind bars and want to keep it for the commendation, but I want to change the commendation's name. Mercy and prisons don't really go together ;p I would almost want to say something like Hades Cross, because those alien prisoners are certainly not going to be treated with humane respect.

As for the colored back grounds, I don't really have an eye for that kind of stuff. Maybe you could give the placeholder medal one of volutar's backgrounds and see what looks best in game.

edit: I am able to now compare initial and current stats, so I can create code to award commendations based on having gotten +20 TUs or whatnot. I don't think I can make this modular in a way that will save me work. I have two choices: create a commendation for every stat (that'll add like "milestone" commendations, they're not too exciting), or add one single commendation that gets a decoration every time the sum of stats passes the threshold.

... having written it out, I am going with the latter. It will be neat, simple, and can have a unique name and representation: global improvement.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 02, 2015, 01:02:04 am
Here are Mockups with Volutar's gradient vs. the previous gradient version by Dioxine.

New                                                                           OLD                                           Class of Award
(https://i.imgur.com/NbjIKs1.png) (https://i.imgur.com/jme5LNc.png) Support
(https://i.imgur.com/94DcKK8.png) (https://i.imgur.com/YcQ25FT.png) Wounds
(https://i.imgur.com/ISeCzRX.png) (https://i.imgur.com/bYrklgX.png) Somber
(https://i.imgur.com/XAlCCIk.png)  (https://i.imgur.com/nhiWLFA.png) Normal
(https://i.imgur.com/iAvN26x.png)  (https://i.imgur.com/DCuUceg.png) Awesome

Submit your votes for New or Old backgrounds. 
Shoes has the deciding vote! ;)

Cheers, Ivan :D




Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: vlad on February 02, 2015, 03:39:07 am
I like the old ones (Dioxine) as they fit the UFO theme more. If the graphics is being updated to higher resolution, maybe there would be a better place for Volutar's gradient.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 02, 2015, 12:23:40 pm
I like how dark the old ones are.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: volutar on February 02, 2015, 01:32:56 pm
Vanilla xcom style doesn't imply black background. It's always "colored" with not vivid hue.
And exactly this darkest color->black dissolve with stochastic pattern looks awful.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 02, 2015, 02:04:27 pm
I do think matching the xcom style is important. Volutar, do you think a border or something is needed here?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: volutar on February 02, 2015, 02:40:18 pm
I think it's needed. But this ribbonpedia utilizes multiple background hues (which is already slightly off the vanilla way) and I'm not sure the border of same color will look okay. This thing better to be done by someone with good experience with 8bit graphics and dealing with limited colors.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 02, 2015, 02:49:22 pm
This thing better to be done by someone with good experience with 8bit graphics and dealing with limited colors.

Then perhaps we'll keep the old backgrounds ivan has made up until someone swoops down and remakes everything :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 02, 2015, 03:04:39 pm
<snip> But this ribbonpedia utilizes multiple background hues (which is already slightly off the vanilla way)  <snip>

The multiple background hues are by design as a way of categorizing the different types of award:

Blue = Normal
Green = Support
Purple = Wound
Black/grey = Somber
Red = Awesome
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: volutar on February 02, 2015, 03:57:57 pm
Blue = Normal
Green = Support
Purple = Wound
Black/grey = Somber
Red = Awesome
This colorcoding logic is questionable.
I woulnd't make WHOLE picture affected by the monotone/gradient background with some vivid color. It'd be better to split picture by 2, with medal+background and text on some neutral background. Looking into the picture filled with a color will affect color-hue shift in the brain (towards complementary colors), so after blue picture you'll perceive everything as yellowish.

Then perhaps we'll keep the old backgrounds ivan has made up until someone swoops down and remakes everything :)
I don't know which background you mean, but backgrounds made by Dioxine with random dithering looks very raw and not accurate, considering they are often contain colors from different colorgroups which is really BAD. It's not the way how XCOM should look. BTW, many of mods with fullscreen ufopaedia images (converted from highcolors) look off.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Meridian on February 02, 2015, 04:00:42 pm
Ivan, just give him the source material and let him do it the way he wants... otherwise this will be a never-ending story.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: volutar on February 02, 2015, 04:09:07 pm
Ivan, just give him the source material and let him do it the way he wants... otherwise this will be a never-ending story.
If "him" is me, I won't do anything more than I already did (these backgrounds). I don't have necessary spare time to spend on mod I'm not really interested in. But the result I'm seeing doesn't reach the level of "good quality". The level of Robin's work is more than "good quality". This - is not. And Ivan knows that. I'm just making Captain Obvious statement, to push someone experiment with the look of these articles. Filling them "somehow" is not enough to make it feel "made with love" as any other part of xcom.
It woulnd't pass Quality Assurance. But it should. It deserves it.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 02, 2015, 04:37:10 pm
<snip>  But the result I'm seeing doesn't reach the level of "good quality". The level of Robin's work is more than "good quality". This - is not. <snip>

LOL!  I certainly wouldn't have tackled this if Robin wanted to do it. ;)  Or Dioxine for that matter, or any number of other good graphics artists. 

However, I felt that adding the UFOPedia entries was worth the work, and it has really enhanced the gameplay experience for me. :)

The sad thing is, that currently, no matter how "perfect" we get this mod, it is not likely to be integrated into the main branch as far as I know.  When Sup and Warboy last talked about it, they felt like it was better standalone.   By integrating it into the main branch, the dev team takes up a significant responsibility in maintaining it going forward, and that, they are reluctant to do. 

Currently, I doubt that there are many people even playing with this Commendations Ufopedia mod.  :)

but, Volutar, as Meridian suggested, I would gladly pass on my .psd file for the medals so you could remaster all of the images as you wish, should you desire to play with this mod.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: volutar on February 02, 2015, 05:31:00 pm
LOL!  I certainly wouldn't have tackled this if Robin wanted to do it. ;)  Or Dioxine for that matter, or any number of other good graphics artists.
I wouldn't put Dioxine near with Robin here. Dioxine by my judgement is using 24bit images and convert them to xcom palette with "default" settings, without too much of hand-work after.

Commedation mod will be integrated into main branch eventually, after TFTD. It worth to be in the main, just, after some good review and perhaps refactor, to fit its concept better. And by that time, better to have really worthy ufopaedia images for it. Nothing stops from making that right now, spend, like a WEEK of precise hand pixel work for each background, but fill them with medals themselves really quickly after. I see no noticeable flaws in the medal images themselves, but excuse me backgrounds are out of XCOM style. They are more for the Pirates (which is full of ugly dithering). Some gradients I made are not good too. In some respect they are better, in some - worse (they are too light). Ideally these images need proper screen split/borders and stylization, and using this colored background only for the right "medal". I would ask Robin to help. He's the man who works in XCOM style perfectly.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 02, 2015, 08:33:55 pm

I like the alien behind bars and want to keep it for the commendation, but I want to change the commendation's name. Mercy and prisons don't really go together ;p I would almost want to say something like Hades Cross, because those alien prisoners are certainly not going to be treated with humane respect.

Aha! Better Name:  "Captus Cross"  for captive in Latin.  Captus de Bello is prisoner of war in Latin.    I think "Captus Cross" is perfect.

Also, Shoes.  Would you like to do this collaboration work for the Ufopedia stuff in another threads, so as not to "clog up" this Completed Mods thread?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 02, 2015, 09:39:32 pm
Aha! Better Name:  "Captus Cross"  for captive in Latin.  Captus de Bello is prisoner of war in Latin.    I think "Captus Cross" is perfect.

I like it!

Also, Shoes.  Would you like to do this collaboration work for the Ufopedia stuff in another threads, so as not to "clog up" this Completed Mods thread?

Well the ufopedia has been fully integrated into the mod, so as far as topics go it's a valid one. I think the discussion has been good so far, and I don't think there is much more to be said. At the moment, the ufopaedia portion of the mod stands out because it doesn't follow the general aesthetic of the game: to fix this, one should seek Robin's opinion on how to help. There was a comment made on the different colors being a bad design choice: the pseudo-categories could be defined using borders, ribbon shape, ribbon pattern or something else that has yet to be suggested.

At the moment, I am in no rush to get these things done because I don't know how the ufopaedia will be affected by TFTD. Not to mention I am not the one maintaining it so I won't force anyone to do work they don't want to do! :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: volutar on February 02, 2015, 10:01:19 pm
There was a comment made on the different colors being a bad design choice: the pseudo-categories could be defined using borders, ribbon shape, ribbon pattern or something else that has yet to be suggested.
If it's reference to me, I didn't say it's BAD. I said it's discussable. And at least it shouldn't be limited with 5 THAT way. It needs for deeper work, better categorization, perhaps mixing of two different hues somehow. Aesthetically it should look more "pro" so to speak.
And apparently, it wouldn't hurt to get a good artist/designer touch, at least to make templates.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 02, 2015, 10:03:33 pm
<snip> Well the ufopedia has been fully integrated into the mod, so as far as topics go it's a valid one. <snip>

Just curious, is the Legacy version, the only one that has an updated package posted in the OP, and or the Mod site?   And how close is the Nightly?
I'm wrestling with how to support development best using the Alpha-release branch.  I don't have the updated language files over in my game dir, and I was wondering if I need other things there to.   No rush, just curious.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 02, 2015, 10:45:20 pm
If it's reference to me, I didn't say it's BAD. I said it's discussable. And at least it shouldn't be limited with 5 THAT way. It needs for deeper work, better categorization, perhaps mixing of two different hues somehow. Aesthetically it should look more "pro" so to speak.
And apparently, it wouldn't hurt to get a good artist/designer touch, at least to make templates.

You were talking about the contrast of colors being too harsh or something, which sounds like poor color choice ;p I fully agree though, if given more thought something amazing could be made of it.

Just curious, is the Legacy version, the only one that has an updated package posted in the OP, and or the Mod site?   And how close is the Nightly?
I'm wrestling with how to support development best using the Alpha-release branch.  I don't have the updated language files over in my game dir, and I was wondering if I need other things there to.   No rush, just curious.

I would suggest you continue to work on the alpha_release branch, and every now and then I'll port our changes to the ar-legacy branch and put out an update. It really doesn't take a lot of time, but it takes more than 0 time so I am sometimes lazy about it ;p I don't know if right now is a good time to make a new "release" with all the placeholder art, but if you think it's better sooner than later, I'll take some time and update it.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 02, 2015, 10:54:21 pm
Yeah... with the lack of art for the new awards (even at the ribbon level), its prob not the right time for a release.   Also. Started a PR with new ribbons I made yesterday.  I don't really have them allocated for the awards yet, just kind of trying to get something to work with.

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 03, 2015, 04:03:36 am
Shoes;
If I wanted to award for either a kill or a capture, do I just add a second line with status_unconcious?


Code: [Select]
  - type: STR_MEDAL_SECTOPOD_KILL_MEDAL_NAME
    description: STR_SECTOPOD_KILL_MEDAL_DESCRIPTION
    sprite: 34
    criteria:
      killsWithCriteriaCareer: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
    killCriteria:
      -
        1: ["STR_SECTOPOD_TERRORIST", "FACTION_HOSTILE", "STATUS_DEAD"]
        1: ["STR_SECTOPOD_TERRORIST", "FACTION_HOSTILE", "STATUS_UNCONSCIOUS]

Like this?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 03, 2015, 02:32:07 pm
The lines together like that would mean "dead AND unconscious".

Code: [Select]
  - type: STR_MEDAL_SECTOPOD_KILL_MEDAL_NAME
    description: STR_SECTOPOD_KILL_MEDAL_DESCRIPTION
    sprite: 34
    criteria:
      killsWithCriteriaCareer: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
    killCriteria:
      -
        1: ["STR_SECTOPOD_TERRORIST", "FACTION_HOSTILE", "STATUS_DEAD"]
      -
        1: ["STR_SECTOPOD_TERRORIST", "FACTION_HOSTILE", "STATUS_UNCONSCIOUS]
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 03, 2015, 03:02:57 pm
is there a way to more easilly work that logic?  "dead or alive" ... it would still count?

i.e. for our Distinguished Service Medal:
Code: [Select]
  - type: STR_MEDAL_DISTINGUISHED_SERVICE_NAME
    description: STR_MEDAL_DISTINGUISHED_SERVICE_DESCRIPTION
    sprite: 12
    criteria:
      killsWithCriteriaCareer: [1, 5, 10, 10, 10, 10, 15, 15, 15, 15]
    killCriteria:
      -
        1: ["STR_SECTOID", "STR_LIVE_SOLDIER", "FACTION_HOSTILE", "STATUS_DEAD"]
        1: ["STR_FLOATER", "STR_LIVE_SOLDIER", "FACTION_HOSTILE", "STATUS_DEAD"]
        1: ["STR_SNAKEMAN", "STR_LIVE_SOLDIER", "FACTION_HOSTILE", "STATUS_DEAD"]
        1: ["STR_MUTON", "STR_LIVE_SOLDIER", "FACTION_HOSTILE", "STATUS_DEAD"]
        1: ["STR_ETHEREAL", "STR_LIVE_SOLDIER", "FACTION_HOSTILE", "STATUS_DEAD"]

one each of every soldier, dead.  But if I want to say dead or alive, I'd have to add about 25 criteria (5 times 5), is that right?  or can we add a universal status that captures this?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 03, 2015, 04:46:29 pm
Categories and BreakDowns.

I've put together a set of slides with the ribbons and award names to show how many we have of what category

https://docs.google.com/presentation/d/1HrWtmUwEo1nwn-tgo2IH9zvWNU32SV3QV5G5ggXqGnU/edit?usp=sharing
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 03, 2015, 05:37:57 pm
Code: [Select]
  - type: STR_MEDAL_DISTINGUISHED_SERVICE_NAME
    description: STR_MEDAL_DISTINGUISHED_SERVICE_DESCRIPTION
    sprite: 12
    criteria:
      killsWithCriteriaCareer: [1, 5, 10, 10, 10, 10, 15, 15, 15, 15]
    killCriteria:
      -
        1: ["STR_SECTOID", "STR_LIVE_SOLDIER", "FACTION_HOSTILE"]
        1: ["STR_FLOATER", "STR_LIVE_SOLDIER", "FACTION_HOSTILE"]
        1: ["STR_SNAKEMAN", "STR_LIVE_SOLDIER", "FACTION_HOSTILE"]
        1: ["STR_MUTON", "STR_LIVE_SOLDIER", "FACTION_HOSTILE"]
        1: ["STR_ETHEREAL", "STR_LIVE_SOLDIER", "FACTION_HOSTILE"]

By removing the "dead" or "unconscious", both are accepted :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 03, 2015, 05:57:56 pm
Sweet!  That makes a ton of sense! 

So there are some awards that probably could be reworked to allow both, some that obviously should be one or the other. 

i.e. Bolts cross, must capture a live leader. Sectopod, should award for a Kill, as it would possibly be easier to have it unconscious.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 04, 2015, 12:40:55 am
I've tried to fix the "Incendiary kills are impossible to get", but it will still be hard to get. If a victim gets hit by DT_IN ammo, it will be assumed that the shooter will have killed the victim. After that, once victim dies, it goes through the shooter's inventory looking for a weapon that is DT_IN compatible and assumes that is the weapon that killed the victim.

It is not a very smart system, but I think under normal circumstances it will work well.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 04, 2015, 01:05:46 am
Very Nice! Me likes!  Can't wait to try it out again! ;)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 04, 2015, 04:11:45 am
I tweaked the fire-credit code to make it smarter. Before it looked for an incendiary item, now it looks for guns loaded with incendiary rounds, then guns matching incendiary rounds found in the inventory, to finally incendiary grenades or proxy mines. So it should work well for the most part.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 04, 2015, 05:59:46 am
Awesome!  Can't wait to get me some Inferno Stars!

I've got a lot of the Ufopedia text entries done and some of the medals renamed as I go.  Its feeling pretty good.

https://docs.google.com/presentation/d/1Y1jtTAfyD1jLhHmowaGfmmbQG1tDoxXAkSIxgcg4kBQ/edit#slide=id.g623210d7f_056

This is a google docs slide show where I am working on them. 

I did have a question about the categories of the three medic related badges.  Should we add those to the "Wounds" (Purple) category?  Its pretty under populated and they do sort of relate.

I think I'll tweak some of the award level values for some of the medals for better balance.  I'll get those in a PR.

Cheers, Ivan :D

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 04, 2015, 12:37:41 pm
Yeah I think the medic badges would fit best in that category, otherwise there would hardly be anything in there ;p

The document looks good too, I like the names and the look of the new ribbons!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 04, 2015, 03:13:41 pm
Okay, cool.  I'll get those into a PR for the ruleset.  Everyone with the link has comment permissions so feel free to leave a comment in the document if you see a spelling error or have any other comment or suggestion.  I can give edit permissions if you like, but I'd need an e-mail address, which you could PM to me.

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: kikimoristan on February 07, 2015, 07:00:06 am
this does not work for me. It simply makes the game crash in terror missions and the other missions the transport crafts including alien crafts are surrounded by black no terrain.

I am on windows. But I have a mac as well. Currently using openxcom nightly for windows as it's most compatible  with all mods and most stable. The mac version 1 only half the mods work and the nightly for mac doesn't even run.

I have tried nightly build on windows or mac with or without mods nightly and legacy with legacy or nightly openxcom. It never works with any combinations.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 07, 2015, 07:11:30 am
This mod requires a modified .exe.  You are using those from the links in the opening post?  The legacy version is working fine for me.

I am successfully using these other mods as well:

Improved Hand Objects
UpClose Modpack
Commendations Ufopedia
HQ Sounds
Yet More UFO's
Terrain Pack
Incendiary Grenade


Nightly crashes on Terror Missions are due to a change in the map scripting, I believe, and may be an issue with custom map packs.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: kikimoristan on February 07, 2015, 10:47:10 am
The landing missions start all black around the crafts and when exploring my soldiers fly over the terrain as the terrain is in fact void space (ie no terrain). This is with legacy version. I can still play like this most ufo crash missions but with terror missions the voids black terrain crashes the game.

I got a couple of mods loaded but mods is not the issue. I tried it without mods and fresh install still does this. This custom executable is the only way to get black void space around crafts and terror mission crashes.

I n other words I have been unable to make this mod work ever. T_T

Note I say black void space around crafts because UFOs also have this voidspace around them just as XCOM crafts do. I assume any map like objects added to the map has black space around it.  Seems to me like this executable changes the way craft is applied on a map from vanilla OpenXCom executable. As any version of OpenXCom never does this and no other mod out there does this.  Except one . Thunder replacement for Lighting adds 8 black squares around the craft around the roof but is not walkable terrain is just visual artifact error.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 07, 2015, 12:53:26 pm
The nightly is under going some pretty heavy changes, and I have not been keeping up with them unfortunately. If you're able to download a nightly that's roughly as old as my .exe, then things would work.

I will try and put another build out tonight. If you install the mod half way through an already started game, you won't run into any problems except not having stats for the first part of your campaign.

Alternatively, you can play the milestone/legacy version until I do update the nightly, and then update your game and the mod at the same time.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 07, 2015, 08:35:53 pm
Some of the new UFOPedia Entries for the New Medals.

(https://i.imgur.com/EbCpT5z.png) (https://i.imgur.com/Mac3ItX.png) (https://i.imgur.com/oWRaJxM.png)

Still need to work on the art for the medals for the rest.  Most ribbons have been created and most UFOpedia text strings as well.

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Goldy on February 07, 2015, 11:05:39 pm
Hi,

I have an interesting problem with this mod. Every screen works, all statistics work, but commendations behave strangely - whenever there is a chance for someone to get a commendation, all of the operatives get all of possible ones (if not all, I haven't been keeping exact notes). I wasn't sure at the start, but when I realized, that all of my soldiers have a medal, that should be awarded "posthumously", I knew, something is wrong. I've finished one playthrough, disregarding this problem, but when it occured again, I've decided to ask about it.

There is also a "{o}" symbol included in some of the commendation names, where a specific name of race/weapon should be.

I may have made a mistake, when installing this mod. I tried to follow the (not-so-difficult) instructions steb-by-step, but I know myself -.- Is there any advice, you could possibly give me? Thanks in advance.

And on the sidenote - this mod is wonderful, I mean both of its parts (commenadions and ufopedia entries), even if it does not work properly for me. Thank you for your work :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 07, 2015, 11:19:42 pm
@goldy: what language are you using?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 07, 2015, 11:20:57 pm
@goldy: Are you using the 1.0 Legacy version or the nightly? The {0} appearing in front of some commendations means that the commendations are being awarded when they should not be ;p as you probably guessed from living soldiers getting the Order of the Fallen.

You can enable debug mode with ctrl + d, and I think I set ctrl + c as a way to clear all the commendations from all the soldiers. It does not affect stats, so the next mission / end of the month you soldiers would get them all back. Try that out and see if all your soldiers get a butt load of commendations the next debriefing.

If they do get a bunch of them again, all I can advise is that you try to follow the steps a second time? :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Goldy on February 08, 2015, 10:18:16 am
Shoes: I am using 1.0 legacy version. I tried the debug mode and the problem persisted (they got "a butt load"), so I decided to reinstall the mod again - for this purpose, I downloaded the Legacy version from the first post of this thread (which seems to be newer, than the one I had, with ufopedia entries integrated), I followed the three simple steps again and this time I even cannot get this mod running :( Whenever I try to activate it in the mods menu, I get the "yaml-cpp: error at line 942, column 6: end of map not found" error.

ivandogovich: Am I too obvious as a non-native speaker? XD Nevertheless, I use english (US, I had UK english set before, but some mods have problems with it), only occasionally switching to czech for the purpose of translating some mods. My problem with commendations persists in both, UK and US setting.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 08, 2015, 03:04:47 pm
ivandogovich: Am I too obvious as a non-native speaker? XD Nevertheless, I use english (US, I had UK english set before, but some mods have problems with it), only occasionally switching to czech for the purpose of translating some mods. My problem with commendations persists in both, UK and US setting.

LOL.  No, your English is impeccable.  I was just wondering if some of this could have been from using another language file. ;)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 08, 2015, 05:30:15 pm
Goldy, I've updated the 1.0 version of the mod: give it a try. If you're getting "all" the commendations, it could be a problem with the ruleset; either it's in the wrong spot, or was wrongly edited. If you're seeing "STR_MEDAL_MERIT_CROSS_NAME" instead of "Merit Cross", that also indicates a ruleset problem.

edit: Oh yeah, the updated 1.0 also means the nightly has been updated :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Goldy on February 08, 2015, 10:24:11 pm
Shoes: I think my problems are adding up. I downloaded the upgraded version of commendations and now I am not even able to start a new game to test it. When the problem occured for the first time, it also somehow messed up Hobbes's terrain pack (no idea how and why), which I finally got to work just yesterday  ;D  I then decided to start from scratch and make a completely new install of the game, but even then the problem persists. The game starts all right, I can set up mods (I only copied commendations this time, so I can test it and then probably add others), but when I want to start new campaign, it crashes to desktop.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: kikimoristan on February 09, 2015, 01:59:51 am
I have tried the new nightly build and it works! FINALLY. The first time I have been able to use this mod. I will let you know any bugs I find.

edit: Thank you! :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 09, 2015, 02:31:38 am
I have tried the new nightly build and it works! FINALLY. The first time I have been able to use this mod. I will let you know any bugs I find.

edit: Thank you! :D

Please let me know how it goes!  I'm considering moving there myself!  ~ Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: kikimoristan on February 09, 2015, 03:23:17 am
Please let me know how it goes!  I'm considering moving there myself!  ~ Cheers, Ivan :D

First I backed up all my files in case I get the dreaded black void around ship crashing bug. I installed. I did a couple of quick battles of various types of aliens and various type ships including MiB ships/aliens. No black terrain everything works as intended and no crashes. I started a new mission and checke all the ufopedia entries and even clicked randomly from ufopedia list commndations on random awards see if it works that way. I checked soldier records clicked around randomly . Off the bat I noticed they all have a first mission award so I knew it is working.  Then went to do a terror mission. No black void no crash (usually around here would crash). Walked around a bit and abandoned the mission left one guy behind. Checked records again the mission shows up as terrible. So i know the record does workl.  So far . Perfect! YES.

I did notice that there are about 20 or so placeholder WIP medals starting with David or Paris and some question marks ? Which is fine I don't mind that. I noticed there is (or likely will be) a medal about being left behind that did not show up on my soldier I left behind from my terror mission. But the incomplete WIP doesn't bother me again. Im happy it finally works.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 09, 2015, 03:27:53 am
Great report! Thanks! 

Yeah, I still have a bunch of graphics to make for the rest of the UFOpedias.  There are some wrong punctuations causing the ?Order of David? etc funny issues.  Still have to make a real ribbon for the MIA award too. etc, as the new awards are being incorporated by shoes almost faster than I can keep up. :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 09, 2015, 03:29:24 am
Great report! Thanks! 

Yeah, I still have a bunch of graphics to make for the rest of the UFOpedias.  There are some wrong punctuations causing the ?Order of David? etc funny issues.  Still have to make a real ribbon for the MIA award too. etc, as the new awards are being incorporated by shoes almost faster than I can keep up. :)

The work definitely comes in bursts ;p and I can get so much more done when I have someone doing all the art!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 09, 2015, 03:40:53 am
;)

and... just tried installing the nightly, by copying in and merging the directories...  on top of the old legacy build ... yeah, it no work (crash on launch).  I'll try a fresh install with a nightly, then dropping the soldier diary nightly on top of it.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 09, 2015, 05:52:04 am
Ok.  I know I'm messing something up.

I bumped back to a clean install of the current nightly (2015-02-08 22:08).   Tested it in new battle.  Fine but for the Lightning I was driving, not having a door that opened (just a wall at the top of the ramp I could walk through).  No worries.

Copied over Soldier Diaries Nightly files over it.   Launched it. Newbattle fine (didn't finish)

However, whenever I try to load a current save, I get an the :"Load Failed:  yaml-ccp error: at line 0, column 0: bad conversion " error message.  This is will all mods off, even commendations. :(

I can load a save from the very beginning of my campaign, where none of the soldiers have combat experience, but nothing newer.

Is there something that changes with the save files ??
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 09, 2015, 12:33:02 pm
I thought that it was possible to start using this mod in the middle of a game.. but I've never tried it. I'll see if I can find time to look into it.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 09, 2015, 03:19:53 pm
I ran into the same issue with the new Legacy build.  Its fine for new battles or very early saves, but it won't load any of the late (recent saves).

Fortunately my backup is working fine.  So I may just keep moving forward with a stale build.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 09, 2015, 04:24:37 pm
Thanks for the info. I have a feeling the mod is trying to load something that mod-less saves simply don't have. It's interesting that it's still able to play very early saves... do the early saves have at least one mission?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 09, 2015, 04:44:36 pm
I can join an early mission in progress, but no saves after that.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Neo23 on February 09, 2015, 08:36:48 pm
I've been waiting since last year for a new nightly to try this out and now it is finally here.
The waiting was worth it. It is as good as expected and I actually never want to miss this
Mod in my setup again. Great work done Shoes and Ivan (also thank you for the improved HandOB Mod too)!

I created a german translation for you to use. Feel free to add it if you like.
The attached file is copy & paste ready.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 09, 2015, 10:50:13 pm
I am glad you like it! Any feedback is always appreciated.

Also, I will totally be adding your German translation to the mod, thank you!

edit: Ivan, I tried to recreate a failure to load, but I didn't manage. I tried debugging myself a few wins, passed a month, and was still able to load it all. Could you send me a save that doesn't load?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 10, 2015, 07:03:37 am
Okay. Went back the nightly builds and tried rolling back a couple.  I chose one from 2015 02 02.  Merged it into my nightly folder overwriting as I went.  Merged in the Soldier Diaries Nightly build as well.

Loaded early save, it worked like before.  Loaded the next one that normally failed, and Behold!  It loads!  Woot.  Ok, lets try my current save: Crash to Desktop, but thats ok.  The LOG is griping that the terrain doesn't exist!  All I have to do is renable my mods, and (crosses fingers), I should be good to go!

I honestly don't know if it was the 02 08 build, or just me messing up.  Probably the latter, because I couldn't get the new legacy to work either. XD


Derp.  Just the vanilla nightly build loads fine, but the soldier diaries executable doesn't work right.  still having problems with it.   

Edit: Sup's Nightly is like 7 MB, and the Diaries Nightly is 2.9.  Is that because the .dll's are included in Sups?

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 10, 2015, 03:34:32 pm
New award Idea:
"Globetrotter Award" - Given to soldiers who participate in missions in every region of the globe. 
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 10, 2015, 05:26:39 pm
Edit: Sup's Nightly is like 7 MB, and the Diaries Nightly is 2.9.  Is that because the .dll's are included in Sups?

I think so. Also, his .exe displays the actual git commit, whereas mine still says 1.0. Not sure why that is.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Goldy on February 10, 2015, 06:30:09 pm
Any idea, why does my game keep crashing to the desktop when starting a new campaign? I have already tried to reinstall it twice and I do not know, where the problem is - according to what I read here, it should work :(
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 10, 2015, 06:42:21 pm
Have you been able to play the game without any mods? Also, what operating system are you using?

The Legacy 1.0 version will only work with the milestone release of OpenXcom, whereas the nightly should work with the latest nightly (sometimes the nightlies change in a big way, so sometimes the latest nightly does not in fact work... something I need to take care of).

If you have the correct version of the mod with the correct version of the game, then I would ask that you make sure the .dlls are in the same directory as the .exe. If this is all right, then I am not sure what would be causing a crash. Is there a log anywhere that tells you why it is crashing?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 10, 2015, 06:49:32 pm
edit: Ivan, I tried to recreate a failure to load, but I didn't manage. I tried debugging myself a few wins, passed a month, and was still able to load it all. Could you send me a save that doesn't load?

I've attached a .zip with some saves. 
Episode1.sav is the beginning of the campaign before any combat and it works fine.  Ep001 Tactical.sav is in the beginning of the first tactical battle.
002.sav is a post battle save that refuses to load.  No crash, just the yaml.ccp error.

Its weird that the vanilla nightly will run these, but the Diaries nightly doesn't. :?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Goldy on February 10, 2015, 07:04:00 pm
I have 1.0 version of OpenXcom (I haven't tried any nightly yet, to tell the truth) and I have downloaded the 2015-02-08 Legacy version of Commendations. There are no other mods - I install the game (I've just done it one more time to make sure, I am not missing something obvious - I don't think that I do, which makes even more probable :P) and it works, I open the Legacy archive and copy the content to the game directory and when I run the game, I can't start a new campaign. It doesn't matter if the mod is activated or not, when I try it, the game crashes to desktop.

My operating system is Windows 7 a everything worked quite well (apart from the obvious problems, when the commendations weren't behaving like they should), up until now. And there si no log anywhere unfortunately :( Only typical Windows message, that "the program stopped working".
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 10, 2015, 07:11:02 pm
There is an OpenXcom.log file in your user directory.  This might be under the My Documents folder.

https://www.ufopaedia.org/index.php?title=Installing_(OpenXcom)#Data_Folder
https://www.ufopaedia.org/index.php?title=Installing_(OpenXcom)#Log_file

Unfortunately, its not overly verbose, so it may not help. 

Also, I haven't tried the combination you are trying.  Mine is an older build, that seems to be working but doesn't have features for the new awards.

Edit:  I think this is the one I am using: https://dl.dropboxusercontent.com/u/234369005/OXC/07182014%20Legacy%20Debug.zip
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Goldy on February 10, 2015, 07:28:48 pm
There is an OpenXcom.log file in your user directory.  This might be under the My Documents folder.
Thank you for the directions. There is even some kind of logfile in the game directory, but both of them are sadly not very helpful :(

Edit:  I think this is the one I am using: https://dl.dropboxusercontent.com/u/234369005/OXC/07182014%20Legacy%20Debug.zip

Yes, that version solves my problem - it does both: doesn't crash the game a gives away commendations the way it should. Thank you :)

It doesn't answer the question "why the hell is not the newer version working?", but now I can stop complaining about it ;)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 10, 2015, 08:28:38 pm
I'll do some more legacy testing when I get home from work. In all honesty, I may have neglected to test the Legacy! :x
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Goldy on February 12, 2015, 12:05:58 am
OK, me again.

There is a bug somewhere in the version ivandogovich provided (07182014 Legacy debug), that I can't pinpoint exactly. I was just finnishing a terror mission - I killed last alien and was ready for debrifieng, clicked "enemy turn" and the game crashed. To make sure, that it was not a random occurence, I tried previous saves and different combinations and no, there was no way to get out of the mission without a crash. I have read about similar bugs before, so I deactivated commendations for a while and voila, no problem. Finished the game, activated commendations and so far nothing.

Unfortunately, I am unable to point at an exact culprit - I have no idea, what could have caused it.

And on a more positive note - I extremely happy with this mod, now that it works (more or less). It's really wonderful. Thank you both :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 12, 2015, 12:35:49 am
I had a bug similar to that, which resulted from what we call "goomba stomping." This occurs if an enemy or civilian walk off a roof or higher level and land one of your units. 

After troubleshooting this with Shoes, I think he has fixed the code, but I don't think its in that version. 

Also, I have not run into that scenario any more because I have the "sneaky AI" option turned on.  Somehow this changes the "lets just charge off the roof toward that big plane over there" logic, and they haven't done it again in 84 episodes worth of game play.

Cheers, Ivan :D



Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 12, 2015, 01:35:07 am
Also, I have not run into that scenario any more because I have the "sneaky AI" option turned on.  Somehow this changes the "lets just charge off the roof toward that big plane over there" logic, and they haven't done it again in 84 episodes worth of game play.

I was wondering how it was even remotely probable that one alien would land on another!!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: kikimoristan on February 12, 2015, 04:40:03 am
Hey shoes.
Is it possible to compile 1 single executable instead of many little files?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 12, 2015, 06:54:59 am
Latest Ufopedia entries and Art:

(https://i.imgur.com/MYtV5gI.png) (https://i.imgur.com/PFKJP36.png) (https://i.imgur.com/vDH9Ssz.png) (https://i.imgur.com/WAYTVoz.png) (https://i.imgur.com/mTsJXtF.png)

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: kikimoristan on February 12, 2015, 07:43:57 am
New award Idea:
"Globetrotter Award" - Given to soldiers who participate in missions in every region of the globe.

I support this one.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Goldy on February 12, 2015, 11:04:06 am
Hm, so it seems, that temporary deactivation of the commendations didn't solve my problem. Because when I activate them, the game crashes at the next point, when it tries to give some awards -.-

Could this be caused by the "goomba stomping" bug (where does the term comes form anyway? XD ) and is there any way to circumviate it completely, other than deactivating commendations again.

Btw, nice artwork - the best of rank medal looks really great.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 12, 2015, 01:09:31 pm
Assuming a goomba stomp (inspired by the mario games) did happen, that means there is a stat for a stunned alien that is being misattributed. If you go through your save file, you might be able to find out who is being credited with the stun (there might be gibberish saved? I really don't know) and you might be able to remove that credit. That's the only way I can think of doing it ;p
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on February 12, 2015, 01:38:07 pm
"Pointy-Eared Person" - for those who max all stats. :P

More seriously, possibly individual medals for those who maxed out a single stat? Or is it already in?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Goldy on February 12, 2015, 02:13:36 pm
Assuming a goomba stomp (inspired by the mario games) did happen, that means there is a stat for a stunned alien that is being misattributed. If you go through your save file, you might be able to find out who is being credited with the stun (there might be gibberish saved? I really don't know) and you might be able to remove that credit. That's the only way I can think of doing it ;p

I thought of the same thing before, problem is that I have no idea what to look for in the save file. It's as if someone wanted me to stop playing and start doing some real work -.-
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 12, 2015, 02:55:36 pm
Hmmm...

If I remember, the goomba stomp bug... I think I had to go back to a geoscape save from before the mission to continue the campaign. :(

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 12, 2015, 04:00:32 pm
Two more awards:
(https://i.imgur.com/mC2T3WA.png) (https://i.imgur.com/MQpACe0.png)

(and yeah, huge props to Luke83) ;)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on February 12, 2015, 04:12:30 pm
The variety of awards is really impressive! Well done guys. I really need to get around to playing with this.

(btw, the apostrophes in the "Enfilade Citation" comes off as ?)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 12, 2015, 04:17:42 pm
"Pointy-Eared Person" - for those who max all stats. :P

More seriously, possibly individual medals for those who maxed out a single stat? Or is it already in?

Easy to add; at the moment I am tracking stat increases, so it's not a big leap to track absolute stat value.

I thought of the same thing before, problem is that I have no idea what to look for in the save file. It's as if someone wanted me to stop playing and start doing some real work -.-

Yeah, the work is pretty fruitless since the bug is supposed to have been fixed in the latest versions too ;p So the game only crashes during the end of a mission, correct? If you load the save file and look for something about "Battle Units" or "UnitStatistics", you can delete all of those stats. What will happen is no one will get credited for any kills on that mission, but it should also stop the crash.

The variety of awards is really impressive! Well done guys. I really need to get around to playing with this.

Thanks :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on February 12, 2015, 04:48:35 pm
Easy to add; at the moment I am tracking stat increases, so it's not a big leap to track absolute stat value.

Would it still work properly if the stat was changed by a mod?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 12, 2015, 06:48:02 pm
I would probably use the ruleset that fetches the "max" a stat can attain, so as long as the mod only touched that and did not increase stats some other way it would work.

A lot of these commendations are indeed mod friendly!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Goldy on February 12, 2015, 10:41:53 pm
Ok, I went through older saves of the same terror mission and I was able to pointout the moment, when the problems start. One moment, I can finnish the mission without any crash and then, when I shoot down a cyberdisc, it blows up and takes with it a civilian and an alien (sectoid soldier). And then, every time I try to end the mission, game crashes.

I've been experimenting with the saves, but so far no success.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 12, 2015, 11:36:51 pm
I am not sure how deep I want to go into bug fixing an outdated version of the mod ;p I would rather try and fix the reason you're not able to play the old one.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Goldy on February 13, 2015, 12:07:19 am
I am not sure how deep I want to go into bug fixing an outdated version of the mod ;p I would rather try and fix the reason you're not able to play the old one.

I am not suggesting fixing this version. I have cimcurvented the problem by replaying the mission, so no harm here. I was just happy, that I found the root of the crash and wanted to point out the bug, to know, if it is known and possibly fixed in newer versions, or if it is some odd coincidence ;) When I become enthusiastic about something, I tend to spam a bit, sorry :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 13, 2015, 12:31:33 am
No worries ;p I did do some work with cyberdisc deaths so that must be pre-that.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 13, 2015, 12:49:23 am
:(  I'd really like to get on the Nightly... but I can't figure anything out about why those campaign saves won't load.  Shoot. Even the updated Legacy, because it would be nice to check the logic on the some of the new awards.

Also.  After completing my first mission since the new commendations are in the ruleset, I did get a rash of erroneous awards.

All of them were the ones that have multiple criteria:

- Armis Potens (all battle types),
- Taking Names (all ranks)

Code: [Select]
  - type: STR_MEDAL_ALLBATTLETYPES_NAME
    description: STR_MEDAL_ALLBATTLETYPES_DESCRIPTION
    sprite: 40
    criteria:
      killsWithCriteriaCareer: [1, 2, 3, 4, 5, 6, 7, 8, 8, 9]
    killCriteria:
      -
        1: ["BT_FIREARM", "FACTION_HOSTILE", "STATUS_DEAD"]
        1: ["BT_MELEE", "FACTION_HOSTILE", "STATUS_UNCONSCIOUS"]
        1: ["BT_PROXIMITYGRENADE", "FACTION_HOSTILE", "STATUS_DEAD"]
        1: ["BT_GRENADE", "FACTION_HOSTILE", "STATUS_DEAD"]

  - type: STR_MEDAL_ALLRANKS_NAME
    description: STR_MEDAL_ALLRANKS_DESCRIPTION
    sprite: 42
    criteria:
      killsWithCriteriaCareer: [1, 2, 3, 3, 3, 3, 4, 4, 4, 4]
    killCriteria:
      -
        1: ["STR_LIVE_SOLDIER", "FACTION_HOSTILE", "STATUS_DEAD"]
        1: ["STR_LIVE_ENGINEER", "FACTION_HOSTILE", "STATUS_DEAD"]
        1: ["STR_LIVE_MEDIC", "FACTION_HOSTILE", "STATUS_DEAD"]
        1: ["STR_LIVE_NAVIGATOR", "FACTION_HOSTILE", "STATUS_DEAD"]
        1: ["STR_LIVE_LEADER", "FACTION_HOSTILE", "STATUS_DEAD"]
        1: ["STR_LIVE_COMMANDER", "FACTION_HOSTILE", "STATUS_DEAD"]
        1: ["STR_LIVE_TERRORIST", "FACTION_HOSTILE", "STATUS_DEAD"]

Could I be running into that same array error that you found a while ago?
https://openxcom.org/forum/index.php/topic,1718.msg34086.html#msg34086

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 13, 2015, 04:12:53 am
Newest UFOPedia Art.  (Almost Done!  :o )


(https://i.imgur.com/WsR053p.png) (https://i.imgur.com/f1VG5a1.png) (https://i.imgur.com/sogvZXh.png)

Edit: Wasn't happy with the field surgeon so I re-worked it:
(https://i.imgur.com/3ORmo5K.png)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: endersblade on February 13, 2015, 07:37:30 am
On a whim I installed this mod from the Steam Workshop last night, oh man, I'm in love with this lol.  Such an amazing job, and the detail it goes into is great!  Favorite weapon, number of types killed, so many stats <3
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 13, 2015, 07:39:45 am
Can you provide a link from the Steam workshop?  I didn't even know there was anything out there for OpenXcom!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: vlad on February 13, 2015, 09:08:13 am
given the game is played in 1999, citing Obama from 2009 seems kinda extraterrestrial :o (remove the year ?)
also typo at didn't - didn?t at the very same medal
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 13, 2015, 01:12:00 pm
:(  I'd really like to get on the Nightly... but I can't figure anything out about why those campaign saves won't load.  Shoot. Even the updated Legacy, because it would be nice to check the logic on the some of the new awards.

Also.  After completing my first mission since the new commendations are in the ruleset, I did get a rash of erroneous awards.


Don't forget that the stats for those new medals were already being tracked, so if your soldiers had already killed one of each rank or one with each weapon, then they would rightfully suddenly all get the commendation.

As for the not loading thing, I need to sit down and have a look at that. So to be clear, the issue is that games, legacy or nightly, with commendations mod pre-Feb-08 cannot be loaded with the Feb-08 mod, correct?

On a whim I installed this mod from the Steam Workshop last night, oh man, I'm in love with this lol.  Such an amazing job, and the detail it goes into is great!  Favorite weapon, number of types killed, so many stats <3

Great to hear! I am also curious to see the steam workshop link ;p
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 13, 2015, 07:59:45 pm
given the game is played in 1999, citing Obama from 2009 seems kinda extraterrestrial :o (remove the year ?)
also typo at didn't - didn?t at the very same medal

Yeah, when I copy and paste often apostrophes and quotes insert in the wrong format.  I clean them up with a find and replace. :)  They'll be fixed when the new ruleset gets published. :)

And yeah.. time travel and all that... the quotes are really for fluff anyway, ;)

Also... I really don't like the black wings on the Field Surgeon medal. I'll be reworking that one.

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 13, 2015, 08:04:56 pm
Don't forget that the stats for those new medals were already being tracked, so if your soldiers had already killed one of each rank or one with each weapon, then they would rightfully suddenly all get the commendation.

As for the not loading thing, I need to sit down and have a look at that. So to be clear, the issue is that games, legacy or nightly, with commendations mod pre-Feb-08 cannot be loaded with the Feb-08 mod, correct?

I keep meaning to upload the save with the erroneous medals... I'll get that this weekend.

As far as the not loading:

My old (and newer, for that matter) campaign saves are from an old legacy version.  I'm not sure if it is from July or October.

I tried loading it in both the New Nightly build, and the new Legacy build.  Both times it refused to load with the yaml.ccp error.
When I tried loading it with a vanilla nightly, it loaded alright, just commendations didn't work etc.  I didn't test any more than to see that the save loaded.

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 13, 2015, 08:21:53 pm
Were you able to load a Geoscape save, a Battlescape save, or neither?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 13, 2015, 08:29:42 pm
With the new Diaries builds, I could load saves up to and during my first tactical mission. 
After that mission is over, any save fails to load. 

With the vanilla nightly, I tried loading the first Geoscape save after the first mission (it loaded successfully).

(I included these saves linked to an earlier post.)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 14, 2015, 07:15:36 am
Woot!  Here is the Last Batch

(https://i.imgur.com/2k8IhEi.png) (https://i.imgur.com/koL9TLQ.png)
(https://i.imgur.com/QbBjduE.png) (https://i.imgur.com/2MKCizo.png)
(https://i.imgur.com/VXecrbs.png)

Shoes, The Pull Request should be final.    All the little punctuation has been ironed out and the ruleset looks good to go. :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: kikimoristan on February 14, 2015, 07:27:24 am
These guys are busy bees.

Once everything is ironed out plz make a pull request to SupSuper/Warboy MAYBE they gonna merge this mod with main branch.  MAYBE? I think is very useful feature to have. Keeping track of your soldiers. These are xcom achievements and challenges if you think about it. People have proof/something to boast about in screen pics and videos. And this mod is completely side thing doesn't even matter if you don't wanna use it feature is there. And doesn't change anything from original game. Only adds stat tracking for soldiers.

Gj guys. Looking good.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 14, 2015, 07:43:44 am
Hmm... Shoes... Could the save not loading come from using a stock version of the .exe rather than the "debug" version (that I might have used in the past) ?

(Still trying to sort out my inability to load my saves with the new builds).
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 14, 2015, 02:27:33 pm
These guys are busy bees.

Once everything is ironed out plz make a pull request to SupSuper/Warboy MAYBE they gonna merge this mod with main branch.  MAYBE? I think is very useful feature to have. Keeping track of your soldiers. These are xcom achievements and challenges if you think about it. People have proof/something to boast about in screen pics and videos. And this mod is completely side thing doesn't even matter if you don't wanna use it feature is there. And doesn't change anything from original game. Only adds stat tracking for soldiers.

Gj guys. Looking good.

Thanks! The devs have told me that the stat tracking portion of the mod would indeed be viable for making it into the base game, and then the comms mod could be packaged with it by default. Neither of us are in a rush to get it merged though; they're busy with TFTD, I am still trying to cram as much stuff into it and fix any bugs that creep up.

Hmm... Shoes... Could the save not loading come from using a stock version of the .exe rather than the "debug" version (that I might have used in the past) ?

(Still trying to sort out my inability to load my saves with the new builds).

I don't think so.. I am gonna investigate a bit this morning.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 14, 2015, 04:54:07 pm
Ok... erroneous award thing.

Here is my latest save. Only soldiers on the mission got the erroneous awards. Not all of them did.

Taking Names (All Ranks) (soldier, engineer, medic, navigator, leader, commander, terrorist)
Code: [Select]
  - type: STR_MEDAL_ALLRANKS_NAME
    description: STR_MEDAL_ALLRANKS_DESCRIPTION
    sprite: 42
    criteria:
      killsWithCriteriaCareer: [1, 2, 3, 3, 3, 3, 4, 4, 4, 4]
    killCriteria:
      -
        1: ["STR_LIVE_SOLDIER", "FACTION_HOSTILE"]
        1: ["STR_LIVE_ENGINEER", "FACTION_HOSTILE"]
        1: ["STR_LIVE_MEDIC", "FACTION_HOSTILE"]
        1: ["STR_LIVE_NAVIGATOR", "FACTION_HOSTILE"]
        1: ["STR_LIVE_LEADER", "FACTION_HOSTILE"]
        1: ["STR_LIVE_COMMANDER", "FACTION_HOSTILE"]
        1: ["STR_LIVE_TERRORIST", "FACTION_HOSTILE"]

Armis Potens (All Battle Types - needs firearm, melee, grenade, & proximity grenade)
Here is the Ruleset Logic:
Code: [Select]
  - type: STR_MEDAL_ALLBATTLETYPES_NAME
    description: STR_MEDAL_ALLBATTLETYPES_DESCRIPTION
    sprite: 40
    criteria:
      killsWithCriteriaCareer: [1, 2, 3, 4, 5, 6, 7, 8, 8, 9]
    killCriteria:
      -
        1: ["BT_FIREARM", "FACTION_HOSTILE", "STATUS_DEAD"]
        1: ["BT_MELEE", "FACTION_HOSTILE", "STATUS_UNCONSCIOUS"]
        1: ["BT_PROXIMITYGRENADE", "FACTION_HOSTILE", "STATUS_DEAD"]
        1: ["BT_GRENADE", "FACTION_HOSTILE", "STATUS_DEAD"]

Here is the kill record of a soldier record of one who got both erroneously:

        id: 40
        name: MilksterProd.

Code: [Select]
          killList:
            - rank: STR_LIVE_NAVIGATOR
              race: STR_SECTOID
              weapon: STR_PISTOL
              weaponAmmo: STR_PISTOL_CLIP
              status: 6
              faction: 1
              mission: 10
              turn: 3006
            - rank: STR_LIVE_ENGINEER
              race: STR_SECTOID
              weapon: STR_PISTOL
              weaponAmmo: STR_PISTOL_CLIP
              status: 6
              faction: 1
              mission: 32
              turn: 9633
            - rank: STR_LIVE_SOLDIER
              race: STR_MUTON
              weapon: STR_FLASHBANG_GRENADE
              weaponAmmo: STR_FLASHBANG_GRENADE
              status: 7
              faction: 1
              mission: 35
              turn: 10515
            - rank: STR_LIVE_NAVIGATOR
              race: STR_MUTON
              weapon: STR_LASER_PISTOL
              weaponAmmo: STR_LASER_PISTOL
              status: 7
              faction: 1
              mission: 35
              turn: 10524
            - rank: STR_LIVE_ENGINEER
              race: STR_MUTON
              weapon: STR_HIGH_EXPLOSIVE
              weaponAmmo: STR_HIGH_EXPLOSIVE
              status: 6
              faction: 1
              mission: 35
              turn: 10563
            - rank: STR_LIVE_SOLDIER
              race: STR_SNAKEMAN
              weapon: STR_BLASTERPACK
              weaponAmmo: STR_BLASTERPACK
              status: 6
              faction: 1
              mission: 46
              turn: 13833
            - rank: STR_LIVE_SOLDIER
              race: STR_SNAKEMAN
              weapon: STR_BLASTERPACK
              weaponAmmo: STR_BLASTERPACK
              status: 6
              faction: 1
              mission: 46
              turn: 13833
            - rank: STR_LIVE_COMMANDER
              race: STR_SNAKEMAN
              weapon: STR_BLASTERPACK
              weaponAmmo: STR_BLASTERPACK
              status: 6
              faction: 1
              mission: 46
              turn: 13833
            - rank: STR_LIVE_TERRORIST
              race: STR_CHRYSSALID
              weapon: STR_BLASTERPACK
              weaponAmmo: STR_BLASTERPACK
              status: 6
              faction: 1
              mission: 46
              turn: 13833

Analysis:
AllRanks is missing a medic and a leader, and AllBattleTypes is missing melee and Proximity.
There are five other soldiers with erroneous AllBattleTypes (ids; 102, 106, 99, 66, 63).  No other ones with the erroneous AllRanks.
One correctly awarded the AllBattleType: Xenophage2 (id: 82).


I've attached the entire save as a zip file below.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 15, 2015, 02:34:50 am
After discussing with Volutar some of the difficullties of getting a background gradient that looks decent, I have been working on a new style that uses the pattern gradient that he discussed and is more in line with classic XCOM style (look&feel).  I have taken the gradients that he mocked up and moved them over so they are only a background to the medals. 

(https://i.imgur.com/GDRXQjv.png)
(https://i.imgur.com/zJZIkBO.png)
(https://i.imgur.com/EmGBlLR.png)
(https://i.imgur.com/GgYU9Dd.png)
(https://i.imgur.com/36zpVMA.png)

I am willing to rework all the art if necessary to get a better look and feel.  This isn't a huge job, as its basically swapping out the background layer.  Some of the older art needs some love too.

Thoughts, everyone?  How do you like these in comparison to the images previously posted in the thread?
(Again, Shoes has the last word. ;)  )

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Mr. Quiet on February 15, 2015, 02:45:59 am
Amazing job with this pictures, I don't need anything too fancy to grab this mod. I only have one or two requests: I'd love to have a version without the quotes and the second part. Just the requirement is fine. Thanks mate.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 15, 2015, 03:06:56 am
Amazing job with this pictures, I don't need anything too fancy to grab this mod. I only have one or two requests: I'd love to have a version without the quotes and the second part. Just the requirement is fine. Thanks mate.

LOL.  Sorry, my friend.  You are stuck with the "fluff"

You are always welcome to edit the ruleset and clear out all the extra stuff in the ufopedia entries. ;)

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Mr. Quiet on February 15, 2015, 03:19:14 am
Thanks, I shall if it's as easy as you stated. Great work nonetheless both you and Shoes.

One thing I've always been wanting is adding a simple, but immersive message after the debriefing screen or within it, specifying a ceremony in base after a certain time and date. Nothing more. If I didn't forget the memorable quotes by my favorite mod on Freespace 2, Wing Commander Saga, I'd give you the one from a debriefing that mentioned the same thing. Little pieces of dialog that go a long way.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: volutar on February 15, 2015, 06:15:20 am
From my point of view they feel somehow more completed. It's feels like obvious progress. But I'm sure about red ribbons over red gradient. They are too close, I think.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 15, 2015, 06:36:01 am
From my point of view they feel somehow more completed. It's feels like obvious progress. But I'm sure about red ribbons over red gradient. They are too close, I think.

Yeah, fortunately, there isn't as much red on red with the other "Awesome" Category medals.  There are a couple ways to mitigate it a little more, that I was already considering:  better shadows, and a glow around the ribbon.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: kikimoristan on February 15, 2015, 06:49:47 am
the quotes are kinda funny but othewise looking good.

About the background I kinda like it both ways. Second way is a bit nicer I guess.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: volutar on February 15, 2015, 07:19:57 am
Yeah, fortunately, there isn't as much red on red with the other "Awesome" Category medals.  There are a couple ways to mitigate it a little more, that I was already considering:  better shadows, and a glow around the ribbon.
Glow? I guess better shadows around ribbon would look more xcomish. I didn't see any glow in xcom style concept. Maybe make falloff gradient from the sides to the center toward ribbon/medal?

P.S. Some of medals seems to be ovelapping the border, perhaps it'd be better to move them slightly higher?
Seeing on the PC (previously i've looked on a phone screen) - they seem better. Even red.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 15, 2015, 02:57:39 pm
I feel the addition of the X-COM at the top really seals the deal. I like it!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 15, 2015, 03:54:30 pm
Allright.  One more consideration, before I start re-mastering all of these. :)

I play the game with 1/2 resolution on the Geoscape as it feels best for gameplay for me.  As such the UFOPedia Entries don't fill the screen.  The new gradient box floats in a sea of black and sometimes feels a little too high?... idk... It just doesn't feel tied in at other resolutions.

(https://i.imgur.com/9jEAJws.png)

I'm considering adding a Border to frame the whole entry, and this is quite similar to other UFOpedia entries.

(https://i.imgur.com/nm82Nge.png)

So:  Border? or No Border?

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Neo23 on February 15, 2015, 04:33:00 pm
I would say go for the border version. I use 2x resolution and think this looks actually a lot better than the first original version.
Maybe consider a background for the text box too? But black is fine too. As Volutar said, it is very close to the original X-Com style.
The medal is also easier to see with the edges.

When you're done, is there an update or a new full version released (recent nightly includes some nice bug fixes)?
I will update my german translation to the now complete Ufopedia when it comes out.

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 15, 2015, 04:42:23 pm
I have a feeling volutar will be pro-border ;p as long as it fits the rest of the ufopedia. I like it too!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: volutar on February 15, 2015, 06:16:55 pm
Nope. I think without border is better.
Because:
(https://ufopedia.csignal.org/ufopedia/099.png)
Reasoning why there's no border around the text is simple. It has black background. And borders are meant to be around some plates or backgrounds.

But current borders also better to be reworked, they are too thick and "blobby". 1-2 pixels is enough.

BTW, Blue ribbon over blue background (exactly the same blue) - makes them too mixed.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 15, 2015, 06:40:33 pm
Nope. I think without border is better.
Because:
https://ufopedia.csignal.org/ufopedia/099.png
But borders also better to be reworked, they are too thick and "blobby". 1-2 pixels is enough.

LOL!! So hard to please!
https://ufopedia.csignal.org/ufopedia/Hyper-Wave%20Decoder.html 

all the other borders are about 3 pixels, which is what I have set.

I think, I'll keep the all screen border. :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: volutar on February 15, 2015, 06:43:31 pm
LOL!! So hard to please!
https://ufopedia.csignal.org/ufopedia/Hyper-Wave%20Decoder.html 
I'll repeat:
Reasoning why there's no border around the text is simple. It has black background. And borders are meant to be around some plates or backgrounds.
By the same reason the HWD has border - it has not-black background inside. That's the vanilla concept.
https://ufopedia.csignal.org/ufopedia/all.php
There are NO ufopedia articles with borders around the black.
It's not about pleasing me.
BTW borders over these images is content-aware. It's not just a line.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: vlad on February 15, 2015, 10:02:31 pm
Must agree with volutar on this one. At first glimpse the border version looked better for me, but after checking with game it doesnt really need it at all. Just the border of medals alone did look weird, thats why I picked border version first time. Does the background of medal still work as color code ? Why not make it like some display cushion ?
(https://encrypted-tbn2.gstatic.com/images?q=tbn:ANd9GcT6kIis0pJRUXXk28Je56G122xkRXb94hY7DUlDJHLMhCIU7Waoyw)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 15, 2015, 11:03:13 pm
Must agree with volutar on this one. At first glimpse the border version looked better for me, but after checking with game it doesnt really need it at all. Just the border of medals alone did look weird, thats why I picked border version first time. Does the background of medal still work as color code ? Why not make it like some display cushion ?

The multiple background hues are by design as a way of categorizing the different types of award:

Blue = Normal
Green = Support
Purple = Wound
Black/grey = Somber
Red = Awesome

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 16, 2015, 01:25:11 am
If we need though, we can drop those color categories. Or find a different way to display them.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Mr. Quiet on February 16, 2015, 03:16:28 am
A uniform background can work. Have a different colored Uniform background for each type of medal. For the "awesome" medals, I assume they mean the really tough to get medals, so make it a black uniform background.

Uniform background as in a colored cloth pattern covering the background screen.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: vlad on February 16, 2015, 07:15:17 am
That was the idea. Aka current gradient (displayed in last border images) is analogy of say sectoid ufopaedia entry and the cushion-like item under the medal with uniform color of the color code under the medal is analogy of sectoid autopsy ufopaedia entry.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: hellrazor on February 16, 2015, 04:24:10 pm
Any way to use this Mod with normal git branch?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 16, 2015, 04:55:40 pm
Any way to use this Mod with normal git branch?

I am not sure what you mean by normal git branch. The Legacy version of this mod is meant to work with the 1.0 milestone, and the Nightly version is supposed to work with the latest nightly. I think you are looking for the nightly; it should work, unless Warboy has been especially busy rewriting important parts of code.

Let me know if you have problems!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 16, 2015, 05:04:31 pm
Any way to use this Mod with normal git branch?

Um.. just to clarify.  Shoes has written a bunch of custom code that does the stat tracking for the soldier record, as well as for criteria for commendations.  You have to use one of his custom executables as he mentioned above.  This project is branched off the normal git branch to allow for the custom code and custom resources like all the graphics.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: hellrazor on February 16, 2015, 08:30:07 pm
Um.. just to clarify.  Shoes has written a bunch of custom code that does the stat tracking for the soldier record, as well as for criteria for commendations.  You have to use one of his custom executables as he mentioned above.  This project is branched off the normal git branch to allow for the custom code and custom resources like all the graphics.

Wouldn't it more convinient if his code would be pulled into Master branch? Because custom executables are kinda alergic  to my OS ;D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: volutar on February 16, 2015, 08:36:57 pm
Wouldn't it more convinient if his code would be pulled into Master branch? Because custom executables are kinda alergic  to my OS ;D
I'm affraid main branch won't take any "heavy" modifying code until all necessary things on a main plan be completed. Adding this uber-commit will obviously require alot of attention and learning from the devs, before it become fully supportable. Results may become unpredictable. It is possible, though, after tftd.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: hellrazor on February 16, 2015, 09:11:24 pm
I'm affraid main branch won't take any "heavy" modifying code until all necessary things on a main plan be completed. Adding this uber-commit will obviously require alot of attention and learning from the devs, before it become fully supportable. Results may become unpredictable. It is possible, though, after tftd.

Well of course it will take time and main dev's are working on tftd support. But i really like what i see even thou i am not inclined to pull another git and have 2 Versions installed...
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 16, 2015, 10:59:03 pm
I went ahead and re-mastered all of the medals with the overall screen border.  In game, these feels better to me than without it. 

I have also shifted all the ribbons up, and adjusted the positioning of the medallions so that they don't overlap the bottom border.

Here is a sample of the image thumbnails.

(https://i.imgur.com/ZxPdl5L.png)

Volutar, I understand you do not like this solution, as it is not like vanilla.  This is true.  This is like Commendations which didn't even exist in vanilla.  I'm happy with the art for now.

If we come up with an alternate means of categorization, I'll consider re-mastering.

Shoes, Do you want these in a PR?    If so, shall they bundle in the current open PR, or in a separate PR?

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 16, 2015, 11:50:25 pm
Looks good! Throw 'em in the open PR. If I don't look at it this week, I'll have time for sure next week.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 17, 2015, 12:15:14 am
Alright.  They are all in the PR.  :)

Edit: Also.  If anyone wants access to these before they are packaged in another release, they are available here: https://github.com/IvanDogovich/OpenXcom/tree/AR-ID-Working/bin/data
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: hellrazor on February 17, 2015, 12:31:10 am
Shoes, does your github repo pull in all changes from the master on regular basis?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 17, 2015, 12:34:11 pm
Shoes, does your github repo pull in all changes from the master on regular basis?

Not too regularly, but I can easily do it on request.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Neo23 on February 17, 2015, 05:53:09 pm
I pulled the new files and updated my german translation of the mod. The new version contains all new
Ufopaedia entries, the renamed medals and some cosmetic corrections. As before, feel free to use it.

I like the border version a lot more than the old style. Good work!

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 17, 2015, 06:14:00 pm
Thanks a ton for the Translation work and taking the initiative to pull the files! :D

Cheers!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Neo23 on February 18, 2015, 03:07:10 am
You're welcome :)

Time for me to watch the latest "Up Close and Personal" and Meridian's FMP episodes now.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: kikimoristan on February 18, 2015, 12:11:08 pm
Ivan . Make both sets of graphics available and I guess the second re-mastered ones are the graphics that come with default mod. But plz  have a second zipped file with alternative/original medal look. Some may like original better. I kinda like both to be honest. Second is more XCOM-like but first one is more unique to the mod and more "oiginal " mod look.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 18, 2015, 01:39:48 pm
Ivan . Make both sets of graphics available and I guess the second re-mastered ones are the graphics that come with default mod. But plz  have a second zipped file with alternative/original medal look. Some may like original better. I kinda like both to be honest. Second is more XCOM-like but first one is more unique to the mod and more "oiginal " mod look.

The issue with releasing both would be needing to update both sets. And if we don't update the second set, it wouldn't be a great set to play with ;p
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on February 18, 2015, 05:47:12 pm
During today's Up Close and Personal episode, there is a special feature at the end with an in game Preview of all the new UFOPedia Art for the Commendations.

https://youtu.be/FKbw4SWluqw?t=26m24s
(https://i.imgur.com/eFiwnFy.png) (https://youtu.be/FKbw4SWluqw?t=26m24s)

Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on February 19, 2015, 05:51:54 am
I really need to catch up with your LP :P
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: mrxian on February 19, 2015, 09:30:32 am
I really like the concept of this mod.
So much, in fact, that I decided to use it.
But after installing the legacy version, I found it doesn't work, it makes the game crash upon loading a save or starting a new game.

Am I doing something wrong?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 19, 2015, 12:19:47 pm
I really like the concept of this mod.
So much, in fact, that I decided to use it.
But after installing the legacy version, I found it doesn't work, it makes the game crash upon loading a save or starting a new game.

Am I doing something wrong?

Did you follow the instructions? Otherwise, common errors are that the .exe and the .dlls need to be in the same folder, and you can only play the legacy version with the 1.0 milestone of OXC.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: mrxian on February 19, 2015, 11:24:36 pm
I'll go doublecheck, but I think I did all that.

I'll be in touch.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: mrxian on February 20, 2015, 06:02:54 pm
Tried reinstalling everything, game still hangs. I'm using the milestone, correct version of the mod and followed the instructions.

Game loads fine, gets me into the menu, but as soon as I load or start a game or start a battle, the game hangs.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 20, 2015, 07:26:32 pm
Are you able to play without the mod installed? What about without the mod turn on? (Named Commendations in the mod section of the options)

Also, what operating system are you using?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: mrxian on February 21, 2015, 08:17:37 am
Game runs fine without the mod installed.
Turning the mod on or off has no effect on the hanging.

I'm using windows 7
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 21, 2015, 01:02:38 pm
Sounds like you have a run of the mill setup, so this is quite puzzling. Could you do me a favor and try the nightly OXC with the nightly mod? Tell me if that hangs too. Thanks!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: mrxian on February 21, 2015, 10:02:23 pm
That seems to work.
Let me try an even cleaner clean install.

Nope, with the cleanest install I can manage of the 1.0 milestone, I can't get the legacy mod to work.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Kevloc on February 22, 2015, 06:18:55 am
Having the same issue as mrxian.
Did a clean install of Openxcom 1.0 over a Steam game install, test ran ok.   Extracted the 2015-02-08 Legacy.zip files, start up game, enable the ruleset and as soon as I try to start a new game it crashes to desktop.   Running Windows 7 64.   I can post the error if needed.   Going to try the Nightly method.   Hope it works, really like this addition.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Goldy on February 22, 2015, 03:18:18 pm
It's the same problem I had - I had to revert to older version :(
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on February 22, 2015, 03:28:39 pm
Well dang guys, sorry about that. Glad to hear the nightly seems to be working as intended. I wonder if this is related to the "can't load games from an older version" problem others have had.

This week I should have time to look into it.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Kevloc on February 22, 2015, 07:22:56 pm
No problem Shoes.   The Nightly zip does work over the Nighties "openxcom_git_master_2015_02_22_0621.zip".   So I'm in business.   Thanks!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on February 24, 2015, 01:36:16 am
Watching Ivan's playthough, I got an idea for a new reward.

The "light handed" or "tactful punch" award, to a soldier who manages to stun an alien with a lethal weapon, whereas the order of restraint would be for stunning with a stun weapon.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: kikimoristan on March 04, 2015, 10:05:37 pm
waiting for shoes to update to latest nightly to use that multi terror mission  system .
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: NuclearStudent on March 13, 2015, 12:31:19 am
I just wanted to say I had the exact same issue Mrxian and Kevloc had. I had a clean 1.0 install and the legacy build, and the game crashed to desktop when I tried to load a save, start a new game, or start a battle.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on March 13, 2015, 12:44:14 am
I didn't have the free time to look at the code like I had hoped. I think I will put up the old Legacy version along side the new one as people have been having problems.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on March 13, 2015, 12:44:38 am
I just wanted to say I had the exact same issue Mrxian and Kevloc had. I had a clean 1.0 install and the legacy build, and the game crashed to desktop when I tried to load a save, start a new game, or start a battle.

Sorry to hear that.  If you are willing to go with the Nightly Build, You may have better luck.  I know that I got it running at one point.  And thanks for confirming the difficulty with the legacy build.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: NuclearStudent on March 13, 2015, 07:08:00 am
Sorry to hear that.  If you are willing to go with the Nightly Build, You may have better luck.  I know that I got it running at one point.  And thanks for confirming the difficulty with the legacy build.

I don't want to use the Nightly build. I'm wondering if it might be a problem with my resolution problems. The game crashed immediately when I had the 1024 by 800 res.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: jgatkinsn on March 13, 2015, 07:17:16 am
I get the same crash on startup.  My res is 1440x900. 

I'm also having trouble getting the nightly up and running.  The earliest nightly I can download is 3/3/2015.  I noticed the nightly for this mod is almost a month older than the oldest nightly.  I tried run it, but got some yaml errors with the xcom rules.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on March 13, 2015, 11:25:18 am
I was afraid that would happen to the nightly ;p I think Warboy is making a lot of changes so my nightly and the current nightly are different. Hopefully this weekend I'll be able to recompile and try it out.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: kikimoristan on March 13, 2015, 11:27:54 am
that would be great as right now i am using 2 different openxcoms your nightly for stat tracking and latest nightly
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: SIMON on March 13, 2015, 04:01:28 pm
In my current game I'm using the ur mod of 08-02-2015 without any problems but I was wondering if it's possible to widen out the "kills/stuns per mission" screen as any done with mass accelerator weapons don't show fully, see attached pic. Also I'm assuming that improvisation is a general term for taking out an alien by exploding something very near it. Thanks in advance and a great addition to any playthrough.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on March 13, 2015, 06:54:24 pm
It's a good suggestion to make that screen bigger, I'll keep it in mind when I dive into the code next time. Also you're right with the improvisation: I have a few catch-all strings like that in the event a stat has no name.

tollworkout: when I do update the .exe, you will be able to transfer your save no problem :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: bloodman123726 on April 10, 2015, 09:40:14 pm
i tried all of the downloads and none of them worked, shame
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on April 10, 2015, 11:19:38 pm
Huh, that is a shame. I have been busy lately, but when I have found time to tinker, I was not able to reproduce any "failure to launch" problems. Only a "failure to load a game", and I got no where with that :x

Any details on how things didn't work? Did you make sure you put the DLLs and all that stuff in the right places? (Did you read the readme?)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Cypruss on April 11, 2015, 10:44:19 pm
Hey Shoes,

First of all, I want to tell you that this is exactly the mod I always envisioned being a part of xcom. Anyway, as I was reading responses from others I can tell you that I have installed everything as well exactly as you dictated with the .dll files. I have years of programming and modding experience and I can't get it to work either. It boots up fine and I enable it inder the options for xcom. My other mods work, just not this one with the latest legacy/nightly mod and utilizing the 1.0 build of openxcom. Once enabled, this mod works fine until I try to start a new game. Crashes directly upon entering the geoscape where I would normally be prompted to choose a location for the base. Windows 7, 64 bit here.

Cypruss
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on April 12, 2015, 05:48:44 am
Well that's no good ;p Next time I find some time, I'll give another crack at finding what the problem is.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Cypruss on April 13, 2015, 09:32:31 pm
That would be great. I'd be happy to test for you if you need anything tested. Thanks Shoes.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on April 13, 2015, 09:38:12 pm
That would be great. I'd be happy to test for you if you need anything tested. Thanks Shoes.

If I can't reproduce it, I might ask of you to ... download the dev tools, the source code, the game assets, the mod, put it all together and reproduce it in debug mode ...

I might ask.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ThePiedPiper on April 23, 2015, 10:06:04 pm
This may sound stupid When I use the mod all of the text related to the mod is displayed incorrectly  e.g. Diary is actually  STR_DIARY
Thaks for the help guys :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on April 23, 2015, 10:08:43 pm
This may sound stupid When I use the mod all of the text related to the mod is displayed incorrectly  e.g. Diary is actually  STR_DIARY
Thaks for the help guys :)

You're probably using a language that isn't supported by the mod. I can't remember right now which English variant is used, so please try them all (EN-US, EN-GB etc.) and check which one works.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on April 23, 2015, 10:41:08 pm
En-US is the current working language for the mod.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: pilot00 on April 30, 2015, 01:03:20 pm
I checked the first three-four pages of the mod and I must have missed it so heres a question for when you have time:

Is this compatible with other mods? Especially I am looking at the final mod pack. I would hazard a guess as to no since its an exe modification but I thought Id ask first.

Seems like a great work.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Dioxine on April 30, 2015, 01:28:13 pm
It is compatible with any mod, as long as the mod is not using Nightly functions not supported by Soldier Diaries. Which is sadly true for FMP.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on April 30, 2015, 01:50:18 pm
At this point I think it's OK to ask:

Is the Commendations mod dead?

I mean, there has been no new releases for months, no declarations of having done any work on it, no nothing. Shoes, if you're done with it that's understandable, but could you please make some sort of statement regarding the mod? This would clear things up, and I'm sure there are some people here who might be willing and able to pick it up.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on April 30, 2015, 04:06:06 pm
At this point I think it's OK to ask:

Is the Commendations mod dead?

I mean, there has been no new releases for months, no declarations of having done any work on it, no nothing. Shoes, if you're done with it that's understandable, but could you please make some sort of statement regarding the mod? This would clear things up, and I'm sure there are some people here who might be willing and able to pick it up.

I am surprised I have been away from the mod for so long myself, to be honest :x I still hope to get this mod merged into the base game, but at this point there is nothing new to add to the mod. I think I've added pretty much everything I want.. and that's the fun part. Keeping the nightly up to date or fixing hard to reproduce bugs does little to excite me ;p However making the mod playable is something I want to do.

Maybe this weekend I will sit down and update the nightly. Perhaps dropping support for the Legacy version of the mod will also make working on this more pleasant too.

I checked the first three-four pages of the mod and I must have missed it so heres a question for when you have time:

Is this compatible with other mods? Especially I am looking at the final mod pack. I would hazard a guess as to no since its an exe modification but I thought Id ask first.

Seems like a great work.

Thanks! The mod should work with any ruleset mod, but not .exe mods. You would have to compile a merged version of both mods. It's possible to do, but it would be a little bit of a headache if both mods touch the same code. Also like Dioxine said: you can use it in the nightly if there haven't been big changes. It will effectively revert your game back to the nightly that this mod was updated to. For example, if map work has been changed since the last Diary update, it probably won't work.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on April 30, 2015, 04:33:20 pm
Wow, this is encouraging. But AFAIK there are still bugs to fix, right? (I haven't really tested it, but that's the general feeling I got from this thread.)

Anyway I'd love to play this great mod. Hey, how about first integrating it in the OpenXCom Extended first (provided Yankes says it's fine)?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Yankes on April 30, 2015, 08:06:03 pm
Wow, this is encouraging. But AFAIK there are still bugs to fix, right? (I haven't really tested it, but that's the general feeling I got from this thread.)

Anyway I'd love to play this great mod. Hey, how about first integrating it in the OpenXCom Extended first (provided Yankes says it's fine)?
I prefer not, I try keep my mod as stand alone exe. This mean that I don't add any new resources like rulsets, language or graphic, but Solder Diaries require them to work properly. Shoes can of cores merge my branch into his, but did he will want all changes to vanilla behavior I made in my mod?
Maintaining two version (baisc and extended) will be equal painful to maintaining 1.0 and Nightly.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on April 30, 2015, 08:47:38 pm
I prefer not, I try keep my mod as stand alone exe. This mean that I don't add any new resources like rulsets, language or graphic, but Solder Diaries require them to work properly. Shoes can of cores merge my branch into his, but did he will want all changes to vanilla behavior I made in my mod?
Maintaining two version (baisc and extended) will be equal painful to maintaining 1.0 and Nightly.

Hmm, yeah, this is true. Well then, I can only hope for adding the mod to the vanilla. :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on May 01, 2015, 12:00:31 am
Wow, this is encouraging. But AFAIK there are still bugs to fix, right? (I haven't really tested it, but that's the general feeling I got from this thread.)

Yeah, but I think it's with Legacy. Stuff about saved games not loading. I spent a bit of time with looking into it, even Warboy couldn't help me ;p
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on May 01, 2015, 01:10:10 am
As far as I know, changes in the nightly have probably made the current Diaries nightly version not work.  I haven't tested this.

@Shoes, I do have a pending pull request from a few months back that updated some more of the Ufopedia stuff.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on May 01, 2015, 01:08:56 pm
As far as I know, changes in the nightly have probably made the current Diaries nightly version not work.  I haven't tested this.

@Shoes, I do have a pending pull request from a few months back that updated some more of the Ufopedia stuff.

Yeah I know :3 someone else made a PR, I'll be sure to merge those when I update the nightly.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on May 25, 2015, 10:22:12 pm
The top post has now been updated with a fresh link :) Quick testing showed it worked for me, hopefully it does for you guys too. Folder structure has been moved around, so let me know if things extract to the wrong place! A big thanks goes to Fudgedragon for updating to the May 22nd nightly :)

Minor tweaks have been done too.

In the following link is where I jot down some notes to guide me whenever the urge strikes me to tinker with this mod. At the moment, I have a few commendations that I would like to add, a new type of commendation to add, and a few house keeping things. It's public, so feel free to post things there or here. Link : https://gist.github.com/Shoes01/3af40f402d287ae9c229
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: NuclearStudent on May 26, 2015, 06:21:52 am
YES

THIS MOD IS NOW COMPATIBLE WITH UPDATED FMP

HELL YES
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: FudgeDragon on May 26, 2015, 10:14:02 am
Hey Shoes,

You weren't kidding about doing something strange with the git, the branch I had checked out evaporated overnight. Also I am somewhat headscratching at your SupSuper/master merge into your own master. While that technically works all you really need to do when one is a less up to date version of the other is to checkout localy, then push to your own master. It's uh, somewhat cleaner if things ever get merged back the other way.

I also wanted to ask about your recent 'Added Spite' commit. It's not only in the wrong place for the new mod system (bin\data\Resources\Commendations instead of bin\standard\Resources\Commendations) but a duplicate of an already existing medal. Was this just confusion over the new system or did you have something else in mind?

It would probably be a good idea to merge master in again at some point in the near future. There's nothing gamebreaking in the nightly I picked, but it will give you the text and anim for winning when you lose if I am reading Warboy's recent commits correctly. Now that you are fairly up to date the merge should be painless.

If you'd like I can do another pull request against alpha_release to do another merge for you, but I wanted to find out what was going on with the sprite first.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on May 26, 2015, 03:18:55 pm
YES

THIS MOD IS NOW COMPATIBLE WITH UPDATED FMP

HELL YES

Yay :3

FudgeDragon, the spaghetti branch stuff is because I had done a bit of work on my mod weeks ago, and didn't want to lose the progress. So.. I pulled your PR into its own branch, cherry-picked my changes into it, and then --force pushed the new branch into alpha_release. One of the cherry picked changes was the "added sprited", explaining why it is entirely out of place!

I am not an avid git user, so I will take your advice about cleaner merges!

I would also appreciate if you did do another PR. I have been a bit of a ghost around here for a while, and a few things have changed since I've last paid attention.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: FudgeDragon on May 26, 2015, 03:48:31 pm
Heh, no problem. I prepared a branch this morning, so pull request is up now. I figured the sprite was something like that, but without realizing that you had accidentally cherry picked an existing commit I was looking for minute differences between the files.

I take it you are running git command line? In which case you probably know more about its inner workings than I do. I've been running it through git extensions for windows which is probably a bit lazy, but it just makes everything so easy! I have like 3 'master's sat on the same commit. There's my local master, my remote master and supSuper/master, so it was somewhat puzzling when Shoes01/master appeared on its own ahead of the current master commit.

Oh well, we learn new things every day. I've actually got a merge of this mod and OpenXcom Extended in a local branch in preparation for Piratez Extended, and OpenXcom Extended doesn't even compile in visual studio out of the box. That was a headscratcher! I spent the entire weekend programming OpenXcom when I intended to be playing it.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on May 26, 2015, 04:02:39 pm
If you manage to get working versions of this mod and other mods like Piratez or Extended, I can compile them and throw up some download links for others. I tried writing this to work well with mods, so I guess it will be a true test if it also works with other modded exes.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on May 26, 2015, 04:33:55 pm
If you manage to get working versions of this mod and other mods like Piratez or Extended, I can compile them and throw up some download links for others. I tried writing this to work well with mods, so I guess it will be a true test if it also works with other modded exes.

Yeah, that would be super neat. Not just for Piratez (I'm not sure it suits them), but certainly for the FMP and other big mods.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: FudgeDragon on May 26, 2015, 05:03:31 pm
We can't currently work with Piratez currently, It's not an exe mod, but I think we completely skipped the nightly it runs on, we'd need to cherry pick changes onto an old(er) nightly, so as far as I can tell it might be better to wait until Piratez Extended is ready at which point my understanding is it should just run on a merge with extended. Of course at that point someone might want to put together a more piratey ruleset, as conventional ribbons/medals don't make as much sense, not that just having the stats tracking isn't nice.

Extended on the other hand is quite feasible, other than a few tweaks (->ResistType) to your code needed because damage type has been moved into the ruleset. It's largely untested, but I am fairly confident in the merge. It uses a slightly tweaked version of extended to get it to compile on Visual Studio, but it should be equivalent. I pushed it to my github as a branch called SoldierDiariesExtended. You should be a able to pull it/check it out from git@github.com:fudgedragon/OpenXcom.git (https://git@github.com:fudgedragon/OpenXcom.git)

EDIT: By my understanding, now that we are updated to the lastest nightly, we should already be compatible with most other (non exe) mods. The only potentially conflicting changes are the ufopedia entries for the medals, and the name changes around that.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on May 26, 2015, 05:35:57 pm
EDIT: By my understanding, now that we are updated to the lastest nightly, we should already be compatible with most other (non exe) mods. The only potentially conflicting changes are the ufopedia entries for the medals, and the name changes around that.

Hey FudgeDragon. :)
Is that because their path has changed for the new mod folder structure?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: jgatkinsn on May 26, 2015, 05:39:10 pm
Woot! This is so awesome!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: FudgeDragon on May 26, 2015, 06:00:34 pm
Hey FudgeDragon. :)
Is that because their path has changed for the new mod folder structure?

Nope. Simply that other mods may place HWPs in that category, which we've renamed for commendations. Everything'll still work. It'll just look a little odd.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on May 26, 2015, 06:06:27 pm
Right.  That makes sense.  Thanks!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: FudgeDragon on May 27, 2015, 01:10:27 am
Been playing around with building a version on an earlier nightly this evening.

(https://i.imgur.com/MEttzLfm.png) (https://imgur.com/MEttzLf)

(https://i.imgur.com/2Zsp664m.png) (https://imgur.com/2Zsp664)

Looking promising so far. No issues other than the Pirate that keeps shotgunning her friend.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on May 27, 2015, 01:20:02 am
dude....  me wants  :-*

(Edit) Probably need some significant UFOPedia surgery, and probably better with Commendations off for now.
--- at least the UFOpedia entries for the commendations off, might help.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: FudgeDragon on May 27, 2015, 01:38:27 am
Yea, at this point I haven't got the commendations ruleset enabled. I'm just using it for the Diaries. At the end of the day a Total Conversion like Piratez really needs its own separate set of rewards to fit the theme. Even the 'Kills' and 'Missions' buttons stand out. When you think about it even TFTD might need some small tweaks (do the navy have different ribbons and stuff irl? probably.)

As I said earlier it's largely untested (I've played about 2 missions) but all the interfaces seem to work. If you want to have a go at building it yourself the branch is at https://github.com/fudgedragon/OpenXcom/tree/SoldierDiariesLegacy20150430 (https://github.com/fudgedragon/OpenXcom/tree/SoldierDiariesLegacy20150430). Otherwise I can probably provide my current build here, in either 32 or 64 bit, if you want.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on May 27, 2015, 01:46:58 am
Yeah, in the US, the Navy has different awards from the Army, with some that are very similar, esp for heroism under fire.

The lazy part of me says, Yeah, that 32 bit would be sweet! then I think, oh yeah, but the melee statrings.... and flashing health bar.  Should pull those back in too. ;)  I'll take a look. :)

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: FudgeDragon on May 27, 2015, 02:03:46 am
Best of luck, just took a look at the pull requests and they look fairly clean. If that proves tricky, you may be able to determine the relevant commits and cherry pick them to just get the changes to the files you want.

If you decide you want one of the prebuilt files after all I have uploaded them temporarily to my dropbox at https://www.dropbox.com/sh/103v5r6cet19yv1/AAD6INkoSf30P81z7USjAhKAa?dl=0 (https://www.dropbox.com/sh/103v5r6cet19yv1/AAD6INkoSf30P81z7USjAhKAa?dl=0) (they exceed the maximum attachment size for the forum just a little)

If you're wondering why I'm bothering to build x64 consider it force of habit. Some time ago I managed to get the win7 SDK installed and a static x64 yaml library built. I can't for the life of me remember how I managed it but it means I can build for x64 as easily as everyone else does 32 bit.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on May 27, 2015, 02:28:00 am
Yeah, I completely gave up in frustration on the compiling 64x front.  Warboy said in tests it actually is slower, and there is not a lot of threading that can even use it so I don't feel so bad with the 32 bit builds anymore. XD
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: jgatkinsn on May 27, 2015, 02:32:49 am
Well, I copied the contents of the zip file into OpenXcom, and I get an error about yaml-cpp: error at line 0. column 0: bad file.

Any ideas?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on May 27, 2015, 03:47:12 am
I am adding a Martyr Medal, awarded for scoring kills on the same turn as your death, provided you are the cause of your own death. Neato fact: the amount of pins you get is depends on the number of aliens you killed. The picture below means Kamaka scored three kills.

I am also thinking of moving the "best of" medals (these are awarded after death to the best soldiers of a given rank, and best overall) to the end of the month instead of immediately after death. This might be a good way to be reminded of your "good" soldiers. And a good way to not hand out a prestigious medal to every up and commer.

Picture:
(https://i.imgur.com/YR9t9kP.png)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: SDEDEN on May 27, 2015, 04:32:10 am
I think this mod looks really interesting, but is there any way it would ever be compatible OpenXCom Extended?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: jgatkinsn on May 27, 2015, 05:07:05 am
I think this mod looks really interesting, but is there any way it would ever be compatible OpenXCom Extended?

Yep.  Requires changing the OXC Extended code :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: FudgeDragon on May 27, 2015, 07:57:29 am
Well, I copied the contents of the zip file into OpenXcom, and I get an error about yaml-cpp: error at line 0. column 0: bad file.

Any ideas?

Typicaly a yaml-cpp: error at line 0. column 0: bad file is bad config file that needs to be options.cfg that needs to be deleted because it is out of date/too new. Which zip did you download.

disclaimer: Also please be aware that any build I provide that isn't also on the front page isn't guaranteed to be supported by shoes. But I'll try to help where I can.

I think this mod looks really interesting, but is there any way it would ever be compatible OpenXCom Extended?

As shoes had said this involves a few tweaks to both the code of extended and soldier diaries. Extended needs to be made to compile in visual studio if you use that, and Diaries needs to be updated to account for a change to how damage types are stored.

If you feel up to building it yourself, I currently have a repo here :https://github.com/fudgedragon/OpenXcom/tree/SoldierDiariesExtended (https://github.com/fudgedragon/OpenXcom/tree/SoldierDiariesExtended) which has these changes made

again this code is largely untested and may not be supported by Shoes or Yankes and I make no promices about being able to help myself. But I'll give it my best shot.

I am adding a Martyr Medal, awarded for scoring kills on the same turn as your death, provided you are the cause of your own death. Neato fact: the amount of pins you get is depends on the number of aliens you killed. The picture below means Kamaka scored three kills.

I am also thinking of moving the "best of" medals (these are awarded after death to the best soldiers of a given rank, and best overall) to the end of the month instead of immediately after death. This might be a good way to be reminded of your "good" soldiers. And a good way to not hand out a prestigious medal to every up and commer.

Picture:
Snip!

Sounds good shoes.  I looked at the picture before I read your text though and was wondering how your soldier had died more than once!  :o

Reading your gist I understand you have doubts about where you're trying to do the best of medals, but I admit the end of the month does sound good. If you do work out how to do it after every mission maybe you could have both, switchable in the ruleset?

I was almost thinking about taking a look at this bit myself

- Polish Lost in Service state
-- Stats: rank, score, number of missions, kills/stuns, cause of death? Times hit? Total commendations
-- Commendations
-- Cause of Death

Can you explain a little more about what you might have intended? I have a few ideas myself but wanted to hear what you think before I present them.

EDIT3: I'm ok at C++, but apparently suck at BBCode. How many times can you get a quote wrong Fudge.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on May 27, 2015, 01:11:46 pm
Regarding the Lost in Service screen: I sort of threw it together as a proof of concept to make sure it would even look good, and it did. As is, I've made no attempt to prevent text from overlapping itself (if your score is -400 let's say, it will touch the Kills title"), and there might be other stats that would be cool to do. What's funny is with the martyr code, IDs are linked to kills, so we can find out what killed this soldier and write a little blurb like "Kamaka was struck down by the plasma pistol of a sectoid" or something like that.

Here's a screenshot:
(https://i.imgur.com/DH5La3M.png)

As for forking the commendations branch and doing things to it, feel free! I would be more than happy to add a link to a working SDE mod :)

EDIT: Rereading your post FudgeDragon, I now see what you are asking ;p So yeah, the information on the Lost in Service screen is just what I was able to easily do. The only mandatory thing I would say is listing the commendations the soldier received. Anything else is up for discussion; I think any tracked statistic could be displayed, it's just a matter of choosing them and formatting the list.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: jgatkinsn on May 27, 2015, 03:05:57 pm
Typicaly a yaml-cpp: error at line 0. column 0: bad file is bad config file that needs to be options.cfg that needs to be deleted because it is out of date/too new. Which zip did you download.

disclaimer: Also please be aware that any build I provide that isn't also on the front page isn't guaranteed to be supported by shoes. But I'll try to help where I can.

I downloaded the 5-22 zip file.  My current installation is  based off the 5/12 nightly.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: FudgeDragon on May 27, 2015, 03:53:36 pm
Hmm, I just downloaded the 5-25 zip file from the first page, and the 05_25_0957 nightly from the openxcom website.

I extracted the openxcom zip first, then the 5-25 soldier diaries over the top and everything worked fine.

The only thing I can suggest if that doesn't work is have you made sure your original xcom files have been moved from data into the UFO folder?

On that note shoes, I realize that you may be trying to save room on your dropbox, but you're missing the en-GB language file even if you are only trying to distribute the differences from master.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on May 27, 2015, 04:04:02 pm
On that note shoes, I realize that you may be trying to save room on your dropbox, but you're missing the en-GB language file even if you are only trying to distribute the differences from master.

Are there missing strings? The reason I mess with the language files instead of modding them is so when a user turns off the mod, they can continue to track stats. I should be a quick copy paste job to get the en-GB file updated.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: FudgeDragon on May 27, 2015, 04:13:01 pm
Eeh, I think the file is probably fine. You just haven't included it in the zip.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: jgatkinsn on May 27, 2015, 07:17:40 pm
Hmm, I just downloaded the 5-25 zip file from the first page, and the 05_25_0957 nightly from the openxcom website.

I extracted the openxcom zip first, then the 5-25 soldier diaries over the top and everything worked fine.

The only thing I can suggest if that doesn't work is have you made sure your original xcom files have been moved from data into the UFO folder?

On that note shoes, I realize that you may be trying to save room on your dropbox, but you're missing the en-GB language file even if you are only trying to distribute the differences from master.

I've been running fine with the new nightlies, and I installed the latest nightly and it works fine.  I updated per myk002 instructions when they went to the new mod format.

I'll try deleting the options.cfg file and see if that helps when I get home tonight.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: jgatkinsn on May 28, 2015, 03:41:41 am
Upgrading to 5/25 normal nightly fixed the issue.  I didn't delete the options.cfg file.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on June 01, 2015, 03:44:53 am
Order of the Reaper is functional it seems! This soldier got a flurry of commendations for a grenade that killed two aliens. I think debug-killing the rest of the aliens caused him to get a few more :x Also notice how he was not commended as being an awesome rookie; only squaddies and up get commendations like that.

(https://i.imgur.com/96FvpsL.png)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: FudgeDragon on June 01, 2015, 10:16:27 am
Looking good shoes.

And with that I'm bringing all my unoffical extra builds up to date.
All builds below are currently based off of the current build of Soldier Diaries (01/06/2015 01:45:12 - Commit:4a5c9e73d308f97d526959b62cb438e79ace1863)

Soldier Diaries Extended (based of of OpenXCom 25/05/2015 08:57:51 - Commit:db285720550dd4cd87482010f9e94464929ad60b & OpenXCom Extended 27/05/2015 18:37:59 - Commit:c90d5f8cfc7a2a351cae1ce60ee348f681eb1b06)
Combines OpenXCom Extended with Soldier Diaries for the latest nightly
Git: https://github.com/fudgedragon/OpenXcom/tree/SoldierDiariesExtended (https://github.com/fudgedragon/OpenXcom/tree/SoldierDiariesExtended)
Downloads: Windows (win32 (https://www.dropbox.com/s/3rrzdvzx6f581jz/Soldier%20Diaries%20Extended%20win32.zip?dl=0) x64 (https://www.dropbox.com/s/qifgjnrysxz5bnw/Soldier%20Diaries%20Extended%20x64.zip?dl=0))

Soldier Diaries Legacy (based of of OpenXCom 30/04/2015 06:20:02 - Commit:28bdaf9eaae8af5d1fa2f6593cf4f619c67fee83)
Provides the latest soldier diaries code, backported to work with the last nightly before the mod changes were brought in, should work with older mods such as Piratez that were designed to work with the older system
Git: https://github.com/fudgedragon/OpenXcom/tree/SoldierDiariesLegacy20150430 (https://github.com/fudgedragon/OpenXcom/tree/SoldierDiariesLegacy20150430)
Downloads: Windows (win32 (https://www.dropbox.com/s/2p5qim5ppf4lym3/Soldier%20Diaries%20Legacy%202015%2004%2030%200620%20win32.zip?dl=0) x64 (https://www.dropbox.com/s/4vu5zuaprqesfcw/Soldier%20Diaries%20Legacy%202015%2004%2030%200620%20x64.zip?dl=0))

Soldier Diaries Legacy+ (based of of OpenXCom 30/04/2015 06:20:02 - Commit:28bdaf9eaae8af5d1fa2f6593cf4f619c67fee83)
Playtested for 8 ingame months
The same as above but also provides the following additional features:
Git: https://github.com/fudgedragon/OpenXcom/tree/SoldierDiariesLegacy20150430+ (https://github.com/fudgedragon/OpenXcom/tree/SoldierDiariesLegacy20150430+)
Downloads: Windows (win32 (https://www.dropbox.com/s/mbl9qqh1qz8k6oc/Soldier%20Diaries%20Legacy%202015%2004%2030%200620%2Bwin32.zip?dl=0) x64 (https://www.dropbox.com/s/0x9s28421jn7a0f/Soldier%20Diaries%20Legacy%202015%2004%2030%200620%2B%20x64.zip?dl=0))

The piratez_diaries_lang.rul file is also available seperately here (https://www.dropbox.com/s/9qlmuhofiam0fo8/Piratez_lang_diaries.rul?dl=0).
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on June 01, 2015, 03:02:09 pm
<snip>

Soldier Diaries Legacy+ (based of of OpenXCom 30/04/2015 06:20:02 - Commit:28bdaf9eaae8af5d1fa2f6593cf4f619c67fee83)
Playtested for 8 ingame months
The same as above but also provides the following additional features:
  • Adds Pull Request: Maintenance time is now displayed in the intercept window in the Geoscape by bslaveboy
  • Adds Pull Request: Profitability information on the manufacturing screen by myk002
  • Adds Pull Request: Add melee availability to statstring conditions by    IvanDogovich
  • Adds Pull Request: Add heath bar flash when a soldier has fatal wounds by redv
  • Adds Custom Code: Adds a new (optional) advanced option to restrict aliens to the same psionics rules as humans (someone needs to establish line of sight, but not the soldier doing the MC) by me
  • Adds Custom Code: Adds a new (optional) advanced option to reduce alien time units on the first turn to simulate prior movement and reduce reaction fire by me
Git: https://github.com/fudgedragon/OpenXcom/tree/SoldierDiariesLegacy20150430+ (https://github.com/fudgedragon/OpenXcom/tree/SoldierDiariesLegacy20150430+)
Downloads: Windows (win32 (https://www.dropbox.com/s/mbl9qqh1qz8k6oc/Soldier%20Diaries%20Legacy%202015%2004%2030%200620%2Bwin32.zip?dl=0) x64 (https://www.dropbox.com/s/0x9s28421jn7a0f/Soldier%20Diaries%20Legacy%202015%2004%2030%200620%2B%20x64.zip?dl=0))

<Sniff>  Its so beautiful!!  Awesome work!
Cheers, Ivan :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: FudgeDragon on June 01, 2015, 04:27:48 pm
Heh, I figured you'd like it. While I don't expect you to use it for your Let's Play, in my head that has always been the Ivandogovich build. That last advanced option was actually written in an afternoon after watching you're disastrous terror mission at the black citadel (ep #21). Of course it wouldn't have stopped the grenade.

Learned something new today. Piratez doesn't have any en-UK translations, and I've been playing all this time with my game set to en-UK completely fine.

Today I set about throwing together a small string file, making the Soldier Diaries interface more piratey, I included en-UK and en-US strings. Upon its activation all the Piratez stings stopped working.

Moral of this story. OpenXCom will happily fall back to en-US if a mod doesn't include your current language, but the second another mod loads any extraStrings for that language at all, the fallback stops.  ::) I understand why this works like this in practice, but ugh.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on June 01, 2015, 05:43:06 pm
 ;D  Its the new Let's Play build.  :) (Won't get to employ until episodes next week as this week's are all recorded.  The diaries will kinda start from scratch, but I'm cool with that too. :)

On the fence about reduced enemy TUs.  In some ways it feels unfair to the AI, but it would be nice to not feel like a mouse trapped by a cat in the early game when baddies are staring up the Bonnie's skirt.  It always feels so helpless and exposed.   Once you have decent ranged weapons, it may get easier, as you can start with a volume of fire that may neutralize that extreme immediate danger.  I just hate charging down ramps into reaction fire.  That zerg rush thing is my least favorite tactic.

Anyway, thanks for the awesome build!!! THANK YOU!! :D

Edit: Also, throw me the strings for the piratey soldier diaries. ;)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: FudgeDragon on June 01, 2015, 06:06:35 pm
;D  Its the new Let's Play build.  :) (Won't get to employ until episodes next week as this week's are all recorded.  The diaries will kinda start from scratch, but I'm cool with that too. :)

On the fence about reduced enemy TUs.  In some ways it feels unfair to the AI, but it would be nice to not feel like a mouse trapped by a cat in the early game when baddies are staring up the Bonnie's skirt.  It always feels so helpless and exposed.   Once you have decent ranged weapons, it may get easier, as you can start with a volume of fire that may neutralize that extreme immediate danger.  I just hate charging down ramps into reaction fire.  That zerg rush thing is my least favorite tactic.

Anyway, thanks for the awesome build!!! THANK YOU!! :D

Edit: Also, throw me the strings for the piratey soldier diaries. ;)

On Blackbeard you're looking at 35-85% of regular TUs at the start. I use it myself and find that I still face a fair volume of fire. What I do find is you are less likely to be fired at by heavy weapons. It's a personal choice, you can still get really hot deployments. (I had a boomisaurus virtualy right underneath the hatch)

And sure thing on the piraty diaries, I attached it to this post. Just drop this into your rulesets folder and enable. Just make sure you're on en-US and not en-UK.

Please be aware it's only the diaries interface, not the commendations. If you have any suggestions let me know, I might start bundling it in the + packages.

On that note I was taking a look at actually adapting the commendations for Piratez. I was thinking something like Trophies or Wanted posters. It might take a slight code tweak to move the "First award" text out into the ruleset so that different rewards can have different text. I was also thinking it would be a good idea to have a way to access the UFOPediea page from somewhere other than the main GEOSCAPE Screen.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on June 01, 2015, 06:30:15 pm
On that note I was taking a look at actually adapting the commendations for Piratez. I was thinking something like Trophies or Wanted posters. It might take a slight code tweak to move the "First award" text out into the ruleset so that different rewards can have different text.

The "First award" and stuff is hard coded in an ugly way. However, the text can be easily changed; you can add more awards if you wanted by just adding more strings. Commendations can also skip different awards, so you can make weird "categories" of awards, so you can have 1x awards being for wantedness and 2x awars being for awesomness.

If you look at the ruleset, some commendations are like
Code: [Select]
  - type: STR_MEDAL_ALLRANKS_NAME
    description: STR_MEDAL_ALLRANKS_DESCRIPTION
    sprite: 00
    criteria:
      killsWithCriteriaCareer: [3, 6, 9, 9, 9, 9, 12, 12, 12, 12]

So there are four awards for this commendations, it goes straight to "no decoration", "1 bronze pin", "2 silver pins", "3 gold pins".
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Yankes on June 01, 2015, 08:00:57 pm
FudgeDragon if you are interested in more clean exe (a.k.a without all this dll's) you could checkout mxe environment (only draw back it require Linux, but VM can handle this).
OpenXcom nightly and my extended version is build on this.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Dioxine on June 02, 2015, 02:40:32 am
This is quite awesome. I'll have to check it out.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on June 02, 2015, 03:34:08 am
This is quite awesome. I'll have to check it out.

If you like it, you might consider posting the link in the PirateZ opening post.   Just a thought. :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Dioxine on June 02, 2015, 05:58:15 am
Nah it needs to be fully integrated. Looks like another feature for the extended version... hope it gets updated from time to time else I'm stuck with the current Nightly/Extended :) Well provided this doesn't cause any game crashes.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on June 02, 2015, 05:59:03 am
@Fudge Dragon:

Code: [Select]
STR_MISSION_DETAILS: "MISSION LOG"
Thats the only suggestion I thought of for the file. :)  Can't wait fer the gals to get some missions under their belts. :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: FudgeDragon on June 02, 2015, 08:34:13 am
FudgeDragon if you are interested in more clean exe (a.k.a without all this dll's) you could checkout mxe environment (only draw back it require Linux, but VM can handle this).
OpenXcom nightly and my extended version is build on this.

Hmm it's certainty appealing, and probably easier than getting visual studio to build everything statically. What's a popular linux disto for that sort of thing at the moment?

@Fudge Dragon:

Code: [Select]
STR_MISSION_DETAILS: "MISSION LOG"
Thats the only suggestion I thought of for the file. :)  Can't wait fer the gals to get some missions under their belts. :)

Thanks for the feedback, good to hear it's alright.

Interesting, I'll upload the changed file both to my previous post, and I'll bundle it with the Legacy + Build, but I came across what may be a bug.

Shoes you have two sets of STR_MISSION_DETAILS:, One says "MISSION DETAILS", and the other says "MISSION DETAILS FOR{NEWLINE}{0}"

EDIT: Shoes, I notice you've linked my post from the OP, I'll make sure to update that with any changes rather than posting a reply.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on June 02, 2015, 12:44:57 pm
Shoes you have two sets of STR_MISSION_DETAILS:, One says "MISSION DETAILS", and the other says "MISSION DETAILS FOR{NEWLINE}{0}"

Good find ;p I wonder how long that's be like that. If you look at the OP, there's a screen shot of mission details that even says "MISSION DETAILS FOR". The source doesn't provide arguments. I'll keep the simple "Mission Details".

EDIT: Shoes, I notice you've linked my post from the OP, I'll make sure to update that with any changes rather than posting a reply.

That might be the safest thing to do. I would totally post a reply with a link to that post if you ever you make updates though.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: jgatkinsn on June 02, 2015, 03:25:59 pm
Hmm it's certainty appealing, and probably easier than getting visual studio to build everything statically. What's a popular linux disto for that sort of thing at the moment?


That could opening a can of worms right there :)  I think it could be safe to say that Ubuntu Linux distribution is quite popular.  That's what I use.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: SIMON on June 02, 2015, 04:35:35 pm
Looking good shoes.

And with that I'm bringing all my unoffical extra builds up to date.
All builds below are currently based off of the current build of Soldier Diaries (01/06/2015 01:45:12 - Commit:4a5c9e73d308f97d526959b62cb438e79ace1863)

Soldier Diaries Extended (based of of OpenXCom 25/05/2015 08:57:51 - Commit:db285720550dd4cd87482010f9e94464929ad60b & OpenXCom Extended 27/05/2015 18:37:59 - Commit:c90d5f8cfc7a2a351cae1ce60ee348f681eb1b06)
Combines OpenXCom Extended with Soldier Diaries for the latest nightly
Git: https://github.com/fudgedragon/OpenXcom/tree/SoldierDiariesExtended (https://github.com/fudgedragon/OpenXcom/tree/SoldierDiariesExtended)
Downloads: Windows (win32 (https://www.dropbox.com/s/3rrzdvzx6f581jz/Soldier%20Diaries%20Extended%20win32.zip?dl=0) x64 (https://www.dropbox.com/s/qifgjnrysxz5bnw/Soldier%20Diaries%20Extended%20x64.zip?dl=0))

Soldier Diaries Legacy (based of of OpenXCom 30/04/2015 06:20:02 - Commit:28bdaf9eaae8af5d1fa2f6593cf4f619c67fee83)
Provides the latest soldier diaries code, backported to work with the last nightly before the mod changes were brought in, should work with older mods such as Piratez that were designed to work with the older system
Git: https://github.com/fudgedragon/OpenXcom/tree/SoldierDiariesLegacy20150430 (https://github.com/fudgedragon/OpenXcom/tree/SoldierDiariesLegacy20150430)
Downloads: Windows (win32 (https://www.dropbox.com/s/2p5qim5ppf4lym3/Soldier%20Diaries%20Legacy%202015%2004%2030%200620%20win32.zip?dl=0) x64 (https://www.dropbox.com/s/4vu5zuaprqesfcw/Soldier%20Diaries%20Legacy%202015%2004%2030%200620%20x64.zip?dl=0))

Soldier Diaries Legacy+ (based of of OpenXCom 30/04/2015 06:20:02 - Commit:28bdaf9eaae8af5d1fa2f6593cf4f619c67fee83)
Playtested for 8 ingame months
The same as above but also provides the following additional features:
  • Adds Pull Request: Maintenance time is now displayed in the intercept window in the Geoscape by bslaveboy
  • Adds Pull Request: Profitability information on the manufacturing screen by myk002
  • Adds Pull Request: Add melee availability to statstring conditions by    IvanDogovich
  • Adds Pull Request: Add heath bar flash when a soldier has fatal wounds by redv
  • Adds Custom Code: Adds a new (optional) advanced option to restrict aliens to the same psionics rules as humans (someone needs to establish line of sight, but not the soldier doing the MC) by me
  • Adds Custom Code: Adds a new (optional) advanced option to reduce alien time units on the first turn to simulate prior movement and reduce reaction fire by me
  • A Custom ruleset: Optionally changes some interface elements in the diaries for users of the Piratez mod
Git: https://github.com/fudgedragon/OpenXcom/tree/SoldierDiariesLegacy20150430+ (https://github.com/fudgedragon/OpenXcom/tree/SoldierDiariesLegacy20150430+)
Downloads: Windows (win32 (https://www.dropbox.com/s/mbl9qqh1qz8k6oc/Soldier%20Diaries%20Legacy%202015%2004%2030%200620%2Bwin32.zip?dl=0) x64 (https://www.dropbox.com/s/0x9s28421jn7a0f/Soldier%20Diaries%20Legacy%202015%2004%2030%200620%2B%20x64.zip?dl=0))

The piratez_diaries_lang.rul file is also available seperately here (https://www.dropbox.com/s/9qlmuhofiam0fo8/Piratez_lang_diaries.rul?dl=0).

Just updated my current pirates game to the above and really like the new features especially the flashing health bar and fair psionics, well done!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: FudgeDragon on June 02, 2015, 05:29:31 pm
I'm somewhat fond of the flashing health bar myself, so thanks to redv for that.

I don't actually use the fair psionics much myself. While not as crippling to the AI as LOS psionics it still nerfs em slightly, but I certainly see the appeal (I did after all write it).
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Yankes on June 02, 2015, 07:13:21 pm
Hmm it's certainty appealing, and probably easier than getting visual studio to build everything statically. What's a popular linux disto for that sort of thing at the moment?
I grabbed Ubuntu for my uses, but any popular distribution could be fine.
https://mxe.cc/#requirements all supported versions by mxe.

I use this makefile https://github.com/Yankes/OpenXcom/blob/master/src/Makefile.mxe to build.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on June 02, 2015, 08:59:11 pm
Can you guys recommend something that would work with Cygwin, if it exists?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: SIMON on June 03, 2015, 12:44:36 am
Having a problem atm, at the end of my turn during the aliens 1st turn the game crashes to the desktop. It seems to be something to do with either alien soldier id's (01, 05, 07 or 22), attached is .sav file. All u have to do is end the turn. Thanks in advance. Using the previously mentioned SoldierDiariesLegacy20150430+win32. I've managed to work around it by changing the status of those 4 soldiers to "7" and giving them 100 stun but haven't a clue what caused this prob in 1st place and wud like to avoid it again as it took me over an hour to tweak the .sav file.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: FudgeDragon on June 03, 2015, 12:54:22 am
Righto, I'll take a look at that.

EDIT: I build a quick debug build of my binary, and after pulling together your extra mods (Armor_Stealth_Suit, ExtraPockets, WeaponNaymore, WeaponTranquilizer) I was able to load the file and observe the problem.

According the the stack trace the AI is crashing, which neither Shoes original code or my merges have touched. I'll investigate further in the morning, but I suspect loading the file into a non modded exe will give the same crash.

I'm sure Dioxine will correct me if I'm wrong, but my initial guess is a bugged map from Hobbes Terrain pack. At one point people were being encouraged to upgrade it in the Piratez thread, but I don't know what version you would have to download. The latest has been upgraded to the latest nightly and is thus now potentially incompatible.

My initial guess is that those 4 soldiers you knocked out were spawned on bad nodes of some kind. I suspect if you keep playing you won't encounter the problem again, at least not until you encounter another bugged map.

I will however perform my second test in the morning to make sure for you.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Yankes on June 03, 2015, 01:23:03 am
Can you guys recommend something that would work with Cygwin, if it exists?
after couples of hours of fighting with cygwin and mxe I managed to create broken exe that cant load basic game :/
I probably stick to VM and Linux to creating exe.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: SIMON on June 03, 2015, 01:52:10 am
Had to do the same for the last 3 enemies so I look forawrd to what u may come up with. Btw pirates pogrom are bloody hard like flintlocks vs laser weapons!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on June 03, 2015, 02:45:34 am
after couples of hours of fighting with cygwin and mxe I managed to create broken exe that cant load basic game :/
I probably stick to VM and Linux to creating exe.

Thanks for the legwork anyway :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: SDEDEN on June 03, 2015, 05:11:18 am
I can't wait to try the Extended edition! Gonna finish my current play through first. Really just making the final preps for Cydonia.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: FudgeDragon on June 03, 2015, 08:56:45 am
Had to do the same for the last 3 enemies so I look forawrd to what u may come up with. Btw pirates pogrom are bloody hard like flintlocks vs laser weapons!

Right. I built a version of the required nightly for Piratez in debug mode, and you still get the same crash.

From this I believe it is definitely a map crash. Once you get back to the geoscape you should be alright, you might even never see it again. However there was something suggested on the pirates thread that may reduce the chance of this happening. I'm going to quote Dioxine directly:

It might also be a map crash, but those are rare. Grab the latest Hobbes' Terrain Pack and overwrite Terrains, Maps and Routes with what you find there. If the crash persists, I guess there is no other choice than loading your game from before the landing and re-playing the mission. Also make sure Savescumming is enabled so a different terrain will be spawned.

The last version of the terrain pack specifically built for our nightly is 3.5.3, however as we only want TERRAIN, MAPS and ROUTES 3.7 may still be viable, as any incompatibility should be in the ruleset.

This should greatly reduce the risk of it ever happening again although not eliminate it completely. See Dioxine's next post:

Terrains that might cause crashes like this (occassionally, but still) are: Commercial, Railyard, Farm, Urban. The last 2 contain non-Hobbes made custom maps. Sooner or later I'll have to tackle those, but I don't want to 'fix' Hobbes' maps...

It's a pretty small chance it happens anyway, I'm 8 months in and haven't seen a map crash.

Sadly, replacing those files may not fix your current crash, as some map information is baked into your save. You may have to continue as you are (removing troublesome units from the save) for the duration of your current geoscape mission.

Maybe someone else may have another suggestion, but I'm sorry I cannot be any further help. Im 99.9% sure its not my exe.

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Dioxine on June 03, 2015, 12:00:35 pm
The last version of the terrain pack specifically built for our nightly is 3.5.3, however as we only want TERRAIN, MAPS and ROUTES 3.7 may still be viable, as any incompatibility should be in the ruleset.

If a new Nightly created any incompatibility with TERRAINS, MAPS or ROUTES (ie. original game file formats), we'd be better off packing and leaving this site, or rather, waiting for a nightly that repairs such a fatal error :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: SIMON on June 03, 2015, 12:45:51 pm
Ta for all the info, IF I encounter this again I'll reload from just b4 the mission and hence have a different terrain or if that doesn't work I'll try ur suggestion of using just the TERRAIN, MAPS and ROUTES of v3.7.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Dioxine on June 03, 2015, 12:59:22 pm
@Simon: Please use proper English while speaking to civilized people, apparently I can despite being a foreigner to it ;)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: SIMON on June 03, 2015, 01:04:58 pm
Sorry about that, I guess I'm used to using text language a lot but won't be lazy in the future.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: NuclearStudent on June 04, 2015, 03:55:23 am
Sorry about that, I guess I'm used to using text language a lot but won't be lazy in the future.

Yah, m8, ah sware on me fooking mum the grammar takes it to it 'very day. Got's to use the jobber's english or none knows whats to coming through the pipe.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: FudgeDragon on June 05, 2015, 10:22:18 am
I grabbed Ubuntu for my uses, but any popular distribution could be fine.
https://mxe.cc/#requirements all supported versions by mxe.

I use this makefile https://github.com/Yankes/OpenXcom/blob/master/src/Makefile.mxe to build.

Hey Yankes, could you explain a few things about your make file please. I've got a build to compile, after modifing the file to refer to master assets instead of the ones from extended, but I also had to tear out OBJRES = ../obj/OpenXcom_res.o and the $(OBJRES) bit of OBJS =, which stops it complaining about cannot find ..\res\windows\openxcom.ico, but this makes it build without an icon.

My question is, is there something different about OpenXcomEx.rc compared to OpenXcom.rc?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Dioxine on June 05, 2015, 11:08:02 pm
Your custom build has trouble reading custom soldier name directories. Well, it simply doesn't read them. Or so it seems. Care to explain?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: FudgeDragon on June 06, 2015, 12:48:31 am
Can I ask which build you're using? and what you mean by a custom soldier name directory? I spent a while testing the legacy+ build, and initially agreed with your assessment, then realised it was the base nightly too, I then spend ~2h stepping though the code, realised it can't do anything but load all .nam files in the directory, which I'd neglected to remove when I installed pirates. When I stopped being utterly pants on head daft and removed them, my game's now showing pirate names fine.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on June 06, 2015, 12:55:57 am
LOL.  One of the things I built into my "let me upgrade to the latest nightly" powershell script, is a line to delete all the stock .nam files and another to copy in the PirateZ.nam file.  ;)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Dioxine on June 06, 2015, 02:27:00 am
Well yeah but the latest nightlies allow to do it the softcode way, through the ruleset - doing it the old way, by replacement, well it works but I hoped these times are behind us. :)
Ah - and I got a CTD when lost my last unit on a Pogrom (with some uncoscious ones still alive).

Oh, the build - the .exe is dated on 1st June, most other files at 25th May.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: pilot00 on June 06, 2015, 02:48:04 am
Yah, m8, ah sware on me fooking mum the grammar takes it to it 'very day. Got's to use the jobber's english or none knows whats to coming through the pipe.

You be Scotish or Oirish m8?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: NuclearStudent on June 06, 2015, 05:54:55 am
You be Scotish or Oirish m8?

Wot the fok did ye just say 2 me m8? i dropped out of newcastle primary skool im the sickest bloke ull ever meet & ive nicked ova 300 chocolate globbernaughts frum tha corner shop. im trained in street fitin' & im the strongest foker in tha entire newcastle gym. yer nothin to me but a cheeky lil bellend w/ a fit mum & fakebling. ill waste u and smash a fokin bottle oer yer head bruv, i swer 2 christ. ya think u can fokin run ya gabber at me whilst sittin on yer arse behind a lil screen? think again wanka. im callin me homeboys rite now preparin for a proper scrap. A roomble thatll make ur nan sore jus hearin about it. yer a waste bruv. me crew be all over tha place & ill beat ya to a proper fokin pulp with me fists wanka. if i aint satisfied w/ that ill borrow me m8s cricket paddle & see if that gets u the fok out o' newcastle ya daft kunt. if ye had seen this bloody fokin mess commin ye might a' kept ya gabber from runnin. but it seems yea stupid lil twat, innit? ima shite fury & ull drown in it m8. ur ina proper mess knob.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Dioxine on June 06, 2015, 06:45:36 am
@FudgeDragon: Nevermind about the ruleset-defined soldier names - looks like this functionality was broken by 27th May Nightly, so it's not about your build. Well, it was fun while it lasted.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: FudgeDragon on June 06, 2015, 08:21:05 am
@FudgeDragon: Nevermind about the ruleset-defined soldier names - looks like this functionality was broken by 27th May Nightly, so it's not about your build. Well, it was fun while it lasted.

Always the issue with custom builds. You can never be quite sure where the problem is coming from.

I'll check to see if I can get my extended build to crash on a regular terror mission. It's somewhat difficult to test without your savegame, and you can't really send me that because it's useless without your unreleased mod.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on June 07, 2015, 02:28:40 am
So I've done a bit of work to get psi related attacks tracked and I added two basic commendations to take advantage of it. Now the issue is that the screen that displays all the kill stats is getting messy... here is the screen I am talking about.

(https://i.imgur.com/VHpxTLt.png)

The main issue is that kills, stuns, panick attacks and mind controls are all being lumped in there without any discretion. The psi-amp is the weapon for both psi related attacks, so you can't really tell how many of each you've done ... I am wondering if you guys have suggestions on how to get around this. I could straight up list "Sectoid Soldier panicked by a psi amp" and "Muton Soldier killed by a heavy plasma blaster" as a scrollable list, and at the bottom (where it says kills> 2, stuns> 2) I could have more totals. Or I could add more buttons; like kills+stuns and psi, or kills and stuns and psi.

It's something I want to tackle so I want some input before I tear it apart ;p
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: jgatkinsn on June 07, 2015, 04:23:27 am
I think I would prefer another page dedicated to the PSI stats, since PSI is not "kill" or "stun".  As far as Kill/Stun vs Kill + Stun, I don't have a preference.  I'm kind of used to those the way they are.  However, I could see the value of consistency splitting them apart like the psi.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on June 07, 2015, 05:20:26 am
You could use the generic "Psi Attacks" at the bottom with kills and stuns and call it good.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: FudgeDragon on June 07, 2015, 08:18:17 am
Hmm, I'm not really that good at laying out interfaces, but I'm tempted to agree with Ivan here and just have a Psi Attacks total at the bottom, with a couple of caveats.

Is it possible to track kills and stuns via psi: i.e. I mind control that guy, he kills two people and those are technically my kills, or I make that alien panic and he kills one of his buddies.
You could list these as Psionics in the kills list, with maybe a medal for causing an AI unit to commit suicide by grenade.

The only place I think you can afford to go into greater detail is the mission details screen, maybe listing them like PANIC Sectoid Soldier Psionics/Psi Amp
Maybe if the above is possible you could list the kills the enemy makes as a result of this in more detail too. Not entirely sure how you would present that, seeing as you'd want both the aliens weapon and the alien doing the kill on there.

Hmm, thats all I can think of at the moment, either way, having stats for psi will be interesting.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on June 07, 2015, 02:19:58 pm
While I was falling asleep, I did think of a new layout: clicking the Records button would then bring you to a mini menu with only buttons, "missions", "kills/stuns", "psi-attacks", "commendations". Right now it's a mix of buttons and lists, but this way it would be buttons leading to lists. It's more work, so I may just got with Ivan and have a "psi attacks" total.

Now, for crediting mind controlled alien kills to the mind controller, that's gonna be fun! Again, thanks to the new addition of tracking IDs, I can back track and check to see who MCd the alien and give the kill to him. Question will be, how do I describe this kill... this will definitely be a fun little challenge :3

Edit: I did edit the mission details screen to say panic or mind control :)

Here's what I've done today: Added commendations for MCing and panicking aliens, and added a commendation for getting kills with a unit while under your control. Thanks to the code for attributing a cyberdisc explosion's kills to the soldier that killed him, it was pretty straight forward to do the same but for mind control.

Mind Control commendation:
(https://i.imgur.com/jSFmpoJ.png)

Panic commendation:
(https://i.imgur.com/DJ3TzZM.png)

Mind Control kills commendation (I fixed the description, it should read: "Given to a soldier who has used aliens against one another."):
(https://i.imgur.com/cwmk6tv.png)

And the mission details window, which needs to be enlarged (I shot another soldier using an MCd sectoid) :
(https://i.imgur.com/C48BpLP.png)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: pilot00 on June 13, 2015, 01:41:59 am
Wot the fok did ye just say 2 me m8? i dropped out of newcastle primary skool im the sickest bloke ull ever meet & ive nicked ova 300 chocolate globbernaughts frum tha corner shop. im trained in street fitin' & im the strongest foker in tha entire newcastle gym. yer nothin to me but a cheeky lil bellend w/ a fit mum & fakebling. ill waste u and smash a fokin bottle oer yer head bruv, i swer 2 christ. ya think u can fokin run ya gabber at me whilst sittin on yer arse behind a lil screen? think again wanka. im callin me homeboys rite now preparin for a proper scrap. A roomble thatll make ur nan sore jus hearin about it. yer a waste bruv. me crew be all over tha place & ill beat ya to a proper fokin pulp with me fists wanka. if i aint satisfied w/ that ill borrow me m8s cricket paddle & see if that gets u the fok out o' newcastle ya daft kunt. if ye had seen this bloody fokin mess commin ye might a' kept ya gabber from runnin. but it seems yea stupid lil twat, innit? ima shite fury & ull drown in it m8. ur ina proper mess knob.

Bloody hell!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: NuclearStudent on June 13, 2015, 08:16:42 am
Bloody hell!

What the in the name of the Lord did you just say about me, you little beggar? I have you know I am highly trained in gorilla warfare and have flown out with Her Majesties' Secret Service numerous times on top secret raids on Al Qaeda. You are dead to me, good sir. My network of cricket club buddies in MI6 are tracking you down this very minute, and as soon as I'm finished my tea, you will be sorry.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: FudgeDragon on June 14, 2015, 05:49:25 pm
Hey Shoes. Are your most recent commits ready to build? or are you still bughunting?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on June 14, 2015, 06:22:11 pm
Hey Shoes. Are your most recent commits ready to build? or are you still bughunting?

The github branch is up to date with the changes I've made. The only thing that's left to do regarding the mind control changes is what we've talked about: make that mission info window wider, and add a little total for psi-related attacks rather than have the stats mixed in with kills/stuns. Both of these things are aesthetic, so any changes won't result in loss of stats.

So there shouldn't be bugs, but it could be prettier!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: FudgeDragon on June 15, 2015, 09:37:42 am
Righto, was just checking if you'd forgotten to update the first post if if you hadn't built a version yet. I'm in the process of updating my extended builds (testing atm). Partially because extended has been updated, but mostly because Piratez is now using it.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Oladele.Itsifanus on July 13, 2015, 09:01:04 pm
Hi guys, is this mod compatible with Mac version? The Mac version has no OpenXcom.exe, or DLL files. Please say you can make it compatible :) It looks so cool it should be in the default mods.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 13, 2015, 10:29:03 pm
I'm guessing you'd have to compile it yourself. Mac (and Linux) users don't have it quite as easy as the Windows users (but we can use a terminal and scripts, so we're obviously better!  ;D)

Joking aside, I'm about to start a new modded "vanilla" game to test the next version of the XAE, and it feels like I should try it with commendations. Is the code at https://github.com/Shoes01/OpenXcom/tree/alpha_release still the latest one? Just checking because "alpha_release" sounds very preliminary for such a crazy amount of work!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Oladele.Itsifanus on July 14, 2015, 11:15:04 am
Okay, I just installed the Windows version through Wineskin :) Copied my data folder, saves and config, everything works and Soldier Diaries is ready to rock! I just wish I did that earlier, so I had all the stats form the beginning, cause I friggin love my guys ;D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: kikimoristan on July 14, 2015, 01:02:53 pm
Okay, I just installed the Windows version through Wineskin :) Copied my data folder, saves and config, everything works and Soldier Diaries is ready to rock! I just wish I did that earlier, so I had all the stats form the beginning, cause I friggin love my guys ;D
use Vbox and an old XP disc you might have around is what I do. EZ
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Oladele.Itsifanus on July 14, 2015, 01:09:55 pm
use Vbox and an old XP disc you might have around is what I do. EZ
Actually Wineskin wrapper is better, because it doesn't need to start a virtual OS. Or do I miss something?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: hellrazor on July 14, 2015, 02:28:41 pm
I'm guessing you'd have to compile it yourself. Mac (and Linux) users don't have it quite as easy as the Windows users (but we can use a terminal and scripts, so we're obviously better!  ;D)

Joking aside, I'm about to start a new modded "vanilla" game to test the next version of the XAE, and it feels like I should try it with commendations. Is the code at https://github.com/Shoes01/OpenXcom/tree/alpha_release still the latest one? Just checking because "alpha_release" sounds very preliminary for such a crazy amount of work!

I hope that this Soldier stats tracking code will find its way into the Master Branch somewere in the future.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 14, 2015, 07:01:11 pm
Actually Wineskin wrapper is better, because it doesn't need to start a virtual OS. Or do I miss something?
That's probably true, but compiling your own Linux version of the code is even better :P

That's why I was asking about the latest repo, but I guess it is indeed the alpha_release one, since that roughly corresponds to the last update by Shoes.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 14, 2015, 09:41:04 pm
I hope that this Soldier stats tracking code will find its way into the Master Branch somewere in the future.

I just started a new game of OXC yesterday, and I have been finding a number of bugs :x Only one is game breaking!

Don't let your soldiers bleed out. If they are hurt, you will have to put them down.

edit: Updated alpha_release to latest nightly, including the fix for your soldiers bleeding out and crashing your game.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 17, 2015, 08:29:50 am
I started a new game with Commendations too :D And I was loving it! No mod enabled except commendations and statstrings.

But I also decided that for the medals to mean something, I had to play true: No reloads -> Ironman. And I promptly got a crash in my 2nd terror  :'(

I'm not 100% sure what happened.. One of my soldier got shot, then MC'd, then the game crashed. I tried an ethereal terror to check and I can't play past first turn. Presumably because of psi-stuff.

Another comment on the mod: Is there any order in the medals section? It's really hard to find anything since they are not in alphabetical order, and I can't figure out any meaningful grouping.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 17, 2015, 08:14:52 pm
I started a new game with Commendations too :D And I was loving it! No mod enabled except commendations and statstrings.

But I also decided that for the medals to mean something, I had to play true: No reloads -> Ironman. And I promptly got a crash in my 2nd terror  :'(

I'm not 100% sure what happened.. One of my soldier got shot, then MC'd, then the game crashed. I tried an ethereal terror to check and I can't play past first turn. Presumably because of psi-stuff.

Another comment on the mod: Is there any order in the medals section? It's really hard to find anything since they are not in alphabetical order, and I can't figure out any meaningful grouping.

Damn, it's a shame about the crashes. Since your soldier was shot, it might be the same problem as I just fixed and pushed to github. I am doing my own playthrough so I hope to catch lingering bugs. I'll boot up an ethereal terror mission and see if I can get a crash.

The medals themselves don't really have an order to them; the order they're in is the order they're created. For your soldiers, it may be the other in which they're awarded.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 17, 2015, 08:23:03 pm
Yeah, I was thinking it might be that the dude bled out after being MC'd, but with the ethereal terror, I had crashes even with no soldier bleeding (but lots of MC, of course).

Would you be interested in an update to the ruleset which sorts the commendations by alphabetical order?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on July 17, 2015, 08:28:19 pm
Is the UFOpedia section working for you Arthanor? (Just Curious) :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 17, 2015, 08:32:01 pm
Yeah, I was thinking it might be that the dude bled out after being MC'd, but with the ethereal terror, I had crashes even with no soldier bleeding (but lots of MC, of course).

Would you be interested in an update to the ruleset which sorts the commendations by alphabetical order?

I would be very interested in that! Also, the crash was me making (for the second time) the mistake of assuming soldiers had a race. They don't. So when an enemy MCs your soldier, it tries to track his race and fails.

edit: pushed the MC fix to github.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 17, 2015, 08:59:06 pm
Is the UFOpedia section working for you Arthanor? (Just Curious) :)

The UFOpedia looks awesome :D But it was a bit tedious to try to find a specific medal in it. I'd do a mission, my soldiers got something and then finding the article took more time than I liked to spend looking. (I did find all of them though, at the search was worth it!). That's why I suggested I could do a listOrder fix where medals are put in alphabetical order.

I would be very interested in that! Also, the crash was me making (for the second time) the mistake of assuming soldiers had a race. They don't. So when an enemy MCs your soldier, it tries to track his race and fails.

edit: pushed the MC fix to github.
haha! We learn from our mistakes, but sometimes it takes a few tries ;) I bet the fix was faster this time though!

Thanks for fixing it! I'll recompile tonight or this weekend and work on the ordering as well :D

Awesome work, you two, btw. This mod adds a much appreciated layer to XCom, that finally motivated me to play properly.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 17, 2015, 09:51:25 pm
Awesome work, you two, btw. This mod adds a much appreciated layer to XCom, that finally motivated me to play properly.

Always great to hear :) if ever you have suggestions for commendations that you'd like to see, post 'em! I am thinking about adding a commendation for killing an alien that you were not aiming for. I've landed a fair amount of kills like that in this playthrough..
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: DracoGriffin on July 17, 2015, 10:44:48 pm
Killing civilians might be a ... "bad" commendation, lol.

Another suggestion would be integration with X-Piratez! :D

I wouldn't mind coming up with some titles for piratey medals. :P
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 17, 2015, 11:14:33 pm
Actually, the civilian stuff has potential:

Order of Control: Stun 2/5/10/15 civilians
Mark of the Ruthless: Kill 1+ alien and 1+ civilian from the same action (autoshot or explosives). Higher levels could be either for repeats, or for increasing number of alien and/or civilians
Brand of Brutality: Kill 1/2/5/10 civilians
Wreath of the Angel: Complete a terror mission with 60/70/80/90/100% of civilians still alive.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 18, 2015, 04:38:54 am
I love the idea of a commendation that gets a higher decoration based on % of completion!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 18, 2015, 04:55:39 am
I just looked quickly through the ruleset for inspirations of names, and actually you do have a similar medal:
Valiant Crux: "Given to a soldier who protected all civilians during a terror mission."

So maybe downgrade the 60 to 90% ones to citations? (A citation is sort of a "low level" reward, right?) And 100% would give the Crux?

I was going to suggest something similar for stunned aliens, from 60% to 100% (and medium sized UFOs or more), but the Mercy Cross already does more than that, as it rewards a soldier who stuns all the aliens all by himself. Maybe, again, a citation issued for 60% to 90%?

Also, is there something for successfully recovering cyberdiscs by stunning them instead of making them blow up?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 18, 2015, 05:28:32 pm
Good point on the Valiant Crux. I think I'll add the Wreath of the Angel anyway, because of the low likelihood of saving 100% of the civilians. To distinguish the "betterness" of the Crux, the Wreath would have one gold star while the Crux would have three.

As for stunning cyberdiscs, I was under the impression that those guys couldn't be captured; however, the commendation can be made in the ruleset without additional code!

Something along the lines of:

Code: [Select]
  - type: STR_MEDAL_TERRORISTSTUN_NAME
    description: STR_MEDAL_TERRORISTSTUN_DESCRIPTION
    sprite: 00
    criteria:
      killsWithCriteriaCareer: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
    killCriteria:
      -
        1: ["STR_LIVE_TERRORIST", "STATUS_STUNNED"]

Replace the STR_LIVE_TERRORIST with STR_CYBERDISC_TERRORIST and your commendation is specific to that unit instead of Reapers, Sectopods and the rest.

If you're still alphabetizing the commendations, feel free to throw in some custom ones too. As long as the player doesn't get flooded with commendations every mission, it's all good!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 18, 2015, 06:39:06 pm
Ah! Good to know. I'll have to look into how to define commendations too :)

You indeed can't capture cyberdiscs, but you can kill them in such a way as to preserve the corpse instead of having it blow up. In certain mods that's hugely beneficial (in mine you can disassemble it, in others you can then use it). So I was thinking of a "Order of Preservation" or something, for soldiers who manage to kill a number of discs without having them blow up.

Saving all civilians is indeed pretty unlikely, that's why I was thinking of a % based commendation where higher "levels" would be saving a larger %.

Another one: Brand of the Wrecker, for causing large amount of property (building) damage.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 18, 2015, 09:22:44 pm
Tracking if a cyberdisc blew up or not would require new code, but I think it would be straight forward enough: take a look at what was looted from a mission, and track it. Destroying tiles opens interesting possibilities, but I have no experience in that part of the source code. I have a feeling it might be either too restricting if done properly, as the engine doesn't differentiate between a meaningful tile and simply grass; I would have to make a list of "tracks" and "don't tracks". Doing something like "has destroyed 1000 tiles in his lust for xenocide" is appealing though!

I'll add these to my list of things to think about.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 18, 2015, 11:55:55 pm
Good! I'm just throwing ideas around. There's already a lot so I have to come up with weird ones ;)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 19, 2015, 04:58:18 am
So.. I started working on the ordering, but I am getting confused now. Thinking of the bigger picture, the names will be all jumbled in other languages (which I guess is not different from now..) and it looks a bit all over the place with orders/ribbons/stars/crosses/etc. all mixed up.

Is there an order that would be sensible to use for the different types of commendations? I was first thinking of something like:

Code: [Select]
- Titles (ex.: Man of Steel)
- Stars
- Crosses
- Orders
- Medal
- Ribbon
- Citations

Sort of in order of prestige? (from my perception of the name, I have no idea if that's actually the case!) Then they would be ordered alphabetically within a type. That way, in other languages, there would be a small amount of order which would make things a bit easier to find.

Edit: I've got another possibility, which is "simply" sorted by commendation type alphabetically first, then by full name. That way you get:

Code: [Select]
- Badges
- Citations
- Commendations
- Crosses
- Hearts
- Medals
- Orders
- Ribbons
- Star
- Titles
- Misc/Others

It makes the UFOPaedia listing feel sort of like a book in which each chapter is a commendation type, which I find appealing. It's also relatively easy to look through: Quickly go through types, then slowly through names of that type. And it's easier to go through types alphabetically since that's an ordering scheme your brain is used to.

I've made a google spreadsheet with all the names and types here (https://docs.google.com/spreadsheets/d/1H9QCX30FW8cjQNINb_85yt9m6h6Kj-HTzFe5WmT5ka4/edit?usp=sharing) so you can see what ordering by names and types alpabetically look like. I didn't do "types by prestige" since I don't really know what the order would be ;)

What do you think? Type by prestige, type alphabetically or straight up names alphabetically?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on July 19, 2015, 06:00:04 am
I had basically sorted the medals by category too:

https://docs.google.com/presentation/d/1HrWtmUwEo1nwn-tgo2IH9zvWNU32SV3QV5G5ggXqGnU/edit?usp=sharing

This may be another way to order them.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: wsmithjr on July 19, 2015, 07:11:43 am
I've installed the recent Extended + Commendations install found in another thread.  I've just noticed, that after 3 completed missions, a few of my soldiers have not been promoted.  One guy has 3 missions completed and 1 kill and another 2 kills and they are still Rookies.  In fact, I noticed that I have no Squaddies in the roster at all.  They are either Rookies or Sergeants/Captains.

Anybody else noticing similar behavior?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 19, 2015, 03:20:26 pm
I haven't messed with promotions like that, so I can't be sure what's going on. Maybe Extended got rid of Squaddies because it's not reallya rank?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: wsmithjr on July 19, 2015, 03:26:52 pm
I haven't messed with promotions like that, so I can't be sure what's going on. Maybe Extended got rid of Squaddies because it's not reallya rank?

Very next battle I had a bunch promoted to Squaddie.  Still, it's weird that guys with kills were not at least squaddies and I have a dead soldier in the memorial who was in 6 battles with 6 kills and is still a Rookie.  I'll set up Commendations with vanilla and see if the behavior is different.  Some other odd things were going on, but I'm sure it's because of other mods I'm using.

On another note, is there an explanation somewhere of how the score is calculated for soldiers?  Just curious.

Thanks.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 19, 2015, 09:01:06 pm
The score for soldiers is the same as the score for missions; each soldier is given that score. So a rookie that sits in the back of the skyranger will still get a good score at the end of the month!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 19, 2015, 11:53:38 pm
I had basically sorted the medals by category too:

https://docs.google.com/presentation/d/1HrWtmUwEo1nwn-tgo2IH9zvWNU32SV3QV5G5ggXqGnU/edit?usp=sharing

This may be another way to order them.

Hum.. Interesting! It's hard to organize everything using those categories since the names are not uniform. Maybe I could change the UFOPaedia display names to something like:

Attack - Inferno Star
Attack - Order of the Hammer
Attack - XenoCide
Heroism - Order of Glory
Heroism - Valiant Cross
Sacrifice - Black Cross
Sacrifice - Purple Heart
Support - Honor Cross
Support - Terran Cross

But then the Medal of Heroism needs to go from Wounds to Heroism.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 20, 2015, 10:29:22 pm
Well.. I decided to go with the "order by commendation type, alphabetically" scheme. Let me know what you think!

Shoes, do you think it would be possible to add a new UFOPaedia section for commendations instead of moving HWPs?

I would love to use commendations for the XAE, but I'm not sure about distributing 2 rulesets, 1 for vanilla, 1 for commendations.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 21, 2015, 01:52:48 am
Ivangodovich did all the ufopaedia work, and at the time it was much much simpler to shuffle around existing links instead of creating a new one. I can take another look, but at my present pace I wouldn't count on anything soon!

Also, the reason I distribute a vanilla ruleset as well is because I hope to one day have this mod, specifically the stat tracking portion, be a part of the source code. It might be possible to move everything to have one ruleset again!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 21, 2015, 03:06:07 am
No rush ;)

The comment on rulesets was in order to make other mods that have HWPs compatible with the Commendation mod. Currently, other mods have HWPs in the HWP section, which means that they would show up with medals if Commendations is enabled.

This makes other mods require two rulesets: One for HWPs in the craft section to use with Commendations, one for HWPs in the HWPs section to use with vanilla. It's not much work, but it is a bit of a hindrance in terms of compatibility (and you can bet some people will enable both, then complain that the ufopedia is wonky! ;)).

If you were to add an extra "Commendations" section, then other mods would not have to change anything in order to work. Make it enabled through ruleset and you get a fully compatible vanilla+mods code, which is a step further to being integrated.

I fully support your attempt to get this rolled into the source. I think it is amazing in terms of immersion and motivation. You care even more for your soldiers, but at the same time it adds more value to not-reloading, since otherwise every soldier will end up "the same".
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 21, 2015, 03:28:15 am
Good point! I'll add it to my list of things to do ;p
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 21, 2015, 04:08:29 am
Bug report! :(

Got a soldier (Jan Fuglestad) who killed an engineer and navigator and somehow managed to get himself awarded the "Taking names" commendation, which was promptly taken away with a letter blaming an intern who doesn't work at XCom anymore.

I kept some record though, see save attached.

Edit:
The stats tracking side of things seems to work very well, except for being a bit generous with what's a "Night Op". I've got some other issues with the awards though and I am still not well versed enough in this to figure them out (See Com1 save attached):
1 - More "Taking names" were awarded. It seems like killing any 2 ranks awards it?
2 - The Order of Earth is awarded if you fight a medium scout + 2 large scouts. In the logs the missions are properly identified, but the soldiers got the award any ways.
3 - The criterion for night is a bit loose. I often wait until dawn to raid UFOs, so I am not at a disadvantage vision-wise. But that still seems to be considered night for the awards.

Maybe there could be the "Night Stalker" award for when it's dark enough to impair soldiers' vision range, and a "Dawn and Dusk Raider" for raids conducted at low light but full vision?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: wsmithjr on July 21, 2015, 06:05:18 am
Don't know if it affects anything, but there's a string error in Commendations with the latest nightly.  In the Options - Mods screen, putting the cursor over any of the mods shows the string "STR_MODS_TOOLTIPS" instead of a description of the mod.  I'm using the 2015-05-25-Nightly version with the latest OXC nightly.  I've checked and I don't see the same problem with vanilla OXC.  I think I have it installed correctly as everything else seems to work.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 21, 2015, 02:39:06 pm
Don't know if it affects anything, but there's a string error in Commendations with the latest nightly.  In the Options - Mods screen, putting the cursor over any of the mods shows the string "STR_MODS_TOOLTIPS" instead of a description of the mod.  I'm using the 2015-05-25-Nightly version with the latest OXC nightly.  I've checked and I don't see the same problem with vanilla OXC.  I think I have it installed correctly as everything else seems to work.

That means there's a string missing. I think it used to work, so double check that you've installed things correctly. I know the folder structure for mods have changed too, so you might need to do a clean install to make sure everything is working right.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 21, 2015, 06:10:18 pm
I just checked on my install (made using git and compiled/installed locally) and everything works fine. Seems like it's either something from the pre-compiled Windows version or a mistake while installing.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 21, 2015, 07:24:42 pm
Good news! I've added commendations button to the ufopaedia: https://imgur.com/f5XHegJ,wPiBdkh,LbwPi4f

Now that it works, I can make it pretty.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: DracoGriffin on July 21, 2015, 07:45:22 pm
Nice; can't wait to see the improved UFOpedia.

Anything text-wise that you could use help with?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 21, 2015, 08:32:09 pm
Nice; can't wait to see the improved UFOpedia.

Anything text-wise that you could use help with?

ivandogovich did a great job adding flavor text to the commendations in the ufopaedia; any new commendations I've added are missing that text. If you wanted to dig through the ruleset and add some text, it would be greatly appreciated!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 21, 2015, 08:42:07 pm
Good news! I've added commendations button to the ufopaedia: https://imgur.com/f5XHegJ,wPiBdkh,LbwPi4f

Now that it works, I can make it pretty.

Awesome! That extra section will make things much easier :D

How do things work with modded alien races? Can you get "Gazer XenoCide" if you will a whole bunch of gazers? Or is it restricted to vanilla races? I guess one could mod-in the required commendations for extra races?

And how would it impact things like the Hercules medal (for killing one of each terror unit) if you add new terror units?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 21, 2015, 10:14:49 pm
Here is the commendation for killing one of each terror units:

Code: [Select]
  - type: STR_MEDAL_ANTITERROR_NAME
    description: STR_MEDAL_ANTITERROR_DESCRIPTION
    sprite: 46
    criteria:
      killsWithCriteriaCareer: [1, 2, 3, 3, 3, 3, 4, 4, 4, 4]
    killCriteria:
      -
        1: ["STR_CYBERDISC", "STR_LIVE_TERRORIST", "FACTION_HOSTILE", "STATUS_DEAD"]
        1: ["STR_REAPER", "STR_LIVE_TERRORIST", "FACTION_HOSTILE", "STATUS_DEAD"]
        1: ["STR_CHRYSSALID", "STR_LIVE_TERRORIST", "FACTION_HOSTILE", "STATUS_DEAD"]
        1: ["STR_SILACOID", "STR_LIVE_TERRORIST", "FACTION_HOSTILE", "STATUS_DEAD"]
        1: ["STR_CELATID", "STR_LIVE_TERRORIST", "FACTION_HOSTILE", "STATUS_DEAD"]
        1: ["STR_SECTOPOD", "STR_LIVE_TERRORIST", "FACTION_HOSTILE", "STATUS_DEAD"]
        1: ["STR_ZOMBIE", "STR_LIVE_TERRORIST", "FACTION_HOSTILE", "STATUS_DEAD"]

Here you would have to add the new terror units to be properly recognized.

The Xenocide medal is special though :) it was made with modding in mind, so adding new races will "add" new xenocide medals. Same goes for the weapons proficiency medal and the campaign medal: add new weapons or countries, and you get "new" medals.

I was thinking more about the "saving civilians" medal, and I think it's possible to overwrite a medal with another, thus "upgrading" a medal. I don't know how the rest of the code would react... maybe if you have the 100% rescue medal, you'll continue to receive the 90% rescue medal as well... it's something I will test.

And another note on the ufopaedia: I am able to have a "with commendations enabled" and "without commendations enabled" version, I just need to play with some numbers to make it pretty. This is essential in having the code included in the base game.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 21, 2015, 11:08:50 pm
Awesome forward thinking for the XenoCide, Weapons and Campaign medals!

For the Hercules, I would just have to add

Code: [Select]
        1: ["STR_CYBERMITE", "STR_LIVE_TERRORIST", "FACTION_HOSTILE", "STATUS_DEAD"]
in order for a cybermite to be included as a requirement?

Is this an additive list? Or do I have to rewrite the whole thing?

It would be good as an additive list, then each new race's ruleset could simply add entries to the commendation lists, without having to worry about conflicts.

And great news on the new UFOPedia! :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 22, 2015, 12:12:28 am
I'm not sure what you mean by additive list, but I think it is yes. By adding that line of code, you are saying that "1" kill needs to have the following: be of race STR_CYBERMITE, be of rank STR_LIVE_TERRORIST, be of faction HOSTILE and be DEAD.

Here's a fun fact! The kills with criteria career (opposed to mission or turn) is a list of 10 (or fewer (or more if you add new sprites!)) integers that need to be reached; in this case, 1, 2, 3, 4. The repeating is to skip decorations, so you go from no pins, to 1 bronze, to 2 silver, to 3 gold. However, the numbers in the kill criteria itself are important too; in this case they are all ones. So if you've killed 1 of each terrorist, you've completed "1" kill with criteria career. If you changed it to "2: ["STR_CYBERMITE", ...]" but left the others one, you would only get the "1" kill with criteria career if you've killed one of each, but 2 terrorists.

Probably would have been simpler if I pointed you to the grenadiers medal:

Code: [Select]
  - type: STR_MEDAL_GRENADIERS_MEDAL_NAME
    description: STR_MEDAL_GRENADIERS_MEDAL_DESCRIPTION
    sprite: 14
    criteria:
      killsWithCriteriaTurn: [1, 2, 3, 3, 3, 3, 4, 4, 4, 4]
    killCriteria:
      -
        3: ["FACTION_HOSTILE", "STATUS_DEAD", "BT_GRENADE"]
      -
        3: ["FACTION_HOSTILE", "STATUS_DEAD", "BT_PROXIMITYGRENADE"]

Here, in a single turn, you need to kill "3" hostiles with a grenade OR a proximity mine. Fun stuff. There's a big comment chunk in the ruleset with more details on how to make your own :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 22, 2015, 12:29:11 am
By additive I mean: If I had this in a new alien race mod:

Code: [Select]
- type: STR_MEDAL_ANTITERROR_NAME
    killCriteria:
      -
        1: ["STR_CYBERMITE", "STR_LIVE_TERRORIST", "FACTION_HOSTILE", "STATUS_DEAD"]

Will it add this killCriteria to the existing list (meaning you need to kill a cybermite on top of one of everything else), or will it overwrite the whole list (meaning you only need to kill a cybermite).

So parts of the rulesets are loaded in an additive way, others are loaded by replacing previous entries.

I'll look in the ruleset for more details too :D I didn't notice..
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 22, 2015, 03:22:04 am
Interesting, I hadn't considered that behavior for the ruleset. I doubt that it will be additive though; I think it would replace. You can try it though :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: DracoGriffin on July 22, 2015, 06:39:39 am
Looking through the ruleset; a standardized template would be good, especially for consideration inclusion to source code.

Some quotes had a leading space or trailing space (or neither), others did or didn't, some had one dash, most had two, a few had colons. Term for soldiers doesn't seem uniform. Term for enemy is loose; aliens, hostiles, threat, enemies, targets, etc are all used. Term for commendations is also sporadic: award, medal, commendation, order, citation, etc. Lastly, some of the quotes seem out of place, considering; Darth Vader, Disney movie, comedy movies, etc.

A defined template/standard would be great; although for source inclusion it may be best if text is geared towards "aliens"/"XCOM", in contrast to a more "neutral" tone and terms to allow "plug & play" accessibility for mods.

(e.g., XCOM -> Awarded to a soldier who killed ten Ethereals with a laser pistol. / "Neutral" -> Given to a unit after eliminating ten hostiles with a sidearm.)

Perhaps "awards" are the "upgradable" ones, "medals" are the generic one-off awards, "orders" the more exclusive/difficult to achieve; rather than just a "because it sounds cooler".

So far, this is what I've gleaned as a mock "standardized" template:

Flavor Quote - "... And so, thus medals were given to soldiers." -- A historical commander
Flavor Text - Soldiers that accomplish cool stuff against the big bad aliens get shiny bits attached to their uniforms.
Oracle (Actual) Text - This award is given to a soldier after killing X aliens.
Specific Level/Upgrades - Further levels are awarded after every Y alien kills, until reaching Z status.


Attached a compare (just change to .htm, much better readability), and suggested revisions. I apologize for being forthcoming; tried to use a more "neutral" tone and standardize the entries somewhat, but can't do much more without official clarification (see above).
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: wsmithjr on July 22, 2015, 07:30:40 am
I just checked on my install (made using git and compiled/installed locally) and everything works fine. Seems like it's either something from the pre-compiled Windows version or a mistake while installing.

Well, I don't know what I'm doing wrong, then.  Tried a brand new install and still have the error.  The following is the exact install procedure I've used in Windows 7:

a) Redownload latest nightly: openxcom_git_master_2015_07_13_1222.zip
b) Redownload latest Commendations: 2015_05_25 Nightly.zip
1) Create d:\Games\OXC folder
2) Copy contents of openxcom_git_master_2015_07_13_1222.zip to d:\Games\OXC
3) Copy original UFO files to d:\Games\OXC\UFO folder
4) Copy contents of universal_patch.zip file to d:\Games\OXC\UFO folder, overwrite all files
5) \User\Documents\Openxcom folder is completely empty
6) Test game, everything works including MOD description text
7) The following is automatically added to \User\Documents\Openxcom foder: mods folder, options.cfg and openxcom.log
8) Copy Commendations contents from 2015-05-25 Nightly.zip to d:\Games\OXC folder, overwrite all files
9) Run game, get STR_MODS_TOOLTIP instead of mod descriptions
10) Enable Commendations mod in mod list
11) OXC reloads STR_MODS_TOOLTIP is still there instead of mod descriptions.

So, what am I doing wrong?  Everything seems to work except that one string, but it doesn't make sense to me why that one string is wrong.  And, if that is wrong, it makes me wonder what else might be wrong that I can't see right now.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: yrizoud on July 22, 2015, 11:44:07 am
If your  language is set to English-US, try English-England
If your  language is set to English-England, try English-US
If it fixes something, the issue was specific to that one language you moved from.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: wsmithjr on July 22, 2015, 11:58:35 am
If your  language is set to English-US, try English-England
If your  language is set to English-England, try English-US
If it fixes something, the issue was specific to that one language you moved from.

Thanks.  I meant to check that but forgot.  For some reason, language was set to "ar" ... whatever that is.  Changing it to English (US) didn't matter because nothing changed.  Changing it to English (UK) mucked everything up.  Changed it back to US but that string is still missing.

Just for kicks and went back and tried the oldest nightly I could download.  No change.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 22, 2015, 03:15:26 pm
So, what am I doing wrong?  Everything seems to work except that one string, but it doesn't make sense to me why that one string is wrong.  And, if that is wrong, it makes me wonder what else might be wrong that I can't see right now.

It would definitely seem like you're doing everything right, especially given that the mod tooltip text worked before my mod was installed. You have a few options: find the May 25th nightly and use that to play the mod, or compile from source your own version of the game to play the mod, or play the mod without the tooltip texts.

At some point once I have the ufopaedia stuff sorted out I will post another updated .exe, and it should work then. Statistics carry over, so you won't "lose" anything in that sense. I would also be interested in knowing if other strings are missing, or if it's only the tooltips.

@DracoGriffin, thanks for the input! Standardization is something I do want to do, even in the source code I use interchangeably "commendation" and "medal" and "award". I'm not able to properly look at the commend_compare.txt; it looks like a git diff file, but I don't know how to look at those independently. I use a CLI for git, so any advice there would be appreciated.

One of my goals for this mod is to be itself moddable and usable by other mods, so I would definitely want a more "neural" tone to the commendations. It's funny timing that you would mention creating a definition for what is a "medal" and what is a "cross" and all that, as Arthanor is hoping to put some order in the commendations listings.

I will add this to my growing list of things to keep in mind! (found here: https://gist.github.com/Shoes01/3af40f402d287ae9c229 )

edit: Here are the final ufopedia alterations, both with and without the mod enabled: https://imgur.com/a/nWF87/all ; I decided not to increase the length of the list however.

edit 2: new size of the soldier mission details window: https://imgur.com/enwrGzQ

edit 3: the kills screen (https://i.imgur.com/VHpxTLt.png) at the moment will mix psi panicks, psi controls, kills and stuns all in one big mess. I have added a "Panicks> ##" and a "Controls> ##" at the bottom of the screen, but the psi-attacks will still show up in the list of kills/stuns, unless I do some fiddlin', that is code duplication. Which I am not fond of. For the moment, I will leave it all jumbled in, but I would like to input again on what to do with it. Screenshot: https://imgur.com/03yyG9f ; notice the numbers are 0 despite the psi-amp being at 1, this is because the totals are calculated on the fly.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 22, 2015, 05:25:40 pm
Nice looking UI work Shoes! The Commendations section fits right in  :D

Did you see the ruleset I uploaded a few posts ago? It has commendations ordered by type (alphabetically), then by name (alphabetically again). I like that the most for now since it makes it feel like a book (with a chapter on medals, one on crosses, etc.).

I'm not sure I agree with the idea of making the text neutral, I think it should be made XCom specific. The source code is for XCom so this addition should be too. If someone wants to make a Pirate mod, a Fantasy mod, a WW2 mod, a realistic modern day mod or whatever, they will likely want to rename everything and change all the text any ways, so we might as well do something that fits in with XCom.

What I do agree with, though, is putting some kind of sense into which medal is which. The mix of orders/crosses/medals/etc, with no real link with how prestigious they are, is odd (but all the names sound cool :D). I haven't changed it in the ruleset I made because that's not my work and I didn't want to go renaming stuff others did but if you and Ivan are up for that, I think it could be a good thing.

We currently have:
- Badge
- Citation
- Commendation
- Cross
- Heart
- Medal
- Order
- Ribbon
- Star
- Titles (ex.: Iron Man, Man of Steel, Night Stalker)

It is a bit hard to order (and I have no military knowledge), but I would say:
- Star (Most prestigious, hardest ones to get)
- Cross
- Order
- Medal
- Ribbon
- Commendation
- Citation
- Badge (Least prestigious, easiest one to get)

- Heart/Titles/Others (Special cases)

What do you think?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 22, 2015, 05:44:16 pm
I am looking at it now! It looks great; I am surprised by how much polish it adds.

 I agree with your ideas on the prestigiousness of the names. Have you played many games using the mod? If you've got a decent feel for the flow of commendations, I would gladly accept your changes. It's sort of what I'm doing at the moment, playing through and seeing what is being given too often (Order of Earth), or incorrectly (anything that needs a list of kills).

My thoughts on keeping things neutral is more along the lines of "Enemy has been killed" instead of "Space alien has been killed". By trying to keep things more traditional, it makes it more believable that a military organisation would hand out these commendations. I don't think there are any really offending commendations though.

Also! New nightly mod: https://dl.dropboxusercontent.com/u/234369005/OXC/2015-07-22%20Nightly.zip

As mentioned above, some commendations aren't working right anymore, I'm not sure why. No worries though, as stats continue to be tracked correctly, so when this gets fixed, you can enter debug mode (Ctrl+D) and then wipe the commendations (Ctrl+C); they'll all be regiven at the end of the month or the next mission.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 22, 2015, 06:06:52 pm
It seems like such a small change, but it actually makes quite a big difference in that section. I'm glad you like it :) I can look into polishing the text after that, although Ivan did a great job with it. And we can think of which awards should go where (which is a fair amount of work with 60+ of them!) I'll recompile from git tonight or tomorrow to see the UI improvements.

This is only my first attempt at using commendations, after being interested for so long. I'm doing an almost completely unmodded playthrough now. My suggestion of adding your own category was so that it would be easier to import the XAE into my next playthrough ;)

I have noticed that medium scouts count towards Order of Earth (supposed to be 3 missions, Large scouts or bigger). I actually would suggest making it 3 missions: medium UFO or bigger, or terror/base defence/base attack. All the small UFOs are too routine to deserve an award I think.

I assume that the kills problem also affects Taking Names? I've had that one awarded too much too.

@wsmithjr: Are you sure your installation is looking at the right ruleset? In theory, mods should have a metadata file that would cover that, which now is missing so the game tries to display the default string, which also is missing. That, to me, points towards your installation trying to run off data from an older version of OpenXCom.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 22, 2015, 06:35:21 pm
I took a look at the Order of Earth, wondering what exactly the problem was: I am handing it out for every mission. I have a list of mission "types" that aren't counted, but then I list "ufos" as the types. Meaning nothing is not counted.

I am going to change it's behavior though, and award a point towards Order of Earth for any mission that was not a UFO Recovery. It's not entirely fair, but it is future proof: by singling out which UFOs this counts for or not, any future mod that adds UFOs will not interact desirably with the commendation. This also means that a small UFO that lands will grant Order of Earth, but I think it's still appropriate. You're assaulting the UFO, you're not cleaning up after your interceptors.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 22, 2015, 08:32:17 pm
That's an interesting take on it. Could it use the size class of the UFO instead? Something like anything medium (or large?) and above count regardless of if it is a recovery or an assault. Assaulting a medium scout is nowhere near as difficult as cleaning up a terror ship or battleship.

Any modded UFO will also have a size class (for the radar/hyperwave feedback), so that would be future proof as well. The only difference with the current intended behaviour would be that large scouts would be excluded as well, which really isn't that bad since those are quite routine (and thus not really worthy of a reward).

I guess it is easier to implement: "Anything but recovery" than "recovery&assaults of UFOs medium and larger, plus anything but recovery&assaults" ;)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 23, 2015, 12:32:52 am
I'm glad I did a bit of research before replying to you, otherwise I would be eating my words ;p It seems like going with UFO size is the easiest thing; up until now I did not know UFOs actually had a size. It seems like going with Medium size and up gets rid of the scouts, or going with Large size and up gets rid of harvesters and abductors as well. I don't mind going with medium and up. The way I will code it though is, if a mission was _not_ against a small or very small UFO, then it was important. That way, base missions will still be important.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 23, 2015, 02:09:55 am
That's awesome! I'm glad I could help. I think medium and up are indeed worthy foes. Anything but small UFOs keeps terrors, base attack/defense and any other crazy stuff people are bound to come up with :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: DracoGriffin on July 23, 2015, 02:16:50 am
@DracoGriffin, thanks for the input! Standardization is something I do want to do, even in the source code I use interchangeably "commendation" and "medal" and "award". I'm not able to properly look at the commend_compare.txt; it looks like a git diff file, but I don't know how to look at those independently. I use a CLI for git, so any advice there would be appreciated.

One of my goals for this mod is to be itself moddable and usable by other mods, so I would definitely want a more "neural" tone to the commendations. It's funny timing that you would mention creating a definition for what is a "medal" and what is a "cross" and all that, as Arthanor is hoping to put some order in the commendations listings.

I will add this to my growing list of things to keep in mind! (found here: https://gist.github.com/Shoes01/3af40f402d287ae9c229 )

Yeah, if you download that .txt and change the .txt to .htm, it'll work. It's just a WinMerge Report.

And I think Arthanor misunderstood me...

But anyway, Shoes, if your goal is both source code inclusion and moddability, it would be best to gear towards the XCOM feel (by fitting the tone/theme of other UFOpedia entries), but having commented lines so modders can easily make changes. An open standard established by you would be great for people like me (I love to edit wikis; ask Hobbes :P).

So uh, let me know if you want me to do more work or not, based on previous convo looks like you guys moved onto bigger and brighter. lol

edit: Also, what I meant about the award thingy:
(general, everyone gets) Commendations - awarded for surviving first mission, or surviving first month with XCOM
(moderate, most soldiers will get if specialized/live long enough) Medals - attained certain rank, captured X enemies, killed Y enemies with grenades
(rare stuff, the commemorate those "Picard" hero types) Star - hit a target with less than 5% chance, mind-controlled an Ethereal (or an enemy with over X Psi-Defense)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 23, 2015, 02:32:14 am
Yeah, if you download that .txt and change the .txt to .htm, it'll work. It's just a WinMerge Report.

...

So uh, let me know if you want me to do more work or not, based on previous convo looks liek you guys moved onto bigger and brighter. lol

Wow, you did a lot of work! I think those changes are great. What other changes did you have in mind? It seems like you already touched on a majority of strings. Anything that adds polish to this project is more than welcome!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: DracoGriffin on July 23, 2015, 02:51:29 am
Wow, you did a lot of work! I think those changes are great. What other changes did you have in mind? It seems like you already touched on a majority of strings. Anything that adds polish to this project is more than welcome!

If you notice, they aren't completely uniform. Some were just cleaned up, and some were altered with a neutral point of view; kind of to serve as a mock sample. I have no problem doing more work, as I was getting started on the British version but I'd rather do the work with your approval and how you'd like it to look. :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 23, 2015, 05:51:07 am
If you notice, they aren't completely uniform. Some were just cleaned up, and some were altered with a neutral point of view; kind of to serve as a mock sample. I have no problem doing more work, as I was getting started on the British version but I'd rather do the work with your approval and how you'd like it to look. :D

I say have your fill! My only concern would be the ufopaedia entries, as those were all done up by ivandogovich. If you have big plans with those entries, I would suggest checking in with him for some feedback.

With the work you're doing, and the work Arthanor has done, this mod is gonna feel pretty good.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 23, 2015, 06:38:03 am
And I think Arthanor misunderstood me...

Halfway ;) The way you presented your example (XCom first, Neutral second) confused me. I didn't understand what you meant for the tone and thought you wanted to make it neutral as in not flavoured for any one application. Rereading your post now, I see that it wasn't the case and that we, in fact, agree on a lot.

As for vocabulary, it is probably easiest to say "alien" for the aliens, as that seems to be what they are most often refered as, with enemy being a decent substitute to avoid too much repetition within articles (since it is Enemy Unknown, I feel like it keeps the same vibe). Soldiers for soldiers.

The order of awards you have (Commendation -> Medal -> Star, from easy to rare) is similar to what I was suggesting, but I think it would be good to keep some other terms, something like, from common to rare:

Citation (soldier is cited as an example):
The "easy" stuff, surviving, total kill numbers, flanking, backstabbing, headshots, total missions

Commendation (soldier is commended for his action) :
Somewhat exceptional, but not something that would get you a medal. ex: Long distance shots, lucky shots, killing multiple enemies with explosives, stats improvement

Medal (soldier is honored for something worthy):
The first special thing (for absolute number of kills, number of kills per missions), going on X missions, going on Y (less than X) night mission

Order (soldier joins an elite order made of outstanding individuals, like the French Légion d'Honneur):
For things that only a few would manage to do, but also have a "personality". XenoCide is a good example, where you would expect soldiers that excel at killing a certain alien to share a certain "bond", like members of an order would. Stunning lots of aliens and saving all civilians could fit here too. It would be neat to have ranks here be knight, officer, commander, grand officer and grand cross, or something similar, to give the impression of an Order.

Cross:
Really hard/rare stuff, like capturing leaders and commanders, drawing fire a lot

Stars:
The almost impossible stuff, like killing/stunning all aliens in a mission, doing a mission all by yourself. Checks have to be made so that you can't do those against a small scout ;)

I've just updated my spreadsheet (https://docs.google.com/spreadsheets/d/1H9QCX30FW8cjQNINb_85yt9m6h6Kj-HTzFe5WmT5ka4/edit?usp=sharing) with all the requirements for awards and made it editable. I'll start listing what I feel those should be based on the above, feel free to edit it (the link should allow that)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: wsmithjr on July 23, 2015, 07:27:24 am
@wsmithjr: Are you sure your installation is looking at the right ruleset? In theory, mods should have a metadata file that would cover that, which now is missing so the game tries to display the default string, which also is missing. That, to me, points towards your installation trying to run off data from an older version of OpenXCom.

Arthanor,

Thanks for the help.  That makes a lot of sense.  I did have a bunch of old folders lying about, so I went and deleted every last reference to OpenXcom from both my install drive and my user folder.  Reinstalled everything from scratch exactly as above.  Problem still exists.

I looked at the openxcom.log file and can't get anything out of that which makes sense.  It does mention E:\Users\Warren.Warren-PC\Documents\OpenXcom\ under Data search but that folder actually does not exist.  Instead of using that, the game just created the user folder in my install folder, D:\Games\OXC.  It says both user and config folder is set to D:\Games\OXC\user.  If there's something extra in there, I didn't put it there myself and I can't figure out what it is or where it could be as the whole folder was wiped before doing a complete reinstall.

Here's the log file which shows where it is searching for and finding everything.  Also, at the end it does show that I'm missing 3 strings from en-us.  But, why are they missing when they are not for others and I haven't touched that file and there's no other file around it could be loading instead?

[23-07-2015 00:16:56]   [INFO]   Data folder is:
[23-07-2015 00:16:56]   [INFO]   Data search is:
[23-07-2015 00:16:56]   [INFO]   - E:\Users\Warren.Warren-PC\Documents\OpenXcom\
[23-07-2015 00:16:56]   [INFO]   - D:\Games\OXC
[23-07-2015 00:16:56]   [INFO]   - D:\Games\OXC
[23-07-2015 00:16:56]   [INFO]   User folder is: D:\Games\OXC\user\
[23-07-2015 00:16:56]   [INFO]   Config folder is: D:\Games\OXC\user\
[23-07-2015 00:16:56]   [INFO]   Options loaded successfully.
[23-07-2015 00:16:56]   [INFO]   Scanning standard mods in 'standard'...
[23-07-2015 00:16:56]   [INFO]   - standard/Aliens_Pick_Up_Weapons
[23-07-2015 00:16:56]   [INFO]   - standard/Commendations
[23-07-2015 00:16:56]   [INFO]   - standard/Limit_Craft_Item_Capacities
[23-07-2015 00:16:56]   [INFO]   - standard/PSX_Static_Cydonia_Map
[23-07-2015 00:16:56]   [INFO]   - standard/UFOextender_Gun_Melee
[23-07-2015 00:16:56]   [INFO]   - standard/UFOextender_Psionic_Line_Of_Fire
[23-07-2015 00:16:56]   [INFO]   - standard/UFOextender_Starting_Avalanches
[23-07-2015 00:16:56]   [INFO]   - standard/XcomUtil_Always_Daytime
[23-07-2015 00:16:56]   [INFO]   - standard/XcomUtil_Always_Nighttime
[23-07-2015 00:16:56]   [INFO]   - standard/XcomUtil_Fighter_Transports
[23-07-2015 00:16:56]   [INFO]   - standard/XcomUtil_High_Explosive_Damage
[23-07-2015 00:16:56]   [INFO]   - standard/XcomUtil_Improved_Ground_Tanks
[23-07-2015 00:16:56]   [INFO]   - standard/XcomUtil_Improved_Heavy_Laser
[23-07-2015 00:16:56]   [INFO]   - standard/XcomUtil_No_Psionics
[23-07-2015 00:16:56]   [INFO]   - standard/XcomUtil_Pistol_Auto_Shot
[23-07-2015 00:16:56]   [INFO]   - standard/XcomUtil_Skyranger_Weapon_Slot
[23-07-2015 00:16:56]   [INFO]   - standard/XcomUtil_Starting_Defensive_Base
[23-07-2015 00:16:56]   [INFO]   - standard/XcomUtil_Starting_Defensive_Improved_Base
[23-07-2015 00:16:56]   [INFO]   - standard/XcomUtil_Starting_Improved_Base
[23-07-2015 00:16:56]   [INFO]   - standard/XcomUtil_Statstrings
[23-07-2015 00:16:56]   [INFO]   - standard/xcom1
[23-07-2015 00:16:56]   [INFO]   - standard/xcom2
[23-07-2015 00:16:56]   [INFO]   Scanning user mods in 'D:\Games\OXC\user\mods'...
[23-07-2015 00:16:56]   [INFO]   Mapping resource files...
[23-07-2015 00:16:56]   [INFO]     mapping resources in: standard/Commendations
[23-07-2015 00:16:56]   [INFO]     mapping resources in: standard/xcom1
[23-07-2015 00:16:56]   [INFO]     mapping resources in: UFO
[23-07-2015 00:16:56]   [INFO]     mapping resources in: common
[23-07-2015 00:16:56]   [INFO]   SDL initialized successfully.
[23-07-2015 00:16:56]   [INFO]   SDL_mixer initialized successfully.
[23-07-2015 00:16:56]   [INFO]   Attempting to set display to 640x400x8...
[23-07-2015 00:16:56]   [INFO]   Display set to 640x400x8.
[23-07-2015 00:16:56]   [INFO]   Loading rulesets...
[23-07-2015 00:16:56]   [INFO]   - standard/xcom1/alienDeployments.rul
[23-07-2015 00:16:56]   [INFO]   - standard/xcom1/alienItemLevels.rul
[23-07-2015 00:16:56]   [INFO]   - standard/xcom1/alienMissions.rul
[23-07-2015 00:16:56]   [INFO]   - standard/xcom1/alienRaces.rul
[23-07-2015 00:16:56]   [INFO]   - standard/xcom1/armors.rul
[23-07-2015 00:16:56]   [INFO]   - standard/xcom1/countries.rul
[23-07-2015 00:16:56]   [INFO]   - standard/xcom1/craftWeapons.rul
[23-07-2015 00:16:56]   [INFO]   - standard/xcom1/crafts.rul
[23-07-2015 00:16:57]   [INFO]   - standard/xcom1/cutscenes.rul
[23-07-2015 00:16:57]   [INFO]   - standard/xcom1/extraSprites.rul
[23-07-2015 00:16:57]   [INFO]   - standard/xcom1/facilities.rul
[23-07-2015 00:16:57]   [INFO]   - standard/xcom1/globe.rul
[23-07-2015 00:16:57]   [INFO]   - standard/xcom1/interfaces.rul
[23-07-2015 00:16:57]   [INFO]   - standard/xcom1/inventories.rul
[23-07-2015 00:16:57]   [INFO]   - standard/xcom1/items.rul
[23-07-2015 00:16:57]   [INFO]   - standard/xcom1/manufacture.rul
[23-07-2015 00:16:57]   [INFO]   - standard/xcom1/mapScripts.rul
[23-07-2015 00:16:57]   [INFO]   - standard/xcom1/mcdPatches.rul
[23-07-2015 00:16:57]   [INFO]   - standard/xcom1/music.rul
[23-07-2015 00:16:57]   [INFO]   - standard/xcom1/regions.rul
[23-07-2015 00:16:57]   [INFO]   - standard/xcom1/research.rul
[23-07-2015 00:16:57]   [INFO]   - standard/xcom1/soldiers.rul
[23-07-2015 00:16:57]   [INFO]   - standard/xcom1/startingBase.rul
[23-07-2015 00:16:57]   [INFO]   - standard/xcom1/terrains.rul
[23-07-2015 00:16:57]   [INFO]   - standard/xcom1/ufoTrajectories.rul
[23-07-2015 00:16:57]   [INFO]   - standard/xcom1/ufopaedia.rul
[23-07-2015 00:16:57]   [INFO]   - standard/xcom1/ufos.rul
[23-07-2015 00:16:57]   [INFO]   - standard/xcom1/units.rul
[23-07-2015 00:16:57]   [INFO]   - standard/xcom1/vars.rul
[23-07-2015 00:16:57]   [INFO]   - standard/Commendations/Commendations.rul
[23-07-2015 00:16:57]   [INFO]   Rulesets loaded successfully.
[23-07-2015 00:16:57]   [INFO]   Loading resources...
[23-07-2015 00:16:57]   [INFO]   Loading font... Font.dat
[23-07-2015 00:16:57]   [INFO]   Loading extra resources from ruleset...
[23-07-2015 00:16:57]   [INFO]   Resources loaded successfully.
[23-07-2015 00:16:57]   [INFO]   Loading language...
[23-07-2015 00:16:57]   [INFO]   Language loaded successfully.
[23-07-2015 00:16:57]   [INFO]   OpenXcom started successfully!
[23-07-2015 00:16:57]   [INFO]   Playing flx, 320x200, 890 frames
[23-07-2015 00:16:57]   [INFO]   Using software scaling routine. For best results, try an OpenGL filter.
[23-07-2015 00:16:59]   [INFO]   SDL_mixer initialized successfully.
[23-07-2015 00:16:59]   [INFO]   SDL_mixer initialized successfully.
[23-07-2015 00:17:01]   [WARN]   STR_1_5X not found in en-us
[23-07-2015 00:17:02]   [WARN]   STR_GAME_TYPE not found in en-us
[23-07-2015 00:17:02]   [WARN]   STR_MODS_TOOLTIP not found in en-us

I beginning to think that this really isn't worth the effort.  As far as I can tell, it doesn't affect game play, only some missing strings.  It just doesn't make sense and *that* is what is driving me up a wall.

I had a similar problem when trying the UFO Redux mod but without Commendations.  A scripted mission kept crashing, but my save ran fine on other computers.  There's gotta be a reason for both of these issues, but I'm completely baffled.

Thanks.  I really appreciate the efforts to help track this down.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 23, 2015, 04:27:39 pm
Arthanor, I think those are great guidelines. Again, if you have suggestions about existing commendations needing to be bumped up or down the rarity scale, that can easily be done.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 23, 2015, 05:29:07 pm
@wsmithjr: Alright.. I think I know what's happening here. It's not that you have an old ruleset lying about, it's that you have too new of a ruleset! You have downloaded the Nightly for July 13th, but you have Commendations for May 25th. That's almost two months of updates in the Nightly that aren't in Commendations.

Particularly, on June 21st, SupSuper changed how languages are handled and, amongst other things, moved STR_MODS_TOOLTIP, STR_1_5X and STR_GAME_TYPE from bin/standard/xcom1/Language/en-US.yml to bin/common/Language/en-US.yml. So when you put the "old" Commendations executable in your folder, it looks in the wrong file and can't find what it's looking for.

Honestly I'm surprised the game managed to work with this setup :P The good news is that Shoes just updated Commendations to July 22nd. I suggest you grab the July 22nd Nightly, the July 22nd Commendations and give that a try :)

@Shoes: I've added a new column in my spreadsheet of what I think commendations should be, and there's a fair few changes I would do. If anyone would like to take a look (and make their own column with what they think it should be), then we can start thinking about changing names. If nobody else takes interest, I'll submit a new ruleset with my suggested changes this weekend or something.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 23, 2015, 08:36:06 pm
Those name changes look good. I see that Ribbons and badges were axed, but I think they could stay for one-of commendations. At the moment there are only like two of them I think, the first month of service and the first to serve. However, first to serve might be a good  example of an order. I might have time tomorrow to put down a column of my own.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 23, 2015, 08:57:42 pm
I was trying to slim down the variety. It looks odd to have many categories with few items in them, ideally you have a medium number of categories with a medium number of entries. I'm not entirely sure how it looks for number/category right now though.

Thinking more about it now, we might want to replace commendations with ribbons, actually (I think there is only one with the name commendation right now). Commendations is already the name of the mod/UFOPaedia section and kind of the general term for all of these. Ribbons would fit well between citations and medals.

Badges.. Actually we could keep badges for certain "role" things. Grenadier, field surgeon, maybe a breacher badge for close range kills and a sniper badge for long range. Kind of a way to make the different soldier roles more official.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on July 23, 2015, 09:17:29 pm
Just chiming in here:  You guys are doing awesome!  I love the analysis and thought that is going on!  Its going to make a great mod even better!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: DracoGriffin on July 23, 2015, 09:43:50 pm
Just chiming in here:  You guys are doing awesome!  I love the analysis and thought that is going on!  Its going to make a great mod even better!

Hey Ivan, Shoes said you did a lot of the UFOpedia work; did you happen to look at the suggested changes I made? You just have to change the compare.txt to .htm, as not able to upload .htm here, and it's just a WinMerge report (makes it VERY easy to read the differences, if you haven't tried WinMerge before!).

I'd love your input since you put so much sweat into the entries.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 23, 2015, 10:07:50 pm
I was trying to slim down the variety. It looks odd to have many categories with few items in them, ideally you have a medium number of categories with a medium number of entries. I'm not entirely sure how it looks for number/category right now though.

Thinking more about it now, we might want to replace commendations with ribbons, actually (I think there is only one with the name commendation right now). Commendations is already the name of the mod/UFOPaedia section and kind of the general term for all of these. Ribbons would fit well between citations and medals.

Badges.. Actually we could keep badges for certain "role" things. Grenadier, field surgeon, maybe a breacher badge for close range kills and a sniper badge for long range. Kind of a way to make the different soldier roles more official.

Ribbons replacing commendations sounds great, and badges being for roles sounds great too.

I wouldn't want to cut out cool commendation names for the sake of categories, but I also don't want a million categories. For example, I would like to see a Crux peppered in with all the Crosses. That's really the only example I can think of ;p I would also be on board in "Titles" being changed to fit the categories; some of the names are simply an example of my lack of creativity!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on July 23, 2015, 10:10:14 pm
Hey Ivan, Shoes said you did a lot of the UFOpedia work; did you happen to look at the suggested changes I made? You just have to change the compare.txt to .htm, as not able to upload .htm here, and it's just a WinMerge report (makes it VERY easy to read the differences, if you haven't tried WinMerge before!).

I'd love your input since you put so much sweat into the entries.

Looks good Draco!  I did all my work in EN-US, so those entries are often copied over to EN-GB.  Not sure if that is an impact or not.  I also, could Anglicize the spellings etc, properly, because my brain refuses to work that way. XD
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: wsmithjr on July 24, 2015, 01:00:03 am
@wsmithjr: Alright.. I think I know what's happening here. It's not that you have an old ruleset lying about, it's that you have too new of a ruleset! You have downloaded the Nightly for July 13th, but you have Commendations for May 25th. That's almost two months of updates in the Nightly that aren't in Commendations.

Particularly, on June 21st, SupSuper changed how languages are handled and, amongst other things, moved STR_MODS_TOOLTIP, STR_1_5X and STR_GAME_TYPE from bin/standard/xcom1/Language/en-US.yml to bin/common/Language/en-US.yml. So when you put the "old" Commendations executable in your folder, it looks in the wrong file and can't find what it's looking for.

Honestly I'm surprised the game managed to work with this setup :P The good news is that Shoes just updated Commendations to July 22nd. I suggest you grab the July 22nd Nightly, the July 22nd Commendations and give that a try :)

Thanks so much for the help.  Got the new version and everything seems fine -- no errors in the .log file.  I had the right idea by trying to get an old nightly, but the oldest I could get was still 7 days too new.  I think it might have actually been less frustrating had it not worked at all.

Maybe once we get a new standard version, these kinds of issues will not be a problem.  In the interim it might be really helpful for mod authors to make sure the proper nightly is available for their mods somewhere, but I'm certain that would be a lot of extra work for everybody so I guess we just need to live with it.

Anyway, I appreciate all the time and effort everybody has taken to help.  Think I can take a pill and relax for a while and take my frustrations out on some Sectoids.  Though, knowing my skill level at the game, it'll probably just add to them.

Again, thanks.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 24, 2015, 01:22:59 am
Ribbons replacing commendations sounds great, and badges being for roles sounds great too.

I wouldn't want to cut out cool commendation names for the sake of categories, but I also don't want a million categories. For example, I would like to see a Crux peppered in with all the Crosses. That's really the only example I can think of ;p I would also be on board in "Titles" being changed to fit the categories; some of the names are simply an example of my lack of creativity!

I've started listing alternate names for some commendations on the spreadsheet, using badges for roles, ribbons instead of commendations, etc. Keeping some variety is good indeed, and I am having problems with the names too! So anyone who's up for it, feel free to make a column in the spreadsheet.

[...]
Again, thanks.

Hehe! I'm glad that worked! It is hard to keep on top of all the updates, yes. You have to get in the habit of grabbing the nightly when people release their mod. This is mostly true for mods like this one or OpenXCom extended that actually change the executable code. "Normal mods" usually are good either for the nightly or the 1.0 release and don't break very often.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on July 24, 2015, 01:56:37 am
I haven't looked at the spreadsheet, but just something to be aware of when considering names. 

Most of the Medals in the UFOpedia (by this I mean the devices hanging from the ribbons) are designed around the title of the award.  Therefore if the name changes too much, a new medal would probably need to be redesigned (i.e. Athena Citation:  - designed with a nod to the goddess of wisdom and the medal uses the owl that was symbolic of Athena).

(https://i.imgur.com/WAYTVoz.png)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 24, 2015, 05:12:04 am
Good point! And you've done an awesome job tying the medals and their ribbons to the name of the award. Especially for crosses which are often actual crosses! I will make sure to retain the link.

Unfortunately, it kind of conflicts with the idea of having badges for roles as the graphics are not badges, but medals.. hum..
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: new_civilian on July 24, 2015, 11:26:03 am
I know it has been asked before, but let me do it again for the heck of it.... Is there ANY chance to see this merged with the Extended Exe by Yankes?  :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on July 24, 2015, 11:32:06 am
I know it has been asked before, but let me do it again for the heck of it.... Is there ANY chance to see this merged with the Extended Exe by Yankes?  :)

FudgeDragon did it already. Apparently there were some minor technical issues, but the entire mod is still in the making, so I think it's fair chance that the merged version will be updated regularly.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on July 24, 2015, 04:44:40 pm
Unfortunately, it kind of conflicts with the idea of having badges for roles as the graphics are not badges, but medals.. hum..

The other thing is that all of the medals start from the ribbons.  The ones that show up on the Soldier's Record.  So any "badge" will have to include some sort of ribbon to display there properly.  So the classic "Jump Wings" of a parachutist badge would not really work. 

That said, the medallion could be redesigned for the badges to be more distinctive and look like a "badge."
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: hellrazor on July 24, 2015, 04:48:07 pm
I am wondering in which UFOpaedia section are you putting the Medals?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on July 24, 2015, 05:31:08 pm
I am wondering in which UFOpaedia section are you putting the Medals?

The way the mod currently works, it uses the HWP section with the HWPs combined with Craft above.  Shoes has recently added code to create a new "Commendations" section at the bottom of the list.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 24, 2015, 05:51:54 pm
And as far as I understand it, that section only shows up if you have a ruleset that requests it. It's a nifty piece of work :)

@Ivan: That's true too.. Difficult.. I think all of your work should remain (because it is excellent and we need to use it all!) but maybe with some tweaks in names where graphics allow, in order to follow a "prestige/rarity" scheme, or tweaks in the conditions to obtain the medal.

For the badges, the ribbon part could be a simple pattern or monochrome that feels appropriate, but the badge graphic would be harder to come up with.. I certainly do not have your talent in making graphics.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: wsmithjr on July 25, 2015, 04:11:57 pm
I've upgraded to July 22 version of Commendations.  Just noticed something with the UFOpedia.  If I click on the first line for "XCOM CRAFT, ARMAMENTS & HWPS" and then click on "Canon" and then click the Right Arrow, the next entry up is Military Cross.  However, on the UFOpedia menu, the next section should be "Heavy Weapons Platforms".  'Course, as I'm typing this it dawns on me that HWPs are not included in the first section anymore but as still labelled in that way.

Anyway, is it intentional that the order is different from the menu?  It's obviously still a work in progress, but thought I would mention it.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 25, 2015, 07:17:45 pm
It's likely that the listOrder values (which orders ufopaedia articles) is what is used to determine what's next when you click the buttons. Now that there is a new section at the end instead of being the 2nd one, those values will have to be adjusted in consequence.

I'll try to update too and provide a new ruleset.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 26, 2015, 07:03:29 pm
It's likely that the listOrder values (which orders ufopaedia articles) is what is used to determine what's next when you click the buttons. Now that there is a new section at the end instead of being the 2nd one, those values will have to be adjusted in consequence.

I'll try to update too and provide a new ruleset.

Thanks Arthanor, I did a real quick copy/past find/replace when adding that new ufopaedia entry.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 28, 2015, 07:30:34 pm
Well, I've updated the ruleset with new listOrder entries, starting at 15000 instead of 6000, to move things after UFOs. Unfortunately, it doesn't seem to do anything?! I tried moving all the commendations to the UFOs section, and they behaved normally there with listOrder 15000+. Could it be in your implementation of the new section Shoes? It behaves as if the section were between Crafts&Armaments and HWPs.

I've also fixed the section of one of the commendations, which was wrong and preventing it from showing up, and removed the change in STR_XCOM_CRAFT_ARMAMENT, since with the new Commendations section that one isn't changed anymore.

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on July 28, 2015, 08:29:56 pm
Guys, I'd like to start a new campaign with Commendations (FMP). Can you please tell me if I can use your mod as it is now, or should I wait for the next release?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 28, 2015, 08:41:27 pm
I think the mod is totally usable. The stat tracking part is fully operational and that's the really important part. The GUI still needs some work, but that should not affect gameplay much.

There are some medals which aren't awarded quite the right way, and some medals will likely be changed, but you can clear the medals from your soldiers and the proper medals will be awarded after their next mission or the end of the month, so it's an easy update.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on July 28, 2015, 09:05:00 pm
OK, thanks Arthanor.

One last thing, and it's for Shoes: is the .exe more or less updated with the nightly? There were some changes to the mission code, so I wonder how I should tweak the ruleset.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 29, 2015, 03:57:32 am
OK, thanks Arthanor.

One last thing, and it's for Shoes: is the .exe more or less updated with the nightly? There were some changes to the mission code, so I wonder how I should tweak the ruleset.

The last .exe is matched with the July 22nd nightly, before the big mission code changes. I don't have time to take a look at the moment, but my code doesn't touch missions beyond fetching names.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on July 29, 2015, 12:48:57 pm
The last .exe is matched with the July 22nd nightly, before the big mission code changes. I don't have time to take a look at the moment, but my code doesn't touch missions beyond fetching names.

I guess I'll wait for the integration then, since the mod is already being updated to the latest version. Thanks!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: new_civilian on July 29, 2015, 04:49:04 pm
FudgeDragon did it already. Apparently there were some minor technical issues, but the entire mod is still in the making, so I think it's fair chance that the merged version will be updated regularly.
Wait. What. Where?  :o  :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on July 29, 2015, 05:28:38 pm
Wait. What. Where?  :o  :D

https://openxcom.org/forum/index.php/topic,1718.msg45954.html#msg45954

I've got that post linked on the original post, but mind you it was last edited June 2nd. Might still be worth a try though!

I guess I'll wait for the integration then, since the mod is already being updated to the latest version. Thanks!

I hope it won't be too long, I am without a computer at the moment!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Meridian on July 31, 2015, 08:26:14 pm
If anyone is having problems with the installation, here's the tutorial I did for one confused soul:
https://youtu.be/UpuGyPSEA-g
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: SIMON on July 31, 2015, 11:27:59 pm
Very simple and elegant presentation but I noticed one thing regarding the folders you need from your original steam game. You copied over 13 folders including these four in the first picture. Are these 4 needed just for the soldier diaries or should I've been doing this all along for any variation of openxcom? What I've always been copying over is the 9 in second picture.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on July 31, 2015, 11:35:22 pm
I think the 9 you list is sufficient, although the other ones won't hurt. I don't even have some of the 4 extra folders from my installation of the original.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: new_civilian on August 01, 2015, 11:28:46 am
Thanks for the Link SolariusScorch!  :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: jgatkinsn on August 04, 2015, 10:50:30 pm
It's time for TFTD medals!!! yeah boooyyyyeeee!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on August 06, 2015, 08:38:38 pm
It's time for TFTD medals!!! yeah boooyyyyeeee!

I haven't tried (or ever played) TFTD before, but the stat tracking should still work the same :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: wsmithjr on August 06, 2015, 10:56:22 pm
I haven't tried (or ever played) TFTD before, but the stat tracking should still work the same :)

Any plans/timeframe for an updated EXE to give it a whirl?  Looking forward to trying it as TFTD is my favorite version.

Thanks.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: DrakeEB on August 07, 2015, 06:10:36 am
I wanna play with this mod so bad but it crashes anytime i shoot down an alien ship and send my skyranger to the crash site.

I am using built 2015-08-06 23:07 that just came out. I have no problems activating it in the mods tab and it works fine. Ufopedia and the soldier records are fine.

I've tried the Nightly build and Legacy build and it always happens.

I do use Final Mod Pack and High Quslity Sounds, wih no issues.

Any idea why this keeps happening? I even tried just the base Openxcom 1.0 with Legacy build and no other mods and it still happens....

I read somewhere maybe it is a terrain pack issue so i disabled and re-enabled Final Mod Pack like was suggested and still no go...
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on August 07, 2015, 06:55:39 am
The 1.0 build got broken a while back, and Shoes never got into fixing it since there is 2.0 coming out soon(ish). So you'll have to use the nightly, which is much better any ways.

Just to get a bit more info, which operating system are you running on? I'm assuming you're on windows for now.

You said you downloaded the new 2015-08-06 nightly build of OpenXCom? And then you installed commendations on top of it?

I expect you have the same problem someone else had earlier: You are trying to apply the Commendations custom executable on a nightly that's much too recent. In this case, newer is not better, newer means different codes from how it was when Shoes developed the latest version of Commendations, which will cause problems.

Get a nightly that matches the date of the latest Commendations release, then apply the latest Commendations release on top of it. That should work.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on August 07, 2015, 06:57:46 am
Wow.... just wow....

You guys have taken this beyond the next level... amazing work I have not had a chance to play with it, but looking at all the work being done this is a great mod, glad I had a little  input :)

Shoes, Ivan, Arthanor amazing work
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: DrakeEB on August 07, 2015, 09:13:08 am
The 1.0 build got broken a while back, and Shoes never got into fixing it since there is 2.0 coming out soon(ish). So you'll have to use the nightly, which is much better any ways.

Just to get a bit more info, which operating system are you running on? I'm assuming you're on windows for now.

You said you downloaded the new 2015-08-06 nightly build of OpenXCom? And then you installed commendations on top of it?

I expect you have the same problem someone else had earlier: You are trying to apply the Commendations custom executable on a nightly that's much too recent. In this case, newer is not better, newer means different codes from how it was when Shoes developed the latest version of Commendations, which will cause problems.

Get a nightly that matches the date of the latest Commendations release, then apply the latest Commendations release on top of it. That should work.

Yep Windows, and ok i'll try using an older nightly that matches up better and let ya know what happens. Thx!

Or i could just wait for 2.0....nah lol i just recently got back into Xcom and found all these awesome mods. :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Corsix on August 07, 2015, 06:24:39 pm
Ok. I figured out how to make this awesome stat tracking mod to work with Nightly, but still having problems with the OpenXCom Extended version I tend to use usually.

All the fine medals are showing up in the Ufopedia but the inventory screen is lacking the "record" button.

Is there a good soul around, that could point out the correct install procedure to me maybe ? Think I screwed something badly up  ::)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on August 07, 2015, 06:28:36 pm
Extended and Soldier Diaries are naturally incompatible because they both use different custom .exe executable files. 

I believe FudgeDragon might have been able to create a merge a couple months ago.  Check back through this thread if you are interested.  Just be aware that it will be a bit out of date.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Corsix on August 07, 2015, 07:00:45 pm
Allright, got it.

Soldier Diaries Extended (based of of OpenXCom 25/05/2015 08:57:51 - Commit:db285720550dd4cd87482010f9e94464929ad60b & OpenXCom Extended 27/05/2015 18:37:59 - Commit:c90d5f8cfc7a2a351cae1ce60ee348f681eb1b06)
Combines OpenXCom Extended with Soldier Diaries for the latest nightly
Git: https://github.com/fudgedragon/OpenXcom/tree/SoldierDiariesExtended
Downloads: Windows (win32 x64)

And its working pretty good, thanks for it, appreciate it.

Will repay that favor with some sounds in the future hopefully  ;D

One more question guys, if you don't mind ofc. Were there plans made already to merge together those two major overhauls of the game ? They contain so much lovely changes a true X-Com fan could ever dream of, that's the reason why I ask. In any case, you guys rule :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on August 07, 2015, 07:06:19 pm
Generally no.   :(

Shoes has hopes that Soldier Diaries might get integrated into the main branch.  ExTended on the other hand, has gone so far beyond the original code that it will always be an alternative to the main project. 

Someone with the patience and some github skill can continue to do the same thing that FudgeDragon did.  It just takes a lot of dedication to continually update them for all of the changes made by the developers.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Corsix on August 07, 2015, 07:28:01 pm
Yeah, GitHubbing is way better still then working with FTP servers and waiting for their response usually. Forking and tracking would be the way to go. But it's hell to manage it usually. Respect for ForgeDragoon work would be at place then. And anyone else who wrote those wonderful lines of code that still make fun after so many years :)

Got your point anyway. I might see what I can do. At least, I know now, how to handle those two. Thanks again.

And good luck for Shoes. I hope his mod will make into the main branch.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on August 07, 2015, 07:38:30 pm
I would expect that commendations will be merged in at some point after TftD. If I recall correctly, Shoes said Warboy expressed support to the idea.

And the awesome news is: When/if Commendations is merged with the main branch, the next time Yankes updates Extended, it will merge in Commendations too!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: kikimoristan on August 07, 2015, 10:50:01 pm
i hope commendations make it into the main branch.

the best feature of this mod  is actually the soldier performance tracking. you can see what missions soldiers went to, how many times they got hurt, how many aliens they killed, what kind of aliens they killed etc.


i'd love to see even more like all time accuracy %, or total kill count, or kpd (kills per day) rating, total service in days. even the ability to graph kills / time or accuracy % / time etc.  i love that stuff.  you could see random patterns develop like your soldier kills less on on wednesdays or your accuracy is better in the winter etc. completely random but make the game much more fun for me. i don't know. i love statistics.  \

even create some form of Performance rating based on available data . and you can see who is your best and most valuable assets. not based on rank but based on performance in battle.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: jgatkinsn on August 08, 2015, 03:14:37 am
i hope commendations make it into the main branch.

the best feature of this mod  is actually the soldier performance tracking. you can see what missions soldiers went to, how many times they got hurt, how many aliens they killed, what kind of aliens they killed etc.


i'd love to see even more like all time accuracy %, or total kill count, or kpd (kills per day) rating, total service in days. even the ability to graph kills / time or accuracy % / time etc.  i love that stuff.  you could see random patterns develop like your soldier kills less on on wednesdays or your accuracy is better in the winter etc. completely random but make the game much more fun for me. i don't know. i love statistics.  \

even create some form of Performance rating based on available data . and you can see who is your best and most valuable assets. not based on rank but based on performance in battle.

Wholeheartedly agree on all points you've stated.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Corsix on August 08, 2015, 05:59:06 pm
Same here
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on August 09, 2015, 03:22:21 pm
Accuracy % should be doable: I think I already track shots fired and shots landed...

Kills per missions can also be done with the tracking that's already there, so it could also be added to the kills screen or another screen.

Total service days should also be doable, but I would need to add a a bit of code as I only track months now.

Graphs I haven't considered. As there is already code to produce graphs, I might be able to graph things...

And now performance rating! I would be interested in calculating one for the soldier, as the soldier score can be the same for a lot of soldiers. What do you think would go into the performance rating? Kills per mission x accuracy?

edit: Regarding timeline, hopefully soon :x I'll ignore bug fixes for the moment and merge to TFTD.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on August 09, 2015, 08:03:44 pm
Hi Shoes! Glad to hear a new version is coming up. The aquanauts definitely need their medals too!

As for bugs, I've come to the conclusion that the "kill one of every X" awards are not given properly. I have a lot of soldiers with the "Taking Names" medal, even though I have never killed a commander, similarly, I have a lot of "one of every race" even though I have never seen ethereals.

Is it possible that, as currently built, ranks/races that you kill multiple times still give credits, meaning you can kill 7 soldiers and that will give you 7 ranks even though they are all the same rank?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on August 09, 2015, 08:20:35 pm
Hi Shoes! Glad to hear a new version is coming up. The aquanauts definitely need their medals too!

As for bugs, I've come to the conclusion that the "kill one of every X" awards are not given properly. I have a lot of soldiers with the "Taking Names" medal, even though I have never killed a commander, similarly, I have a lot of "one of every race" even though I have never seen ethereals.

Is it possible that, as currently built, ranks/races that you kill multiple times still give credits, meaning you can kill 7 soldiers and that will give you 7 ranks even though they are all the same rank?

Something is up with how the ruleset is being read, and it's messing up any commendation that has multiple criteria. Instead of reading all the criteria, it reads one of them, and runs with it. That one is going to be hard to track because it's not a change on my end that is causing the problem. Once it gets fixed though, you will be able to debug-clear your medals and get them properly awarded.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on August 09, 2015, 08:38:41 pm
Oh, that sucks.. I wish I knew anything about C++ to help! Too bad scientists use Fortran for coding :(

The way medals are given and can be reset is really neat btw :) It's nice to have such a safe system!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: kikimoristan on August 10, 2015, 02:16:00 am
for the time you can convert your month variable into a float and capture it every hours. then you can modify all your regular code to use floor down the month variable as n int. but for graphing type code you use float to generate days, hours etc. ex 1.5 month would be 1 month and 15.5 days but rounded down is 46 days of service. you always round down. right?


for efficiency rating maybe this

i guess as an xcom operative most important is alien kills

however as an efficiency rating maybe enemy percentage of total alien kills / mission / no of missions.

ex:
20% of all enemies killed / mission 1
0% kills / mission 2
50% kills / mission 3

(20% + 0% + 50%) / 3 = 23.3333333333% of all aliens encountered killed


then you find accuracy % / mission / number of missions

then you can do something like

% kills * % accuracy


theoretically max number would be 100 x 100 you killed everything and missed nothing.
but realistically  is probably gonna be much lower.

ideally the higher the number the better performance your unit had in the game or more impact. highest values means valuable assets.


what do you think?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: kikimoristan on August 10, 2015, 03:16:57 am
shoes i don't know how your mod works but i was thinking you could split up this mod into 2 components:
1.  tracking engine & interface enhancements as code and have code provision for awards/medals as a modder feature. uses regular xcom assets.
2.   commendations/awards/medals as a mod in a rul using your modder features  and assets from resource in a mod folder

this way you could easily include 1 in the main branch by making a pull request. warboy or supsuper may be into it

also might simplify your life by focusing on code letting someone else focus on the commendations part. ppl could even make their own awards.

if no awards are defined in any rul file nothing shows up but all the other stats special dialogue is there forever for everyone to use.

the awards as a mod would simply be  conditional if varibles match values then award is given. up to 3 variables . something like that.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on August 10, 2015, 04:34:54 am
That's already how it works :P

The executable tracks the stats and puts them in saves, plus it adds the interface for seeing the records. Then there is a mod that you enable and can tweak which enables the awards and adds the commendations section to the UFOPaedia. It's a pretty good system :)

The only problem is part of the ruleset not being processed properly for some reason (which as far as I know only impacts the kill/stun one of each terrorists/ranks/races awards).
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on August 10, 2015, 02:09:18 pm
@tollworkout, that sounds good. I think rank should be considered too. What do you think is more important, stun or kill?

And as Arthanor says, the mods are seperate :) if you turn off "Commendations" in the mod list, the stats are still tracked and can still be viewed. The commendations buttons in the Records windows and the ufopaedia are removed when the mod is off too. :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on August 10, 2015, 06:24:13 pm
@tollworkout, that sounds good. I think rank should be considered too. What do you think is more important, stun or kill?

I'd say stun is better, since it's easier to blow them up than capture them. Besides, having a living alien means you'll get a corpse at some point, too. :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: kikimoristan on August 10, 2015, 06:45:30 pm
shoes, what do you think about this

stun unlocks key research  but since stuns happen less often maybe weigh them equally .

(kills + stun ) / 2

kills = aliens killed / total aliens encountered
stun = aliens stunned / total aliens encountered

this works because it calculates based on total aliens encountered and you cannot stun and kill at the same time. if you stun and they die later counts as stun. so max is 100 if you stun 50% of all aliens encountered and kill 50% of all aliens encountered

then that times acc

(kills + stun ) / 2 * acc

acc = successful hit / total attacks made
 
if you wanna measure efficiency maybe  rank shouldn't count. this would be equal for everyone.  but if you do it should't count too much
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on August 10, 2015, 07:03:44 pm
I suppose you and I have a different thing in mind: if you're measuring efficiency, then yeah rank shouldn't matter and nor should stun or kill; if the alien is down, you dun good. I was thinking more of a "experience" level, where higher ranking aliens and races would award more points, and so would stuns over kills.

I'm not fond of the efficiency rating simply because it would be so low. Compounded with poor accuracy, I would find most soldiers would have a rating of near zero. I prefer the "experience" level, because that just keeps going up. It'll be like score, but more customized to the individual soldier.

All this said, most data is being tracked to calculate the efficiency rating, so it could be added too. Experienced soldiers can be inefficient after all ;p
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: jgatkinsn on August 10, 2015, 07:27:56 pm
Let's see.  I like a lot ideas so far.  I have concerns though, because some weapons are naturally more efficient than others that don't necessarily represent the skill of the solider (i.e. blaster bombs anyone?).  It feels like the soldier who always carries the blaster launcher is going to be skewed as the most efficient.  I don't know if a weapon scale factor needs to be added to balance that bias out of the rating.  However, given these mods, it may be very hard to come up with a good weapon scaling factor.

I don't mind including rank of the alien as part of the performance rating, but you need to balance it out by including its negative counter part: killing civilians (or your fellow soldier) reduces your rating. 

Of course separate ratings like kill efficiency and a performance could be supported as a way to gauge your soldiers overall experience.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on August 10, 2015, 08:05:56 pm
Yeah, even without using explosives (which can be coded to be treated differently) it will come up, since a sniper rifle will hit way more often per bullet than a minigun. (The fact that neither is present in vanilla X-Com is irrelevant.)

What can be done though is factoring the "experience bonus per hit" against weapons' accuracy, and even better against actual accuracy (modified by distance if applicable). Therefore a person who often hits with a pistol would get more exp than one who often hits with a rifle. And explosives would be worth less than normal bullets/beams, too.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Dioxine on August 11, 2015, 12:02:01 am
What can be done though is factoring the "experience bonus per hit" against weapons' accuracy, and even better against actual accuracy (modified by distance if applicable).

Jesus, this is a very Nietzchean model there, Solar, isn't it too hardcore? :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on August 11, 2015, 12:22:28 am
Jesus, this is a very Nietzchean model there, Solar, isn't it too hardcore? :)

Well, it wasn't me who came up with the idea for performance in the first place. I only said what should be done to make it worthwhile.

While I'm not really excited about rat races, seeing the smug, annoying sniper sarge getting torn to shreds by a cybermite will be satisfying. 8)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on August 11, 2015, 12:26:24 am
Honestly, I'm not sure I care about all these weird metrics of soldier performance representing "experience" as if it were an rpg. And I generally love numbers!

XCom already has its own form of experience and improvements, which doesn't involve xp points or level ups.

I think seeing "Cumulative kills over time", and kills relative to the squad. Every time you go on a mission, you log 2 numbers: How many aliens you killed, and what % of all the aliens you killed, average that for every month to get the graph in the current monthly format. Maybe also Cumulative and relative hits could be interesting.

Another thing that would be interesting to me is seeing the progression of stats, where you can see the stats of your soldier at the end of every month. It could be done exactly like the current graph, with each line being a different stat, and the total being the sum of all stats and representing the overall quality of your soldier.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: kikimoristan on August 11, 2015, 02:41:06 am
Honestly, I'm not sure I care about all these weird metrics of soldier performance representing "experience" as if it were an rpg. And I generally love numbers!

XCom already has its own form of experience and improvements, which doesn't involve xp points or level ups.

I think seeing "Cumulative kills over time", and kills relative to the squad. Every time you go on a mission, you log 2 numbers: How many aliens you killed, and what % of all the aliens you killed, average that for every month to get the graph in the current monthly format. Maybe also Cumulative and relative hits could be interesting.

Another thing that would be interesting to me is seeing the progression of stats, where you can see the stats of your soldier at the end of every month. It could be done exactly like the current graph, with each line being a different stat, and the total being the sum of all stats and representing the overall quality of your soldier.

for the first part i'll leave it to shoes. i trust his decisions. any form of stat tracking that shows some cummulative information or cummulative info vs other teammates cummullative info is good.

for the second part graphing would be perfect. you could map anything to anything see progression in time.

i'm guessing most important type of graphing would be soldier tracked variables per time as well as some tracked variables calculations to see individual   performance i n relation to the other teammates  like cummulative kills of this soldier vs all other soldiers per days/months etc.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: kikimoristan on August 11, 2015, 02:44:59 am
maybe if graphs were ever implemented it would probably two kinds: a predefined team wide graph and a customizable  soldier individualized graph with a drop down of variables tracked / day (or something like that) . graphs optional but nice :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on August 11, 2015, 03:23:43 am
Regarding performance, efficiency and all those other stats: it seems the consensus is simply "more cumulative stats plz". I'll add a few things to the todo list, like overall accuracy, % of kills per mission, perhaps shots fired as well. Those seemed to be in demand the most. Heck, if I am feeling demented, I could add code to track TUs spent...

I've also glossed over the graphing code, and I might be able to work with it. I would imagine each soldier would have it's own graph state (I imagine it would be difficult to have a weird list of toggle-able soldiers on the side that you can click and have their stats added...). I imagine that having things graphed on the X axis as per mission would be more desirable than per month. Perhaps both would be done too. Depending on how easy the graph code is to work with, I might have a list of buttons like "shots fired", "kills", "stuns" as toggle-able buttons for the Y axis too. This would require a lot of new code and probably a fair bit of motivation ;p but I like the idea, so I'll write it down!

Edit: I prefer the forums for discussion, but I have a public gist with my todo list and what not. If I miss things, or if there are things that I've missed or details you would like to add, you can feel free to post there: https://gist.github.com/Shoes01/3af40f402d287ae9c229

Edit 2 : I've updated github with an uncompiled version of the mod. It's entirely untested.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on August 15, 2015, 09:18:55 pm
Hey shoes, could you or anyone that has an earlier build (circa 7- 22) post it so that people that want to use this mod can just grab it from here? The download site only has 7 - 30 I could not find the earlier build any where. Thanks
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on August 16, 2015, 01:07:43 am
https://www.openxcom.com/mod/soldier-diaries-stat-tracking

That mod page has all the releases I've been doing, is that what you're looking for?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on August 16, 2015, 01:58:17 am
damn i was not specific, when i said "Hey shoes, could you or anyone that has an earlier build (circa 7- 22)" I meant "Hey shoes, could you or anyone that has an earlier OXC game build (circa 7- 22)"  the main download site no longer carries anything below 7-31 :) and i just found out that games build around 5-07 are not compatible either :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on August 17, 2015, 12:58:17 pm
I've managed to get some development going on another computer, but I am unable to test the game with it at the moment. So here is an untested version of the mod, to date with the August 11th nightly. I hope it works :3 I have no idea what will happen in TFTD.

https://dl.dropboxusercontent.com/u/234369005/OXC/2015-08-11%20Nightly.zip
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: niculinux on August 17, 2015, 01:27:53 pm
I'd take out the "regional medals" ( eg.  North america one) since xcom is an international force, and made those more hard to get :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on August 17, 2015, 01:37:03 pm
I'd take out the "regional medals" ( eg.  North america one) since xcom is an international force, and made those more hard to get :)

Do you mean that it's hard to get it in TFTD because you're not landing in countries anymore? I haven't played TFTD yet so I'm not sure. If you mean that Xcom being an international force should not have country specific medals, I see these commendations as being awarded by those countries themselves to your soldiers.

In the former case, I would have to write code to differentiate which commendations are for which game. Or lazily write two rulesets that are nearly identical and need to be turned on or off depending what game you play ;p I've added it to my list of things to do though.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: niculinux on August 17, 2015, 02:01:45 pm
If you mean that Xcom being an international force should not have country specific medals [...]


yep i meant that, saving writings a ton of rulesets!

As for the "hardening" my fear is that having them letting be too easy to earn may result in too much of them in the rooster ;) just highlighting the fact taht these should be mote "uniques". :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on August 17, 2015, 02:17:33 pm
I do want to avoid making commendations that all soldiers get, but I have found the regional commendations to be pretty good. This commendation, like the weapons commendation and the xenocide commendation, are mostly supposed to be proofs of service for your soldiers; every soldier should get one at some point, but maybe one will get one for USA, another for Egypt.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: niculinux on August 17, 2015, 02:26:51 pm
I do want to avoid making commendations that all soldiers get, but I have found the regional commendations to be pretty good. This commendation, like the weapons commendation and the xenocide commendation, are mostly supposed to be proofs of service for your soldiers; every soldier should get one at some point, but maybe one will get one for USA, another for Egypt.

whatever will be fine :) hey thank you for the time dedicated to the openxcom cause!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Corsix on August 17, 2015, 06:37:37 pm
If some companies would think like this community, the world would be a better place to be :-)

Awesome work again. Testing.. erhm, having fun with your August build currently ;-)

By the way.. what is the difference between the Master Exe which is larger then yours for the same build ? 8.145 KB compared to 3.027 KB ? Only the relevant library reading or something else as well ?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on August 17, 2015, 10:47:25 pm
I think the default openxcom.exe is larger than mine because all the .DLLs are included in it. If you use my .exe, you need to have the DLLs lying around in the folder.

At least that's what I think :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Corsix on August 17, 2015, 11:05:34 pm
Works great! Love it   :)

392 MB of different Mods, Libraries Sprites and C++ bit chunks already inside my folder of OpenXCom. That's what I call productive assembly area  ;D

Can't still believe it but that's true, the game still runs like an old good train on a railway.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: kikimoristan on August 17, 2015, 11:29:13 pm
is it possible to compile 1 exe with all dlls included?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: DracoGriffin on August 18, 2015, 12:10:38 am
is it possible to compile 1 exe with all dlls included?

Yes... would love to use the "extended" Commendations with X-Piratez without having to compile stuff on my own (Windows) and FudgeDragon's may be a bit outdated now...
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: kikimoristan on August 18, 2015, 12:14:57 am
commendations + extended + main branch mega executable would be crazy
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on August 18, 2015, 12:27:14 am
is it possible to compile 1 exe with all dlls included?

It is, but I don't know how :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Corsix on August 18, 2015, 12:49:24 am
is it possible to compile 1 exe with all dlls included?

Yes, it is, agree with Shoes  :D But to decompile a C-program on Windows ain't that easy like to throw on a GNU/Linux compiler and start editing as one likes to.

With the free distributable version of a Visual Studio like that one:
- https://www.visualstudio.com/en-us/products/visual-studio-express-vs.aspx (https://www.visualstudio.com/en-us/products/visual-studio-express-vs.aspx)
it is still possible to manage small projects. Don't know if it would be enough to get OpenXCom going to be honest with you... the environment needs to be prepared, cmd.exe and batch processing and so on, with no yummy preview if it ever would work like on other systems.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Yankes on August 18, 2015, 12:56:00 am
is it possible to compile 1 exe with all dlls included?
Yes, nightly and my extended version use mxe.cc environment to build stand alone exes.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: kikimoristan on August 18, 2015, 01:06:09 am
yankes can u share your mxe.cc  env with shoes? perhaps he could try compiling 1 exe  + commendations easier to distribute

i know coding but im so dumb at c++ is barely any use. im sure i could do something but nothing too advanced. i kinda wanna contribute though.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Yankes on August 18, 2015, 01:22:31 am
https://github.com/Yankes/OpenXcom/blob/master/src/Makefile.mxe
One drawback, its require linux (I use VM with Ubuntu) and small tweaks like different icon, enabling flat sound format and exe name.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on August 18, 2015, 01:47:58 am
Yo, I've tried with FMP an sadly it crashes very soon on Geoscape. The same happens if I start a new game. I think it may have something to do with interception.

Haven't tried vanilla yet.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on August 18, 2015, 03:15:19 am
https://github.com/Yankes/OpenXcom/blob/master/src/Makefile.mxe
One drawback, its require linux (I use VM with Ubuntu) and small tweaks like different icon, enabling flat sound format and exe name.

How funny, my main computer is running Ubuntu as it's only OS at the moment. I'm pretty poor when it comes to programmer things beyond my mods, so do you have any instructions on how to do this? If it's too much trouble though don't worry about it.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on August 18, 2015, 06:14:03 am
I've managed to get some development going on another computer, but I am unable to test the game with it at the moment. So here is an untested version of the mod, to date with the August 11th nightly. I hope it works :3 I have no idea what will happen in TFTD.

https://dl.dropboxusercontent.com/u/234369005/OXC/2015-08-11%20Nightly.zip

Awesome!!!  I will give it a try and see how it goes :)

thank you Shoes

I do want to avoid making commendations that all soldiers get, but I have found the regional commendations to be pretty good. This commendation, like the weapons commendation and the xenocide commendation, are mostly supposed to be proofs of service for your soldiers; every soldier should get one at some point, but maybe one will get one for USA, another for Egypt.

I agree, i think regional medals are good, they can tell you basically where you have served. not every soldier will get all of them but all soldiers will at least get one.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: DrakeEB on August 26, 2015, 01:37:17 am
Any chance this will be made compatible with FMP?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on August 26, 2015, 11:29:18 am
Any chance this will be made compatible with FMP?

Well, it would be more of a case of making FMP compatible with this mod, since it comes with an .exe and the FMP doesn't. :)

I don't know why it's not working together, yet. I need to analyse Commendations ruleset structure to find out what musty be added. But for now I'm surprised it crashes the game in Geoscape, an hour or so after new game - I thought Geoscape was generally left untouched?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on August 26, 2015, 05:39:05 pm
Well, it would be more of a case of making FMP compatible with this mod, since it comes with an .exe and the FMP doesn't. :)

I don't know why it's not working together, yet. I need to analyse Commendations ruleset structure to find out what musty be added. But for now I'm surprised it crashes the game in Geoscape, an hour or so after new game - I thought Geoscape was generally left untouched?

That's interesting indeed. I don't think the crash would be due to the Commendations ruleset; all that's in there are language strings and commendation information. I've tried to make the commendations mod play nice with other mods, so perhaps FMP does something I didn't anticipate and it causes commendations to crash when it tries to log a certain statistic. Being in the Geoscape makes it all the more interesting. Solarious, if you compile your own source, you should be able to do so in debug mode and get an indication of where the game crashes. I'm unable to do it at the moment, but it could provide insight as to why it crashes anyway.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on August 26, 2015, 11:34:12 pm
I'm not really prepared to build anything, I just don't have the time to learn the tools and everything. Maybe someone talented and more skilful like Meridian could do it instead, wink wink? :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Meridian on August 27, 2015, 08:41:37 pm
I'm not really prepared to build anything, I just don't have the time to learn the tools and everything. Maybe someone talented and more skilful like Meridian could do it instead, wink wink? :)

I just tried to compile this and test it with FMP.

2/ Everything seems to work fine as far as I can say... but see also next point.

1/ I couldn't compile the sources at first... got errors in DebriefingState.cpp. After adding a couple of lines into DebriefingState.h (missing _noContainment, _manageContainment, _destroyBase, _limitsEnforced) and removing double definition of bool variables success and aborted in prepareDebriefing() method in DebriefingState.cpp I could compile sucessfully.

@Shoes: am I doing something wrong? (I took fresh clone of your repo and switched to branch alpha_release; using VS 2010)

@Solarius: how can I reproduce the error? I have used FMP 1.6.3, Commendations and no other mods.

EDIT: now I see a possible difference... on openxcom.com, the last Soldier Diaries version is from 2015-07-22, whereas the git repo is already on 2015-08-11... so maybe the issue doesn't appear anymore. I could try to go further into past in my local repo, but it will have to wait a couple of days...
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on August 27, 2015, 09:37:02 pm
1/ I couldn't compile the sources at first... got errors in DebriefingState.cpp. After adding a couple of lines into DebriefingState.h (missing _noContainment, _manageContainment, _destroyBase, _limitsEnforced) and removing double definition of bool variables success and aborted in prepareDebriefing() method in DebriefingState.cpp I could compile sucessfully.

@Shoes: am I doing something wrong? (I took fresh clone of your repo and switched to branch alpha_release; using VS 2010)


Oops, did I not push that change? :3 my bad, I merged something incorrectly and forgot to push the fix!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on August 27, 2015, 10:17:48 pm
@Solarius: how can I reproduce the error? I have used FMP 1.6.3, Commendations and no other mods.

Well, it works now, so I can't really say much. :P I just removed all the configs and saves and it just worked. Anyway, many thanks for helping out Meridian, your effort was not in vain! :)

So, I take it a fixed version is coming?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: hellrazor on August 27, 2015, 11:22:53 pm
I am wondering i someone who is playing my Mod also uses this.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on August 31, 2015, 10:36:35 am
I've managed to get some development going on another computer, but I am unable to test the game with it at the moment. So here is an untested version of the mod, to date with the August 11th nightly. I hope it works :3 I have no idea what will happen in TFTD.

https://dl.dropboxusercontent.com/u/234369005/OXC/2015-08-11%20Nightly.zip

Hey Shoes,

So i have been jumping back and forth between games, OXC and OTFTD. I see no significant issue with OXC everything is right of course i am using an 8-11 build to match your 8-11 release.

However on the TFTD side, like you mentioned.
1. The mod is not listed in the mod tab under options.
2. if selected on OXC then the mod is active.
3. The commendation button on the ufopedia is not available.
4. The system seems is tracking all the stats properly however GUI is messy, clearly there are no strings for the new text and since the color is specific for OXC, then OTFTD makes it weird. But i do not think the mod in itself is bad just need to correct a few things in it.

In general i think is just minor issues, i am playing OTFTD because is my favorite :) .

Thanks,
Xracer
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: DrakeEB on September 02, 2015, 01:42:48 pm
So, if i revert back to nightly 8-11 this mod will work with FMP 1.6.4 with no issues?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Meridian on September 02, 2015, 02:10:49 pm
So, if i revert back to nightly 8-11 this mod will work with FMP 1.6.4 with no issues?

No, the version on openxcom.com is still compatible only with 7-13 nightly. There was no new release since then.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on September 03, 2015, 03:00:38 am
No, the version on openxcom.com is still compatible only with 7-13 nightly. There was no new release since then.

actually there was a release 8-11

EDIT:
Actually let me correct that there was a nightly release

Nightly version : https://dl.dropboxusercontent.com/u/234369005/OXC/2015-08-11%20Nightly.zip
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Meridian on September 03, 2015, 09:16:10 am
I was talking about the mod release, not OXC release.

The last available mod versin on openxcom.com is called "2015-07-22 Nightly.zip", which requires this OXC nightly to work properly: "openxcom_git_master_2015_07_13_1222.zip".
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on September 03, 2015, 10:13:55 am
no meridian

The latest is 2015-08-11 Nightly.zip

EDIT:

Let me correct that, in the mod site i have no idea what is the latest, but in this thread the link that i posted is the latest that Shoes compiled, as far as i know.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: DrakeEB on September 07, 2015, 10:44:49 pm
Having an install problem.....

I backed up the openxcom.exe and all the dll files. I extract everything from the folder from the 8-11 nightly build for the mod into my openxcom folder and keep getting an (0xc00007b) error when i start the executable.

I didn't have this problem last time installing the mod. I backed everything up and tried a clean install too....

Any help would be nice thx.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on September 07, 2015, 11:05:01 pm
Having an install problem.....

I backed up the openxcom.exe and all the dll files. I extract everything from the folder from the 8-11 nightly build for the mod into my openxcom folder and keep getting an (0xc00007b) error when i start the executable.

I didn't have this problem last time installing the mod. I backed everything up and tried a clean install too....

Any help would be nice thx.

My best guess would be that the version of the mod and the version of OXC are different. Now that TFTD is in full swing, nightlies are much more sensitive towards this mod I think.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: DrakeEB on September 07, 2015, 11:09:09 pm
Is there a way to download an older nightly version, for example the 8-11 nightly that you most recently merged the mod with?

When i go to the nightly page on openxcom it only has the recent ones.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on September 08, 2015, 12:09:00 am
did you install an 8-11 nightly for OXC?
what i do to prevent any issues is do a clean install of the OXC 1.0 then do OXC 8-11 nightly and then install stats mod 8-11 nightly
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: DrakeEB on September 08, 2015, 03:01:08 am
did you install an 8-11 nightly for OXC?
what i do to prevent any issues is do a clean install of the OXC 1.0 then do OXC 8-11 nightly and then install stats mod 8-11 nightly

No i didn't. Could you post a link to the 8-11 download nightly, not the mod, but the actual OXC nightly itself. When i go on the main page of the website it only goes back to nightly 8-27. I'd appreciate that thx.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on September 08, 2015, 06:36:53 am
hello,

yeah that is one issue with older build they get pushed out and lost in the interwebs.

i do have a copy of the build if you like and trust me :)

https://www.dropbox.com/s/mmrhmgzza4mgd9z/openxcom_git_master_2015_08_11_2246.zip?dl=0
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: DrakeEB on September 08, 2015, 03:08:44 pm
Thx.

Maybe i'm installing it wrong. Now it's saying i have missing dlls.

I installed the 8-11 nightly, copied my data files in it and the nightly runs fine. Then i extract the mod openxcom.exe and dll files and i get that error...

What am i doing wrong....
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Meridian on September 08, 2015, 03:26:17 pm
Here's a full installation video I made earlier for someone: https://youtu.be/UpuGyPSEA-g
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: DrakeEB on September 08, 2015, 03:51:22 pm
NM, i found the issue, it was a windows 7 visual c ++ problem, thx for the help though! :)

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Cristao on September 11, 2015, 09:25:03 am
A bit lost here but will this work with the OpenXCOM v1.0? I dont use the nightlies.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on September 11, 2015, 01:24:03 pm
A bit lost here but will this work with the OpenXCOM v1.0? I dont use the nightlies.

No, it works with a specified nightly version, I can't say which one at the moment though. It's not a very old one, so chances are it'll work with the current nightly - no guarantees though.

Are you on Windows? If so, there's not a single conceivable reason not to use nightlies.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Daemonjax on October 04, 2015, 08:41:28 pm
This is a cool mod, but wouldn't it be best if the exe changes were merged into the nightly builds via pull requests?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: jgatkinsn on October 05, 2015, 08:41:04 pm
This is a cool mod, but wouldn't it be best if the exe changes were merged into the nightly builds via pull requests?

It would be, but the developers are more concerned about working the bugs out of the TFTD support before merging new features like this one into the mainline (rightly so).
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 05, 2015, 11:32:53 pm
It would be, but the developers are more concerned about working the bugs out of the TFTD support before merging new features like this one into the mainline (rightly so).

That and they would forever have to maintain my code once it gets merged. Because sometimes I disappear for weeks at a time :3
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Daemonjax on October 07, 2015, 09:04:58 pm
Fair enough, I guess.

It's just that the number of mods requiring custom builds (making them incompatible with each other) continues to grow.

I'd prefer to not have to choose. ;)  But it is what it is, and I'm grateful that these mods exist at all.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: slothen on October 30, 2015, 10:48:22 pm
Hi, I registered just to ask this..

I really want to get the stat-tracker/commendations mod working.  I understand this mod needs a nightly build of open xcom from July.  The oldest nightly available on the download page is october, and doesn't seem to work.  Can someone get me an older version of the open xcom nightly that works with this mod?  i really want to use this mod!

Basically I need this:  openxcom_git_master_2015_07_13_1222.zip
I can't find it!

Also, the mod page says the most recent version of the mod is from July 22, but I found some posts (and a download link) for a version from Aug. 8.  Does it matter which version of the mod I need to install, assuming I do get the right version to install it on.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Meridian on October 30, 2015, 11:40:27 pm
Try this combination:

OpenXcom: https://www.dropbox.com/s/mmrhmgzza4mgd9z/openxcom_git_master_2015_08_11_2246.zip?dl=0

Commendations mod: https://dl.dropboxusercontent.com/u/234369005/OXC/2015-08-11%20Nightly.zip

As far as I know it is the latest available.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: slothen on October 30, 2015, 11:50:25 pm
fantastic!  I will give this a try!

EDIT:  Seems to work!  Thank you!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on October 31, 2015, 01:57:32 pm
 
Try this combination:

OpenXcom: https://www.dropbox.com/s/mmrhmgzza4mgd9z/openxcom_git_master_2015_08_11_2246.zip?dl=0

Commendations mod: https://dl.dropboxusercontent.com/u/234369005/OXC/2015-08-11%20Nightly.zip

As far as I know it is the latest available.

Thanks Meridian!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: slothen on November 02, 2015, 08:12:17 pm
This is working.  The stat tracking is just beautiful.  This is something I wish xcom2012 had and I'm hoping a similar mod will be made for xcom2.

I'm playing with a few other mods:  better explosions, improved handobs, and lukes extra UFOs.  The extra UFO mod is loaded and it runs correctly, but so far every UFO has been the default interior layout, so I'm not sure about that.

i was also worried something was broken.  I played jan-april and every single mission was sectoids.  I'd seen plenty of floaters in previous games.  However I think this is okay, I've seen floaters for the first time in may.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on November 03, 2015, 01:53:34 am
The mod shouldn't mess with any of that... but while getting xcom1 to work wtih TFTD, the devs made some changes to certain conventions and what not. It may be possible that what you're seeing is a result of a poor merge on my part of these changes. It could also be totally unrelated though! So who knows :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: slothen on November 03, 2015, 05:11:19 pm
I got it figured out.  May was literally 100% floaters after 4 months of 100% sectoids.  The expanded UFOs worked once I adjusted where the files in that mod a bit.  Had to pull the subfolders out of the "data" folder.

There's some minor strangeness with stats and commendations.  Soldiers killed via friendly fire (explosives) and cyberdiscs killed (explosives or lasers) show up in the stat log as stunned.  Soldiers are also getting 'taking names' for killing any terrorist unit, i guess because terrorist species are all "terrorists."  Also getting things like mercy ribbons handed out when according to the description that should only happen if no aliens are killed.  Minor stuff though.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: blackwolf on November 04, 2015, 02:10:44 am
i abandoned the forum some time ago for real life issues, and i have to admit that now that i came back..this is one of the most interesting mods i always tried to keep tracking, i love the concept and i would completely cherish the fact it became nightly-friendly once more, im trhilled with the idea to play with it again...im using FMP and the only thing i miss to get the perfect gameplay its this mod tho....
Hope it get merged again soon, but i also know it may take it time after all the stuff devs are doing with TFTD....so for thanks for the project SHOES , best wishes to this amazing work pal.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on November 04, 2015, 02:22:56 am
I got it figured out.  May was literally 100% floaters after 4 months of 100% sectoids.  The expanded UFOs worked once I adjusted where the files in that mod a bit.  Had to pull the subfolders out of the "data" folder.

There's some minor strangeness with stats and commendations.  Soldiers killed via friendly fire (explosives) and cyberdiscs killed (explosives or lasers) show up in the stat log as stunned.  Soldiers are also getting 'taking names' for killing any terrorist unit, i guess because terrorist species are all "terrorists."  Also getting things like mercy ribbons handed out when according to the description that should only happen if no aliens are killed.  Minor stuff though.

Yeah, there has been a weird bug regarding multi-criteria commendations that occurred out of the blue one day after merging. "Taking Names" should be given after killing all the types of terrorists, but instead if given when you kill the last(?) one. Same with a bunch of other multi-criteria bugs. It's tough to crack because I think a change done elsewhere by the devs is causing it. Once it does get fixed (lol who knows when :D), there's a debug command to clear commendations, so you can reset and get proper commendations.

i abandoned the forum some time ago for real life issues, and i have to admit that now that i came back..this is one of the most interesting mods i always tried to keep tracking, i love the concept and i would completely cherish the fact it became nightly-friendly once more, im trhilled with the idea to play with it again...im using FMP and the only thing i miss to get the perfect gameplay its this mod tho....
Hope it get merged again soon, but i also know it may take it time after all the stuff devs are doing with TFTD....so for thanks for the project SHOES , best wishes to this amazing work pal.

Thanks! At the moment I am warming up to the idea of learning how to program under ubuntu. I hope to get back to it soon enough!

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on November 04, 2015, 03:00:44 am
I think there's some weird thing happening with the "one of each" types commendations, in that they are given for reaching the total, regardless of how. So if you have say: "kill 1 of each 5 kinds of terrorists", as soon as you kill 5 terrorists (it can be 5 of the same kind), you get the medal. Or something like that?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: slothen on November 04, 2015, 06:57:58 pm
I think there's some weird thing happening with the "one of each" types commendations, in that they are given for reaching the total, regardless of how. So if you have say: "kill 1 of each 5 kinds of terrorists", as soon as you kill 5 terrorists (it can be 5 of the same kind), you get the medal. Or something like that?

No, its happening for soldiers that kill only a single disc, as their first kill.  My assumption is that discs only come with the terrorist job, so they're credited for getting a kill on every type of disc.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on November 09, 2015, 06:18:25 am
Well good news, Shoes, is hard at work bringing the code up to date, and very soon we will all be enjoying looking at our medals, and the rumor mills says that it might be incorporated into the main some time in the near future.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on November 09, 2015, 03:01:51 pm
So with the help of R1d0 I have prepared a dev environment on ubuntu, now I just need to learn how to compile a windows executable from windows.

Then I suppose I could test to see if the darned thing even works? I haven't ever tried TFTD before..
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on November 09, 2015, 03:12:48 pm
Woot! So looking forward to that! And integration in the main build if it happens, which may mean integration in OXCE :D

Great news! Now I need to finish my playthrough with the old commendation version..!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: jgatkinsn on November 09, 2015, 06:10:22 pm
+1
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on November 11, 2015, 10:32:20 pm
So with the help of R1d0 I have prepared a dev environment on ubuntu, now I just need to learn how to compile a windows executable from windows.

Then I suppose I could test to see if the darned thing even works? I haven't ever tried TFTD before..

IF need be there are a lot of people that can compile one of those :) myself included. you let me know when the code is ready i can compile and create the .exe for you so you can do whatever it is you need to do
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: DracoGriffin on November 11, 2015, 11:07:54 pm
This would be great for Warboy.

This is not a reference to anything at all.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on November 12, 2015, 03:32:58 am
IF need be there are a lot of people that can compile one of those :) myself included. you let me know when the code is ready i can compile and create the .exe for you so you can do whatever it is you need to do

I might take you up on that! The current branch I have pushed to my git compiled for me, but is entirely untested gameplay wise. You can give it a whirl and see what happens.

Unfortunately for me, at this point in my project the only bugs that are left are the though ones. D:
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on November 16, 2015, 09:17:53 am
I might take you up on that! The current branch I have pushed to my git compiled for me, but is entirely untested gameplay wise. You can give it a whirl and see what happens.

Unfortunately for me, at this point in my project the only bugs that are left are the though ones. D:

Ok i am going to take and see what happens nothing new in it right? just all the good stuff :)

Functionality wise seems to be on par with the previous release.

TFTD of course still not working as mentioned before, the mod does not display in the mod list under option. However if the mod has been enabled in UFO even if not listed in TFTD it will display in the game with clear bugs. 

here are some pics i hope that helps if not then i will create a vid for you
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on November 16, 2015, 10:31:31 pm
Yeah I have no idea how to check if TFTD works with this ;p at the moment I don't have the assets to even run TFTD. I own the game on steam, but ubuntu won't let me download them. I'll have to install wine and then install steam in that and then get TFTD....

I hope in the merge I didn't lose access to TFTD somehow! :x
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on November 16, 2015, 11:35:02 pm
To me, this shows that it actually works. It looks mostly like simple missing strings because the mod was not enabled (the mod is also what defines those strings for buttons). Just go in the mod and change the master to "*" (with the quotation marks, I think?) so that it is recognized for TftD as well, load the save with it and it should look better.

It might have some issues with medals, but things like killing X or stunning Y numbers should work, and since Shoes made the weapons proficiency medals work for all weapons to include mods, that should work too. If the "mod compatibility" was there for races/ranks too (ex.: the xenocide medals), that might work too, but the "one of every race" shouldn't, since I think those are actually defined in the ruleset.

It should be a quick find/replace to make a TftD commendation ruleset where all sectoid occurrences are replaced by aquatoids, etc.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on November 17, 2015, 03:01:11 am

It might have some issues with medals, but things like killing X or stunning Y numbers should work, and since Shoes made the weapons proficiency medals work for all weapons to include mods, that should work too. If the "mod compatibility" was there for races/ranks too (ex.: the xenocide medals), that might work too, but the "one of every race" shouldn't, since I think those are actually defined in the ruleset.

It should be a quick find/replace to make a TftD commendation ruleset where all sectoid occurrences are replaced by aquatoids, etc.

I am actually not good in this I will wait to see if Shoes tries to get it to work the mod seems to work flawlessly in UFO other that some bugs that were reported but i do not know what they are.

In TFTD the medals do not show in the UFOpedia I have not played it just loaded and look at it.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on November 17, 2015, 05:26:18 am
success at least a good start


****UPDATE*****
OK after a quick evaluation and talking to Warboy, making a copy of the folder with _TFTD and modifying the metadata.yml to show xcom2 might be the better option.

****UPDATE 2******
Strings added
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on November 17, 2015, 07:35:35 am
Awards now showing up in in UFOPEDIA

HOwever when selecting an specific item we get a black screen i think this is due to palette, so i think this is as far as i can take it. Shoes will need to take over and fix that :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: DracoGriffin on November 17, 2015, 08:19:23 am
See? I told you. Good work, xracer!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on November 17, 2015, 04:47:07 pm
Falko's pallette converter may make short work of those 'pedia screens. ;)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on November 17, 2015, 06:34:24 pm
Great to hear I don't have to do more work :3 I am especially glad the ufopedia stuff is working to an extent. I wonder if it's a black screen because of ruleset issues again, as if the medals think they're only for xcom1.

Does anyone know if there is a way to share resources between xcom1 and xcom2 mods? I am hoping that I won't have to copy paste things and keep track of updating two locations.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on November 18, 2015, 01:48:47 am
Does anyone know if there is a way to share resources between xcom1 and xcom2 mods? I am hoping that I won't have to copy paste things and keep track of updating two locations.

Arthanor mentioned that it can be done in a simple way by setting master= (*)
But i think the issue will be the palette but then again i know nothing about all this,

Ivan maybe you could look into it :P
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on November 18, 2015, 02:01:49 am
You can load the same mod with different masters using that, but it will load the same data and that won't work because of the palettes. I was talking about the strings being loaded for both.

The UFOpaedia images will have to be redone to fit with the palette, unless Shoes wants to hack something that makes the medal section display with the UFO palette even in TftD. That might work better since the TftD palette is pretty limited and ugly..
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Cristao on November 18, 2015, 04:51:52 pm
I love the idea of this mod and I so want to enable it on mine. A couple of questions.

1 - Do I need to start it with a new game or can I enable it on an existing game and let it keep track from then?

2 - Does it work with the latest nightly? (I am using nightly from September)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on November 18, 2015, 05:59:57 pm
1 - Do I need to start it with a new game or can I enable it on an existing game and let it keep track from then?

Yes you can enable it at any point and start tracking from there.

2 - Does it work with the latest nightly? (I am using nightly from September)
No, currently under "development" I can give you an .exe to try, i have not tried it myself in play only in testing for functionality, Keep in mind that the mod if almost perfect in UFO (almost because Shoes says there are some bug I have not played it long enough to see them) but it works.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on November 18, 2015, 06:01:56 pm
1 - Yes, you can start using stat tracking from any point. It of course will not be able to recover what your soldiers have done in the past, but it will be able to track stats from the point you enable it.

2 - No, the "mod" requires its specific executable and its compatible nightly (from August 11th.. Shoes! We need an update!! ;)) It will most likely not work with more recent nightly (this topic is full of people who tried and failed)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on November 18, 2015, 06:21:38 pm
Falko's pallette converter may make short work of those 'pedia screens. ;)


Well it seems i have no idea how to use the tool, it keeps giving me blank images :(
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on November 18, 2015, 07:18:18 pm
My git branch is up to date, but my local branch actually includes a fix (!) for, of course, a super obscure easy to fix rarely ran into bug. What happens now is that the last person who shot an alien is credited with its kill if the alien dies for reasons that aren't normal; ie, fatal wounds or standing in fire. This of course is not accurate, because if two people shot an alien an both created wounds, they don't both get the kill.

Oh no.

I could.. track everyone whose ever shot an alien, and credit them with assists...

And then I can create commendations that are like "shot everyone in the mission but didn't kill anyone???"
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on November 18, 2015, 07:28:24 pm
But then can you get an assist if nobody gets the kill? If fire gets the kill, shouldn't the soldier with the incendiary ammo get the credit? If the target dies of fatal wounds, then the soldier who inflicted the most damage (thus did the most to bring the alien close to death by fatal wound) should get credit. That would add a few things to track:

- Latest Incendiary Hit: SoldierID (if alien dies by fire, this guy gets credit)
- Damaged by: [SoldierID, total damage] pairs (if alien dies by fatal wound, the soldier with the highest total damage gets credit)

In general, I think it would be nice to track assists, since it would recognize the contribution of some soldiers better, and hopefully it isn't much more work/data. But if the above can be implemented, then I don't think assists would be necessary, just a nice addition.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on November 18, 2015, 09:01:28 pm
But then can you get an assist if nobody gets the kill? If fire gets the kill, shouldn't the soldier with the incendiary ammo get the credit? If the target dies of fatal wounds, then the soldier who inflicted the most damage (thus did the most to bring the alien close to death by fatal wound) should get credit. That would add a few things to track:

- Latest Incendiary Hit: SoldierID (if alien dies by fire, this guy gets credit)
- Damaged by: [SoldierID, total damage] pairs (if alien dies by fatal wound, the soldier with the highest total damage gets credit)

In general, I think it would be nice to track assists, since it would recognize the contribution of some soldiers better, and hopefully it isn't much more work/data. But if the above can be implemented, then I don't think assists would be necessary, just a nice addition.

Fire is a tough one, because if one soldier hits one alien and lights the entire map on fire killing everyone, he still only hit one alien and would get one credit. To assign an "owner" to fire is complicated and breaks saves, and also fire does very little actual damage... so the amount of energy required to do this properly outweighs the benefits.

Fatal wounds, I could add more information to track who inflicts what and how much.

My hesitation with tracking these things more faithfully is that I don't want to introduce so much bloat to the source. I feel like players would never notice that the alien who died from fatal wounds had actually died from wounds inflicted by the 3rd soldier who shot him, whereas soldiers 4 and 5 only hit armor. I also don't think fire will ever actually kill an alien ;p and if it gets buffed to the point where it could kill an alien, well we fall back into the situation from above. Beyond breaking the saves and trying to assign an owner to fire, there's no absolutely faithful way of tracking who lit who on fire.

(Also, come to think of it, an alien could theoretically die from walking on someone else's fire, thus having never been shot. At the present moment, that would probably cause my mod to crash ;p)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on November 18, 2015, 09:41:18 pm
I wasn't meaning that fire should get an owner, or that who did how many fatal wounds.

What I meant is that during a battle, the game could keep track of the last soldier who set it on fire. So in a battle save, I think it is in the unit section, where you save the position and other things, it would look like:

Code: [Select]
Alien1:
- lastSetOnFireBy: Soldier3
- fatalWoundsInflicted:
  - Soldier5
    3
  - Soldier6
    2
- fatalWounds: 2
Then if an alien dies from wounds, Soldier5 gets the credit (he did the most fatalWounds). If the alien dies from fire, Soldier3 gets credit. This is in keeping with the idea of whoever scores the killing hit getting credit as it is currently in the mod, as opposed to who did the most damage.

So it adds a bit of bookkeeping for aliens during a battle, but 0 bookkeeping outside battles as it is still only assigning kills to units.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on November 18, 2015, 11:31:15 pm
At the moment, I am not explicitly tracking how a unit dies. There is a function that does that, but all it really does is check unit hp; damage/death by fire is done elsewhere. For me to know that an alien has died from fire _might_ be difficult, I will have to check.

Hopefully, I can set a flag "has died by fire", and have a variable "was shot by a soldier using DT_IN" ; put those two together, and you have yourself a pyromaniac.

Same thing with fatal wounds though; I don't think those are set at the same time that shots are landed. I will have to look to see if I can credit fatal wounds to certain soldiers and whatnot. Hopefully I can do something similar to my above approach: "has died by wounds", and has a variable "was wounded x times by y soldiers".

Do you have thoughts on what to do with the hypothetical situation where an alien dies but was not shot by anyone? I think the only way for that to happen is death by fire. Death by bleed out if there's a way to wound an alien without hitting him...
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on November 19, 2015, 12:13:10 am
hum.. do you have death by psi for modded psi? (If ever this gets merged the main branch, it will merge with Extended, which has potential for psi-like attacks).

Otherwise.. You already have death by alien? (ie alien panics/goes crazy and blows himself or his friend up)

Those are the only ways I can think of that could kill an alien without the player hitting it. Death by stepping in fire, and the infamous gumba stomps (especially by civilians) are the only other cases.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on November 19, 2015, 01:13:20 am
The other way enemies die without getting shot, is Cyberdisk explosions, etc.  Some elements in the terrain are explosive too, ie. exploding barrels.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on November 19, 2015, 09:17:21 pm
The other way enemies die without getting shot, is Cyberdisk explosions, etc.  Some elements in the terrain are explosive too, ie. exploding barrels.

Terrain explosives pass by the same logic as getting shot, so I do have those covered. And the code I am using to track who shot who was originally implemented for crediting soldiers with killing people via cyberdisk kills :)

hum.. do you have death by psi for modded psi? (If ever this gets merged the main branch, it will merge with Extended, which has potential for psi-like attacks).

Otherwise.. You already have death by alien? (ie alien panics/goes crazy and blows himself or his friend up)

Those are the only ways I can think of that could kill an alien without the player hitting it. Death by stepping in fire, and the infamous gumba stomps (especially by civilians) are the only other cases.

Death by alien is covered because the source treats everyone as "battle units". Death by psi however... do any mods do that without modifying source code? I am worried that there might be a crash when my stats mod tries to figure out which gun, using what ammo, killed the unit.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on November 19, 2015, 11:01:11 pm
As far as I know, it is impossible to kill with psi without modifying the code, but that's exactly what Yankes did in Extended ;) I was just thinking ahead: If commendations gets merged in the main branch, when Extended is updated to the main branch, they will have to work together (but one could say that's Yankes' problem..).
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on November 19, 2015, 11:12:17 pm
Nah, I should make sure that if anything "impossible" happens in the game, that the stats simply don't get added rather than crashing. Sanitization. That'll be the last step ;p
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on November 20, 2015, 02:07:42 am
have you made any updates lately, if you have i do not see GIT reflecting it, last update was 10 days or so ago. I am about to start continuing my LP (TFTD) so i want to update to the latest nightly and bring in the diaries .exe into play ;)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on November 20, 2015, 12:38:47 pm
I just pushed the changes I mentioned earlier. Hopefully they work :D

I did not make any changes to the metadata or pallettes to allow proper TFTD support ;p
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on November 22, 2015, 03:57:42 am
OK for people that would like to test the mod

This is the current release it is working with the latest nightly openxcom_git_master_2015_11_17_1628.zip

I can't upload the file, so this is the link to it

https://www.dropbox.com/s/zwgi206pw2vqaut/Shoes-Diaries_2015_11_21_1340.rar?dl=0

UFO is functional with no error except some bugs when awarding some medals, Shoes will get to them eventually

TFTD is partially working. the medal section in UFOpedia is present but object do not appear, press ESC to get back to the previous window.
There are also some palette work that needs to be done.
Please remember TFTD is a WIP

***NOTE***
I have tried to follow the right folder structure just be mindful it should be a straight paste.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: DracoGriffin on November 22, 2015, 05:58:41 am
If only this was compiled together with OXCE to run X-Piratez!

One day Gadget!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on November 22, 2015, 08:12:52 am
If only this was compiled together with OXCE to run X-Piratez!

One day Gadget!
Sorry for.that you should contact your local dealer :P
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: kikimoristan on November 22, 2015, 05:53:22 pm
shoes, for anything that gets too complicated simply don't award anything.

like figuring out how the unit dies by what weapon  etc place it in a try catch type code block. ie check for sucess or failure then if any of the functions fail to give any meaningful bock back simply break/return and award nothing . ie easy way out. this would avoid any issues like fire, explosives, PSI damage that can't be taken in consideration by your checking routines.

one funny thing is what happend when you PSI an enemy unit then make it kill itself. who gets that kill? in that case it should be the person that used PSI on that unit. you would check this by first checking if the unit is being controlled then skip the regular check routine and award a medal.


there should be a PSI control suicide kill medal .


:)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on November 22, 2015, 06:06:24 pm
one funny thing is what happend when you PSI an enemy unit then make it kill itself. who gets that kill? in that case it should be the person that used PSI on that unit. you would check this by first checking if the unit is being controlled then skip the regular check routine and award a medal.


there should be a PSI control suicide kill medal .


:)

I added functionality last time I worked on this for "MC'ing an alien and getting kills with it", so getting the alien to kill itself should be tracked ;p I don't think I have an award specifically for suiciding an alien though. I wonder if I would have to add more code for that or not..

As for creating a code block that does a general kill-check, I sort of have one at the moment. I think it covers damage types too.. but I am not sure. I would rather award a vague kill than not award one at all though. For example, blowing stuff up to kill an alien awards an "Improvisation" kill. In fact, I think any stat that "doesn't make sense" is given as an improv kill..
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: SupSuper on November 23, 2015, 02:18:26 am
If only this was compiled together with OXCE to run X-Piratez!

One day Gadget!
I am working on merging Soldier Diaries into the main OpenXcom branch, so once that's done it should make its way to OXCE eventually. :)

The Commendations will still be a standalone download though.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on November 23, 2015, 02:52:54 am
I am working on merging Soldier Diaries into the main OpenXcom branch, so once that's done it should make its way to OXCE eventually. :)

You are my hero!!  That's awesome news!!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on November 23, 2015, 03:38:25 am
Indeed! Great news! :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on November 23, 2015, 05:10:13 am
I am working on merging Soldier Diaries into the main OpenXcom branch, so once that's done it should make its way to OXCE eventually. :)

The Commendations will still be a standalone download though.

You are such a tease Sup, given users little pieces at a time :P
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: kikimoristan on November 23, 2015, 08:29:13 am
I am working on merging Soldier Diaries into the main OpenXcom branch, so once that's done it should make its way to OXCE eventually. :)

The Commendations will still be a standalone download though.


NICE!!!!!!!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Cristao on November 23, 2015, 12:27:12 pm
OK for people that would like to test the mod

This is the current release it is working with the latest nightly openxcom_git_master_2015_11_17_1628.zip

I can't upload the file, so this is the link to it

https://www.dropbox.com/s/zwgi206pw2vqaut/Shoes-Diaries_2015_11_21_1340.rar?dl=0

UFO is functional with no error except some bugs when awarding some medals, Shoes will get to them eventually

TFTD is partially working. the medal section in UFOpedia is present but object do not appear, press ESC to get back to the previous window.
There are also some palette work that needs to be done.
Please remember TFTD is a WIP

***NOTE***
I have tried to follow the right folder structure just be mindful it should be a straight paste.

HURRAH!!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Yankes on November 23, 2015, 08:57:39 pm
Oh Noooo! sleepless night on the horizon...
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on November 23, 2015, 09:11:48 pm
Oh Noooo! sleepless night on the horizon...

But we love you.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: jgatkinsn on November 24, 2015, 03:04:14 am
Awesome news, SupSuper!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Cristao on November 24, 2015, 09:54:17 pm
OK for people that would like to test the mod

This is the current release it is working with the latest nightly openxcom_git_master_2015_11_17_1628.zip

I can't upload the file, so this is the link to it

https://www.dropbox.com/s/zwgi206pw2vqaut/Shoes-Diaries_2015_11_21_1340.rar?dl=0

UFO is functional with no error except some bugs when awarding some medals, Shoes will get to them eventually

TFTD is partially working. the medal section in UFOpedia is present but object do not appear, press ESC to get back to the previous window.
There are also some palette work that needs to be done.
Please remember TFTD is a WIP

***NOTE***
I have tried to follow the right folder structure just be mindful it should be a straight paste.

Perhaps I am doing something wrong - is the exe file supposed to be 3MB? The OpenXcom nightly exe is about 8MB. If I double click on the exe in the mod, it says yaml error.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on November 24, 2015, 10:10:44 pm
The OXC .exe likely has all the .dll files stored inside the .exe, making it cleaner but larger. I don't know how to do that, so my .exe comes with a bunch of .dll files that need to be in the right place. I did not check xracer's .rar, but if there are no .dlls, go download my old version and plop his .exe in the place of mine. Plopping his .exe into mine should also fix missing yaml issues, if there are some.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Cristao on November 24, 2015, 10:48:28 pm
The OXC .exe likely has all the .dll files stored inside the .exe, making it cleaner but larger. I don't know how to do that, so my .exe comes with a bunch of .dll files that need to be in the right place. I did not check xracer's .rar, but if there are no .dlls, go download my old version and plop his .exe in the place of mine. Plopping his .exe into mine should also fix missing yaml issues, if there are some.

Worked but all the old commendation data is gone and I didnt back it up. Oh well at least it worked - we can start again. Thanks.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Yankes on November 24, 2015, 11:23:33 pm
The OXC .exe likely has all the .dll files stored inside the .exe, making it cleaner but larger. I don't know how to do that, so my .exe comes with a bunch of .dll files that need to be in the right place. I did not check xracer's .rar, but if there are no .dlls, go download my old version and plop his .exe in the place of mine. Plopping his .exe into mine should also fix missing yaml issues, if there are some.
all libraries need be compiled as static. With it then not need dlls. One way is get mxe.cc tool chain on linux that already have it configured.
https://github.com/Yankes/OpenXcom/blob/OpenXcomExtended/src/Makefile.mxe this is how I do it (based on makefile from nightly).

[ps]
small detail, mxe.cc for default don't have enabled flac file support, here I store commit that re-enable it: https://github.com/Yankes/mxe
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on November 25, 2015, 03:16:45 am
Worked but all the old commendation data is gone and I didnt back it up. Oh well at least it worked - we can start again. Thanks.

Hmm... that is weird. I continued a game with old commendations and it seemed to be working properly.

Perhaps I am doing something wrong - is the exe file supposed to be 3MB? The OpenXcom nightly exe is about 8MB. If I double click on the exe in the mod, it says yaml error.

Shoes is correct i should have added the .dll files into my .rar  but like he said just replacing the his .exe with the one i supplied should fix all the issues.
If you are getting a YAML file double check the language file US_eng  towards the end of the file for  STR_DIARY: "RECORD" i noticed that in one of my files i had 2 extra spaces.


***UPDATE****

I have corrected the YAML issue and included the .DLL into the folder. Sorry for any inconvenince or if any of you kitties got hurt because of it.

Here is the corrected file.

https://www.dropbox.com/s/zwgi206pw2vqaut/Shoes-Diaries_2015_11_21_1340.rar?dl=0



Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: SupSuper on November 25, 2015, 11:55:36 am
I'm not responsible for any conflicts if we end up with 5 separately-maintained versions of the Diaries. :P Once it goes into the nightlies that's the official one.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on November 25, 2015, 04:58:43 pm
What about just putting the stats tracking part in the main branch, and then people can release their own awards mods to take advantage of it? I guess there's not harm in distributing Shoes' version of the awards as an optional mod like some of the other "built in mods" we already have.

Also.. any chance you can fix the "one of each kind" awards that Shoes was having trouble with?  :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on November 25, 2015, 05:31:17 pm
I'm not responsible for any conflicts if we end up with 5 separately-maintained versions of the Diaries. :P Once it goes into the nightlies that's the official one.

Well this is very true as soon as that goes into the nightlies i will remove all my links and take the file offline :) i do not want to add to confusion.

What about just putting the stats tracking part in the main branch, and then people can release their own awards mods to take advantage of it? I guess there's not harm in distributing Shoes' version of the awards as an optional mod like some of the other "built in mods" we already have.

Actually that is exactly what is going to happen Supsuper s only going to add Shoes soldier stats tracking the awards section is not going to be part of it. at least not yet, as far as i know.

I also presume he will correct the UI in the TFTD version i mean palette correct it.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on November 25, 2015, 06:50:42 pm
Actually that is exactly what is going to happen Supsuper s only going to add Shoes soldier stats tracking the awards section is not going to be part of it. at least not yet, as far as i know.

I also presume he will correct the UI in the TFTD version i mean palette correct it.

Right, the code will be there but not the rulesets or resources. When the code is fully merged, I will likely make a wiki page detailing the ins and outs of the code and its flexibility, along with issues :D Gratefully though, the stats tracking portion is not buggy. I (and anyone else for that matter!) will be able to PR fixes too.

And yeah, SupSuper is going through and making it TFTD friendly :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Meridian on November 25, 2015, 06:58:52 pm
Best Christmas present ever, I <3 you guys.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: SupSuper on November 26, 2015, 02:05:48 pm
And yeah, SupSuper is going through and making it TFTD friendly :)

(https://puu.sh/lwsyZ/f14d92c1a9.png)

Getting there. :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: xracer on November 26, 2015, 09:22:51 pm
(https://puu.sh/lwsyZ/f14d92c1a9.png)

Getting there. :)
aaaahhh that is looking PRETTY :) very very very soon
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: DracoGriffin on November 26, 2015, 09:57:53 pm
I cannot express myself with these emoticons appropriately but my god, SupSuper.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: SupSuper on November 29, 2015, 03:35:50 am
Soldier diaries are now in the nightlies! Keep an eye out for bugs. :)

Changes:
- TFTD compatible!
- Various string / UI changes
- Kill statistics now contain full unit name
- Mission statistics now contain marker name
- Various fixes

Old soldier stats should still work, but inconsistencies may arise.

Here's the new standalone Commendations mod (X-COM 1 only):
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on November 29, 2015, 05:17:23 am
With  Stat-Tracking now merged into the Nightlies, I have uploaded the Medal Template file (https://www.openxcom.com/mod/medal-template-commendations)that I used in creating the UFOPEDIA medal images.  Feel free to use it to create your own awesome medals!!! :)

Thanks Supsuper!!  I honestly never really believed this day would come!!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on November 29, 2015, 03:58:55 pm
Soldier diaries are now in the nightlies! Keep an eye out for bugs. :)

Changes:
- TFTD compatible!
- Various string / UI changes
- Kill statistics now contain full unit name
- Mission statistics now contain marker name
- Various fixes

Old soldier stats should still work, but inconsistencies may arise.

Here's the new standalone Commendations mod (X-COM 1 only):

Hooray! I took a look through your commit diffs, and that's quite a bit of work! I appreciate it :) Honestly, I am surprised your "Fix logic holes" commit was so small...


Thanks Supsuper!!  I honestly never really believed this day would come!!


I didn't expect it so early! :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Meridian on December 01, 2015, 12:17:00 pm
Hi SupSuper,

I did Slovak translation and some testing, here's the feedback. Should I open it in bugtracker?

1/ On the mission detail, the "No record" label is too short for other languages, see attached
2/ On "Efficacy", there is not enough space between Panicks and Controls, see attached
3/ On "Performance" everything seems OK to me
4/ On "Awards" the decoration level is also too short, see attached

5/ After base attack mission, the "MEDALS" GUI has wrong colors, see attached screenshot and save for reproducing (save is attached in the next post... take Avenger-1 and attack any base and abort).

6/ Is STR_HUMAN used anywhere?

Nightly: openxcom_git_master_2015_12_01_0110.zip
Mods: only Commendations (your attachment from this thread), nothing else
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Meridian on December 01, 2015, 12:19:32 pm
Sorry for double posting, but I couldn't fit the save into last post for some reason
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: SupSuper on December 01, 2015, 01:50:42 pm
Color bugs should be fixed, but the UI will likely have to be completely redesigned as it's not good for translations (or even TFTD) at all. :P
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Neo23 on December 01, 2015, 05:20:02 pm
I've waited a long time for this. Big thanks to Shoes, SupSuper and Ivan.
Since my german translation was never implemented, I included it in the latest version from SupSuper and updated it accordingly.

P.S. There seems to be some color issues left for awarded medals after a mission (landed UFO). It happens not every time though, which is rather strange.
So far I had a crash after this test mission too. Exactly as I pressed the turn end button (all enemies dead and I do not use the auto end feature), but I cannot reproduce it.
Sadly I can give no useful information about this at the moment.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Meridian on December 02, 2015, 09:14:57 am
Color bugs should be fixed...

Did you mean "...are fixed", "...will/must be fixed" or "...may be fixed in the future"? Don't see any commits, so just asking, sorry to be a pain.

PS: I would ban the english word "should" (and the german word "soll")... they are so confusing
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: SupSuper on December 03, 2015, 11:32:20 am
Did you mean "...are fixed", "...will/must be fixed" or "...may be fixed in the future"? Don't see any commits, so just asking, sorry to be a pain.

PS: I would ban the english word "should" (and the german word "soll")... they are so confusing
It means "I fixed something but I can't guarantee I fixed the root of the problem because this is a harsh bitter world we live in". :P

Anyways I cleaned up the UI sizing stuff, I'll look into the color problems next.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: the_third_curry on December 03, 2015, 09:45:07 pm
PS: I would ban the english word "should" (and the german word "soll")... they are so confusing

English did originally have "should" and "ought" to clarify the difference. Initially, should was a predicative whereas ought indicated a desirable future outcome. Therefore "The bug should be fixed" meant that the bug, based on previous actions taken, is likely to no longer exist, and "The Bug ought to be fixed" indicates a desired course of action that the bug be fixed in the future. Over time, this distinguishment was lost and ought fell out of favor.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on December 04, 2015, 12:47:45 am
English did originally have "should" and "ought" to clarify the difference. Initially, should was a predicative whereas ought indicated a desirable future outcome. Therefore "The bug should be fixed" meant that the bug, based on previous actions taken, is likely to no longer exist, and "The Bug ought to be fixed" indicates a desired course of action that the bug be fixed in the future. Over time, this distinguishment was lost and ought fell out of favor.

I'm using it from today on. Thanks! :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: The Reaver of Darkness on December 05, 2015, 04:38:29 am
This mod seems rather interesting. I never looked at it before because the title made it sound boring and useless. Perhaps it should be called "Soldier Journals" instead, to indicate that the records contain raw attributes and events, rather than a soldier's words of contemplation. It's probably too late to change it though. :/


I might try using this mod. It seems to track a lot of useful info!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: DracoGriffin on December 05, 2015, 05:32:09 am
This mod seems rather interesting. I never looked at it before because the title made it sound boring and useless. Perhaps it should be called "Soldier Journals" instead, to indicate that the records contain raw attributes and events, rather than a soldier's words of contemplation. It's probably too late to change it though. :/


I might try using this mod. It seems to track a lot of useful info!

It's no longer a mod as of https://openxcom.org/2015/11/soldier-diaries-are-here/ - it's now integrated into default vanilla OpenXcom.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: The Reaver of Darkness on December 05, 2015, 07:24:39 am
it's now integrated into default vanilla OpenXcom.
Whoa cool!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on December 05, 2015, 04:35:28 pm
Whoa cool!

Commendation functionality has been merged, but you still need your own rulesets (or the one I link in the original post) to actually get commendations :)

Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Solarius Scorch on December 12, 2015, 02:57:37 pm
All of my men who kill anything get the Armis Potens medal. I guess it's a bug? Do I have an outdated version or what?

EDIT: Nevermind, now I get it...
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: blackwolf on December 18, 2015, 10:22:24 am
so, i get a little confused...i want to use this mod, but i readed it became merged with the nighties....but are the COMMENDATIONS(medal stuff) merged too?, because i found a couple of mods for ivan dogovich that someway replace the ufopedia images or something, but it says its obsolete because the features were already merged.

So the TL;DR version: does nigthies contain both the stat tracking and the commendation mod?
in case the answer is not, can someone recommend me how i can do it by myself? thanks a lot for your patience.

ps: hi solarius, is there any plan to include or improve the commendation feature in your FMP ?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Meridian on December 18, 2015, 10:26:36 am
so, i get a little confused...i want to use this mod, but i readed it became merged with the nighties....but are the COMMENDATIONS(medal stuff) merged too?, because i found a couple of mods for ivan dogovich that someway replace the ufopedia images or something, but it says its obsolete because the features were already merged.

So the TL;DR version: does nigthies contain both the stat tracking and the commendation mod?
in case the answer is not, can someone recommend me how i can do it by myself? thanks a lot for your patience.

ps: hi solarius, is there any plan to include or improve the commendation feature in your FMP ?

Commendations mod is NOT in the nightlies.

The link for download is one page earlier in this thread: https://openxcom.org/forum/index.php/topic,1718.msg55250.html#msg55250
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: blackwolf on December 23, 2015, 01:50:44 am
THANKS A LOT pal!, it worked like a charm!, but..i have another problem now, and i know this could not be the place to ask, but how i install TFTD, i have the collectors edition cdrom so, do i have to "install" the content of everything related of tftd somewhere, or they are included with the nighties..sorry again, and thanks for your help.

ps: im loving the new features and the commendation mod its just wonderfull :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on December 23, 2015, 03:52:32 pm
THANKS A LOT pal!, it worked like a charm!, but..i have another problem now, and i know this could not be the place to ask, but how i install TFTD, i have the collectors edition cdrom so, do i have to "install" the content of everything related of tftd somewhere, or they are included with the nighties..sorry again, and thanks for your help.

ps: im loving the new features and the commendation mod its just wonderfull :D

Glad you like them :) there are a few bugs in it still, but I hope you will overlook them! As for TFTD, the nightlies is only code, no art or sound. It would be best you install TFTD, and then follow the installation instructions to copy/paste the art and sound assets into OXC.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: blackwolf on December 25, 2015, 08:08:36 am
yeah, about "bugs" i only recall a few one being present in the ufopaedia, there are like five or maybe six(?) placeholder entries that have not been deleted , specially the placeholder entries for the kia and mia medals...because if i remember correctly there are the fallen and lost commeration or something like that (i dont recall them etxacly now xD). Aside that, there is nothing specially killing about it, so this its a complete 11/10 :).
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Cristao on December 28, 2015, 11:43:25 pm
GREAT MOD!!!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Neo23 on January 07, 2016, 05:21:11 pm
There are still many false awarded medals left. Recently I had a reproducible crash at mission end and it turned out it was the commendations ruleset. These happen in UFO and TFTD (converted commendations.rul by me) but in UFO more random.
More info about that here:
https://openxcom.org/forum/index.php?topic=4211.msg57180#msg57180 (https://openxcom.org/forum/index.php?topic=4211.msg57180#msg57180)

Here are some confirmed problematic entries:

False awarded:
-------------------
- STR_MEDAL_ALLRANKS_NAME
- STR_MEDAL_ALLBATTLETYPES_NAME
- STR_MEDAL_TRAP_NAME (this can be TFTD only, not sure though)

Can crash the game (TFTD only confirmed):
------------------------------------------------------
- STR_MEDAL_ORDER_OF_RESTRAINT_NAME
- STR_MEDAL_HELLRAISER_MEDAL_NAME
- STR_MEDAL_DISTINGUISHED_SERVICE_NAME
- STR_MEDAL_BOLTS_CROSS_NAME
- STR_MEDAL_SAPPER_NAME
- STR_MEDAL_SECTOPOD_KILL_MEDAL_NAME
- STR_MEDAL_HEADSHOT_NAME
- STR_MEDAL_REARSHOT_NAME
- STR_MEDAL_FLANKSHOT_NAME
- STR_MEDAL_ANTITERROR_NAME
- STR_MEDAL_MINDCONTROL_NAME
- STR_MEDAL_PSIPANIC_NAME
- STR_MEDAL_SLAVEKILLS_NAME

I hope this information helps somehow.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on January 07, 2016, 10:32:37 pm
That's great that you were able to narrow it down to the commendations only. The mod itself is not official, even though I managed to get its source code merged into the base game :3

As for a band-aid fix, I would suggest removing the commendations that are being falsely awarded and that are crashing your game, then enter debug mode and do (if I recall...) ctrl+c. That should clear all the commendations from your soldiers, and at the end of the next mission/month, everything will be reawarded according to what's left in the ruleset. Stats will still be tracked, so if you re-add the commendations later, no progress will have been lost.

As for actually fixing the issues, I don't see a common denominator in the commendations. Some of the commendations you've cited are actually quite old and haven't really ever caused problems. It's possible that Supsuper made some changes to the source code that needs to be reflected in the commendations ruleset, but I can't think of anything that would cause crashes. If a commendation is malformed, it simply gets awarded all the time (the code checks to see if commendations should be NOT awarded, and if one is malformed, it doesn't get checked). I would like to look at the ruleset you've made before spending too much time hunting for these bugs. It's entirely possible that TFTD is the culprit as I haven't done much work on it since TFTD.

As for the falsely awarded commendations, I am aware of the bugs you've mentioned. Last time I dug into the code, I had concluded that the bug was arising from elsewhere in the code, and as I am not actually a programmer, I couldn't make sense of it :D
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Neo23 on January 08, 2016, 03:24:44 pm
Sure, I attached my TFTD version (for UFO I use the one from SupSuper only with my german translation added).
The above mentioned entries are commented out for the moment. So far my test game ist normally playable again, but more issues could maybe arise later.
As for UFO I have no actual test game ongoing at the moment, but short just for fun tests showed similar problems in the past. In UFO crashes are more random and
not often. Very hard to track down. I am too thinking not all these medals are totally broken, but many have problems with TFTD it seems, but there is clear a UFO problem too.
In TFTD all PSI-Medals are affected and many with the condition STATUS_UNCONSCIOUS too as far as I can see.


I really love this mod and I am very happy this got finally merged into the main branch. I hope these issues can be fixed some day in the future.

P.S. English text in this ruleset has not been optimized for TFTD yet. Only the german texts are supported for now. This file is not ready for serious playing in english OXC versions and supposed for debugging only.
P.P.S. @Shoes: If you need the converted graphics as well, I will upload them too.


Edit:
Good news. It seems the crashes are fixed with commit 3eb30c2 (https://github.com/SupSuper/OpenXcom/commit/3eb30c2087de6c33cfcaeb3426d9e3832a8604b9). I cannot reproduce these anymore with latest nightly and all medals enabled again. Funny thing it is I did not even get one of the affected medals after the mission in my affected test save. I think remaining issues are in the EXE source then.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Countdown on January 18, 2016, 07:00:46 pm
Soldier diaries are now in the nightlies! Keep an eye out for bugs. :)

Changes:
- TFTD compatible!
- Various string / UI changes
- Kill statistics now contain full unit name
- Mission statistics now contain marker name
- Various fixes

Old soldier stats should still work, but inconsistencies may arise.

Here's the new standalone Commendations mod (X-COM 1 only):

Sorry, I am new and not sure why this isn't working for me; this is my first time trying to add in a mod. I am using the milestone X-Com 1 download (not the latest Nightly).

On my Mod option screen I have the option for "Commendations" and I turn it to Yes and the game re-loads just fine. But nothing has changed. No stats, no medals after missions or a place to view available medals.

I pasted everything except the ruleset into the "Resources" folder. Am I missing something else?


Thanks for any help/advice. Loving what OXC is doing with this game. Played this once and while on my uncle's computer when I was kid, so just started playing again for the "nostalgia" factor, but then discovered it's one of those rare things that was actually way better than what you remembered/could appreciate when you were younger.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: R1dO on January 19, 2016, 01:27:46 am
Good to have you aboard, my your rookies live long and prosper ;)

The commendation mod depends on the soldier diaries code. Hence the solution lies in the first line of SupSupers quote.

Please remember that the nightlies use a different layout for the data and mod folders.

Good luck
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Orz on January 27, 2016, 02:02:25 am
I couldn't fail to notice that Engineer/Technician (rank 2) was listed above Leader/Navigator (rank 1), while all other ranks are listed correctly in order from bottom to top (Terrorist, Soldier, etc. all the way to Commander)?

Will anyone correct this? I haven't found a way to edit this myself (using latest nightlies).



Scratch that, rank order seems to be totally randomized, correct?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on January 27, 2016, 05:51:22 pm
I couldn't fail to notice that Engineer/Technician (rank 2) was listed above Leader/Navigator (rank 1), while all other ranks are listed correctly in order from bottom to top (Terrorist, Soldier, etc. all the way to Commander)?

Will anyone correct this? I haven't found a way to edit this myself (using latest nightlies).



Scratch that, rank order seems to be totally randomized, correct?

What do you mean by rank order; are you talking about the diary screens, listing who you've killed? The lists aren't really ordered as far as I remember, I think it's more of a first come first serve.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Orz on March 02, 2016, 01:29:12 am
What do you mean by rank order; are you talking about the diary screens, listing who you've killed? The lists aren't really ordered as far as I remember, I think it's more of a first come first serve.

OMG, I totally missed this! Late reply, but yes, that's exactly what I meant.



But I come here now to report a totally unrelated issue, though. I think this is a Soldier Diaries' issue since me fixing the string on my end for Male Civilian still won't change what is displayed here:

(https://s21.postimg.org/j7syg7q9j/screen187.png)

Minor bug, but should display correctly as in UFO/EU. Not sure if the same issue would affect Female Civilian as I haven't "accidentally" killed any.

As an aside, I didn't intend to kill the above dude on purpose; but you see, it was kind of a bottleneck situation and the dude wouldn't budge and my guys needed to pass through or an alien would get away next turn. It was for the greater good, I promise :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on March 02, 2016, 02:04:33 am
I was going to ask how you managed to "accidentally" kill a civilian with a vibroblade. Those are pretty deliberate weapons. But fair enough. Careful with the justification (https://wh40k.lexicanum.com/wiki/Greater_Good) though. Makes you sound like a xeno fish scum (https://wh40k.lexicanum.com/wiki/Tau).

But the main point of my writing here was to check: Did you define a value for "MALE_CIVILIAN" or "STR_MALE_CIVILIAN" ? The first should work, the second will not.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Orz on March 02, 2016, 02:17:28 am
I was going to ask how you managed to "accidentally" kill a civilian with a vibroblade. Those are pretty deliberate weapons. But fair enough. Careful with the justification (https://wh40k.lexicanum.com/wiki/Greater_Good) though. Makes you sound like a xeno fish scum (https://wh40k.lexicanum.com/wiki/Tau).

Thanks, that'll give me something interesting to read later. I always had an eye for Warhammer 40K, but never quite got into it. Curiously, though, from a brief overview I did on the races/factions, the Tau stood from the crowd for me :O

Quote
But the main point of my writing here was to check: Did you define a value for "MALE_CIVILIAN" or "STR_MALE_CIVILIAN" ? The first should work, the second will not.

Yes, indeed, that fixed it!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on March 02, 2016, 06:53:16 pm
Thanks Arthanor!

I am pleased to see this is working so well with the Piratez game :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Kjotleik on March 11, 2016, 01:24:46 am
What does 'Improvisation" mean?

I'm using nightly 2016-02-27 04:45, Final Mod Pack 1.9.1.
I figured this was the most appropriate thread to ask the question, even though Soldier Diaries is included in the OXC itself.

I got this in two missions in a row, with the same soldier.

Mission One: Terror mission.
Weapon: Multi-Launcher.
Situation: Stepped out and fired, missed! Rocket just flew past the target and disappeared in the fog-of-war.
Next step: Getting psi-targeted on enemy turn, fleeing back to the Skyranger and getting out of there...(like a coward).
Result: One Kill - Civilian - weapon: Improvisation (?).

Mission Two: Ground Assault.
Weapon: Multi-Launcher.
Situation: Killed two Floaters (got the kills as Multi-Launcher kills). Then missed a third Floater by hitting the corner of the UFO.
Next step: Used other soldiers to fire (and miss) the target. One other soldier threw an incendiary grenade to light the target on fire.
...target then escaped into the UFO where he died from a fatal would, auto-ending the mission, two turns later.
Result: Three Kills - Floaters - weapons: Multi-Launcher (2) and Improvisation (1).

To me it seems both kills I got credited was indeed done by my Multi-Launcher. But why does it show up as "Improvisation?"

Please enlighten me with the answer to this. I'm a bit curious.


PS!
On a secondary note: I've also gotten a medal (Commendation mod, I presume) for killing with all weapon-types. The problem is I just got two kills from using a grenade (this was the soldier's first mission with kills recorded). Is this something to do with the Commendations mod, FMP or OXC? I have no clue as to where to ask questions about this. About how to fix it, I mean.

Sincerely
Kjotleik


Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on March 11, 2016, 01:34:44 am
Unfortunately, some of the medals are still a little bugged.  (i.e. the All Weapon Types) that you got.

Improvisation is basically anything that the game doesn't track as direct action.  > Shoot a barrel that explodes and kills a civilian? : Improvisation.   Take down a Cyberdisk that then explodes taking out 3 nearby sectoids? :improvisation.

That said, there could still be something buggy going on in your situations.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on March 11, 2016, 02:58:59 am
Some of the awards from commendations are a bit buggy because the logic to attribute them is flawed. The all weapons and all ranks medals in particular, I think.

Regarding improvisation: Improvisation kills are given when something dies of.. something.. unusual. If the kill does not meet any of the checks (it wasn't a rifle kill, a grenade kill, a MC, etc.) it is labelled as improvisation.

If your case, the civilian must have died somehow in the aliens' turn, probably because something blew up (or maybe got wounded by the multi-launcher but not killed?). It probably died of mortal wounds and since that doesn't factor as a "known cause", it was labelled improvisation.

Same thing with the floaters. You killed two with the launcher, then set one on fire who died later. You got two ML kills, so that matches, and the improvisation is for the floater who burned to death, since fire death are not tracked (you would need to track who set him on fire, and who set every] tile on the map on fire, in case an alien steps on it and dies of the fire, which was deemed to be too much tracking).
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Kjotleik on March 12, 2016, 09:48:27 pm
Thank you both, Arthanor and ivandogovich.

That was good information to get. I'll try to keep an eye out for anomalies in the medals given. I can happily report that the Order of the Fallen seems to work as intended, at least. I've got a lot of cases that can confirm only dead soldiers get awarded this medal  :o

Maybe it's just me, but it would be more logical to re-name "Improvisation" to "Unknown Cause."

PS!
Just one question to Arthanor: If the On Fire/Mortally Wounded alien/civilian dies later, and the game doesn't track what injured him... how come one of my soldiers actually got credited with the kill? Is there a "last injured by" flag, or something?

PS2!
Oh, and about tracking tiles on fire: If any alien steps onto a tile on fire (and dies from it), then I'd argue it wasn't really the soldier lighting the tile on fire that made the kill. It was more a suicide than a kill, in my opinion.

Wouldn't it be a better solution to model it such a way that kills of unknown (untracked) sources never got credited to soldiers at all? You could always just give the info on the mission screen (when you click the mission in the diary to see the specifics). Kills by Soldier - Kills by Squad - Deaths of Unknown Causes.

Wops. Didn't mean to be too demanding here. Sorry if this post comes off as that. Not my intention. Just throwing out my ideas, the brainstorming way...


Sincerely
Kjotleik
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Arthanor on March 12, 2016, 09:55:46 pm
Good questions! And it's always interesting to discuss the mechanics of things. Unfortunately, I don't know the proper answers to these.. My answer to your previous question comes from old discussions I've had with Shoes in this very topic.

We really need the medal master (Shoes) to answer these. :/
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Countdown on March 14, 2016, 01:26:23 am
Just posting here in case Shoes or someone else gets to respond. I started a thread (https://openxcom.org/forum/index.php/topic,4393.0.html) elsewhere, but did't get any responses so maybe it was in the wrong section or just too long to bother with.

Anyway, basically I've also noticed some inconsistencies with the stat tracking regarding mind control. Sometimes it miss-attributes kills to the wrong soldier or counts them differently in one place than another. A specific example and save file is linked to in the above thread.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Xeno Wiper on March 14, 2016, 03:25:42 am
Maybe it's just me, but it would be more logical to re-name "Improvisation" to "Unknown Cause."


Or it could be called "Miscellaneous".  ::)


Heh, "Unknown cause" reminds me of a morgue thing. And as Xcom is the one that does the autopsies, they are never unknown... :P


Just posting here in case Shoes or someone else gets to respond. I started a thread (https://openxcom.org/forum/index.php/topic,4393.0.html) elsewhere, but did't get any responses so maybe it was in the wrong section or just too long to bother with.Anyway, basically I've also noticed some inconsistencies with the stat tracking regarding mind control. Sometimes it miss-attributes kills to the wrong soldier or counts them differently in one place than another. A specific example and save file is linked to in the above thread.


But before changing names, it's better to solve this first.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Countdown on March 15, 2016, 05:10:13 am
As for a band-aid fix, I would suggest removing the commendations that are being falsely awarded and that are crashing your game, then enter debug mode and do (if I recall...) ctrl+c. That should clear all the commendations from your soldiers, and at the end of the next mission/month, everything will be reawarded according to what's left in the ruleset. Stats will still be tracked, so if you re-add the commendations later, no progress will have been lost.

As for the falsely awarded commendations, I am aware of the bugs you've mentioned. Last time I dug into the code, I had concluded that the bug was arising from elsewhere in the code, and as I am not actually a programmer, I couldn't make sense of it :D
Just a note to anyone who uses this fix. When you do ctr+c that doesn't delete the commendations for your dead soldiers, only your live ones. So if you delete an award from the ruleset and then go into a dead soldier's awards section who has it, the game will crash. You have to manually go into the save file and delete that commendation from that dead soldier. Just open the save file in a text editor, use ctrl+f to search for that award name and delete all traces of it.


The strange thing to me about the falsely awarded commendations is they're not consistent. If it was just giving them out too easily, you'd think any soldier that meets the false criteria would get it, but it seems random. Also I noticed for example that the Order of the Hammer award was falsely awarded, but when I used the ctrl+c it wasn't re-awarded on the next mission even though I hadn't deleted it from the ruleset. Strange. The rulesets seem fine as far as I can tell, so I assume the problem is in the code and someone with C++ knowledge would have to correct it.


PS - Is there somewhere in the game to view cause of death? I see the info saved in the save file, but not anywhere to access it in game.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Countdown on March 15, 2016, 05:41:30 am
PPS- Just comparing notes with others. These are the commendations I've seen falsely awarded thus far:

-Mercy Cross (supposed to go to someone who stuns all aliens in a mission, but goes if they are the only person to stun one)
-Armis Potens (kill with all weapons award)
-Taking Names (kill all ranks award)
-Order of the Hammer (kill all alien races award)
-Hercules Medal (kill all terror weapon award)

-Order of the Earth (debatable ... supposed to be "special missions", but counts small and medium "landing" sites as special (landing instead of crashed). I just changed the wording in the award to reflect that.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on March 15, 2016, 11:31:09 pm
The strange thing to me about the falsely awarded commendations is they're not consistent. If it was just giving them out too easily, you'd think any soldier that meets the false criteria would get it, but it seems random. Also I noticed for example that the Order of the Hammer award was falsely awarded, but when I used the ctrl+c it wasn't re-awarded on the next mission even though I hadn't deleted it from the ruleset. Strange. The rulesets seem fine as far as I can tell, so I assume the problem is in the code and someone with C++ knowledge would have to correct it.

That might be why I haven't fixed any of these ;p

As others have said (thanks guys!), "Improvisation" is the logic not knowing what happened. You can modify the string in your files to read something more appropriate; I was being a little cheeky when I decided on that term!

Regarding kills involving fire and stuff: fire hardly ever kills in vanilla XCOM. And tracking who lit what on fire meant breaking all the saves, because of the way tiles are saved or something. Thinking it is more pleasing to have your awesome fire kill awarded (and a few erroneous kills) rather than not having that awesome fire kill awarded, I went with a pretty relaxed system. Any unit who gets hit by something remembers who last hit them; then, if that unit dies, the last person who hit them gets a credit for the kill. It's not great, but as I can't track who started what fire, I can't track who kills who via fire properly.

Regarding cause of death: I think that's only used in the 'fallen soldiers' screen after missions. Come to think of it, it should probably show up in the memorial screen too.

I have an old running list of bugs and things I want to look at here : https://gist.github.com/Shoes01/3af40f402d287ae9c229. I have myself the note "MAJOR BUG: The last entry in a the kill "and" criteria is the only one being looked at." pinned as the bug responsible for commendations like Mercy Cross and Taking Names being awarded incorrectly. It's a public gist, so feel free to add comments below about other things I need to look at; it's much cleaner than skimming through discussions in this thread :)

As for your second thread, it would best fit here; stat tracking is officially part of OXC as Warboy and SupSuper maintain it, but the commendations is still my mod. I have some commendations source code in the base game, but that's because I am their favourite modder (I don't need my own subforum!). So yeah, Mind Control commendations were some of the last ones added, so they got the least amount of testing. The main profile screen uses vanilla XCOM code to track kills, I decided not to touch that in an effort to minimize code impact; vanilla XCOM did not give you kills for MC kills, it seems. I do though; they are tracked as slaveKills or something. Killing an MC with an MC is untested; I didn't think of that. When you say "mission screen", do you mean the little popup that reads time of day, alien race, etc; or do you mean the debriefing screen at the end of a mission? If it's the latter, that's vanilla code. If it's the former, then I am surprised that it's in one part but not another. I will add it to my list of things todo!

By design, it's only the profile screen that has vanilla code, and will be different from the rest of the diary. However, come to think of it, since the stat tracking is now 'official', I suppose the three place should indeed be consistent. I am going to add myself a note to fix that too. **

You're covering a lot of corner cases with MC kills, so I am not sure how my "last to hit an alien gets the kill credit" and "I am an MC slave and I killed myself" interact with eachother. Does the MCer get the kill, the last soldier that happened to hit the MCd? This also seems related to your bug. The two systems might be conflicting with eachother.

Regarding neutralizations, I forget if I ever built in an anti abuse system, where stunning an alien repeatedly gave you more stun awards or not... I think I have systems in place now that can prevent that, but I am not sure if I wrote code to make the two interact. I did not spend much time making sure the commendations could not be cheesed, so this may be a result of that.

But yeah, I appreciate the attention you're giving this! I always enjoy talking about this mod :3 some day I will come back to it and tinker some more.

** edit: I reread what you were saying, and the mission popup only lists the total kills for that mission; it won't list the total kills over the soldier's career. I will still look into it to see if it's somehow overlooking certain kill types.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Tiagofvarela on March 17, 2016, 11:59:34 pm
I am confused about this. Supposedly, this is included with the Milestone download  (https://i.imgur.com/y2pwnie.png?1)itself, but I certainly cannot seem to find it (https://i.imgur.com/RPI4O0f.png?1) or enable it (https://i.imgur.com/A7YFVwF.png?1). What am I missing?
Thank you in advance for any help!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on March 18, 2016, 12:08:00 am
I am confused about this. Supposedly, this is included with the Milestone download  (https://i.imgur.com/y2pwnie.png?1)itself, but I certainly cannot seem to find it (https://i.imgur.com/RPI4O0f.png?1) or enable it (https://i.imgur.com/A7YFVwF.png?1). What am I missing?
Thank you in advance for any help!


Unfortunately it is not in the Milestone.  It is included in the Nightlies. 
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Tiagofvarela on March 18, 2016, 12:43:48 am
Unfortunately it is not in the Milestone.  It is included in the Nightlies.
It seems I was mistaken, then. I wonder where I got the idea from...
Thank you!
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: BetterBite on March 24, 2016, 10:53:48 pm
I really can't get this to work. I followed the read me instructions and nope it crashes when I create a new game or load one. I need some help

(P.S. I had problems accesing forums so there is a comment on the mod page)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on March 24, 2016, 11:47:58 pm
I really can't get this to work. I followed the read me instructions and nope it crashes when I create a new game or load one. I need some help

(P.S. I had problems accesing forums so there is a comment on the mod page)

Do you have any other mods installed? Do you have the commendations ruleset? Is it in the right place?

The only issue is that the game auto-crashes when you start a new game or load one? So, at the geoscape, and not at the battlescape?

I assume it's a simple issue :)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: BetterBite on March 26, 2016, 03:32:01 pm
This was the first mod I wanted to install. The commendations ruleset is in the ruleset folder with the imagery and stuff. The game crashes as soon as the difficulty is choosen and start is clicked. It doesnt even go on the geoscape.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on March 26, 2016, 06:40:52 pm
That is very odd. Have you tried playing without the mod active? Are you using the latest nightly? There is one commendation that is given to the original 8 soldiers, I think it's called "First to serve" or something. Maybe if you removed that from the ruleset, that would help?

In any case, if you're itching to play, you can play without the mod enabled until whatever is wrong fixes itself. Once you turn the mod on, after your first mission or end of month, all the commendations will be awarded as if you had the mod on the whole time. You won't have to worry about "missing out" on anything.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: BetterBite on March 26, 2016, 06:42:36 pm
It might be because im not using the steam version.
I didnt pirate the game just using a diffirent LEGAL version
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on March 26, 2016, 07:26:05 pm
Are you able to run the game with the mod off? The assets should be the same from any source. Maybe you're missing a patch or something?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: BetterBite on March 26, 2016, 11:30:05 pm
I did a reset on my PC due to another problem.
Meaning everything is fresh and new.
Theres 1 thing I dont quite understand.
Since the Mod comes with the looks of being a diffirent OpenXcom
What I did
Move All .dll's and .exe of Open Xcom folder into a backup.
Move the Latest 1.0 legacy into the empty OpenXcom Folder.
Thats basicly how I did it and how it crashed
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: ivandogovich on March 26, 2016, 11:51:34 pm
You will need to install a Nightly Version for this to work.  I'm not sure, but it sounds a bit like you just have the 1.0 Milestone version from 2014.

https://openxcom.org/git-builds/
https://www.ufopaedia.org/index.php?title=Installation_FAQ_(OpenXcom)
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Countdown on March 27, 2016, 11:47:41 am
@Shoes: Thank you for the detailed response to my post(s). I've been having a TON of fun using the commendations mod, so I hope my posts didn't come across as complaining, just trying to help fix the issues I came across.

As others have said (thanks guys!), "Improvisation" is the logic not knowing what happened. You can modify the string in your files to read something more appropriate; I was being a little cheeky when I decided on that term!
Personally I think "improvisation" is the perfect word for it. If blowing up a cyberdisc to kill the two sectoids standing nearby isn't "improvisation" I don't know what is! ;D

Regarding cause of death: I think that's only used in the 'fallen soldiers' screen after missions. Come to think of it, it should probably show up in the memorial screen too.
This would be a cool addition to the memorial screen.

I have an old running list of bugs and things I want to look at here : https://gist.github.com/Shoes01/3af40f402d287ae9c229. I have myself the note "MAJOR BUG: The last entry in a the kill "and" criteria is the only one being looked at." pinned as the bug responsible for commendations like Mercy Cross and Taking Names being awarded incorrectly. It's a public gist, so feel free to add comments below about other things I need to look at; it's much cleaner than skimming through discussions in this thread :)
Very good, if I come across something you don't have I'll add a comment. Looks like you are already aware of most of what I've found and you also have some cool ideas in there. I'd be happy to help if you need any, but my C++ knowledge is next to nil (I only know PHP). I'm getting pretty good at tinkering with the rulesets and save files though. ::)

Mind Control commendations were some of the last ones added, so they got the least amount of testing. The main profile screen uses vanilla XCOM code to track kills, I decided not to touch that in an effort to minimize code impact; vanilla XCOM did not give you kills for MC kills, it seems. I do though; they are tracked as slaveKills or something. Killing an MC with an MC is untested; I didn't think of that. When you say "mission screen", do you mean the little popup that reads time of day, alien race, etc; or do you mean the debriefing screen at the end of a mission? If it's the latter, that's vanilla code. If it's the former, then I am surprised that it's in one part but not another. I will add it to my list of things todo!

** edit: I reread what you were saying, and the mission popup only lists the total kills for that mission; it won't list the total kills over the soldier's career. I will still look into it to see if it's somehow overlooking certain kill types.
Yes, I meant the "little popup that reads time of day, etc". The little mission popup will count a kill if you MCed an alien to kill another MCed alien. But those kills will NOT count on the overall career kills at the bottom in the "combat" section. In the save file I attached the only soldier with kills has "1 kill" in the combat section, even though his mission pop-up has 5 kills and it shows he neutralized (in this case killed) several with a plasma rifle.

Hope that made sense.

By design, it's only the profile screen that has vanilla code, and will be different from the rest of the diary. However, come to think of it, since the stat tracking is now 'official', I suppose the three place should indeed be consistent. I am going to add myself a note to fix that too. **
This is understandable since the profile screen is vanilla code. I agree though that since stat tracking is now "official" they should be consistent.

You're covering a lot of corner cases with MC kills, so I am not sure how my "last to hit an alien gets the kill credit" and "I am an MC slave and I killed myself" interact with eachother. Does the MCer get the kill, the last soldier that happened to hit the MCd? This also seems related to your bug. The two systems might be conflicting with eachother.
Yeah it's confusing. In my case it was weird that the bug only happened with one soldier where as the rest got proper credit. If it was a "last to hit an alien" issue, you'd think it'd affect all soldiers. Now that I've started to become familiar with how this data is tracked in the save files, I'll play around with it and see if I can determine exactly where it's going wrong. You are right that these are pretty rare cases, so not worth losing a lot of sleep over.


Thanks again for all your work.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on March 28, 2016, 02:34:21 am
I am happy you're enjoying it! I always like talking about it :3

I chatted up the devs and they're fine with the kill counts being different in the soldier info screen and in the diary. You could think of it as "direct kills" in the info screen, and "in/direct kills" in the diary. I'll have to make sure the mini mission info screen and the diary kill count talk to each other though.

edit: I've taken a closer look at how kills are awarded regarding mind controls. The way I figured out who MC'd who had a fault: I looked at who "shot" the alien last. If you MC an alien, and then he gets shot, I no longer know who controlled the alien. I am going to fix that! Regarding the mission info screen being different: they shouldn't really be... I don't directly save how many kills were done on a mission, so the mission info screen has to recount it. It looks at how many aliens are STATUS_DEAD, however, that's also how the soldier kill total at the bottom of the diary screen is calculated too. So if they're not the same, that's gonna be tricky!

edit2: I took a look at the weird bug you saw, and have found the probable cause. I don't "care" if units MC or stun an alien repeatedly, I count the first one and I am done. So if A mcs X, then B mcs X, then A mcs again again, B is still the mcer because I stopped caring about A. If that makes sense ;p I will have to delete the entries and add the 'latest' ones instead.

edit3: PR has been sent. https://github.com/SupSuper/OpenXcom/pull/1089
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Countdown on March 31, 2016, 06:13:03 pm
I chatted up the devs and they're fine with the kill counts being different in the soldier info screen and in the diary. You could think of it as "direct kills" in the info screen, and "in/direct kills" in the diary. I'll have to make sure the mini mission info screen and the diary kill count talk to each other though.
Sounds good and yeah, that makes sense. I was thinking about it after posting and thought changing the soldier info screen kills to include MC kills might be getting too far away from vanilla since the original never counted MC kills. I like the "direct" vs "indirect" thought process.

edit: I've taken a closer look at how kills are awarded regarding mind controls. The way I figured out who MC'd who had a fault: I looked at who "shot" the alien last. If you MC an alien, and then he gets shot, I no longer know who controlled the alien. I am going to fix that!

edit2: I took a look at the weird bug you saw, and have found the probable cause. I don't "care" if units MC or stun an alien repeatedly, I count the first one and I am done. So if A mcs X, then B mcs X, then A mcs again again, B is still the mcer because I stopped caring about A. If that makes sense ;p I will have to delete the entries and add the 'latest' ones instead.

edit3: PR has been sent. https://github.com/SupSuper/OpenXcom/pull/1089
Thanks for figuring all that out. When I did my original playing with it I wasn't using the commendations mod, but once I started using commendations the MC issue became more apparent/easier to understand as soldiers who had never even used a psi amp were getting "master of puppets" because they would kill an alien who was under XCOM control (and that alien had just thrown a grenade at a non-MCed alien). So they would essentially get credit for another soldier's MC kill. I've actually enjoyed going through the save files and figuring out how all this was calculated.

Regarding the mission info screen being different: they shouldn't really be... I don't directly save how many kills were done on a mission, so the mission info screen has to recount it. It looks at how many aliens are STATUS_DEAD, however, that's also how the soldier kill total at the bottom of the diary screen is calculated too. So if they're not the same, that's gonna be tricky!
I'm not sure based on the above, but are you saying you did or didn't figure this part out?

Looking at the save files, I'm pretty sure actually the kill total in the diary on the bottom is directly saved as "killTotal" in the save files, while the mission pop ups are recounted live as you describe above. So the problem is occurring in-mission when the kill isn't assigned to the soldier who say, had their MCed alien commit suicide with a grenade. Normally when a soldier gets a kill, the in-mission save file counts it as one "kill" and then adds it to their diary total at mission's end. But when you kill an MCed alien (or have one commit suicide) the kill is listed (weapon, alien race, etc) but it isn't added to their in-mission kill count. That causes the discrepancy. If you're PR above fixes that then, the discrepancy issue will be solved.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Xeno Wiper on April 02, 2016, 01:12:16 am

edit2: I took a look at the weird bug you saw, and have found the probable cause. I don't "care" if units MC or stun an alien repeatedly, I count the first one and I am done. So if A mcs X, then B mcs X, then A mcs again again, B is still the mcer because I stopped caring about A. If that makes sense ;p I will have to delete the entries and add the 'latest' ones instead.


Sry, but that didn't make sense at all. Idk why haven't you gone with the latest ones from the beginning.

Last time I saw, you can't MC again an already MCed alien on the same turn with different people. So why not go with the latest?
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Shoes on April 02, 2016, 03:00:19 pm
Sry, but that didn't make sense at all. Idk why haven't you gone with the latest ones from the beginning.

Last time I saw, you can't MC again an already MCed alien on the same turn with different people. So why not go with the latest?

I meant after the MC wears off. So that's why I've fixed; the last person to MC gets credit (regardless if they've MCd them before, which was the bug).

I'm not sure based on the above, but are you saying you did or didn't figure this part out?

Looking at the save files, I'm pretty sure actually the kill total in the diary on the bottom is directly saved as "killTotal" in the save files, while the mission pop ups are recounted live as you describe above. So the problem is occurring in-mission when the kill isn't assigned to the soldier who say, had their MCed alien commit suicide with a grenade. Normally when a soldier gets a kill, the in-mission save file counts it as one "kill" and then adds it to their diary total at mission's end. But when you kill an MCed alien (or have one commit suicide) the kill is listed (weapon, alien race, etc) but it isn't added to their in-mission kill count. That causes the discrepancy. If you're PR above fixes that then, the discrepancy issue will be solved.

If it's not added to the list, then it shouldn't be showing up in either total. I am starting to reorganize how I save stuff to reduce save bloat, so that might touch on this bug.

If it's really not being added to the list, then that's a bug too.
Title: Re: [STAT TRACKING] Soldier Diaries 1.0
Post by: Countdown on April 03, 2016, 09:21:35 am
Shoes,

Kudos on fixing that MC bug. I re-loaded my bug test saves and everything seems to work correctly. No misappropriated MC kills or MC medals. Well done.

I also really like the addition of the arrow buttons to go from mission to mission in a soldier’s diary. Very convenient. And the accuracy stat should be a fun thing to track as well.

If it's not added to the list, then it shouldn't be showing up in either total. I am starting to reorganize how I save stuff to reduce save bloat, so that might touch on this bug.

If it's really not being added to the list, then that's a bug too.

As you said, this was a separate bug not corrected by your latest fix. The mission lists are fine, it’s simply a numerical error. Since I don’t think I’ve done a good job explaining what happens, I think it’s easier just to show you. See the save file code and screen shots below. I had two soldiers get a kill demonstrating the bug and then a standard kill to show the difference.

Soldier 3 MCed a Floater and had it kill itself with a grenade.

Post-Mission Save File (my comments in #RED):
     
      - type: STR_SOLDIER
        name: 3
        diary:
          killList:
            - weapon: STR_PSI_AMP #MC
              rank: STR_LIVE_SOLDIER
              type: STR_FLOATER_SOLDIER
              race: STR_FLOATER
            &nb