OpenXcom Forum

OpenXcom => Suggestions => Topic started by: CanadianBeaver on August 25, 2016, 06:40:42 pm

Title: Combine clips after combats.
Post by: CanadianBeaver on August 25, 2016, 06:40:42 pm
Let's imagine following situation. During combat, 3 soldiers have same weapon and ammunition. First soldier shooted 10 bullets, Second 12, Last - 8. Standard clip capacity is 20 bullets. Remaining bullets in the soldier's weapon are 10, 8 and 12.

Current game behavior: all will disappear. Where will 10+8+12 bullets are?

Proposed game behavior: let the game combine remained bullets and keep 1 clips - 10+8+12 = 30 bullets = 1 full clip.
Also, not every clips can be combined. For example, the plasma accumulators cannot be combined with each other. I thing it can be controlled by new boolean value in the items definition (https://www.ufopaedia.org/index.php/Ruleset_Reference_(OpenXcom)#Items).
Title: Re: Combine clips after combats.
Post by: Meridian on August 25, 2016, 06:45:16 pm
Clips do combine after combat.
Only the last "incomplete" clip will be lost, not all.

See here: https://github.com/SupSuper/OpenXcom/blob/master/src/Battlescape/DebriefingState.cpp#L1420
And here: https://github.com/SupSuper/OpenXcom/blob/master/src/Battlescape/DebriefingState.cpp#L1168

I assume you are not using the latest version of OpenXcom.
In 1.0 this was (most probably) not implemented yet.
Title: Re: Combine clips after combats.
Post by: CanadianBeaver on August 25, 2016, 06:53:16 pm
Clips do combine after combat.
Only the last "incomplete" clip will be lost, not all.

See here: https://github.com/SupSuper/OpenXcom/blob/master/src/Battlescape/DebriefingState.cpp#L1420
And here: https://github.com/SupSuper/OpenXcom/blob/master/src/Battlescape/DebriefingState.cpp#L1168

I assume you are not using the latest version of OpenXcom.
In 1.0 this was (most probably) not implemented yet.

Yes, I am speaking about 1.0. If it has been done in nightly - perfect. What about accumulators that cannot be combine (incomplete)?
Title: Re: Combine clips after combats.
Post by: Meridian on August 25, 2016, 06:55:35 pm
What about accumulators that cannot be combine (incomplete)?

That was not implemented (yet).
It wouldn't be hard to do.