STR_YOU_WILL_NEED_TO_RESEARCH_A
STR_XCOM_BASES
STR_BUILD_NEW_BASE
STR_START_PROJECT
STR_UNITS_TO
STR_PRODUCE
As a side note, I think this is the screen in which STR_START_PROJECT would be used instead of the OK button.
@@ -166,21 +166,22 @@ void ResearchInfoState::buildUi ()
_timerMore->onTimer((StateHandler)&ResearchInfoState::more);
_timerLess = new Timer(250);
_timerLess->onTimer((StateHandler)&ResearchInfoState::less);
_btnOk->setColor(Palette::blockOffset(13)+10);
- _btnOk->setText(tr("STR_OK"));
_btnOk->onMouseClick((ActionHandler)&ResearchInfoState::btnOkClick);
_btnOk->onKeyboardPress((ActionHandler)&ResearchInfoState::btnOkClick, (SDLKey)Options::getInt("keyOk"));
_btnCancel->setColor(Palette::blockOffset(13)+10);
if (_rule)
{
+ _btnOk->setText(tr("STR_START_PROJECT"));
_btnCancel->setText(tr("STR_CANCEL"));
_btnCancel->onKeyboardPress((ActionHandler)&ResearchInfoState::btnCancelClick, (SDLKey)Options::getInt("keyCancel"));
}
else
{
+ _btnOk->setText(tr("STR_OK"));
_btnCancel->setText(tr("STR_CANCEL_PROJECT"));
_btnOk->onKeyboardPress((ActionHandler)&ResearchInfoState::btnOkClick, (SDLKey)Options::getInt("keyCancel"));
}
_btnCancel->onMouseClick((ActionHandler)&ResearchInfoState::btnCancelClick);
}
So I started checking where the strings are used, and I have some questions.A lot of strings are unused, either because they are remains of dropped features in the original (like STR_YOU_WILL_NEED_TO_RESEARCH_A) or because OpenXcom has made them obsolete (STR_START_PROJECT was used in a research confirmation screen which became redudant since you can just cancel projects now). Eventually I'll have to go through it and clean it up.
1. There are some strings that I could not find where are they used:Code: [Select]STR_YOU_WILL_NEED_TO_RESEARCH_A
STR_XCOM_BASES
STR_BUILD_NEW_BASE
STR_START_PROJECT
STR_UNITS_TO
STR_PRODUCE
STR_UNITS_TO and STR_PRODUCE appear to be meant to be used in the manufacture item screen, but there is a string already being used here, i.e. STR_TOTAL_TO_PRODUCE.However you are correct about this mistake, I'll be sure to fix it in the string revision.
2. Everywhere into the game xcom is written as XCom, but the string STR_XCOM, displayed at the start of the turn, is written as Xcom.Trying to find consistency in X-Com is a fool's errand. :P Developers aren't designers or even writers, which becomes immediately apparent. I'll make a note of #2 though.
3. There are some inconsistencies regarding color of some screens:
I know that the project wants to be like the original, so it's no biggie, just some observations. I will continue checking the strings and where are they used, and I will post the table when it's finished, to make te job easy for translators.I've considered making a reference list for translators (after all I already have screenshots of every single X-Com screen), it's just a pain to manually hook it up to GetLocalization. I might just post the screenshots in your thread or something to help people out.
not when researching are in progress, "OK" here is more suitableNot a bad idea, though both strings would have to be uppercase then.
edit
https://github.com/SupSuper/OpenXcom/blob/5afe0b7106faceb100f0cbfa118970503e4914f6/src/Basescape/ResearchInfoState.cpp#L171Code: [Select]@@ -166,21 +166,22 @@ void ResearchInfoState::buildUi ()
_timerMore->onTimer((StateHandler)&ResearchInfoState::more);
_timerLess = new Timer(250);
_timerLess->onTimer((StateHandler)&ResearchInfoState::less);
_btnOk->setColor(Palette::blockOffset(13)+10);
- _btnOk->setText(tr("STR_OK"));
_btnOk->onMouseClick((ActionHandler)&ResearchInfoState::btnOkClick);
_btnOk->onKeyboardPress((ActionHandler)&ResearchInfoState::btnOkClick, (SDLKey)Options::getInt("keyOk"));
_btnCancel->setColor(Palette::blockOffset(13)+10);
if (_rule)
{
+ _btnOk->setText(tr("STR_START_PROJECT"));
_btnCancel->setText(tr("STR_CANCEL"));
_btnCancel->onKeyboardPress((ActionHandler)&ResearchInfoState::btnCancelClick, (SDLKey)Options::getInt("keyCancel"));
}
else
{
+ _btnOk->setText(tr("STR_OK"));
_btnCancel->setText(tr("STR_CANCEL_PROJECT"));
_btnOk->onKeyboardPress((ActionHandler)&ResearchInfoState::btnOkClick, (SDLKey)Options::getInt("keyCancel"));
}
_btnCancel->onMouseClick((ActionHandler)&ResearchInfoState::btnCancelClick);
}