OpenXcom Forum

OpenXcom Forks => OXCE Support => OpenXcom Extended (OXCE) => OXCE Support Y-scripts => Topic started by: Aldorn on March 31, 2025, 09:22:26 pm

Title: [SOLVED] Y-scripts modifying stats and causing stat display issues
Post by: Aldorn on March 31, 2025, 09:22:26 pm

Hi all,

I have a display issue due to soldierBonuses

It's not a big issue, as I can play with it, it is just "cosmetic"

This is about the progression bar, whose extremity does not include bonuses, as shown in the attached JPG

Here is the corresponding code

Code: [Select]

soldierBonuses:
  - name: STR_SB_MEDAL_ALIENS_KILLED1
    stats:
      stamina: 1
  - name: STR_SB_MEDAL_ALIENS_KILLED2
    stats:
      stamina: 2
  - name: STR_SB_MEDAL_ALIENS_KILLED3
    stats:
      stamina: 3
  - name: STR_SB_MEDAL_ALIENS_KILLED4
    stats:
      stamina: 4

I tried that, without success

Code: [Select]

soldierBonuses:
  - name: STR_SB_MEDAL_ALIENS_KILLED1
    stats:
      stamina: 1
    statCaps:
      stamina: 1

Does anyone have any idea how to fix this?

Title: Re: [Support requested] Y-scripts modifying stats and causing stat display issues
Post by: Aldorn on March 31, 2025, 10:08:36 pm

Apparently Meridian noticed the same issue here
https://openxcom.org/forum/index.php?topic=7405.msg116841#msg116841
But I can't find any fix in the thread

Title: Re: [Support requested] Y-scripts modifying stats and causing stat display issues
Post by: Juku121 on March 31, 2025, 10:36:31 pm

But your stamina bar actually is a little bit over the cap, as the bonus indicates? What happens if you  make the value into 99, like in Meridian's example? Should shoot to the right like a battering ram and leave your 'natural maximum bar' behind.

Title: Re: [Support requested] Y-scripts modifying stats and causing stat display issues
Post by: Aldorn on March 31, 2025, 11:01:37 pm

Quote from: Juku121 on March 31, 2025, 10:36:31 pm

But your stamina bar actually is a little bit over the cap, as the bonus indicates? What happens if you  make the value into 99, like in Meridian's example? Should shoot to the right like a battering ram and leave your 'natural maximum bar' behind.

Good idea

Let me first switch to english :P

Then, I replaced small bonuses with 99, now it's more obvious

I don't understand in Meridian's thread if this is an issue and if it has been solved, or if it's just expected.


I asked Chat GPT: OMG  :o he knows a lot about OpenXcom and modding  ;D
He made some misunderstanding between soldierBonuses, soldierTransformations and commendations, but he proposed several solutions that could have worked

Title: Re: [Support requested] Y-scripts modifying stats and causing stat display issues
Post by: Juku121 on March 31, 2025, 11:07:19 pm

What precisely is your issue here? This is how the stat bar works: initial value, trained value, 'cap', then overflow from armours and bonuses.

Title: Re: [Support requested] Y-scripts modifying stats and causing stat display issues
Post by: Aldorn on March 31, 2025, 11:08:49 pm

Quote from: Juku121 on March 31, 2025, 11:07:19 pm

What precisely is your issue here? This is how the stat bar works: initial value, trained value, 'cap', then overflow from armours and bonuses.

Ok, so if armours and bonuses are considered as an overflow, that explains

I wanted just these bonuses to be included in the light part, but not overflowing (from a cosmetic point of view: my cosmetic point of view ;))
Cf. attached image for Strength as an example

So thank you very much Juku121

I close this thread