OpenXcom Forum

OpenXcom Forks => OXCE Bugs => OpenXcom Extended (OXCE) => OXCE Bugs FIXED => Topic started by: zRrr on November 04, 2024, 07:00:02 pm

Title: [FIXED] Armor button uses same element id as Ok button in InventoryState
Post by: zRrr on November 04, 2024, 07:00:02 pm

In Battlescape/InventoryState.cpp (https://github.com/MeridianOXC/OpenXcom/blob/0f8616d8339b2d842932a9127616a6dffecb2f91/src/Battlescape/InventoryState.cpp#L150) _btnArmor uses same element id as _btnOk, so when I move Ok button with ruleset like

Code: [Select]

interfaces:
  - type: inventory
    elements:
      - id: buttonOK
        pos: [213, 1]
armor selection also moves.

Title: Re: Armor button uses same element id as Ok button in InventoryState
Post by: Meridian on November 04, 2024, 07:48:44 pm

Many buttons on many GUIs in OXC and OXCE share the same interface element.
We're lazy to create a new interface element for each button.

Title: Re: [FIXED] Armor button uses same element id as Ok button in InventoryState
Post by: Meridian on December 29, 2024, 04:43:26 pm

Fixed here: https://github.com/MeridianOXC/OpenXcom/commit/0af3490793ffedf4fb36fdc03e9fd99ac4c16a1c

Title: Re: [FIXED] Armor button uses same element id as Ok button in InventoryState
Post by: zRrr on December 31, 2024, 08:03:03 pm

Thanks

No more starting missions unprepared because I accidentally clicked Ok. Now only starting missions unprepared because I deliberately clicked Ok :)