OpenXcom Forum

OpenXcom Forks => OpenXcom Extended (OXCE) => OXCE Suggestions DONE => Topic started by: MIK517 on June 23, 2024, 03:57:39 pm

Title: [DONE][Suggestion] Consistent implementation of 'disables' and 'reenables' for research
Post by: MIK517 on June 23, 2024, 03:57:39 pm

Zero cost research that auto-researched when all the required researches are completed will apply its 'disabled' references, but won't apply its 'reenables'.
Those are only working for projects that are directly completed through lab/one-free/event etc.

After checking sources (SavedGame::addFinishedResearch) I'm not sure if this logic is intentional or not, since 'reenables' were added when loop with 'disables' for zero-cost projects existed, so there may be some reason why they were added outside of that loop.
Still I think this either should be fixed (with 'reenables' also preferably going after 'disables' to allow simpler repeatable projects) or difference between two properties should be documented on Wiki's Ruleset Reference to prevent confusion.

Title: Re: [bug?] Inconsistent implementation of 'disables' and 'reenables' for research
Post by: Meridian on August 25, 2024, 02:56:06 pm

Original discussion is lost.
All we have is the commit: https://github.com/MeridianOXC/OpenXcom/commit/e5e7f2f7bfab12f892dea09925a901fade1884c1

I don't have any strong opinion on this.
I can allow 'reenables' also on zero cost research.
(thread moved to Suggestions)

PS: even after the change, there will still be differences between 'disables' and 'reenables', e.g. 'disables' is only applied once (when a topic is researched first time), but 'reenables' will apply each time (when a topic is researched also for the 42nd time, let's say a 42nd interrogation of a Sectoid Commander :) )

Title: Re: [Suggestion] Consistent implementation of 'disables' and 'reenables' for research
Post by: Meridian on August 25, 2024, 03:37:40 pm

Test ruleset:

Code: [Select]

research:
  - name: STR_MEDI_KIT
    cost: 210
    points: 20
    disables: [STR_MOTION_SCANNER]

  - name: STR_LEADER_PLUS
    reenables: [STR_MOTION_SCANNER]
    requires:
      - STR_ALIEN_ORIGINS
    dependencies:
      - STR_SECTOID_COMMANDER
      - STR_SECTOID_LEADER


Title: Re: [DONE][Suggestion] Consistent implementation of 'disables' and 'reenables' for research
Post by: Meridian on August 25, 2024, 05:58:54 pm

Done.

https://github.com/MeridianOXC/OpenXcom/commit/2bbd83c00290150c9771e3d33647318be69d4357

Title: Re: [DONE][Suggestion] Consistent implementation of 'disables' and 'reenables' for research
Post by: MIK517 on August 27, 2024, 07:57:06 pm

Thank you.

Yeah, I hadn't thought about disables on already completed topics that give one free.
But now if that logic (reapplying 'disables' after each research) is needed it can instead be achieved by moving those disables to zero-cost topic in 'unlocks' that has (already researched) 'requires' (to get `checkRelatedZeroCostTopics`) and immediately resets itself each time. Even it that sounds like quite a dirty hack.