OpenXcom Forum

OpenXcom Forks => OXCE Bugs => OpenXcom Extended (OXCE) => OXCE Bugs FIXED => Topic started by: Dioxine on May 27, 2024, 05:12:16 am

Title: [Cannot reproduce] Kills awarded for no kills - Bug or feature?
Post by: Dioxine on May 27, 2024, 05:12:16 am
I get commendations for killing enemies (eg. kill X per turn) even if I don't kill enemies immediately but also if they bleed out later. Was this intended? If so, how can I have the previous behaviour?
Title: Re: Kills awarded for no kills - Bug or feature?
Post by: Delian on May 27, 2024, 12:21:17 pm
Can you attach a save file where you're erroneously awarded the "kill X per turn" commendation?

Normally (standard OXC behavior which afaik never changed), when an enemy bleeds out, the last unit that did HP damage to this enemy gets the kill and this kill is counted on the turn the enemy dies, not earlier.
Title: Re: Kills awarded for no kills - Bug or feature?
Post by: Dioxine on May 27, 2024, 07:03:22 pm
Sadly I don't have a save, and my saves would be incompatible with any published XPZ version anyway as I play on my current WIP build. But I see it happening a lot, and it would be easy to replicate. I specifically mean 'X kills per turn' commendations, which previously definitely did not grant the title if the enemies didn't die during your turn. It is fine and expected that other commendations count the kill during the enemy turn as well (eg. condemnations for reaction kills etc)
Title: Re: Kills awarded for no kills - Bug or feature?
Post by: Delian on May 27, 2024, 08:15:09 pm
Commendations with killsWithCriteriaTurn could always be awarded on any turn, yours or enemies. If you killed two enemies with reaction fire, the Ice-Cold Killer commendation would get awarded (you can download an old XPZ version and try it if you don't believe me). Something else must be the problem.

The save doesn't need to be compatible; we can manually edit it and make it compatible with any game version. Optimally, it should be right at the end of a mission, where the player only needs to press End Turn to finish.
Title: Re: Kills awarded for no kills - Bug or feature?
Post by: Yankes on May 28, 2024, 06:13:56 pm
What version had this previous behavior? Can you confirm its behave diffrent?
Title: Re: Kills awarded for no kills - Bug or feature?
Post by: Meridian on August 25, 2024, 08:16:42 pm
I get commendations for killing enemies (eg. kill X per turn) even if I don't kill enemies immediately but also if they bleed out later. Was this intended? If so, how can I have the previous behaviour?

I tested today and it seems to be working the way you want.

When I kill two enemies, I get "ice cold killer".

Code: [Select]
        diary:
          commendations:
            - {commendationName: STR_MEDAL_ORIGINAL8_NAME, noun: NoNoun, decorationLevel: 0}
            - {commendationName: STR_MEDAL_DBLKILL_NAME, decorationLevel: 0}
            - {commendationName: STR_MEDAL_MURDERER_NAME, decorationLevel: 0}
          killList:
            - {type: STR_ACADEMY_NURSE, rank: STR_LIVE_SOLDIER, race: STR_SECTOID, weapon: STR_SHORT_SWORD, weaponAmmo: STR_SHORT_SWORD, status: 6, faction: 1, mission: 0, turn: 3, side: 1, bodypart: 3, id: 1000004}
            - {type: STR_ACADEMY_NURSE, rank: STR_LIVE_SOLDIER, race: STR_SECTOID, weapon: STR_SHORT_SWORD, weaponAmmo: STR_SHORT_SWORD, status: 6, faction: 1, mission: 0, turn: 3, side: 0, bodypart: 1, id: 1000002}

When I kill one enemy, hurt the second enemy and let it bleed, I don't get "ice cold killer".

Code: [Select]
        diary:
          commendations:
            - {commendationName: STR_MEDAL_ORIGINAL8_NAME, noun: NoNoun, decorationLevel: 0}
            - {commendationName: STR_MEDAL_MURDERER_NAME, decorationLevel: 0}
          killList:
            - {type: STR_ACADEMY_NURSE, rank: STR_LIVE_SOLDIER, race: STR_SECTOID, weapon: STR_SHIV, weaponAmmo: STR_SHIV, status: 6, faction: 1, mission: 0, turn: 3, side: 3, bodypart: 1, id: 1000004}
            - {type: STR_ACADEMY_NURSE, rank: STR_LIVE_SOLDIER, race: STR_SECTOID, weapon: STR_SHIV, weaponAmmo: STR_SHIV, status: 6, faction: 1, mission: 0, turn: 4, side: 1, bodypart: 3, id: 1000003}

You can see the "turn" being different too in the diary.
Turn 3 = first game turn, player side
Turn 4 = first game turn, enemy side

"turn" is calculated as: game_turn * 3 + game_side
where game_side is: 0 = player, 1 = enemy, 2 = civilian



Attached is a save with a mission, where I already killed one enemy and the second is about to bleed out.
Feel free to use for testing.


PS: I believe you that it may work differently for you, but I will need a save to say more.
Even a save after the mission is actually OK (we can reconstruct the commendation awarding from the diary)
Title: Re: Kills awarded for no kills - Bug or feature?
Post by: Dioxine on August 27, 2024, 01:09:59 pm
Thank you, this proves I was wrong. I have no idea what was happening back then and why this behaviour occured (or why I was convinced it did).