OpenXcom Forum

OpenXcom Forks => OXCE Bugs => OpenXcom Extended (OXCE) => OXCE Bugs FIXED => Topic started by: psavola on January 01, 2024, 08:39:56 pm

Title: [FIXED][Bug] Needed item coloring issue
Post by: psavola on January 01, 2024, 08:39:56 pm
Another change or regression in the screenshot. Previously an unresearched topic would show up in 'ITEM DESTROYED' as pink-ish. Now everything is in white, whether new or already researched. With this change there is no longer (AFAIK) a handy way to check if you have already researched the items recovered from a mission (depending a bit on how what the research gives you is structured - at least those ones that don't open up any new researches but give you a few points).
Title: Re: [Bug] Needed item coloring issue
Post by: Meridian on January 01, 2024, 08:56:26 pm
This is because of this change: https://openxcom.org/forum/index.php/topic,8653.0.html

Now the "item destroyed" / "item needed" don't need to correspond to any research topic... and thus I cannot determine whether they are researched or not.
Title: Re: [Bug] Needed item coloring issue
Post by: psavola on January 01, 2024, 09:13:27 pm
This is because of this change: https://openxcom.org/forum/index.php/topic,8653.0.html

Now the "item destroyed" / "item needed" don't need to correspond to any research topic... and thus I cannot determine whether they are researched or not.

Ok, thanks for the explanation.
Title: Re: [Bug] Needed item coloring issue
Post by: Meridian on January 02, 2024, 02:53:48 pm
I tried to improve it a bit:

1. if the item has a corresponding (= same name) research topic, it is shown grey, pink or purple (based on research status: disabled/researched/not researched)

2. if the item doesn't have a corresponding topic (e.g. sectoid soldier / smoke grenade example below), it will be shown as pink

3. if the item doesn't exist at all (e.g. Sectoid example below), it is shown as white "-"

https://github.com/MeridianOXC/OpenXcom/commit/5114ce520900e3b0febfe7e0ec3830c48b0d87e7