OpenXcom Forum

OpenXcom Forks => OpenXcom Extended (OXCE) => OXCE Suggestions DONE => Topic started by: Nord on October 13, 2023, 06:19:35 pm

Title: [DONE][Suggestion] Option to override item used for self destruct
Post by: Nord on October 13, 2023, 06:19:35 pm

Looks like "specab" does not work, if unit's armor have not only "corpseBattle" but "corpseGeo" too, and geoscape corpse item have no "power".
I can add power to geo corpse, but it will make different units explode with the same strength, and this is not good.

Title: Re: specab and corpseGeo
Post by: Yankes on October 13, 2023, 06:59:37 pm

OXC use globe corpse, because of this OXCE behave same, I would like to change it but this could break some mods.

Code: [Select]

if (_attack.attacker)
{
itemRule = _attack.attacker->getArmor()->getCorpseGeoscape(); //TODO: not getCorpseBattlescape ones?
_power = itemRule->getPowerBonus(_attack);
_damageType = itemRule->getDamageType();
_radius = itemRule->getExplosionRadius(_attack);
if (!RNG::percent(itemRule->getSpecialChance()))
{
_power = 0;
}
}

Probably without consensus of all major modders it can't be changed.

Title: Re: [DONE][Suggestion] Option to override item used for self destruct
Post by: Meridian on December 09, 2023, 10:22:29 am

Done: https://github.com/MeridianOXC/OpenXcom/commit/d13c4bebe6a825a78bbee52e0b5445a2192070d0

There is a new attribute `selfDestructItem` on the armor, which is used instead of `corpseGeo`.
(corpseGeo still works if selfDestructItem is not specified)