OpenXcom Forum

OpenXcom Forks => OXCE Bugs => OpenXcom Extended (OXCE) => OXCE Bugs FIXED => Topic started by: Dioxine on May 14, 2023, 01:42:48 pm

Title: [FIXED] Vapor trails issue in OXCE 7.9
Post by: Dioxine on May 14, 2023, 01:42:48 pm

After upgrading from 7.8 to 7.9, vapor trails started to display wrong colors in XPZ. Eg. flamethrower is now blue with a tint of yellow, instead of full yellow. What happened? How to fix it? Can it be fixed mod-side?

Title: Re: Vapor trails issue in OXCE 7.9
Post by: Meridian on May 14, 2023, 02:18:30 pm

Likely a code issue, I will check.

Title: Re: Vapor trails issue in OXCE 7.9
Post by: Meridian on May 14, 2023, 03:03:44 pm

@Yankes: the change appeared in this commit: https://github.com/MeridianOXC/OpenXcom/commit/a9d8e11eb3dd0d21d1b4a55fc7a89d878a7e908a

Please review.

Title: Re: Vapor trails issue in OXCE 7.9
Post by: Yankes on May 14, 2023, 03:08:16 pm

Can I have screenshots of affected vapors (before and after upgrade, or at least what exactly weapon to test)?
I did try to preserve old coloring, like I make sure that vanilla vapors look same.
Probably some specific configs after change start work different than before.

Title: Re: Vapor trails issue in OXCE 7.9
Post by: Meridian on May 14, 2023, 03:15:24 pm

Weapon Flamethrower, ammo Fuel Tank.

Save attached.

Videos before and after attached.

Title: Re: Vapor trails issue in OXCE 7.9
Post by: Yankes on May 14, 2023, 03:17:08 pm

Thanks for that, I will check it today

Title: Re: Vapor trails issue in OXCE 7.9
Post by: Yankes on May 15, 2023, 02:51:01 am

In OXCE 7.9.4 it should be fixed, I did not check for value roll over and for values and opacity bigger 10 you get sometimes 0 instead max of 255.

Title: Re: Vapor trails issue in OXCE 7.9
Post by: Dioxine on May 15, 2023, 06:30:21 pm

Flamethrowers work properly again. Thanks. If something else is still bugged - will report.

Title: Re: Vapor trails issue in OXCE 7.9
Post by: Yankes on May 15, 2023, 08:38:33 pm

btw, in 7.9 you can have muli color "flame".

Code: [Select]

      - #custom colors levels
        - [ 60, 160, 0,  15 ]
        - [ 40, 30, 30,  10 ]
        - [ 130, 20, 20,   5 ]
        - [ 20, 20, 120,   2 ]
Each step can have different color and transparency:
https://www.youtube.com/watch?v=tieJPHsf55Q