OpenXcom Forum

OpenXcom Forks => OXCE Bugs => OpenXcom Extended (OXCE) => OXCE Bugs FIXED => Topic started by: robin on February 19, 2023, 10:14:23 am

Title: [FIXED] Vanilla civllians spawning, why? [OXC]
Post by: robin on February 19, 2023, 10:14:23 am

Vanilla civilians are spawning but they should not.

Could it be because there aren't enough civilian spawn points on the map, so to fill the "16" quota it spawns regular civilians?

terrains:
  - &WAREFACTORY_SMALL
    name: WAREFACTORY_SMALL
    civilianTypes:
      - STR_CIV_SCIENTIST_M
      - STR_CIV_SCIENTIST_F
    mapDataSets: *mapDataSetsWarehouse
    [...]
  - name: WAREFACTORY_LARGE
    refNode: *WAREFACTORY_SMALL
    script: WAREFACTORY_LARGE
       
alienDeployments:
  - &STR_DROP_MISSION_LARGE
    type: STR_DROP_MISSION_LARGE
    [...]
    civilians: 16
    [...]
  - type: STR_DROP_MISSION_LARGE_INDUSTRIAL
    refNode: *STR_DROP_MISSION_LARGE
    terrains:
      - WAREHOUSE_LARGE
      - WAREFACTORY_LARGE
      - WAREMTL_LARGE

Title: Re: Vanilla civllians spawning, why?
Post by: Meridian on February 19, 2023, 11:00:44 am

Probably a bug/sideeffect of using refNode.

I'll check.

Title: Re: Vanilla civllians spawning, why?
Post by: robin on February 19, 2023, 12:05:05 pm

Thanks
I noticed that in language strings, terrains have "MAP_" added to them, so "WAREFACTORY_SMALL" --> "MAP_WAREFACTORY_SMALL".
Maybe this screws the refNode?
Just a wild guess, I don't know it works.

Title: Re: Vanilla civllians spawning, why?
Post by: Meridian on February 19, 2023, 12:11:31 pm

Quote from: robin on February 19, 2023, 12:05:05 pm

I noticed that in language strings, terrains have "MAP_" added to them, so "WAREFACTORY_SMALL" --> "MAP_WAREFACTORY_SMALL".
Maybe this screws the refNode?

No, it's something else, related to source code, hard to explain.

Title: Re: Vanilla civllians spawning, why?
Post by: Meridian on February 20, 2023, 10:07:26 am

Found the issue.
It's not even related to refNode, just a quirk in loading civilianTypes.

Reported to OXC devs.

Title: Re: Vanilla civllians spawning, why?
Post by: robin on February 20, 2023, 11:02:23 pm

Thank you a lot.

Title: Re: [FIXED] Vanilla civllians spawning, why? [OXC]
Post by: Meridian on March 11, 2023, 07:18:43 pm

Fixed in OXCE 7.8.11

https://github.com/MeridianOXC/OpenXcom/commit/f296c2d18c8465d72fd7cad912e2d1749acffaa6