OpenXcom Forum

OpenXcom Forks => OpenXcom Extended (OXCE) => OXCE Suggestions DONE => Topic started by: Nord on October 03, 2021, 10:54:58 am

Title: [DONE][Suggestion]Store armor during unit transformation
Post by: Nord on October 03, 2021, 10:54:58 am

When one transforms a unit, it is possible to keep new unit wearing old armor. But what if new unit can not use such armor type, but player does not want to lose old suit?
I think it is needed to divide

Code: [Select]

keepSoldierArmorinto two:

Code: [Select]

keepSoldierArmorand perhaps

Code: [Select]

storeSoldierArmor, which will remove armor suit from unit and place it into base inventory.
Thanks.

Title: Re: [Suggestion]Store armor during unit transformation
Post by: Meridian on December 12, 2021, 03:45:52 pm

Not possible automatically, when "stripping" a soldier who started with a non-unlimited armor, the game would create an armor out of thin air.

Most I can do is give you a warning.

Title: Re: [Suggestion]Store armor during unit transformation
Post by: Nord on December 13, 2021, 08:35:33 am

Quote from: Meridian on December 12, 2021, 03:45:52 pm

...when "stripping" a soldier who started with a non-unlimited armor, the game would create an armor out of thin air.

emm. Really, i can not undeerstand how it is connected with keeping old armor. But if you say it's impossible, then it's impossible.

Quote

Most I can do is give you a warning.

Please? It will be useful in the terms of QOL.

Title: Re: [Suggestion]Store armor during unit transformation
Post by: Meridian on December 13, 2021, 04:40:47 pm

maybe it can be done without technically stripping the armor, I'll check

Title: Re: [Suggestion]Store armor during unit transformation
Post by: Meridian on December 18, 2021, 01:44:44 pm

So, my proposal:

When:
1. keepSoldierArmor: false
2. and createsClone: false
3. and the armor the soldier was wearing before the transformation (old) is different than the armor the soldier is wearing after the transformation (new)
4. and the old armor is not unlimited

Then:
- add 1 old armor into base stores

Does that cover the requirement?
Can you see any other problem with that?

Title: Re: [Suggestion]Store armor during unit transformation
Post by: Nord on December 18, 2021, 05:13:31 pm

Pretty good as i can see.
What about dead soldiers going back to live? Do they wear some armor when dead? Will this not cause problem?

Title: Re: [Suggestion]Store armor during unit transformation
Post by: Meridian on December 18, 2021, 06:15:33 pm

Yes, dead soldiers wear armor too.
In OXC, they wear the same armor as when they went KIA/MIA.

In OXCE, they are changed into their default armor on KIA/MIA (and the armor they were wearing while alive disappears)... btw. this is intentional, so that the soldier stats look nicer and consistent in the Memorial GUI (not affected by different armors).

Is this OK?

Title: Re: [Suggestion]Store armor during unit transformation
Post by: Yankes on December 18, 2021, 06:24:20 pm

I think it should behave this way, why resurrecting dead should give you free armor? Especially it have hole through it? :>
Probably corpse item should be way to recover armor form dead solder.

Title: Re: [Suggestion]Store armor during unit transformation
Post by: Nord on December 18, 2021, 08:32:55 pm

Quote from: Meridian on December 18, 2021, 06:15:33 pm

...and the armor they were wearing while alive disappears...

That's good.

Quote from: Yankes on December 18, 2021, 06:24:20 pm

I think it should behave this way, why resurrecting dead should give you free armor? Especially it have hole through it? :>
Probably corpse item should be way to recover armor form dead solder.

Completely agreed.

Title: Re: [DONE][Suggestion]Store armor during unit transformation
Post by: Alex_D on December 19, 2021, 07:24:52 pm

Thank you Meridian.

So if I understood correctly, there is no need of a new ruleset entry as this "removal" will occur automatically when the conditions are met.