Messages

16

Released Mods / Re: [STAT TRACKING] Soldier Diaries 1.0

« on: August 02, 2016, 08:39:20 pm »

Hmm... ok.  Looks like Original 8 must be hardcoded, and not generated by the Commendations ruleset.  This makes more sense.   Thanks Countdown!

Oops, yeah, I could have told you that :3 I had to give the commendation something to look for, but it is actually hardcoded to be given out when the first base is made. You can change the criteria to anything else you want, naturally. Did you want me to un-hardcode it some way?

17

XPiratez / Re: [PirateZ] Commendations Mod 0.1

« on: July 29, 2016, 11:52:40 pm »

Discussions:
Replacing the vanilla ribbons with more piratey bling, eg, tattoos, or jewelry pieces. 
- This would most likely require re-coding how the graphics are displayed, and would need Meridian or Shoes, or some other willing soul to lend a hand.

Here is the code for printing the sprites: https://github.com/SupSuper/OpenXcom/blob/689371638dc85dffc928884f1313fb255c3c7384/src/Basescape/SoldierDiaryPerformanceState.cpp#L75

I imagine there are more locations, but I forget them and I can't find them! I think making new sprites will be easy enough, especially if you keep the same dimensions. If you wanted bigger sprites, you will need to spread things out more by making bigger rows or something. If you wanted different kinds of decorations (stars, skulls, scars, etc), that would need new code, but I don't think it would be too complicated to do

Good luck!! It makes me too happy to see this development!

18

Released Mods / Re: [STAT TRACKING] Soldier Diaries 1.0

« on: July 29, 2016, 11:31:28 pm »

Some Commendations Programming requests and thoughts:

You seem to have gone good work with simplifying things! Regarding renaming variables from the source code: it was something I wanted to do, as I didn't like the source code and the rule set having different names, however if we make that change now, it will break saves for commendations. For example, there is one typo in the source code, I think it's with falling unconcious.... well, it should be unconscious. That was never fixed because of the saves. I think having generic medal names that reflect how they're awarded would be great, and maybe SupSuper can be convinced, but it will break saves. Unless we add more code for "legacy" saves... I would greatly appreciate if you took on the effort to normalize the commendations It would take magnitudes longer if I did it!

Regarding the important missions, it would require new code for it to work. The logic would be similar to the custom kill medals, but kill information and mission information are different. I agree that it should be externalized for mods to better take advantage of them. The hardest part will be diving into the layers of logic again ;p haven't been there in a while! But the actual work has been done before. Edit: I forget how the logic currently works, but I think it will be possible to code quite a few varieties of mission medals. Let's say you need "3" missions of A, B, C, you could do (1) A+B+C >= 3, (2) A or B or C  >= 3, (3) A and B and C >= 3.

How would an externalized Valient Crux work? It seems to be awarded when no civilians have died (and a non zero amount has been rescued) in a successful mission. Would you want it to be awarded if all STR_UNIT_RACE survived a mission? Valient Crux is checked in the debriefing state, as not much global mission information like that is saved.

Regarding the Original8, I have only been following development loosely so I don't know about the crashes. Looking at github, it seems like the code is still there? Does it not work? I'll have to take a look when I have time, maybe next week.

19

Released Mods / Re: [STAT TRACKING] Soldier Diaries 1.0

« on: May 20, 2016, 11:34:51 pm »

Thanks for your time to help me clear this up. I'm really not getting it all, I feel. Perhaps it's just me misunderstanding how the logic works, but...well...   

There is one outstanding bug that has eluded me for some time... the logic used to work, and then one day, it stopped working. In hindsight, I should have identified exactly what commit caused the bug.

The bug you are likely encountering is one to do with multi-criteria. My todo list as the bug described as "The last entry in a the kill "and" criteria is the only one being looked at.", which lines up with what you're describing: you got a grenade kill (last in the list), so you are awarded the commendation for getting a firearm, melee, proxy mine and grenade kill.

Regarding the grenadiers medal, if you're getting it for having killed a soldier, then that's odd. Was the soldier under mind control at the time? I seem to recall you said he was unconscious, so probably not. I might have to add that to the list!

List is found here, by the way : https://gist.github.com/Shoes01/3af40f402d287ae9c229

Feel free to add to it!

Btw, the diaries sorta reveal what is the kind of UFO you fought in - should't be unknown until your research from captured aliens reveal the ships?

What Arthanor said

20

Released Mods / Re: [STAT TRACKING] Soldier Diaries 1.0

« on: May 16, 2016, 06:26:32 pm »

You're at the right place! I had a feeling that I had some commendations being given out in the cases of friendly kills. If you want to fix it locally for your game, you can edit the definition of the medal to include a "FACTION_HOSTILE" somewhere's in there. If you enter debug mode (CTRL+D) you can clear commendations (CTRL+C) and then they will all be reawarded at the end of a mission/month, but with the correction you've brought.

Countdown, thanks for the list! I haven't touched OXC in a while, but if it's on the gist, then it won't be forgotten.

21

Released Mods / Re: [STAT TRACKING] Soldier Diaries 1.0

« on: April 20, 2016, 07:06:08 pm »

So I started digging in the code to see what happens... then I had the brilliant idea of just booting up the game and checking it out myself!

I have a feeling that I did not actually code the ufopaedia to be dynamic like it is now; I think I went with ivandogovich's idea and just took over the HWPs section. However, the list is indeed dynamic now.

So yeah. The problem is in the ruleset, there is a typo; that extra "5". All the other commendations are in the right place, and the HWP section is still present. In fact, that extra button is pushing the "UFOpedia" outside it's own little window box, so maybe I will have to report that issue or fix it myself.

22

Released Mods / Re: [STAT TRACKING] Soldier Diaries 1.0

« on: April 13, 2016, 06:53:58 pm »

Maybe i can help with russian translation?

Somebody did translate the mod to Russian a while back, but new content has been added. And then all the ufopaedia stuff was added too.

I think the original translation is still there if you download the mod; if you improve that translation, I'll bundle it with the mod!

23

Released Mods / Re: [STAT TRACKING] Soldier Diaries 1.0

« on: April 11, 2016, 05:27:23 pm »

Thanks for these two finds, I'll try to find time to get those fixed. Busy week ahead of me!

24

Released Mods / Re: [STAT TRACKING] Soldier Diaries 1.0

« on: April 06, 2016, 05:27:25 pm »

I was trying to imagine a scenario where your old logic could work.... but couldn't... It was just too messy.


I wonder if it was an oversight or a concept fail. But, whatever, at least it's fixed now.

Oversight I was trying to prevent a play from being able to "farm" MC stats, but then for some reason grouped the "I was the last person to MC this alien" piece of code in with the anti-duplication code.

25

Released Mods / Re: [STAT TRACKING] Soldier Diaries 1.0

« on: April 03, 2016, 03:53:25 pm »

Yeah, you're definitely right that it has to do with the faction. In the Mission window, I am only checking to see if the unit is dead, whereas in the kill total I look to see if the unit is dead and was an enemy.

So, given the OriginalFaction and CurrentFaction, there are four possibilities: OF = 0 && CF == 0 (is and always was a friendly), OF == 0 && CF == 1 (aliens MCed your guy), OF == 1 && CF == 0 (you MCed an alien) and OF == 1 && CF == 1 (is and always was the enemy).

What I will do is this: only OF == 1 will count in kill totals. The XCOM reason will be because 0/1 (MCed soldier) kills are never celebrated. 0/0s are obviously accidents. The real reason is because I am only tracking one faction in the kills, so I will make it the OF and not the CF ;p

In the Mission window, I will continue to list all kills, but I will only increment the kill counter for OF == 1 kills. It will be weird, but likely obvious too. "This guy killed 2 aliens and 5 civilians, but only has two kills to his credit???"; should be easy to figure out why ;p The Diary already uses Faction == 1 kills, so I will now make sure it is OF and not CF.

Thanks again! It's much easier to fix when I'm clearly given the bug!

26

Released Mods / Re: [STAT TRACKING] Soldier Diaries 1.0

« on: April 02, 2016, 03:00:19 pm »

Sry, but that didn't make sense at all. Idk why haven't you gone with the latest ones from the beginning.

Last time I saw, you can't MC again an already MCed alien on the same turn with different people. So why not go with the latest?

I meant after the MC wears off. So that's why I've fixed; the last person to MC gets credit (regardless if they've MCd them before, which was the bug).

I'm not sure based on the above, but are you saying you did or didn't figure this part out?

Looking at the save files, I'm pretty sure actually the kill total in the diary on the bottom is directly saved as "killTotal" in the save files, while the mission pop ups are recounted live as you describe above. So the problem is occurring in-mission when the kill isn't assigned to the soldier who say, had their MCed alien commit suicide with a grenade. Normally when a soldier gets a kill, the in-mission save file counts it as one "kill" and then adds it to their diary total at mission's end. But when you kill an MCed alien (or have one commit suicide) the kill is listed (weapon, alien race, etc) but it isn't added to their in-mission kill count. That causes the discrepancy. If you're PR above fixes that then, the discrepancy issue will be solved.

If it's not added to the list, then it shouldn't be showing up in either total. I am starting to reorganize how I save stuff to reduce save bloat, so that might touch on this bug.

If it's really not being added to the list, then that's a bug too.

27

Released Mods / Re: [STAT TRACKING] Soldier Diaries 1.0

« on: March 28, 2016, 02:34:21 am »

I am happy you're enjoying it! I always like talking about it :3

I chatted up the devs and they're fine with the kill counts being different in the soldier info screen and in the diary. You could think of it as "direct kills" in the info screen, and "in/direct kills" in the diary. I'll have to make sure the mini mission info screen and the diary kill count talk to each other though.

edit: I've taken a closer look at how kills are awarded regarding mind controls. The way I figured out who MC'd who had a fault: I looked at who "shot" the alien last. If you MC an alien, and then he gets shot, I no longer know who controlled the alien. I am going to fix that! Regarding the mission info screen being different: they shouldn't really be... I don't directly save how many kills were done on a mission, so the mission info screen has to recount it. It looks at how many aliens are STATUS_DEAD, however, that's also how the soldier kill total at the bottom of the diary screen is calculated too. So if they're not the same, that's gonna be tricky!

edit2: I took a look at the weird bug you saw, and have found the probable cause. I don't "care" if units MC or stun an alien repeatedly, I count the first one and I am done. So if A mcs X, then B mcs X, then A mcs again again, B is still the mcer because I stopped caring about A. If that makes sense ;p I will have to delete the entries and add the 'latest' ones instead.

edit3: PR has been sent. https://github.com/SupSuper/OpenXcom/pull/1089

28

Released Mods / Re: [STAT TRACKING] Soldier Diaries 1.0

« on: March 26, 2016, 07:26:05 pm »

Are you able to run the game with the mod off? The assets should be the same from any source. Maybe you're missing a patch or something?

29

Released Mods / Re: [STAT TRACKING] Soldier Diaries 1.0

« on: March 26, 2016, 06:40:52 pm »

That is very odd. Have you tried playing without the mod active? Are you using the latest nightly? There is one commendation that is given to the original 8 soldiers, I think it's called "First to serve" or something. Maybe if you removed that from the ruleset, that would help?

In any case, if you're itching to play, you can play without the mod enabled until whatever is wrong fixes itself. Once you turn the mod on, after your first mission or end of month, all the commendations will be awarded as if you had the mod on the whole time. You won't have to worry about "missing out" on anything.

30

Released Mods / Re: [STAT TRACKING] Soldier Diaries 1.0

« on: March 24, 2016, 11:47:58 pm »

I really can't get this to work. I followed the read me instructions and nope it crashes when I create a new game or load one. I need some help

(P.S. I had problems accesing forums so there is a comment on the mod page)

Do you have any other mods installed? Do you have the commendations ruleset? Is it in the right place?

The only issue is that the game auto-crashes when you start a new game or load one? So, at the geoscape, and not at the battlescape?

I assume it's a simple issue