OpenXcom Forum

Modding => OpenXcom Extended => OXCE Suggestions DONE => Topic started by: bulletdesigner on March 17, 2023, 08:24:38 pm

Title: [DONE][Suggestion] requiresBuyCountry for soldiers (and craft)
Post by: bulletdesigner on March 17, 2023, 08:24:38 pm

Basically just introduce the requiresBuyCountry for soldiers as you got for item's. (isn't listed in the ruleset reference if it already exist)

Title: Re: [Suggestion] requiresBuyCountry for soldiers (and craft)
Post by: MaxMahem on March 18, 2023, 11:12:55 am

The feature seemed easy and reasonable, so I went ahead and implemented it. Pull request here. (https://github.com/MeridianOXC/OpenXcom/pull/118) I also added the feature to craft as well. Now the only items lacking it are scientists and engineers. I would have added it to them, but the location to put the key in the rule is not so straightforward, so I held off.

Title: Re: [Suggestion] requiresBuyCountry for soldiers (and craft)
Post by: Meridian on March 18, 2023, 11:58:08 am

I'll just repeat that there should be a discussion before any PR.

Just because something is easy, doesn't mean we want it.
And "reasonable" is very subjective as we all know.

Don't be surprised and/or disappointed if undiscussed PRs are simply closed without any explanation.

Title: Re: [Suggestion] requiresBuyCountry for soldiers (and craft)
Post by: MaxMahem on March 18, 2023, 01:38:18 pm

Sorry, I didn't mean to step on any toes. I do this mostly for the fun of it, so any request I send is either going to be something I want for myself or something that looks fun (and probably easy) to do. If you don't want the patch, feel free to close it. I've already got my enjoyment out of doing it :P

Title: Re: [Suggestion] requiresBuyCountry for soldiers (and craft)
Post by: Meridian on March 18, 2023, 05:20:41 pm

I'm just preventively informing... there are (quite a few) people who get mortally offended if their unannounced PR is closed.
Regardless of how many disclaimers I put out there.

The feature is indeed reasonable and bulletdesigner certainly is one of the people I enjoy helping, so it has a good chance of being implemented.

Title: Re: [Suggestion] requiresBuyCountry for soldiers (and craft)
Post by: Meridian on April 08, 2023, 01:38:51 pm

Quote from: MaxMahem on March 18, 2023, 11:12:55 am

The feature seemed easy and reasonable, so I went ahead and implemented it. Pull request here. (https://github.com/MeridianOXC/OpenXcom/pull/118) I also added the feature to craft as well. Now the only items lacking it are scientists and engineers. I would have added it to them, but the location to put the key in the rule is not so straightforward, so I held off.

Review on github.

Some formatting nitpicking, one missing feature (stats for nerds for craft) and one bug (buying items).

Title: Re: [DONE][Suggestion] requiresBuyCountry for soldiers (and craft)
Post by: Meridian on April 09, 2023, 10:40:38 am

Fixed and merged.

Title: Re: [DONE][Suggestion] requiresBuyCountry for soldiers (and craft)
Post by: bulletdesigner on April 09, 2023, 04:29:01 pm

Nice thks