[DONE] [Suggestion] Soldier bonuses (from transformations and commendations)

[wcho035]

Do you have a link for the latest test build for this Meridian?

I tried to download the latest one, but I am getting segmentation faults and the older versions doesn't.

[Ethereal]

No... stats, regen and visibility are tracked on each unit separately... that's why I could affect them with bonuses.
Other attributes defined by armor are only on the armor itself, not on each unit, so they are the same for all units (having the same armor) and cannot be changed individually.

Does this apply to "visibilityAtDay", "psi-heatVision", "camouflageAt", "psiDefence", "meleeDodge", "antiCamouflageAt"?

[Meridian]

Does this apply to "visibilityAtDay", "psi-heatVision", "camouflageAt", "psiDefence", "meleeDodge", "antiCamouflageAt"?

No, it does not apply to: "visibilityAtDay"

Yes, it does apply to: "psi-heatVision", "camouflageAt", "psiDefence", "meleeDodge", "antiCamouflageAt"

[Ethereal]

No: "visibilityAtDay"

Yes: "psi-heatVision", "camouflageAt", "psiDefence", "meleeDodge", "antiCamouflageAt"

Understood. How and where will such bonuses be displayed?

[Meridian]

Understood.

I have answered the question: "Does this apply to "visibilityAtDay", "psi-heatVision", "camouflageAt", "psiDefence", "meleeDodge", "antiCamouflageAt"?"

The answer is "Yes"...or in full sentence "Yes, this does apply to all those attributes" (except visibilityAtDay).

Where "this" = "No... stats, regen and visibility are tracked on each unit separately... that's why I could affect them with bonuses. Other attributes defined by armor are only on the armor itself, not on each unit, so they are the same for all units (having the same armor) and cannot be changed individually."

How and where will such bonuses be displayed?

As written above, there are no such bonuses and they are not displayed anywhere.

[Meridian]

Update: The soldier bonuses in the soldier bonuses overview window are now sorted by a newly added "listOrder" attribute.

Example:

Code: [Select]

soldierBonuses:
  - name: STR_THIRD
    listOrder: 30
  - name: STR_SECOND
    listOrder: 20
  - name: STR_FOURTH
    listOrder: 40
  - name: STR_FIRST
    listOrder: 10


[krautbernd]

Question:

What exactely are the hard limits for stat bonuses awarded via commendations, and can they be defined somewhere?

[Yankes]

I would need check, but scripts are responsible for summing final bonus values, and one goal was to add limits to values it returns.

[Meridian]

Bonuses can improve soldier stats (even over any maximum), regeneration of resources every turn and visibility at dark (until global maximum).

Visibility limits are at global mod maximum (e.g. vanilla 20, piratez 40, etc.).

Regen stats are unlimited, but final resource values don't go over their maximum. E.g. morale regen of +100000 doesn't give more than 100 final morale.

Other stats are practically unlimited.

[Meridian]

Since OXCE 7.1.4, also armor values can be modified by soldier bonuses.

Code: [Select]

soldierBonuses:
  - name: STR_ARMOR_BUFF_BONUS
    frontArmor: 200
    leftArmorDiff: -100
    sideArmor: 400
    rearArmor: 500
    underArmor: 600


[Nord]

Great, but why armors?
IMHO, it is more potent to affect psiVision or resistances.

[Meridian]

Great, but why armors?

Because it was easy to do.

IMHO, it is more potent to affect psiVision or resistances.

Affecting resistances is practically not possible.
Not without a HUGE rework anyway.

psiVision would need a small rework too, but not too big... I can add that in future if needed

[Yankes]

Remember that y-scripts are aware of bonuses, this mean you can add nearly any logic linked to it and affect most of scripted parts.

[Nord]

Because it was easy to do.

This is an important argument.

psiVision would need a small rework too, but not too big... I can add that in future if needed

No thanks, not without this.
And as Yankes say, desired effects can be achieved by scripts.

[Finnik]

Remember that y-scripts are aware of bonuses, this mean you can add nearly any logic linked to it and affect most of scripted parts.

Can I alter vision (heatVision, psiVision, visibilityAtDark) with YS?