[COMMENDATIONS] UFOPedia Mod 3.2 (Updated by hellrazor)

[SteamXCOM]

The instructions seem clear enough from the first post on the install, putting in each mod resource in the following order (except does "commendationsUfopedia2_0" supersede "CommendationUFOPedia.zip?"

 1  * Commendations_v2.1.zip
2  * CommendationUFOPedia.zip +* commendationsUfopedia2_0.
3 * CommendationsAdded_ID.zip

The big hangup seems to be finding the correct Shoes' mod "Stat Tracking/Soldier Diaries" which should be the link
site (https://openxcom.org/forum/index.php/topic,1718.0.html)
 --for the nightly version  leads to a file not found.
--Version for OpenXCOM 1.0 file link gives a warning about a crash if used
--Github link appears to be  source files with no metadata.yml or .rul file indicating it is an actual working mod
--and another forum linked has "unofficial extra builds" (https://openxcom.org/forum/index.php/topic,1718.msg45954.html#msg45954)
--and links to updated rul files (https://pastebin.com/thCz8GW6   again without a clear idea of where the install of the mod is at which itself needs pieces that are posted in the forum).

Yes, where to get all the files and how to correctly install (using the Nightly)?
Thanks

EDIT Jest occured to me I should be posting this in the other forum since you did not set up the Shoes mod(just the supporting files for it here) however the   commendationsUfopedia2_0 does it superceed the earlier version or are both needed?

[Meridian]

You need only latest nightly + hellrazor's latest posted mod (Commendations_v2.1.zip), nothing else.

You definitely don't need Shoes' stuff, it's already included in the nightly.

[SteamXCOM]

You need only latest nightly + hellrazor's latest posted mod (Commendations_v2.1.zip), nothing else.

You definitely don't need Shoes' stuff, it's already included in the nightly.

THAT makes it totally simple, thank you very much

[hatchery]

Android OXCE+ v3.9a, Jule nightly built. Final mod pack 1.9.7. Game crashing after going into a soldier awards menu. The soldier just got the Purple heart. Didn't test other medals, but First to serve works well. Watching Purple heart in a ufopedia doesn't cause crash.
Have tried to overwrite the mod merged with FMP by Commendations v2.1, didn't work.
I have installed only music pack and modified SoldierPlus (purchase more experienced soldiers).

[Meridian]

For people who would like to use the Commendations mod in TFTD, I am attaching a fix.
All it does is import the required UFO palette, so that it's not just all black.
OXCE+ required.

PS: of course don't forget to change the metadata.yml in Commendations mod... and change master from xcom1 to xcom2, if you want to see it in TFTD mod list

[BlackStaff]

Thank you very much ! 

[LFM]

After finishing a hybrid mission and receiving the xenocide award im getting a crash if i scroll past Defenders Of Earth on the award menu of soldiers with a lot of other awards, for example Gerrit van der Meer and Tomas Jelinek.While on other soldiers like Bilal Karim i can't even check their awards without crashing.

Playing with FMP and the Retaliator mod attached.

[Meridian]

I can't find Gerrit van der Meer, Tomas Jelinek or Bilal Karim in your save... please upload the correct save.

[LFM]

I can't find Gerrit van der Meer, Tomas Jelinek or Bilal Karim in your save... please upload the correct save.

I'm sorry about that, must have gotten the saves confused.

[Meridian]

It's crashing because you are using both FMP and the standalone Commendations mod.

Since FMP contains (an older version of) Commendations mod already... you get conflicts!

Turn off Commendations mod and restart your campaign... or remove all commendations from your save if you know how to do it (ctrl+C in debug mode on geoscape).

[LFM]

Removed all earned commendations from the save and commendations from the FMP rulesets and now it works flawlessly, thanks Meridian

[DoxaLogos (JG)]

This is now available on Github.  I made new files to reflect the changes for Github markdown.  Nothing biggie... same stuff basically.

https://github.com/jgatkinsn/Commendations

https://github.com/jgatkinsn/Commendations/releases

[DoxaLogos (JG)]

I've been looking at the Angel's Cross after Meridian's LP showed a soldier was awarded this from reviving an alien.  The description of the medal that it is for reviving a fellow soldier.

I looked in the code (MedikitState.cpp) and saw this:

Code: [Select]

if (!_revivedTarget)
{
_targetUnit->setTimeUnits(0);
_action->actor->getStatistics()->revivedSoldier++;
_revivedTarget = true;
}

This makes sense with what we saw. It's just keeping track of revives of anything even though the variable says revivedSoldier

Now, I could do it this way:

Code: [Select]

if (!_revivedTarget)
{
_targetUnit->setTimeUnits(0);
        if(_targetUnit->getOriginalFaction() == FACTION_PLAYER)
        {
        _action->actor->getStatistics()->revivedSoldier++;
}
        _revivedTarget = true;
}

But I ran into a problem, when I saw the comments around "revivedSoldier".

Code: [Select]

int revivedSoldier; ///< Tracks how many times this soldier revived another unit

Sounds like this variable should be called "revivedUnit" instead of "revivedSoldier". Which is stored in a save file under revivedUnitTotal:

Code: [Select]

_revivedUnitTotal += unitStatistics->revivedSoldier
Confusing right?

I'm not sure how to proceed with fixing this issue with Angel's Cross.

I could add a new stat that really is for reviving soldiers and renamed revivedSoldier to revivedUnit.  I'm not sure how open the devs will be to adding more statistics.

Then the code becomes this:

Code: [Select]

if (!_revivedTarget)
{
_targetUnit->setTimeUnits(0);
        if(_targetUnit->getOriginalFaction() == FACTION_PLAYER)
        {
       _action->actor->getStatistics()->revivedSoldier++;
}
        _action->actor->getStatiistics()->revivedUnit++;
        _revivedTarget = true;
}


While I'm at, I could add reviving citizens and aliens to boot, but that might be going overboard

Or the award could be renamed to just include anybody and no code changes?

Thoughts? Suggestions?

[Shoes]

The description for the medal reads "Given to a soldier who returned from the brink a fellow soldier." I suppose it doesn't technically say soldier of the same race! But I do think it's meant for human soldiers only. Adding commendations for reviving other faction's unit could be fun though ;p

The naming conventions used throughout the code are all out of whack. Fixing them would break saves though.

[DoxaLogos (JG)]

The description for the medal reads "Given to a soldier who returned from the brink a fellow soldier." I suppose it doesn't technically say soldier of the same race! But I do think it's meant for human soldiers only. Adding commendations for reviving other faction's unit could be fun though ;p

The naming conventions used throughout the code are all out of whack. Fixing them would break saves though.

Shoes! You're around!

So, would it be better to tweak the text in the award to reflect the current state of the code?

Example:

"Given to soldier who returned from the brink a  fellow being"