[FIXED] "Not enough mana" flash message from enemy.

[Nord]

When an enemy has enough time to reaction fire, but not enough mana for use his mana-requiring weapon, we will receive flash message "not enough mana" with each step of our soldiers (visible to that enemy).
Not sure, is it a bug or a feature.

[Meridian]

Does not happen to me.

Can you provide a save?

[Nord]

Next time when i catch it, sure.

[Meridian]

We don't have to wait that long.
You can give me any save where the enemy has a mana-requiring weapon and is able to react.

I can decrease its mana manually in the save file.

[Nord]

Looks like it is not so easy. Maybe something other causes it. I'll try to catch it again in-game.

[Blazen]

I've also encountered this bug, however when I've reloaded the save it no longer occurred. The enemy isn't using a mana requiring weapon, however I was trying to train mana growth so I may have tried to use one when the soldier didn't have enough mana.

Edit - I think it happens when one of your soldiers tries to use an ability without having enough mana, and if a different soldier then successfully uses an ability it resolves it.

So to replicate have a soldier use a mana required ability and then move someone.

Edit 2 - It has to be an innate ability, not a staff or glove ect... but something like the ignite ability.

[Meridian]

To reproduce in vanilla, let the soldiers use skill for example to auto-fire from the rifle:

Code: [Select]

items:
  - type: STR_RIFLE
    tuAuto: 0
    confAuto:
      shots: 4
skills:
  - type: STR_RAPID_FIRE
    costUse:
      time: 500
    flatUse:
      time: true
    targetMode: 7 # auto
    battleType: 1 # firearms
    compatibleWeapons: [STR_RIFLE]
soldiers:
  - type: STR_SOLDIER
    skillIconSprite: 1
    skills:
      - STR_RAPID_FIRE

To reproduce:
1. click on Skill icon and select STR_RAPID_FIRE... selecting is enough, you don't even need to try to fire
2. select someone else and try to do anything, for example move, you will get a "Not enough time units" error, which originates from step 1 (and wasn't cleared/reset)

Video attached.

PS: the bug is there since the skill feature was introduced in March 2020, in OXCE v6.4: https://openxcom.org/forum/index.php/topic,7974.0.html

[Meridian]

Reported issue fixed here: https://github.com/MeridianOXC/OpenXcom/commit/f92c1a73e4001a4ae6f518a828bcb0577ac5a400

But this is likely not a complete fix, nor the most beautiful one.
I will keep the thread under "open bugs", and review later.