aliens

Author Topic: [FIXED][bug] units phasing through doors in oxce 7.8.21+  (Read 1672 times)

Offline Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 9136
    • View Profile
[FIXED][bug] units phasing through doors in oxce 7.8.21+
« on: June 11, 2023, 03:33:24 pm »
when a unit has low TU, e.g. 5 TU, it walks through a door without opening it

expected: cannot make a move (not enough TU)

@yankes: introduced in this commit: https://github.com/MeridianOXC/OpenXcom/commit/cefeaf6b65a28cfc4001bf018f74315da36464d6
please check

save attached
« Last Edit: July 03, 2023, 10:09:05 pm by Meridian »

Offline Yankes

  • Global Moderator
  • Commander
  • *****
  • Posts: 3374
    • View Profile
Re: [bug] units phasing through doors in oxce 7.8.21+
« Reply #1 on: June 11, 2023, 04:44:00 pm »
Ok, I recheck this commit and I suspect:
Code: [Select]
if ((direction == 0 || direction == 7 || direction == 1) && startTile[i]->hasLadderOnNorthWall())
I mess up condition as it should be false for case where is not climb wall but its true.

Offline Yankes

  • Global Moderator
  • Commander
  • *****
  • Posts: 3374
    • View Profile
Re: [bug] units phasing through doors in oxce 7.8.21+
« Reply #2 on: June 13, 2023, 02:44:49 am »
Should be fixed in OXCE 7.9.7

Offline Vakrug

  • Colonel
  • ****
  • Posts: 323
    • View Profile
Re: [bug] units phasing through doors in oxce 7.8.21+
« Reply #3 on: June 13, 2023, 10:13:34 am »
Oh...  :'( This bug was so hilarious...  ;D