[DONE] Storestate grand totals.

[R1dO]

As a player i would probably never noticed it, but found this one while browsing through the code.

In StoreState::InitList() when tallying items for the grand total this method goes to great length in order to include every item that can theoretically return to a base.

It feels like it is missing two options though
1) A scenario 6. "Items in manufacture if they are refundable"
    To have the same behavior as scenario 4, which includes items that are destroyed after research.
2) Armors worn by soldiers while in transfer to a base.

Was this an oversight or design choice?

[Meridian]

1. sounds like a bug... I don't know/remember why I would include items destroyed by research
2. sounds like my laziness

I'll check both...

[R1dO]

If i understand the code correct it is because items destroyed by research are refundable when a player cancels the appropriate research.
That would mean such an item could theoretically return to base stores.

Then again .. i am not your memory, so it is all assumptions on my part. 

[Meridian]

2. was fixed, armor worn by soldiers in transfer is now included

1. I'd prefer removing research items over adding manufacture items... but since the research items are there for a long time and it is also described here on the forum, I'll just leave it be as it is

I've probably (not 100% sure) added the research items into the total because they are visible in the Alien Containment Management GUI and block space there; but manufacture items are not visible anywhere and don't block any storage space (they can block manufacturing space). Also, refund option didn't exist back then

[R1dO]

That was swift .. thank you (also for taking the time to explain rationale).