[DONE][Suggestion]Store armor during unit transformation

[Nord]

When one transforms a unit, it is possible to keep new unit wearing old armor. But what if new unit can not use such armor type, but player does not want to lose old suit?
I think it is needed to divide

Code: [Select]

keepSoldierArmorinto two:

Code: [Select]

keepSoldierArmorand perhaps

Code: [Select]

storeSoldierArmor, which will remove armor suit from unit and place it into base inventory.
Thanks.

[Meridian]

Not possible automatically, when "stripping" a soldier who started with a non-unlimited armor, the game would create an armor out of thin air.

Most I can do is give you a warning.

[Nord]

...when "stripping" a soldier who started with a non-unlimited armor, the game would create an armor out of thin air.

emm. Really, i can not undeerstand how it is connected with keeping old armor. But if you say it's impossible, then it's impossible.

Most I can do is give you a warning.

Please? It will be useful in the terms of QOL.

[Meridian]

maybe it can be done without technically stripping the armor, I'll check

[Meridian]

So, my proposal:

When:
1. keepSoldierArmor: false
2. and createsClone: false
3. and the armor the soldier was wearing before the transformation (old) is different than the armor the soldier is wearing after the transformation (new)
4. and the old armor is not unlimited

Then:
- add 1 old armor into base stores

Does that cover the requirement?
Can you see any other problem with that?

[Nord]

Pretty good as i can see.
What about dead soldiers going back to live? Do they wear some armor when dead? Will this not cause problem?

[Meridian]

Yes, dead soldiers wear armor too.
In OXC, they wear the same armor as when they went KIA/MIA.

In OXCE, they are changed into their default armor on KIA/MIA (and the armor they were wearing while alive disappears)... btw. this is intentional, so that the soldier stats look nicer and consistent in the Memorial GUI (not affected by different armors).

Is this OK?

[Yankes]

I think it should behave this way, why resurrecting dead should give you free armor? Especially it have hole through it? :>
Probably corpse item should be way to recover armor form dead solder.

[Nord]

...and the armor they were wearing while alive disappears...

That's good.

I think it should behave this way, why resurrecting dead should give you free armor? Especially it have hole through it? :>
Probably corpse item should be way to recover armor form dead solder.

Completely agreed.

[Alex_D]

Thank you Meridian.

So if I understood correctly, there is no need of a new ruleset entry as this "removal" will occur automatically when the conditions are met.